15656 2007-10-23 21:41:09 -0700 [GTK] Implement WebCore::Widget::isEnabled/setEnabled 2007-10-25 15:08:21 -0700 1 1 1 Unclassified WebKit WebKitGTK 523.x (Safari 3) PC Linux RESOLVED FIXED Gtk P3 Enhancement --- 0 jmalonzo webkit-unassigned oldest_to_newest 59305 0 jmalonzo 2007-10-23 21:41:09 -0700 Attached is a patch implementing Widget::isEnabled and Widget::setEnabled. 59306 1 16828 jmalonzo 2007-10-23 21:41:56 -0700 Created attachment 16828 implement isEnabled and setEnabled 59311 2 alp 2007-10-23 22:37:32 -0700 I'm curious, does this patch make WidgetGtk work any better? The rest of the file looks a bit confused right now, like it needs a cleanup. Most other places where the GTK+ widget is used null-check it first. 59314 3 jmalonzo 2007-10-23 23:18:18 -0700 Hi Alp. Are you suggesting that WidgetGtk needs cleanup as well? If that's the case I can refactor it and submit a refactored patch. 59471 4 alp 2007-10-25 15:07:32 -0700 Fixed in r27069 (with a check added). 16828 2007-10-23 21:41:56 -0700 2007-10-25 15:08:21 -0700 implement isEnabled and setEnabled widget-is-enabled.patch text/plain 1130 jmalonzo ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjZjY2ZmMS4uMjAzMDY0NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwNy0xMC0yMyAgSmFuIE1pY2hhZWwg QWxvbnpvICA8am1hbG9uem9AdW5wbHVnZ2FibGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQg T1IgQ0hBTkdFRAorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpXaWRnZXQ6OnNldEVuYWJsZWQpOiBJbXBsZW1lbnRlZC4KKwogMjAwNy0x MC0yMyAgSnVzdGluIEdhcmNpYSAgPGp1c3Rpbi5nYXJjaWFAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvV2lkZ2V0R3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1dpZGdldEd0ay5jcHAKaW5k ZXggMTAwYzc4Mi4uMmJhYTJjMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvV2lk Z2V0R3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9XaWRnZXRHdGsuY3BwCkBAIC0x NDgsMTUgKzE0OCwxNiBAQCB2b2lkIFdpZGdldDo6aGlkZSgpCiAgICAgZ3RrX3dpZGdldF9oaWRl KGd0a1dpZGdldCgpKTsKIH0KIAotdm9pZCBXaWRnZXQ6OnNldEVuYWJsZWQoYm9vbCkKK3ZvaWQg V2lkZ2V0OjpzZXRFbmFibGVkKGJvb2wgc2hvdWxkRW5hYmxlKQogewotICAgIG5vdEltcGxlbWVu dGVkKCk7CisgICAgaWYgKCFndGtXaWRnZXQoKSkKKyAgICAgICAgcmV0dXJuOworICAgIGd0a193 aWRnZXRfc2V0X3NlbnNpdGl2ZShndGtXaWRnZXQoKSwgc2hvdWxkRW5hYmxlKTsKIH0KIAogYm9v bCBXaWRnZXQ6OmlzRW5hYmxlZCgpIGNvbnN0CiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAg ICByZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIEdUS19XSURHRVRfSVNfU0VOU0lUSVZFKGd0a1dp ZGdldCgpKTsKIH0KIAogdm9pZCBXaWRnZXQ6OnJlbW92ZUZyb21QYXJlbnQoKQo=