156555 2016-04-13 14:01:36 -0700 PolymorphicAccess should try to generate a stub only once 2016-04-14 16:08:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1183526 0 fpizlo 2016-04-13 14:01:36 -0700 Currently, we don't do any buffering of access cases prior to the first stub generation. We only enable it after a stub has been generated. I implemented buffering that way to be conservative. Now we should push it further and always buffer. The outcome ought to be that most ICs only generate a stub once. 1183897 1 276437 fpizlo 2016-04-14 15:14:01 -0700 Created attachment 276437 the patch 1183899 2 276437 ggaren 2016-04-14 15:22:04 -0700 Comment on attachment 276437 the patch r=me 1183927 3 fpizlo 2016-04-14 16:08:24 -0700 Landed in http://trac.webkit.org/changeset/199566 276437 2016-04-14 15:14:01 -0700 2016-04-14 15:22:04 -0700 the patch blah.patch text/plain 7167 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5NTU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQyIEBA CisyMDE2LTA0LTE0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UG9seW1vcnBoaWNBY2Nlc3Mgc2hvdWxkIHRyeSB0byBnZW5lcmF0ZSBhIHN0dWIgb25seSBvbmNl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY1NTUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAg IFRoaXMgY2hhbmdlcyB0aGUgUG9seW1vcnBoaWNBY2Nlc3MgaGV1cmlzdGljcyB0byByZWR1Y2Ug dGhlIGFtb3VudCBvZiBjb2RlIGdlbmVyYXRpb24gZXZlbgorICAgICAgICBtb3JlIHRoYW4gYmVm b3JlLiBXZSB1c2VkIHRvIGFsd2F5cyBnZW5lcmF0ZSBhIG1vbm9tb3JwaGljIHN0dWIgZm9yIHRo ZSBmaXJzdCBjYXNlIHdlIHNhdy4KKyAgICAgICAgVGhpcyBjaGFuZ2UgZGlzYWJsZXMgdGhhdC4g VGhpcyBjaGFuZ2UgYWxzbyBpbmNyZWFzZXMgdGhlIGJ1ZmZlcmluZyBjb3VudGRvd24gdG8gbWF0 Y2ggdGhlCisgICAgICAgIGNvb2wtZG93biByZXBhdGNoIGNvdW50LiBUaGlzIG1lYW5zIHRoYXQg d2Ugd2lsbCBhbGxvdyBmb3IgdGVuIHNsb3cgcGF0aHMgZm9yIGFkZGluZyBjYXNlcywKKyAgICAg ICAgdGhlbiB3ZSB3aWxsIGdlbmVyYXRlIGEgc3R1YiwgYW5kIHRoZW4gd2Ugd2lsbCBnbyBpbnRv IGNvb2wtZG93biBhbmQgdGhlIHJlcGF0Y2hpbmcgc2xvdworICAgICAgICBwYXRocyB3aWxsIG5v dCBldmVuIGF0dGVtcHQgcmVwYXRjaGluZyBmb3IgYSB3aGlsZS4gQWZ0ZXIgd2UgZW1lcmdlIGZy b20gY29vbC1kb3duIC0gd2hpY2gKKyAgICAgICAgcmVxdWlyZXMgYSBidW5jaCBvZiBzbG93IHBh dGggY2FsbHMgLSB3ZSB3aWxsIGFnYWluIHdhaXQgZm9yIHRlbiBzbG93IHBhdGhzIHRvIGdldCBu ZXcKKyAgICAgICAgY2FzZXMuIE5vdGUgdGhhdCBpdCBvbmx5IHRha2VzIDEzIGNhc2VzIHRvIGNh dXNlIHRoZSBzdHViIHRvIGdpdmUgdXAgb24gZnV0dXJlIHJlcGF0Y2hpbmcKKyAgICAgICAgZW50 aXJlbHkuIEFsc28sIG1vc3Qgc3R1YnMgZG9uJ3QgZXZlciBnZXQgdG8gMTAgY2FzZXMuIFRoZXJl Zm9yZSwgZm9yIG1vc3Qgc3R1YnMgdGhpcyBjaGFuZ2UKKyAgICAgICAgbWVhbnMgdGhhdCBlYWNo IElDIHdpbGwgcmVwYXRjaCBvbmNlLiBJZiB0aGV5IG1ha2UgaXQgdG8gdHdvIHJlcGF0Y2hpbmcs IHRoZW4gdGhlIGxpa2VsaWhvb2QKKyAgICAgICAgb2YgYSB0aGlyZCBiZWNvbWVzIGluZmluaXRl c2ltYWwgYmVjYXVzZSBvZiBhbGwgb2YgdGhlIHJ1bGVzIHRoYXQgY29tZSBpbnRvIHBsYXkgYXQg dGhhdAorICAgICAgICBwb2ludCAodGhlIHNpemUgbGltaXQgYmVpbmcgMTMsIHRoZSBmYWN0IHRo YXQgd2UgZ28gaW50byBleHBvbmVudGlhbCBjb29sLWRvd24gZXZlcnkgdGltZSB3ZQorICAgICAg ICBnZW5lcmF0ZSBjb2RlLCBhbmQgdGhlIGZhY3QgdGhhdCBpZiB3ZSBoYXZlIGxvdHMgb2Ygc2Vs ZiBjYXNlcyB0aGVuIHdlIHdpbGwgY3JlYXRlIGEKKyAgICAgICAgY2F0Y2gtYWxsIG1lZ2Ftb3Jw aGljIGxvYWQgY2FzZSkuCisKKyAgICAgICAgVGhpcyBhbHNvIHVuZG9lcyBhIGNoYW5nZSB0byB0 aGUgbWVnYW1vcnBoaWMgb3B0aW1pemF0aW9uIHRoYXQgSSB0aGluayB3YXMgdW5pbnRlbnRpb25h bC4KKyAgICAgICAgQXMgaW4gdGhlIGNoYW5nZSB0aGF0IG9yaWdpbmFsbHkgaW50cm9kdWNlZCBt ZWdhbW9ycGhpYyBsb2Fkcywgd2Ugd2FudCB0byBkbyB0aGlzIG9ubHkgaWYgd2UKKyAgICAgICAg d291bGQgb3RoZXJ3aXNlIGV4aGF1c3QgdGhlIG1heCBzaXplIG9mIHRoZSBJQy4gVGhpcyBpcyBi ZWNhdXNlIG1lZ2Ftb3JwaGljIGxvYWRzIGFyZSBwcmV0dHkKKyAgICAgICAgZXhwZW5zaXZlIGFu ZCBpdCdzIGJlc3QgdG8gdXNlIHRoZW0gb25seSBpZiB3ZSBrbm93IHRoYXQgdGhlIGFsdGVybmF0 aXZlIGlzIGdpdmluZyB1cCBvbgorICAgICAgICBjYWNoaW5nLgorCisgICAgICAgIFRoaXMgaXMg bmV1dHJhbCBvbiBKUyBiZW5jaG1hcmtzLCBidXQgbG9va3MgbGlrZSBpdCdzIGFub3RoZXIgc3Bl ZWQtdXAgZm9yIHBhZ2UgbG9hZGluZy4KKworICAgICAgICAqIGJ5dGVjb2RlL1BvbHltb3JwaGlj QWNjZXNzLmNwcDoKKyAgICAgICAgKEpTQzo6QWNjZXNzQ2FzZTo6Y2FuQmVSZXBsYWNlZEJ5TWVn YW1vcnBoaWNMb2FkKToKKyAgICAgICAgKEpTQzo6QWNjZXNzQ2FzZTo6Y2FuUmVwbGFjZSk6Cisg ICAgICAgIChKU0M6OkFjY2Vzc0Nhc2U6OmR1bXApOgorICAgICAgICAoSlNDOjpQb2x5bW9ycGhp Y0FjY2Vzczo6cmVnZW5lcmF0ZSk6CisgICAgICAgICogYnl0ZWNvZGUvU3RydWN0dXJlU3R1Yklu Zm8uY3BwOgorICAgICAgICAoSlNDOjpTdHJ1Y3R1cmVTdHViSW5mbzo6U3RydWN0dXJlU3R1Yklu Zm8pOgorICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorCiAyMDE2LTA0LTE0ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgdHJlYXRtZW50IG9mIGlu dm9raW5nIFJlZ0V4cC5wcm90b3R5cGUgbWV0aG9kcyBvbiBSZWdFeHAucHJvdG90eXBlLgpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1BvbHltb3JwaGljQWNjZXNzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUG9seW1vcnBoaWNB Y2Nlc3MuY3BwCShyZXZpc2lvbiAxOTk1MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvUG9seW1vcnBoaWNBY2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NzIsNiArNDcy LDkgQEAgYm9vbCBBY2Nlc3NDYXNlOjpjb3VsZFN0aWxsU3VjY2VlZCgpIGNvbgogCiBib29sIEFj Y2Vzc0Nhc2U6OmNhbkJlUmVwbGFjZWRCeU1lZ2Ftb3JwaGljTG9hZCgpIGNvbnN0CiB7CisgICAg aWYgKHR5cGUoKSA9PSBNZWdhbW9ycGhpY0xvYWQpCisgICAgICAgIHJldHVybiB0cnVlOworICAg IAogICAgIHJldHVybiB0eXBlKCkgPT0gTG9hZAogICAgICAgICAmJiAhdmlhUHJveHkoKQogICAg ICAgICAmJiBjb25kaXRpb25TZXQoKS5pc0VtcHR5KCkKQEAgLTQ4MSwxNyArNDg0LDIzIEBAIGJv b2wgQWNjZXNzQ2FzZTo6Y2FuQmVSZXBsYWNlZEJ5TWVnYW1vcnAKIAogYm9vbCBBY2Nlc3NDYXNl OjpjYW5SZXBsYWNlKGNvbnN0IEFjY2Vzc0Nhc2UmIG90aGVyKSBjb25zdAogewotICAgIC8vIFdl IGNvdWxkIGRvIGEgbG90IGJldHRlciBoZXJlLCBidXQgZm9yIG5vdyB3ZSBqdXN0IGRvIHNvbWV0 aGluZyBvYnZpb3VzLgotICAgIAotICAgIGlmICh0eXBlKCkgPT0gTWVnYW1vcnBoaWNMb2FkICYm IG90aGVyLmNhbkJlUmVwbGFjZWRCeU1lZ2Ftb3JwaGljTG9hZCgpKQotICAgICAgICByZXR1cm4g dHJ1ZTsKKyAgICAvLyBUaGlzIHB1dHMgaW4gYSBnb29kIGVmZm9ydCB0byB0cnkgdG8gZmlndXJl IG91dCBpZiAnb3RoZXInIGlzIG1hZGUgc3VwZXJmbHVvdXMgYnkgJyp0aGlzJy4KKyAgICAvLyBJ dCdzIGZpbmUgZm9yIHRoaXMgdG8gcmV0dXJuIGZhbHNlIGlmIGl0J3MgaW4gZG91YnQuCiAKLSAg ICBpZiAoIWd1YXJkZWRCeVN0cnVjdHVyZUNoZWNrKCkgfHwgIW90aGVyLmd1YXJkZWRCeVN0cnVj dHVyZUNoZWNrKCkpIHsKLSAgICAgICAgLy8gRklYTUU6IEltcGxlbWVudCB0aGlzIQotICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgc3dpdGNoICh0eXBlKCkpIHsKKyAgICBjYXNlIE1lZ2Ftb3Jw aGljTG9hZDoKKyAgICAgICAgcmV0dXJuIG90aGVyLmNhbkJlUmVwbGFjZWRCeU1lZ2Ftb3JwaGlj TG9hZCgpOworICAgIGNhc2UgQXJyYXlMZW5ndGg6CisgICAgY2FzZSBTdHJpbmdMZW5ndGg6Cisg ICAgY2FzZSBEaXJlY3RBcmd1bWVudHNMZW5ndGg6CisgICAgY2FzZSBTY29wZWRBcmd1bWVudHNM ZW5ndGg6CisgICAgICAgIHJldHVybiBvdGhlci50eXBlKCkgPT0gdHlwZSgpOworICAgIGRlZmF1 bHQ6CisgICAgICAgIGlmICghZ3VhcmRlZEJ5U3RydWN0dXJlQ2hlY2soKSB8fCAhb3RoZXIuZ3Vh cmRlZEJ5U3RydWN0dXJlQ2hlY2soKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAg ICAgCisgICAgICAgIHJldHVybiBzdHJ1Y3R1cmUoKSA9PSBvdGhlci5zdHJ1Y3R1cmUoKTsKICAg ICB9Ci0KLSAgICByZXR1cm4gc3RydWN0dXJlKCkgPT0gb3RoZXIuc3RydWN0dXJlKCk7CiB9CiAK IHZvaWQgQWNjZXNzQ2FzZTo6ZHVtcChQcmludFN0cmVhbSYgb3V0KSBjb25zdApAQCAtMTU4Nyw3 ICsxNTk2LDcgQEAgQWNjZXNzR2VuZXJhdGlvblJlc3VsdCBQb2x5bW9ycGhpY0FjY2VzcwogICAg IC8vIG9wdGltaXphdGlvbiBpcyBhcHBsaWNhYmxlLiBOb3RlIHRoYXQgd2UgYmFzaWNhbGx5IHR1 bmUgbWVnYW1vcnBoaWNMb2FkQ29zdCBhY2NvcmRpbmcgdG8gY29kZQogICAgIC8vIHNpemUuIEl0 IHdvdWxkIGJlIGZhc3RlciB0byBqdXN0IGFsbG93IG1vcmUgcmVwYXRjaGluZyB3aXRoIG1hbnkg bG9hZCBjYXNlcywgYW5kIGF2b2lkIHRoZQogICAgIC8vIG1lZ2Ftb3JwaGljTG9hZCBvcHRpbWl6 YXRpb24sIGlmIHdlIGhhZCBpbmZpbml0ZSBleGVjdXRhYmxlIG1lbW9yeS4KLSAgICBpZiAoY2Fz ZXMuc2l6ZSgpID49IE9wdGlvbnM6Om1lZ2Ftb3JwaGljTG9hZENvc3QoKSkgeworICAgIGlmIChj YXNlcy5zaXplKCkgPj0gT3B0aW9uczo6bWF4QWNjZXNzVmFyaWFudExpc3RTaXplKCkpIHsKICAg ICAgICAgdW5zaWduZWQgbnVtU2VsZkxvYWRzID0gMDsKICAgICAgICAgZm9yIChhdXRvJiBuZXdD YXNlIDogY2FzZXMpIHsKICAgICAgICAgICAgIGlmIChuZXdDYXNlLT5jYW5CZVJlcGxhY2VkQnlN ZWdhbW9ycGhpY0xvYWQoKSkKQEAgLTE2NTgsOSArMTY2NywxNCBAQCBBY2Nlc3NHZW5lcmF0aW9u UmVzdWx0IFBvbHltb3JwaGljQWNjZXNzCiAgICAgICAgIC8vIG9mIHNvbWV0aGluZyB0aGF0IGlz bid0IHBhdGNoYWJsZS4gVGhlIHNsb3cgcGF0aCB3aWxsIGRlY3JlbWVudCAiY291bnRkb3duIiBh bmQgd2lsbCBvbmx5CiAgICAgICAgIC8vIHBhdGNoIHRoaW5ncyBpZiB0aGUgY291bnRkb3duIHJl YWNoZXMgemVyby4gV2UgaW5jcmVtZW50IHRoZSBzbG93IHBhdGggY291bnQgaGVyZSB0byBlbnN1 cmUKICAgICAgICAgLy8gdGhhdCB0aGUgc2xvdyBwYXRoIGRvZXMgbm90IHRyeSB0byBwYXRjaC4K KyNpZiBDUFUoWDg2KSB8fCBDUFUoWDg2XzY0KQorICAgICAgICBqaXQubW92ZShDQ2FsbEhlbHBl cnM6OlRydXN0ZWRJbW1QdHIoJnN0dWJJbmZvLmNvdW50ZG93biksIHN0YXRlLnNjcmF0Y2hHUFIp OworICAgICAgICBqaXQuYWRkOChDQ2FsbEhlbHBlcnM6OlRydXN0ZWRJbW0zMigxKSwgQ0NhbGxI ZWxwZXJzOjpBZGRyZXNzKHN0YXRlLnNjcmF0Y2hHUFIpKTsKKyNlbHNlCiAgICAgICAgIGppdC5s b2FkOCgmc3R1YkluZm8uY291bnRkb3duLCBzdGF0ZS5zY3JhdGNoR1BSKTsKICAgICAgICAgaml0 LmFkZDMyKENDYWxsSGVscGVyczo6VHJ1c3RlZEltbTMyKDEpLCBzdGF0ZS5zY3JhdGNoR1BSKTsK ICAgICAgICAgaml0LnN0b3JlOChzdGF0ZS5zY3JhdGNoR1BSLCAmc3R1YkluZm8uY291bnRkb3du KTsKKyNlbmRpZgogICAgIH0KIAogICAgIENDYWxsSGVscGVyczo6SnVtcExpc3QgZmFpbHVyZTsK SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9TdHJ1Y3R1cmVTdHViSW5mby5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1N0cnVjdHVy ZVN0dWJJbmZvLmNwcAkocmV2aXNpb24gMTk5NTA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2J5dGVjb2RlL1N0cnVjdHVyZVN0dWJJbmZvLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDMsNyAr NDMsNyBAQCBTdHJ1Y3R1cmVTdHViSW5mbzo6U3RydWN0dXJlU3R1YkluZm8oQWNjCiAgICAgLCBj b3VudGRvd24oMSkgLy8gRm9yIGEgdG90YWxseSBjbGVhciBzdHViLCB3ZSdsbCBwYXRjaCBpdCBh ZnRlciB0aGUgZmlyc3QgZXhlY3V0aW9uLgogICAgICwgcmVwYXRjaENvdW50KDApCiAgICAgLCBu dW1iZXJPZkNvb2xEb3ducygwKQotICAgICwgYnVmZmVyaW5nQ291bnRkb3duKDApCisgICAgLCBi dWZmZXJpbmdDb3VudGRvd24oT3B0aW9uczo6cmVwYXRjaEJ1ZmZlcmluZ0NvdW50ZG93bigpKQog ICAgICwgcmVzZXRCeUdDKGZhbHNlKQogICAgICwgdG9va1Nsb3dQYXRoKGZhbHNlKQogICAgICwg ZXZlckNvbnNpZGVyZWQoZmFsc2UpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv T3B0aW9ucy5oCShyZXZpc2lvbiAxOTk1MDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNSw3ICsxMjUsNyBAQCB0eXBlZGVm IGNvbnN0IGNoYXIqIG9wdGlvblN0cmluZzsKICAgICBcCiAgICAgdih1bnNpZ25lZCwgcmVwYXRj aENvdW50Rm9yQ29vbERvd24sIDEwLCBudWxscHRyKSBcCiAgICAgdih1bnNpZ25lZCwgaW5pdGlh bENvb2xEb3duQ291bnQsIDIwLCBudWxscHRyKSBcCi0gICAgdih1bnNpZ25lZCwgcmVwYXRjaEJ1 ZmZlcmluZ0NvdW50ZG93biwgNywgbnVsbHB0cikgXAorICAgIHYodW5zaWduZWQsIHJlcGF0Y2hC dWZmZXJpbmdDb3VudGRvd24sIDEwLCBudWxscHRyKSBcCiAgICAgXAogICAgIHYoYm9vbCwgZHVt cEdlbmVyYXRlZEJ5dGVjb2RlcywgZmFsc2UsIG51bGxwdHIpIFwKICAgICB2KGJvb2wsIGR1bXBC eXRlY29kZUxpdmVuZXNzUmVzdWx0cywgZmFsc2UsIG51bGxwdHIpIFwK