156544 2016-04-13 09:58:11 -0700 FindWebP should not be misguided by pkg-config when cross-compiling. 2016-04-14 03:26:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 annulen webkit-unassigned cgarcia clopez commit-queue gyuyoung.kim lforschler mario mcatanzaro mrobinson ossy tpopela oldest_to_newest 1183435 0 annulen 2016-04-13 09:58:11 -0700 We should use pkg-config output only as a hint, like other modules do. 1183436 1 276330 annulen 2016-04-13 10:00:42 -0700 Created attachment 276330 Patch 1183441 2 276331 annulen 2016-04-13 10:31:41 -0700 Created attachment 276331 Patch 1183450 3 276331 mcatanzaro 2016-04-13 10:49:22 -0700 Comment on attachment 276331 Patch By the way, do you have committer access yet? You can stop setting cq? and move it straight to cq+ once you do. 1183456 4 annulen 2016-04-13 10:57:22 -0700 Not yet. 1183572 5 276331 commit-queue 2016-04-13 15:58:22 -0700 Comment on attachment 276331 Patch Clearing flags on attachment: 276331 Committed r199518: <http://trac.webkit.org/changeset/199518> 1183573 6 commit-queue 2016-04-13 15:58:28 -0700 All reviewed patches have been landed. Closing bug. 1183603 7 clopez 2016-04-13 18:06:41 -0700 Continuous build broke with this. I have triggered clean builds on all the GTK+ bots. 1183674 8 annulen 2016-04-14 02:47:10 -0700 (In reply to comment #7) > Continuous build broke with this. > > I have triggered clean builds on all the GTK+ bots. This patch requires one clean build after landing, after that continuous builds should work fine (at least it works in my local tests). 1183678 9 clopez 2016-04-14 03:26:05 -0700 (In reply to comment #8) > (In reply to comment #7) > > Continuous build broke with this. > > > > I have triggered clean builds on all the GTK+ bots. > > This patch requires one clean build after landing, after that continuous > builds should work fine (at least it works in my local tests). Yes. that is what I wanted to say :) 276330 2016-04-13 10:00:42 -0700 2016-04-13 10:31:30 -0700 Patch bug-156544-20160413200052.patch text/plain 2095 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZFdlYlAuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZFdlYlAuY21ha2UKaW5kZXggYTYyN2IxMzhj ZmRmOTI1OGUyYzdiNjI2ZTY1ZmE1Y2U0ODE4NjFiNS4uNjc3MjM1MmQ5NTcxZDk5MzgzN2YyZWZj MTY5NmJmNDI2NGRjNGQwMCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRXZWJQLmNtYWtl CisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kV2ViUC5jbWFrZQpAQCAtMzAsMTkgKzMwLDIyIEBACiAj IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCiBmaW5kX3BhY2th Z2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoV0VCUCBsaWJ3ZWJwKQorcGtnX2NoZWNr X21vZHVsZXMoUENfV0VCUCBRVUlFVCBsaWJ3ZWJwKQogCi1pZiAoTk9UKFdFQlBfRk9VTkQpKQot ICAgICMgT2xkZXIgaW5zdGFsbGF0aW9ucyBvZiBsaWJ3ZWJwIGRvIG5vdCBpbnN0YWxsIGEgcGtn Y29uZmlnIGZpbGUsIHNvIHdlIGZhbGwKLSAgICAjIGJhY2sgdG8gYSBtYW51YWwgc2VhcmNoIGZv ciBhIGxpYndlYnAgaGVhZGVyIGZpbGUuCi0gICAgaW5jbHVkZShDaGVja0luY2x1ZGVGaWxlcykK LSAgICBjaGVja19pbmNsdWRlX2ZpbGVzKCJ3ZWJwL2RlY29kZS5oIiBXRUJQX0ZPVU5EX0hFQURF UikKLSAgICBpZiAoV0VCUF9GT1VORF9IRUFERVIpCi0gICAgICAgIHNldChXRUJQX0xJQlJBUklF UyAiLWx3ZWJwIikKLSAgICAgICAgc2V0KFdFQlBfRk9VTkQgVFJVRSkKLSAgICBlbmRpZiAoKQot ZW5kaWYgKCkKKyMgTG9vayBmb3IgdGhlIGhlYWRlciBmaWxlLgorZmluZF9wYXRoKFdFQlBfSU5D TFVERV9ESVJTCisgICAgTkFNRVMgd2VicC9kZWNvZGUuaAorICAgIEhJTlRTICR7UENfV0VCUF9J TkNMVURFRElSfSAke1BDX1dFQlBfSU5DTFVERV9ESVJTfQorKQorbWFya19hc19hZHZhbmNlZChX RUJQX0lOQ0xVREVfRElSUykKKworIyBMb29rIGZvciB0aGUgbGlicmFyeS4KK2ZpbmRfbGlicmFy eSgKKyAgICBXRUJQX0xJQlJBUklFUworICAgIE5BTUVTIHdlYnAKKyAgICBISU5UUyAke1BDX1dF QlBfTElCRElSfSAke1BDX1dFQlBfTElCUkFSWV9ESVJTfQorKQorbWFya19hc19hZHZhbmNlZChX RUJQX0xJQlJBUklFUykKIAotIyBXRUJQX0lOQ0xVREVfRElSUyBpcyBvZnRlbiBlbXB0eSwgc28g d2UgcmVseSBvbmx5IG9uIFdFQlBfTElCUkFSSUVTLgogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRs ZVN0YW5kYXJkQXJncykKLUZJTkRfUEFDS0FHRV9IQU5ETEVfU1RBTkRBUkRfQVJHUyhXRUJQIERF RkFVTFRfTVNHIFdFQlBfTElCUkFSSUVTKQorRklORF9QQUNLQUdFX0hBTkRMRV9TVEFOREFSRF9B UkdTKFdFQlAgREVGQVVMVF9NU0cgV0VCUF9JTkNMVURFX0RJUlMgV0VCUF9MSUJSQVJJRVMpCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjYyNGIwZDJmOWViMWIwNWFk ZDU0NDFmYTg0YTFkNDE3ZWE2NjA3YS4uMjQ0ZTA4Nzc3YTQ3NDVjOWQyZTZmMzIwZjVlZDI1YWNk NjYxZDJiMyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE2LTA0LTEzICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5y dT4KKworICAgICAgICBGaW5kV2ViUCBzaG91bGQgbm90IGJlIG1pc2d1aWRlZCBieSBwa2ctY29u ZmlnIHdoZW4gY3Jvc3MtY29tcGlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIHVzZSBwa2ctY29uZmlnIG91dHB1dCBvbmx5IGFz IGEgaGludCwgbGlrZSBvdGhlciBtb2R1bGVzIGRvLgorCisgICAgICAgICogU291cmNlL2NtYWtl L0ZpbmRXZWJQLmNtYWtlOgorCiAyMDE2LTAzLTE4ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50 ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIG1pc3NpbmcgU0VUX0FORF9FWFBP U0VfVE9fQlVJTEQgZm9yIFVTRV9VRElTODYgaW4gSlNDT25seSBwb3J0Cg== 276331 2016-04-13 10:31:41 -0700 2016-04-13 15:58:22 -0700 Patch bug-156544-20160413203151.patch text/plain 2095 annulen U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4NjY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmlu ZFdlYlAuY21ha2UgYi9Tb3VyY2UvY21ha2UvRmluZFdlYlAuY21ha2UKaW5kZXggYTYyN2IxMzhj ZmRmOTI1OGUyYzdiNjI2ZTY1ZmE1Y2U0ODE4NjFiNS4uNjc3MjM1MmQ5NTcxZDk5MzgzN2YyZWZj MTY5NmJmNDI2NGRjNGQwMCAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtlL0ZpbmRXZWJQLmNtYWtl CisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kV2ViUC5jbWFrZQpAQCAtMzAsMTkgKzMwLDIyIEBACiAj IEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCiBmaW5kX3BhY2th Z2UoUGtnQ29uZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoV0VCUCBsaWJ3ZWJwKQorcGtnX2NoZWNr X21vZHVsZXMoUENfV0VCUCBRVUlFVCBsaWJ3ZWJwKQogCi1pZiAoTk9UKFdFQlBfRk9VTkQpKQot ICAgICMgT2xkZXIgaW5zdGFsbGF0aW9ucyBvZiBsaWJ3ZWJwIGRvIG5vdCBpbnN0YWxsIGEgcGtn Y29uZmlnIGZpbGUsIHNvIHdlIGZhbGwKLSAgICAjIGJhY2sgdG8gYSBtYW51YWwgc2VhcmNoIGZv ciBhIGxpYndlYnAgaGVhZGVyIGZpbGUuCi0gICAgaW5jbHVkZShDaGVja0luY2x1ZGVGaWxlcykK LSAgICBjaGVja19pbmNsdWRlX2ZpbGVzKCJ3ZWJwL2RlY29kZS5oIiBXRUJQX0ZPVU5EX0hFQURF UikKLSAgICBpZiAoV0VCUF9GT1VORF9IRUFERVIpCi0gICAgICAgIHNldChXRUJQX0xJQlJBUklF UyAiLWx3ZWJwIikKLSAgICAgICAgc2V0KFdFQlBfRk9VTkQgVFJVRSkKLSAgICBlbmRpZiAoKQot ZW5kaWYgKCkKKyMgTG9vayBmb3IgdGhlIGhlYWRlciBmaWxlLgorZmluZF9wYXRoKFdFQlBfSU5D TFVERV9ESVJTCisgICAgTkFNRVMgd2VicC9kZWNvZGUuaAorICAgIEhJTlRTICR7UENfV0VCUF9J TkNMVURFRElSfSAke1BDX1dFQlBfSU5DTFVERV9ESVJTfQorKQorbWFya19hc19hZHZhbmNlZChX RUJQX0lOQ0xVREVfRElSUykKKworIyBMb29rIGZvciB0aGUgbGlicmFyeS4KK2ZpbmRfbGlicmFy eSgKKyAgICBXRUJQX0xJQlJBUklFUworICAgIE5BTUVTIHdlYnAKKyAgICBISU5UUyAke1BDX1dF QlBfTElCRElSfSAke1BDX1dFQlBfTElCUkFSWV9ESVJTfQorKQorbWFya19hc19hZHZhbmNlZChX RUJQX0xJQlJBUklFUykKIAotIyBXRUJQX0lOQ0xVREVfRElSUyBpcyBvZnRlbiBlbXB0eSwgc28g d2UgcmVseSBvbmx5IG9uIFdFQlBfTElCUkFSSUVTLgogaW5jbHVkZShGaW5kUGFja2FnZUhhbmRs ZVN0YW5kYXJkQXJncykKLUZJTkRfUEFDS0FHRV9IQU5ETEVfU1RBTkRBUkRfQVJHUyhXRUJQIERF RkFVTFRfTVNHIFdFQlBfTElCUkFSSUVTKQorRklORF9QQUNLQUdFX0hBTkRMRV9TVEFOREFSRF9B UkdTKFdFQlAgREVGQVVMVF9NU0cgV0VCUF9JTkNMVURFX0RJUlMgV0VCUF9MSUJSQVJJRVMpCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjYyNGIwZDJmOWViMWIwNWFk ZDU0NDFmYTg0YTFkNDE3ZWE2NjA3YS4uMjQ0ZTA4Nzc3YTQ3NDVjOWQyZTZmMzIwZjVlZDI1YWNk NjYxZDJiMyAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDE2LTA0LTEzICBLb25zdGFudGluIFRva2FyZXYgIDxhbm51bGVuQHlhbmRleC5y dT4KKworICAgICAgICBGaW5kV2ViUCBzaG91bGQgbm90IGJlIG1pc2d1aWRlZCBieSBwa2ctY29u ZmlnIHdoZW4gY3Jvc3MtY29tcGlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIHVzZSBwa2ctY29uZmlnIG91dHB1dCBvbmx5IGFz IGEgaGludCwgbGlrZSBvdGhlciBtb2R1bGVzIGRvLgorCisgICAgICAgICogU291cmNlL2NtYWtl L0ZpbmRXZWJQLmNtYWtlOgorCiAyMDE2LTAzLTE4ICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50 ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIG1pc3NpbmcgU0VUX0FORF9FWFBP U0VfVE9fQlVJTEQgZm9yIFVTRV9VRElTODYgaW4gSlNDT25seSBwb3J0Cg==