156543 2016-04-13 09:31:16 -0700 REGRESSION: Web Inspector: Remote inspector doesn't work 2016-04-14 10:44:16 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply commit-queue dbates timothy oldest_to_newest 1183430 0 cgarcia 2016-04-13 09:31:16 -0700 It shows a nice error page saying there was an error: SecurityError:​ DOM Exception 18:​ An attempt was made to break through the security policy of the user agent. (at InspectorFrontendHostStub.js:​50:​39)​ It seems WebSockets are blocked. 1183657 1 cgarcia 2016-04-14 01:33:31 -0700 Adding ws to connect-src fixes this, but then it complains that InspectorFrontendHost.zoomFactor is undefined (this is probably due to r199396) 1183658 2 276379 cgarcia 2016-04-14 01:37:55 -0700 Created attachment 276379 Patch 1183659 3 cgarcia 2016-04-14 01:38:57 -0700 I don't think this is specific to GTK at all. 1183660 4 276380 cgarcia 2016-04-14 01:40:30 -0700 Created attachment 276380 Patch 1183732 5 timothy 2016-04-14 09:56:00 -0700 (In reply to comment #3) > I don't think this is specific to GTK at all. It affects anyone using InspectorFrontendHostStub, which we don't use on the Apple ports. This does open web sockets for us, even though the Inspector does not need them on our ports. That is probably fine. 1183746 6 276380 commit-queue 2016-04-14 10:44:12 -0700 Comment on attachment 276380 Patch Clearing flags on attachment: 276380 Committed r199541: <http://trac.webkit.org/changeset/199541> 1183747 7 commit-queue 2016-04-14 10:44:16 -0700 All reviewed patches have been landed. Closing bug. 276379 2016-04-14 01:37:55 -0700 2016-04-14 01:40:30 -0700 Patch wk-remote-inspector.diff text/plain 2703 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFmN2M0MjkuLjQ2Y2Q3Y2YgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA0LTE0ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBbR1RL XSBSZW1vdGUgaW5zcGVjdG9yIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NTQzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViU29ja2V0IGNvbm5lY3Rpb24gaXMgYmxvY2tlZCBi eSBDU1AsIGJ1dCBuZWVkZWQgYnkgdGhlIHJlbW90ZSB3ZWIgaW5zcGVjdG9yIHRvIHdvcmssIHNv IGFsbG93IGNvbm5lY3QgdG8gd3MKKyAgICAgICAgVVJMcyBmcm9tIHRoZSB3ZWIgaW5zcGVjdG9y LiBBbHNvIGFkZCBzdHVicyBmb3Igem9vbUZhY3RvciBhbmQgc2V0Wm9vbUZhY3RvciB0byBJbnNw ZWN0b3JGcm9udGVuZEhvc3RTdHViLAorICAgICAgICByZXF1aXJlZCBhZnRlciByMTk5Mzk2Lgor CisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIu anM6CisgICAgICAgICh3aW5kb3cuSW5zcGVjdG9yRnJvbnRlbmRIb3N0LldlYkluc3BlY3Rvci5J bnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLnByb3RvdHlwZS5zZXRab29tRmFjdG9yKToKKyAgICAg ICAgKHdpbmRvdy5JbnNwZWN0b3JGcm9udGVuZEhvc3QuV2ViSW5zcGVjdG9yLkluc3BlY3RvckZy b250ZW5kSG9zdFN0dWIucHJvdG90eXBlLnpvb21GYWN0b3IpOgorICAgICAgICAqIFVzZXJJbnRl cmZhY2UvTWFpbi5odG1sOgorCiAyMDE2LTA0LTEyICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHNhdmUgaW5zcGVjdG9yJ3Mgem9vbSBmYWN0 b3IgYXMgYSBwZXJzaXN0ZW50IHNldHRpbmcgYWNyb3NzIHNlc3Npb25zCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL0luc3BlY3RvckZyb250ZW5k SG9zdFN0dWIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL0lu c3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMKaW5kZXggNzY1ZTY3NC4uYzM5MjM0MSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9JbnNwZWN0b3JG cm9udGVuZEhvc3RTdHViLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcwpAQCAtMTY4LDYgKzE2OCwxNSBA QCBpZiAoIXdpbmRvdy5JbnNwZWN0b3JGcm9udGVuZEhvc3QpIHsKICAgICAgICAgICAgIGNvbnNv bGUubG9nLmFwcGx5KGNvbnNvbGUsIGFyZ3VtZW50cyk7CiAgICAgICAgIH0sCiAKKyAgICAgICAg c2V0Wm9vbUZhY3RvcjogZnVuY3Rpb24oem9vbSkKKyAgICAgICAgeworICAgICAgICB9LAorCisg ICAgICAgIHpvb21GYWN0b3I6IGZ1bmN0aW9uKCkKKyAgICAgICAgeworICAgICAgICAgICAgcmV0 dXJuIDE7CisgICAgICAgIH0sCisKICAgICAgICAgLy8gUHJpdmF0ZQogCiAgICAgICAgIF9zZW5k UGVuZGluZ01lc3NhZ2VzVG9CYWNrZW5kSWZOZWVkZWQ6IGZ1bmN0aW9uKCkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbCBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbAppbmRleCA0ZjZjMjU3Li45Y2M5 NWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9NYWlu Lmh0bWwKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTWFpbi5odG1s CkBAIC0yNiw3ICsyNiw3IEBACiA8aHRtbD4KIDxoZWFkPgogICAgIDxtZXRhIGh0dHAtZXF1aXY9 IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KLSAgICA8 bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVNlY3VyaXR5LVBvbGljeSIgY29udGVudD0iZGVmYXVs dC1zcmMgJ3NlbGYnOyBpbWctc3JjICogZmlsZTogYmxvYjogcmVzb3VyY2U6OyBjb25uZWN0LXNy YyAqOyBtZWRpYS1zcmMgKiBibG9iOjsgZm9udC1zcmMgKiBibG9iOjsgc3R5bGUtc3JjICdzZWxm JyAndW5zYWZlLWlubGluZSc7IHNjcmlwdC1zcmMgJ3NlbGYnICd1bnNhZmUtaW5saW5lJyI+Cisg ICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1TZWN1cml0eS1Qb2xpY3kiIGNvbnRlbnQ9ImRl ZmF1bHQtc3JjICdzZWxmJzsgaW1nLXNyYyAqIGZpbGU6IGJsb2I6IHJlc291cmNlOjsgY29ubmVj dC1zcmMgKiB3czo7IG1lZGlhLXNyYyAqIGJsb2I6OyBmb250LXNyYyAqIGJsb2I6OyBzdHlsZS1z cmMgJ3NlbGYnICd1bnNhZmUtaW5saW5lJzsgc2NyaXB0LXNyYyAnc2VsZicgJ3Vuc2FmZS1pbmxp bmUnIj4KIAogICAgIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iRXh0ZXJuYWwvQ29kZU1p cnJvci9jb2RlbWlycm9yLmNzcyI+CiAK 276380 2016-04-14 01:40:30 -0700 2016-04-14 10:44:12 -0700 Patch wk-remote-inspector.diff text/plain 2712 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFmN2M0MjkuLjlmMjkwMjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA0LTE0ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OOiBXZWIg SW5zcGVjdG9yOiBSZW1vdGUgaW5zcGVjdG9yIGRvZXNuJ3Qgd29yaworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NTQzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViU29ja2V0IGNvbm5lY3Rpb24gaXMg YmxvY2tlZCBieSBDU1AsIGJ1dCBuZWVkZWQgYnkgdGhlIHJlbW90ZSB3ZWIgaW5zcGVjdG9yIHRv IHdvcmssIHNvIGFsbG93IGNvbm5lY3QgdG8gd3MKKyAgICAgICAgVVJMcyBmcm9tIHRoZSB3ZWIg aW5zcGVjdG9yLiBBbHNvIGFkZCBzdHVicyBmb3Igem9vbUZhY3RvciBhbmQgc2V0Wm9vbUZhY3Rv ciB0byBJbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLAorICAgICAgICByZXF1aXJlZCBhZnRlciBy MTk5Mzk2LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL0luc3BlY3RvckZyb250ZW5k SG9zdFN0dWIuanM6CisgICAgICAgICh3aW5kb3cuSW5zcGVjdG9yRnJvbnRlbmRIb3N0LldlYklu c3BlY3Rvci5JbnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLnByb3RvdHlwZS5zZXRab29tRmFjdG9y KToKKyAgICAgICAgKHdpbmRvdy5JbnNwZWN0b3JGcm9udGVuZEhvc3QuV2ViSW5zcGVjdG9yLklu c3BlY3RvckZyb250ZW5kSG9zdFN0dWIucHJvdG90eXBlLnpvb21GYWN0b3IpOgorICAgICAgICAq IFVzZXJJbnRlcmZhY2UvTWFpbi5odG1sOgorCiAyMDE2LTA0LTEyICBCcmlhbiBCdXJnICA8YmJ1 cmdAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHNhdmUgaW5zcGVjdG9yJ3Mg em9vbSBmYWN0b3IgYXMgYSBwZXJzaXN0ZW50IHNldHRpbmcgYWNyb3NzIHNlc3Npb25zCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL0luc3BlY3Rv ckZyb250ZW5kSG9zdFN0dWIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL0luc3BlY3RvckZyb250ZW5kSG9zdFN0dWIuanMKaW5kZXggNzY1ZTY3NC4uYzM5MjM0 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9J bnNwZWN0b3JGcm9udGVuZEhvc3RTdHViLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvSW5zcGVjdG9yRnJvbnRlbmRIb3N0U3R1Yi5qcwpAQCAtMTY4LDYg KzE2OCwxNSBAQCBpZiAoIXdpbmRvdy5JbnNwZWN0b3JGcm9udGVuZEhvc3QpIHsKICAgICAgICAg ICAgIGNvbnNvbGUubG9nLmFwcGx5KGNvbnNvbGUsIGFyZ3VtZW50cyk7CiAgICAgICAgIH0sCiAK KyAgICAgICAgc2V0Wm9vbUZhY3RvcjogZnVuY3Rpb24oem9vbSkKKyAgICAgICAgeworICAgICAg ICB9LAorCisgICAgICAgIHpvb21GYWN0b3I6IGZ1bmN0aW9uKCkKKyAgICAgICAgeworICAgICAg ICAgICAgcmV0dXJuIDE7CisgICAgICAgIH0sCisKICAgICAgICAgLy8gUHJpdmF0ZQogCiAgICAg ICAgIF9zZW5kUGVuZGluZ01lc3NhZ2VzVG9CYWNrZW5kSWZOZWVkZWQ6IGZ1bmN0aW9uKCkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbCBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01haW4uaHRtbAppbmRleCA0ZjZj MjU3Li45Y2M5NWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9NYWluLmh0bWwKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TWFpbi5odG1sCkBAIC0yNiw3ICsyNiw3IEBACiA8aHRtbD4KIDxoZWFkPgogICAgIDxtZXRhIGh0 dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04 Ij4KLSAgICA8bWV0YSBodHRwLWVxdWl2PSJDb250ZW50LVNlY3VyaXR5LVBvbGljeSIgY29udGVu dD0iZGVmYXVsdC1zcmMgJ3NlbGYnOyBpbWctc3JjICogZmlsZTogYmxvYjogcmVzb3VyY2U6OyBj b25uZWN0LXNyYyAqOyBtZWRpYS1zcmMgKiBibG9iOjsgZm9udC1zcmMgKiBibG9iOjsgc3R5bGUt c3JjICdzZWxmJyAndW5zYWZlLWlubGluZSc7IHNjcmlwdC1zcmMgJ3NlbGYnICd1bnNhZmUtaW5s aW5lJyI+CisgICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1TZWN1cml0eS1Qb2xpY3kiIGNv bnRlbnQ9ImRlZmF1bHQtc3JjICdzZWxmJzsgaW1nLXNyYyAqIGZpbGU6IGJsb2I6IHJlc291cmNl OjsgY29ubmVjdC1zcmMgKiB3czo7IG1lZGlhLXNyYyAqIGJsb2I6OyBmb250LXNyYyAqIGJsb2I6 OyBzdHlsZS1zcmMgJ3NlbGYnICd1bnNhZmUtaW5saW5lJzsgc2NyaXB0LXNyYyAnc2VsZicgJ3Vu c2FmZS1pbmxpbmUnIj4KIAogICAgIDxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iRXh0ZXJu YWwvQ29kZU1pcnJvci9jb2RlbWlycm9yLmNzcyI+CiAK