15654 2007-10-23 19:28:57 -0700 [GTK] GdkPixbuf support for ImageCairo 2009-04-23 08:40:29 -0700 1 1 1 Unclassified WebKit New Bugs 523.x (Safari 3) All All RESOLVED FIXED Cairo, Gtk P2 Normal --- 1 alp webkit-unassigned alp gustavo krit xan.lopez oldest_to_newest 59294 0 alp 2007-10-23 19:28:57 -0700 We need interoperability between GdkPixbuf and ImageCairo to implement certain features. It may even be the case that we want Image in the GTK+ port to be implemented using GdkPixbuf rather than a Cairo surface. 96699 1 krit 2008-10-26 04:03:28 -0700 (In reply to comment #0) > We need interoperability between GdkPixbuf and ImageCairo to implement certain > features. It may even be the case that we want Image in the GTK+ port to be > implemented using GdkPixbuf rather than a Cairo surface. What is the benefit of GdkPixbuf? Why should we use GdkPixbuf instead of a cairo_surface? Expecially if you read http://live.gnome.org/GtkCairoIntegration. It is intented to replace GdkPixbuf in Gtk by cairo (at least in parts of it). The biggest problem seems to be point 2 in the problems list. We'll have to do something like in 'Workarounds & Solutions' on the same link. 96885 2 alp 2008-10-28 11:37:28 -0700 (In reply to comment #1) > (In reply to comment #0) > > We need interoperability between GdkPixbuf and ImageCairo to implement certain > > features. It may even be the case that we want Image in the GTK+ port to be > > implemented using GdkPixbuf rather than a Cairo surface. > > What is the benefit of GdkPixbuf? Why should we use GdkPixbuf instead of a > cairo_surface? Expecially if you read > http://live.gnome.org/GtkCairoIntegration. It is intented to replace GdkPixbuf > in Gtk by cairo (at least in parts of it). > The biggest problem seems to be point 2 in the problems list. > We'll have to do something like in 'Workarounds & Solutions' on the same link. > I don't think there's any need to switch to GdkPixbuf or stop using cairo_surface. This bug is just here to add some integration between the image classes in GTK+ and the WebCore Cairo backend so we can easily take GdkPixbufs handed to us by GTK+ and render them with Cairo, and vice-versa, generate GdkPixbufs based on Cairo surfaces if we need to expose them in the WebKit GTK+ API for example. This kind of integration could be helpful for Cursor.h and custom image cursors and I think the file chooser needed something like this too. Hope things are a little clearer now. 111646 3 28125 zan 2009-02-28 12:58:31 -0800 Created attachment 28125 Converting Cairo's surfaces to GdkPixbuf Implements a function for converting Cairo's surfaces to GdkPixbufs. There might be a more hackish way of doing this, but I vote this one for being the prettiest. 112734 4 xan.lopez 2009-03-07 13:12:54 -0800 (In reply to comment #3) > Created an attachment (id=28125) [review] > Converting Cairo's surfaces to GdkPixbuf > > Implements a function for converting Cairo's surfaces to GdkPixbufs. There > might be a more hackish way of doing this, but I vote this one for being the > prettiest. > Looks reasonable to me. 113766 5 krit 2009-03-14 12:10:15 -0700 (In reply to comment #3) > Created an attachment (id=28125) [review] > Converting Cairo's surfaces to GdkPixbuf > > Implements a function for converting Cairo's surfaces to GdkPixbufs. There > might be a more hackish way of doing this, but I vote this one for being the > prettiest. > Hi, just a question about GdkPixmap* pixmap = gdk_pixmap_new(0, width, height, 24); Won't we loose the alpha channel here? Isn't 32 a better choice here? (If 32 is possible). We'll need the alpha channel for example on cursors with images. 113918 6 28658 zan 2009-03-16 13:25:08 -0700 Created attachment 28658 Converting Cairo's surfaces to GdkPixbuf, take 2 24 -> 32. Alpha channel should now be preserved through the conversion. 118207 7 gustavo 2009-04-20 19:14:56 -0700 (In reply to comment #6) > Created an attachment (id=28658) [review] > Converting Cairo's surfaces to GdkPixbuf, take 2 > > 24 -> 32. Alpha channel should now be preserved through the conversion. > The patch looks good to me, too, but I still fail to think of a use-case. I think we should have at least one patch using this functionality so that it gets a bit of real-world testing before we take it. Otherwise this may end up being something we have but use for nothing, for a long time. 118254 8 krit 2009-04-21 03:01:01 -0700 (In reply to comment #7) > The patch looks good to me, too, but I still fail to think of a use-case. I > think we should have at least one patch using this functionality so that it > gets a bit of real-world testing before we take it. Otherwise this may end up > being something we have but use for nothing, for a long time. A possible use-case is a cursor icon: https://bugs.webkit.org/show_bug.cgi?id=24565 118323 9 28125 gustavo 2009-04-21 15:42:26 -0700 Comment on attachment 28125 Converting Cairo's surfaces to GdkPixbuf (In reply to comment #8) > A possible use-case is a cursor icon: > https://bugs.webkit.org/show_bug.cgi?id=24565 Right, thanks krit! This one is good to go then, IMO. What about you cook us a patch for those cursors now? =D 118470 10 28658 gustavo 2009-04-22 20:22:31 -0700 Comment on attachment 28658 Converting Cairo's surfaces to GdkPixbuf, take 2 hah... of course I reviewed the wrong patch; I also found that there's a commented out function in Pasteboard::writeImage (at WebKit/WebCore/platform/gtk/) that is waiting on this. 118498 11 gustavo 2009-04-23 08:40:29 -0700 Landed as r42780. Thanks, Zan! 28125 2009-02-28 12:58:31 -0800 2009-04-21 15:42:26 -0700 Converting Cairo's surfaces to GdkPixbuf dnd-2.diff text/plain 3010 zan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTg3Y2ZiMS4uNzc3MzM1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wMi0yOCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTY1NAorICAgICAgICBHZGtQaXhidWYgc3VwcG9ydCBmb3IgSW1hZ2VDYWlybworCisgICAg ICAgIEFkZCBzdXBwb3J0IGZvciBjb252ZXJ0aW5nIGEgQ2Fpcm8gc3VyZmFjZSB0byBhIEdka1Bp eGJ1Zi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmg6CisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdl OjpnZXRHZGtQaXhidWYpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0 ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6Z2V0R2RrUGl4YnVmKToKKwog MjAwOS0wMi0yNSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z25zQGdub21lLm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4gQWRkIFdlYkNvcmUvd29ya2VycyB0byB0aGUgbGlz dCBvZiBwYXRocwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJ bWFnZS5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCmluZGV4IDZm MDI2YTkuLmQxZmEyNWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvQml0 bWFwSW1hZ2UuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgK QEAgLTE0MCw2ICsxNDAsMTAgQEAgcHVibGljOgogICAgIHZpcnR1YWwgYm9vbCBnZXRIQklUTUFQ T2ZTaXplKEhCSVRNQVAsIExQU0laRSk7CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKEdUSykKKyAg ICB2aXJ0dWFsIEdka1BpeGJ1ZiogZ2V0R2RrUGl4YnVmKCk7CisjZW5kaWYKKwogICAgIHZpcnR1 YWwgTmF0aXZlSW1hZ2VQdHIgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSB7IHJldHVybiBm cmFtZUF0SW5kZXgoY3VycmVudEZyYW1lKCkpOyB9CiAKIHByb3RlY3RlZDoKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvSW1hZ2UuaAppbmRleCBkZGQwYWY0Li44YjZhZjViIDEwMDY0NAotLS0gYS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9JbWFnZS5oCkBAIC02MSw2ICs2MSwxMCBAQCBjbGFzcyBOYXRpdmVJbWFnZVNraWE7CiAjaW5j bHVkZSA8UVBpeG1hcD4KICNlbmRpZgogCisjaWYgUExBVEZPUk0oR1RLKQordHlwZWRlZiBzdHJ1 Y3QgX0dka1BpeGJ1ZiBHZGtQaXhidWY7CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewog CiBjbGFzcyBUcmFuc2Zvcm1hdGlvbk1hdHJpeDsKQEAgLTE0Miw2ICsxNDYsMTAgQEAgcHVibGlj OgogICAgIHZpcnR1YWwgYm9vbCBnZXRIQklUTUFQT2ZTaXplKEhCSVRNQVAsIExQU0laRSkgeyBy ZXR1cm4gZmFsc2U7IH0KICNlbmRpZgogCisjaWYgUExBVEZPUk0oR1RLKQorICAgIHZpcnR1YWwg R2RrUGl4YnVmKiBnZXRHZGtQaXhidWYoKSB7IHJldHVybiAwOyB9CisjZW5kaWYKKwogcHJvdGVj dGVkOgogICAgIEltYWdlKEltYWdlT2JzZXJ2ZXIqID0gMCk7CiAKZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3RrL0ltYWdlR3RrLmNwcAppbmRleCBiNzQ1MjA5Li41NjNmZmRkIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0ay5jcHAKKysrIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvSW1hZ2VHdGsuY3BwCkBAIC0yNyw2ICsyNyw5IEBA CiAKICNpbmNsdWRlICJCaXRtYXBJbWFnZS5oIgogCisjaW5jbHVkZSA8Y2Fpcm8uaD4KKyNpbmNs dWRlIDxndGsvZ3RrLmg+CisKIC8vIFRoaXMgZnVuY3Rpb24gbG9hZHMgcmVzb3VyY2VzIGZyb20g V2ViS2l0CiBWZWN0b3I8Y2hhcj4gbG9hZFJlc291cmNlSW50b0FycmF5KGNvbnN0IGNoYXIqKTsK IApAQCAtNDksNCArNTIsMjEgQEAgUGFzc1JlZlB0cjxJbWFnZT4gSW1hZ2U6OmxvYWRQbGF0Zm9y bVJlc291cmNlKGNvbnN0IGNoYXIgKm5hbWUpCiAgICAgcmV0dXJuIGltZy5yZWxlYXNlKCk7CiB9 CiAKK0dka1BpeGJ1ZiogQml0bWFwSW1hZ2U6OmdldEdka1BpeGJ1ZigpCit7CisgICAgaW50IHdp ZHRoID0gY2Fpcm9faW1hZ2Vfc3VyZmFjZV9nZXRfd2lkdGgoZnJhbWVBdEluZGV4KGN1cnJlbnRG cmFtZSgpKSk7CisgICAgaW50IGhlaWdodCA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X2hlaWdo dChmcmFtZUF0SW5kZXgoY3VycmVudEZyYW1lKCkpKTsKKworICAgIEdka1BpeG1hcCogcGl4bWFw ID0gZ2RrX3BpeG1hcF9uZXcoMCwgd2lkdGgsIGhlaWdodCwgMjQpOworICAgIGNhaXJvX3QqIGNy ID0gZ2RrX2NhaXJvX2NyZWF0ZShHREtfRFJBV0FCTEUocGl4bWFwKSk7CisgICAgY2Fpcm9fc2V0 X3NvdXJjZV9zdXJmYWNlKGNyLCBmcmFtZUF0SW5kZXgoY3VycmVudEZyYW1lKCkpLCAwLCAwKTsK KyAgICBjYWlyb19wYWludChjcik7CisgICAgY2Fpcm9fZGVzdHJveShjcik7CisKKyAgICBHZGtQ aXhidWYqIHBpeGJ1ZiA9IGdka19waXhidWZfZ2V0X2Zyb21fZHJhd2FibGUoMCwgR0RLX0RSQVdB QkxFKHBpeG1hcCksIDAsIDAsIDAsIDAsIDAsIHdpZHRoLCBoZWlnaHQpOworICAgIGdfb2JqZWN0 X3VucmVmKHBpeG1hcCk7CisKKyAgICByZXR1cm4gcGl4YnVmOworfQorCiB9Cg== 28658 2009-03-16 13:25:08 -0700 2009-04-22 20:22:31 -0700 Converting Cairo's surfaces to GdkPixbuf, take 2 dnd-2.diff text/plain 2978 zan ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzE0ZTFlNy4uYzg3ZTdhMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAwOS0wMy0xNiAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTY1NAorICAgICAgICBHZGtQaXhidWYgc3VwcG9ydCBmb3IgSW1hZ2VDYWlybworCisgICAg ICAgIEFkZCBzdXBwb3J0IGZvciBjb252ZXJ0aW5nIGEgQ2Fpcm8gc3VyZmFjZSB0byBhIEdka1Bp eGJ1Zi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmg6CisgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdl OjpnZXRHZGtQaXhidWYpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0 ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6Z2V0R2RrUGl4YnVmKToKKwog MjAwOS0wMy0xNiAgRGltaXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvQml0bWFwSW1hZ2UuaAppbmRleCA0MjJjMzU2Li44Yjc3MGExIDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9CaXRtYXBJbWFnZS5oCkBAIC0xNDAsNiArMTQwLDEwIEBAIHB1YmxpYzoKICAg ICB2aXJ0dWFsIGJvb2wgZ2V0SEJJVE1BUE9mU2l6ZShIQklUTUFQLCBMUFNJWkUpOwogI2VuZGlm CiAKKyNpZiBQTEFURk9STShHVEspCisgICAgdmlydHVhbCBHZGtQaXhidWYqIGdldEdka1BpeGJ1 ZigpOworI2VuZGlmCisKICAgICB2aXJ0dWFsIE5hdGl2ZUltYWdlUHRyIG5hdGl2ZUltYWdlRm9y Q3VycmVudEZyYW1lKCkgeyByZXR1cm4gZnJhbWVBdEluZGV4KGN1cnJlbnRGcmFtZSgpKTsgfQog CiBwcm90ZWN0ZWQ6CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdl LmggYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlLmgKaW5kZXggYjgzMmJlOS4uMzQ1 Y2M1OSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuaApAQCAtNjEsNiArNjEsMTAgQEAgY2xh c3MgTmF0aXZlSW1hZ2VTa2lhOwogI2luY2x1ZGUgPFFQaXhtYXA+CiAjZW5kaWYKIAorI2lmIFBM QVRGT1JNKEdUSykKK3R5cGVkZWYgc3RydWN0IF9HZGtQaXhidWYgR2RrUGl4YnVmOworI2VuZGlm CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgVHJhbnNmb3JtYXRpb25NYXRyaXg7CkBA IC0xNDIsNiArMTQ2LDEwIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgZ2V0SEJJVE1BUE9m U2l6ZShIQklUTUFQLCBMUFNJWkUpIHsgcmV0dXJuIGZhbHNlOyB9CiAjZW5kaWYKIAorI2lmIFBM QVRGT1JNKEdUSykKKyAgICB2aXJ0dWFsIEdka1BpeGJ1ZiogZ2V0R2RrUGl4YnVmKCkgeyByZXR1 cm4gMDsgfQorI2VuZGlmCisKIHByb3RlY3RlZDoKICAgICBJbWFnZShJbWFnZU9ic2VydmVyKiA9 IDApOwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0 ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9JbWFnZUd0ay5jcHAKaW5kZXgg Yjc0NTIwOS4uY2FmMzA2OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9n dGsvSW1hZ2VHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL0ltYWdl R3RrLmNwcApAQCAtMjcsNiArMjcsOSBAQAogCiAjaW5jbHVkZSAiQml0bWFwSW1hZ2UuaCIKIAor I2luY2x1ZGUgPGNhaXJvLmg+CisjaW5jbHVkZSA8Z3RrL2d0ay5oPgorCiAvLyBUaGlzIGZ1bmN0 aW9uIGxvYWRzIHJlc291cmNlcyBmcm9tIFdlYktpdAogVmVjdG9yPGNoYXI+IGxvYWRSZXNvdXJj ZUludG9BcnJheShjb25zdCBjaGFyKik7CiAKQEAgLTQ5LDQgKzUyLDIxIEBAIFBhc3NSZWZQdHI8 SW1hZ2U+IEltYWdlOjpsb2FkUGxhdGZvcm1SZXNvdXJjZShjb25zdCBjaGFyICpuYW1lKQogICAg IHJldHVybiBpbWcucmVsZWFzZSgpOwogfQogCitHZGtQaXhidWYqIEJpdG1hcEltYWdlOjpnZXRH ZGtQaXhidWYoKQoreworICAgIGludCB3aWR0aCA9IGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X3dp ZHRoKGZyYW1lQXRJbmRleChjdXJyZW50RnJhbWUoKSkpOworICAgIGludCBoZWlnaHQgPSBjYWly b19pbWFnZV9zdXJmYWNlX2dldF9oZWlnaHQoZnJhbWVBdEluZGV4KGN1cnJlbnRGcmFtZSgpKSk7 CisKKyAgICBHZGtQaXhtYXAqIHBpeG1hcCA9IGdka19waXhtYXBfbmV3KDAsIHdpZHRoLCBoZWln aHQsIDMyKTsKKyAgICBjYWlyb190KiBjciA9IGdka19jYWlyb19jcmVhdGUoR0RLX0RSQVdBQkxF KHBpeG1hcCkpOworICAgIGNhaXJvX3NldF9zb3VyY2Vfc3VyZmFjZShjciwgZnJhbWVBdEluZGV4 KGN1cnJlbnRGcmFtZSgpKSwgMCwgMCk7CisgICAgY2Fpcm9fcGFpbnQoY3IpOworICAgIGNhaXJv X2Rlc3Ryb3koY3IpOworCisgICAgR2RrUGl4YnVmKiBwaXhidWYgPSBnZGtfcGl4YnVmX2dldF9m cm9tX2RyYXdhYmxlKDAsIEdES19EUkFXQUJMRShwaXhtYXApLCAwLCAwLCAwLCAwLCAwLCB3aWR0 aCwgaGVpZ2h0KTsKKyAgICBnX29iamVjdF91bnJlZihwaXhtYXApOworCisgICAgcmV0dXJuIHBp eGJ1ZjsKK30KKwogfQo=