156538 2016-04-13 08:10:35 -0700 Fix two coding mistakes in MathMLInlineContainerElement::childrenChanged 2016-04-13 09:16:11 -0700 1 1 1 Unclassified WebKit MathML WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 152244 1 fred.wang fred.wang commit-queue dbarton mrobinson rego oldest_to_newest 1183395 0 fred.wang 2016-04-13 08:10:35 -0700 From the ChangeLog of attachment 276110: mathml/MathMLInlineContainerElement.cpp: The base wrapper of the <msqrt> element is actually the last child in the render tree. Selecting the correct wrapper makes presentation/mo-form-dynamic.html pass. The <math> element does not have anonymous child but is already a RenderMathMLRow, so we remove the special case for it. 1183399 1 276322 fred.wang 2016-04-13 08:29:55 -0700 Created attachment 276322 Patch 1183418 2 fred.wang 2016-04-13 09:16:11 -0700 Committed r199497: <http://trac.webkit.org/changeset/199497> 276322 2016-04-13 08:29:55 -0700 2016-04-13 08:33:47 -0700 Patch bug-156538-20160413173005.patch text/plain 3010 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NDU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVjYjllMTlmY2U5ZmY4 MzM2NWUyOWQ0YjAxYjMxOTgzMjRiMDE1NS4uODEwM2IyODgwNjU4NWIyNThlZGI2ZGY5ZDI4ZjE0 ODI2Zjc3YTE0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE2LTA0LTEzICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXggdHdvIGNvZGluZyBt aXN0YWtlcyBpbiBNYXRoTUxJbmxpbmVDb250YWluZXJFbGVtZW50OjpjaGlsZHJlbkNoYW5nZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjUzOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGZpeCB0 aGUgY2FsbCB0byB1cGRhdGVPcGVyYXRvclByb3BlcnRpZXMgaW5zaWRlIE1hdGhNTElubGluZUNv bnRhaW5lckVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZAorICAgICAgICBmb3IgdGhlIDxtYXRoPiBh bmQgPG1zcXJ0PiB0YWdzLgorCisgICAgICAgIFRoZSA8bWF0aD4gdGFnIGlzIGFscmVhZHkgYSBS ZW5kZXJNYXRoTUxSb3cgc28gdGhlIGhhc1RhZ05hbWUobWF0aFRhZykKKyAgICAgICAgY29uZGl0 aW9uYWwgaXMgbmV2ZXIgZXhlY3V0ZWQuIFRoZSB0YWcgZG9lcyBub3QgY3JlYXRlIGFueSBhbm9u eW1vdXMKKyAgICAgICAgd3JhcHBlciBzbyB3ZSBkbyBub3QgbmVlZCBhIHNwZWNpYWwgY2FzZSBm b3IgaXQgYW55d2F5LgorCisgICAgICAgIFRoZSA8bXNxcnQ+IHRhZyBpcyBub3QgYSBSZW5kZXJN YXRoTUxSb3cgKHlldCkuIEhvd2V2ZXIsIHRoZSBhbm9ueW1vdXMKKyAgICAgICAgd3JhcHBlciBi ZWhhdmluZyBhcyBhIFJlbmRlck1hdGhNTFJvdyBpcyBhY3R1YWxseSB0aGUgbGFzdCBjaGlsZCwg bm90CisgICAgICAgIHRoZSBmaXJzdCBvbmUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGlz IGlzIGFscmVhZHkgY292ZXJlZCBieSBtYXRobWwvcHJlc2VudGF0aW9uL21vLWZvcm0tZHluYW1p Yy5odG1sCisgICAgICAgIE5vdGUgdGhhdCBmb3Igc29tZSByZWFzb24gdGhlIGNvZGluZyBlcnJv ciBmb3IgPG1zcXJ0PiBvbmx5IHNob3dzIHVwCisgICAgICAgIGFmdGVyIHRoZSByZWZhY3Rvcmlu ZyBvZiBidWcgMTUyMjQ0LgorCisgICAgICAgICogbWF0aG1sL01hdGhNTElubGluZUNvbnRhaW5l ckVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWF0aE1MSW5saW5lQ29udGFpbmVyRWxl bWVudDo6Y2hpbGRyZW5DaGFuZ2VkKTogRml4IHRoZSB0d28gbWlzdGFrZXMgYW5kIGFkZCBzb21l IEZJWE1FIGNvbW1lbnRzLgorCiAyMDE2LTA0LTEyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CiAKICAgICAgICAgQXR0ci52YWx1ZSBzaG91bGQgbm90IGJlIG51bGxhYmxlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9tYXRobWwvTWF0aE1MSW5saW5lQ29udGFpbmVyRWxlbWVu dC5jcHAKaW5kZXggODAxMWI1ZTU0NDEyMzIzYWVmMWNiZGZjOWMyZmU1ZjUxYWE3MTlmYi4uN2Vi MTIyMjViNWY2ZWQzNGFmMTQ2NjU0OWViOGYyZjZiNTFjYjUyYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvbWF0aG1sL01hdGhNTElubGluZUNvbnRhaW5lckVsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL21hdGhtbC9NYXRoTUxJbmxpbmVDb250YWluZXJFbGVtZW50LmNwcApAQCAt NTgsMTAgKzU4LDE1IEBAIFJlZjxNYXRoTUxJbmxpbmVDb250YWluZXJFbGVtZW50PiBNYXRoTUxJ bmxpbmVDb250YWluZXJFbGVtZW50OjpjcmVhdGUoY29uc3QgUXVhCiB2b2lkIE1hdGhNTElubGlu ZUNvbnRhaW5lckVsZW1lbnQ6OmNoaWxkcmVuQ2hhbmdlZChjb25zdCBDaGlsZENoYW5nZSYgY2hh bmdlKQogewogICAgIGlmIChyZW5kZXJlcigpKSB7CisgICAgICAgIC8vIEZJWE1FOiBQYXJzaW5n IG9mIG9wZXJhdG9yIHByb3BlcnRpZXMgc2hvdWxkIGJlIGRvbmUgaW4gdGhlIGVsZW1lbnQgY2xh c3NlcyByYXRoZXIgdGhhbiBpbiB0aGUgcmVuZGVyZXIgY2xhc3Nlcy4KKyAgICAgICAgLy8gU2Vl IGh0dHA6Ly93ZWJraXQub3JnL2IvMTU2NTM3CiAgICAgICAgIGlmIChpczxSZW5kZXJNYXRoTUxS b3c+KCpyZW5kZXJlcigpKSkKICAgICAgICAgICAgIGRvd25jYXN0PFJlbmRlck1hdGhNTFJvdz4o KnJlbmRlcmVyKCkpLnVwZGF0ZU9wZXJhdG9yUHJvcGVydGllcygpOwotICAgICAgICBlbHNlIGlm IChoYXNUYWdOYW1lKG1hdGhUYWcpIHx8IGhhc1RhZ05hbWUobXNxcnRUYWcpKSB7Ci0gICAgICAg ICAgICBhdXRvKiBjaGlsZFJlbmRlcmVyID0gcmVuZGVyZXIoKS0+Zmlyc3RDaGlsZCgpOworICAg ICAgICBlbHNlIGlmIChoYXNUYWdOYW1lKG1zcXJ0VGFnKSkgeworICAgICAgICAgICAgLy8gVXBk YXRlIG9wZXJhdG9yIHByb3BlcnRpZXMgZm9yIHRoZSBiYXNlIHdyYXBwZXIuCisgICAgICAgICAg ICAvLyBGSVhNRTogVGhpcyB3b24ndCBiZSBuZWNlc3Nhcnkgd2hlbiBSZW5kZXJNYXRoTUxTcXVh cmVSb290IGRlcml2ZXMgZnJvbSBSZW5kZXJNYXRoTUxSb3cgYW5kIGRvZXMgbm90IHVzZSBhbm9u eW1vdXMgd3JhcHBlcnMuCisgICAgICAgICAgICAvLyBTZWUgaHR0cDovL3dlYmtpdC5vcmcvYi8x NTM5ODcKKyAgICAgICAgICAgIGF1dG8qIGNoaWxkUmVuZGVyZXIgPSByZW5kZXJlcigpLT5sYXN0 Q2hpbGQoKTsKICAgICAgICAgICAgIGlmIChpczxSZW5kZXJNYXRoTUxSb3c+KGNoaWxkUmVuZGVy ZXIpKQogICAgICAgICAgICAgICAgIGRvd25jYXN0PFJlbmRlck1hdGhNTFJvdz4oKmNoaWxkUmVu ZGVyZXIpLnVwZGF0ZU9wZXJhdG9yUHJvcGVydGllcygpOwogICAgICAgICB9Cg==