156527 2016-04-12 17:53:43 -0700 Fix client certificate authentication with NetworkSession 2016-04-13 10:37:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen commit-queue oldest_to_newest 1183313 0 achristensen 2016-04-12 17:53:43 -0700 Fix client certificate authentication with NetworkSession 1183314 1 276298 achristensen 2016-04-12 18:00:38 -0700 Created attachment 276298 Patch 1183410 2 276298 darin 2016-04-13 08:50:16 -0700 Comment on attachment 276298 Patch Can we add test coverage? 1183434 3 achristensen 2016-04-13 09:55:31 -0700 (In reply to comment #2) > Comment on attachment 276298 [details] > Patch > > Can we add test coverage? For this, I used a manual test at ssl.geoffk.org. We currently have no infrastructure for using valid certificates for ssl testing. This is a much bigger problem than the scope of this bug. 1183443 4 276298 commit-queue 2016-04-13 10:37:43 -0700 Comment on attachment 276298 Patch Clearing flags on attachment: 276298 Committed r199501: <http://trac.webkit.org/changeset/199501> 1183444 5 commit-queue 2016-04-13 10:37:47 -0700 All reviewed patches have been landed. Closing bug. 276298 2016-04-12 18:00:38 -0700 2016-04-13 10:37:43 -0700 Patch bug-156527-20160412180048.patch text/plain 7066 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTM5OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA0LTEyICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNsaWVu dCBjZXJ0aWZpY2F0ZSBhdXRoZW50aWNhdGlvbiB3aXRoIE5ldHdvcmtTZXNzaW9uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY1MjcKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI1NDg5MTU2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwOgorICAg ICAgICAoV2ViS2l0OjpOZXR3b3JrTG9hZDo6Y29udGludWVDYW5BdXRoZW50aWNhdGVBZ2FpbnN0 UHJvdGVjdGlvblNwYWNlKToKKyAgICAgICAgV2Ugb25seSB3YW50IHRvIHVzZSBzZXJ2ZXJUcnVz dENyZWRlbnRpYWwgZm9yIFNlcnZlclRydXN0RXZhbHVhdGlvbiBhdXRoZW50aWNhdGlvbiBjaGFs bGVuZ2VzLCBub3QgCisgICAgICAgICogU2hhcmVkL0F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0 aW9uTWFuYWdlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OkF1dGhlbnRpY2F0aW9uTWFuYWdlcjo6 dHJ5VXNlQ2VydGlmaWNhdGVJbmZvRm9yQ2hhbGxlbmdlKToKKyAgICAgICAgKFdlYktpdDo6QXV0 aGVudGljYXRpb25NYW5hZ2VyOjp1c2VDcmVkZW50aWFsRm9yU2luZ2xlQ2hhbGxlbmdlKToKKyAg ICAgICAgKiBTaGFyZWQvQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25NYW5hZ2VyLmg6Cisg ICAgICAgICogU2hhcmVkL0F1dGhlbnRpY2F0aW9uL21hYy9BdXRoZW50aWNhdGlvbk1hbmFnZXIu bWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpBdXRoZW50aWNhdGlvbk1hbmFnZXI6OnRyeVVzZUNl cnRpZmljYXRlSW5mb0ZvckNoYWxsZW5nZSk6CisgICAgICAgIERvbid0IHVzZSBjaGFsbGVuZ2Uu c2VuZGVyIHdpdGggTlNVUkxTZXNzaW9uLCB3aGljaCByZXF1aXJlcyBjYWxsYmFja3MgaW5zdGVh ZC4KKwogMjAxNi0wNC0xMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgog CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERvY2sgY29udHJvbHMgYXJlIG5vdCBhdmFpbGFibGUg aW4gdG9vbGJhciBpZiBXZWIgSW5zcGVjdG9yIHdpbmRvdyBsZWF2ZXMgZnVsbHNjcmVlbgpJbmRl eDogU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xvYWQuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtMb2FkLmNwcAkocmV2 aXNpb24gMTk5MzA5KQorKysgU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0xv YWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNjAsNyArMzYwLDcgQEAgdm9pZCBOZXR3b3JrTG9h ZDo6Y29udGludWVDYW5BdXRoZW50aWNhdAogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIAot ICAgIGlmICghbV9jaGFsbGVuZ2UucHJvdGVjdGlvblNwYWNlKCkuaXNQYXNzd29yZEJhc2VkKCkp IHsKKyAgICBpZiAobV9jaGFsbGVuZ2UucHJvdGVjdGlvblNwYWNlKCkuYXV0aGVudGljYXRpb25T Y2hlbWUoKSA9PSBQcm90ZWN0aW9uU3BhY2VBdXRoZW50aWNhdGlvblNjaGVtZVNlcnZlclRydXN0 RXZhbHVhdGlvblJlcXVlc3RlZCkgewogICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uOjpVc2VDcmVkZW50aWFsLCBzZXJ2ZXJUcnVzdENy ZWRlbnRpYWwobV9jaGFsbGVuZ2UpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1NoYXJlZC9BdXRoZW50aWNhdGlvbi9BdXRoZW50aWNhdGlvbk1hbmFnZXIu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BdXRoZW50aWNhdGlvbi9B dXRoZW50aWNhdGlvbk1hbmFnZXIuY3BwCShyZXZpc2lvbiAxOTkzMDkpCisrKyBTb3VyY2UvV2Vi S2l0Mi9TaGFyZWQvQXV0aGVudGljYXRpb24vQXV0aGVudGljYXRpb25NYW5hZ2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTg4LDcgKzE4OCw3IEBAIHZvaWQgQXV0aGVudGljYXRpb25NYW5hZ2Vy OjpkaWRSZWNlaXZlQXUKIAogLy8gQ3VycmVudGx5LCBvbmx5IE1hYyBrbm93cyBob3cgdG8gcmVz cG9uZCB0byBhdXRoZW50aWNhdGlvbiBjaGFsbGVuZ2VzIHdpdGggY2VydGlmaWNhdGUgaW5mby4K ICNpZiAhSEFWRShTRUNfSURFTlRJVFkpCi1ib29sIEF1dGhlbnRpY2F0aW9uTWFuYWdlcjo6dHJ5 VXNlQ2VydGlmaWNhdGVJbmZvRm9yQ2hhbGxlbmdlKGNvbnN0IFdlYkNvcmU6OkF1dGhlbnRpY2F0 aW9uQ2hhbGxlbmdlJiwgY29uc3QgQ2VydGlmaWNhdGVJbmZvJikKK2Jvb2wgQXV0aGVudGljYXRp b25NYW5hZ2VyOjp0cnlVc2VDZXJ0aWZpY2F0ZUluZm9Gb3JDaGFsbGVuZ2UoY29uc3QgV2ViQ29y ZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmLCBjb25zdCBDZXJ0aWZpY2F0ZUluZm8mLCBDaGFs bGVuZ2VDb21wbGV0aW9uSGFuZGxlcikKIHsKICAgICByZXR1cm4gZmFsc2U7CiB9CkBAIC0yMDcs MTQgKzIwNywyMCBAQCB2b2lkIEF1dGhlbnRpY2F0aW9uTWFuYWdlcjo6dXNlQ3JlZGVudGlhCiAg ICAgYXV0byBjaGFsbGVuZ2UgPSBtX2NoYWxsZW5nZXMudGFrZShjaGFsbGVuZ2VJRCk7CiAgICAg QVNTRVJUKCFjaGFsbGVuZ2UuY2hhbGxlbmdlLmlzTnVsbCgpKTsKIAotICAgIGlmICh0cnlVc2VD ZXJ0aWZpY2F0ZUluZm9Gb3JDaGFsbGVuZ2UoY2hhbGxlbmdlLmNoYWxsZW5nZSwgY2VydGlmaWNh dGVJbmZvKSkKKyNpZiBVU0UoTkVUV09SS19TRVNTSU9OKQorICAgIGF1dG8gY29tcGxldGlvbkhh bmRsZXIgPSBjaGFsbGVuZ2UuY29tcGxldGlvbkhhbmRsZXI7CisjZWxzZQorICAgIENoYWxsZW5n ZUNvbXBsZXRpb25IYW5kbGVyIGNvbXBsZXRpb25IYW5kbGVyID0gbnVsbHB0cjsKKyNlbmRpZgor ICAgIAorICAgIGlmICh0cnlVc2VDZXJ0aWZpY2F0ZUluZm9Gb3JDaGFsbGVuZ2UoY2hhbGxlbmdl LmNoYWxsZW5nZSwgY2VydGlmaWNhdGVJbmZvLCBjb21wbGV0aW9uSGFuZGxlcikpCiAgICAgICAg IHJldHVybjsKIAogICAgIEF1dGhlbnRpY2F0aW9uQ2xpZW50KiBjb3JlQ2xpZW50ID0gY2hhbGxl bmdlLmNoYWxsZW5nZS5hdXRoZW50aWNhdGlvbkNsaWVudCgpOwogI2lmIFVTRShORVRXT1JLX1NF U1NJT04pCiAgICAgLy8gSWYgdGhlcmUgaXMgYSBjb21wbGV0aW9uIGhhbmRsZXIsIHRoZW4gdGhl cmUgaXMgbm8gQXV0aGVudGljYXRpb25DbGllbnQuCiAgICAgLy8gRklYTUU6IFJlbW92ZSB0aGUg dXNlIG9mIEF1dGhlbnRpY2F0aW9uQ2xpZW50IGluIFdlYktpdDIgb25jZSBORVRXT1JLX1NFU1NJ T04gaXMgdXNlZCBmb3IgYWxsIGxvYWRzLgotICAgIGlmIChjaGFsbGVuZ2UuY29tcGxldGlvbkhh bmRsZXIpIHsKKyAgICBpZiAoY29tcGxldGlvbkhhbmRsZXIpIHsKICAgICAgICAgQVNTRVJUKCFj b3JlQ2xpZW50KTsKICAgICAgICAgY2hhbGxlbmdlLmNvbXBsZXRpb25IYW5kbGVyKEF1dGhlbnRp Y2F0aW9uQ2hhbGxlbmdlRGlzcG9zaXRpb246OlVzZUNyZWRlbnRpYWwsIGNyZWRlbnRpYWwpOwog ICAgICAgICByZXR1cm47CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQXV0aGVudGljYXRp b24vQXV0aGVudGljYXRpb25NYW5hZ2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv U2hhcmVkL0F1dGhlbnRpY2F0aW9uL0F1dGhlbnRpY2F0aW9uTWFuYWdlci5oCShyZXZpc2lvbiAx OTkzMDkpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQXV0aGVudGljYXRpb24vQXV0aGVudGlj YXRpb25NYW5hZ2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTk0LDcgKzk0LDcgQEAgcHJpdmF0ZToK ICAgICAvLyBJUEM6Ok1lc3NhZ2VSZWNlaXZlcgogICAgIHZvaWQgZGlkUmVjZWl2ZU1lc3NhZ2Uo SVBDOjpDb25uZWN0aW9uJiwgSVBDOjpNZXNzYWdlRGVjb2RlciYpIG92ZXJyaWRlOwogCi0gICAg Ym9vbCB0cnlVc2VDZXJ0aWZpY2F0ZUluZm9Gb3JDaGFsbGVuZ2UoY29uc3QgV2ViQ29yZTo6QXV0 aGVudGljYXRpb25DaGFsbGVuZ2UmLCBjb25zdCBXZWJDb3JlOjpDZXJ0aWZpY2F0ZUluZm8mKTsK KyAgICBib29sIHRyeVVzZUNlcnRpZmljYXRlSW5mb0ZvckNoYWxsZW5nZShjb25zdCBXZWJDb3Jl OjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYsIGNvbnN0IFdlYkNvcmU6OkNlcnRpZmljYXRlSW5m byYsIENoYWxsZW5nZUNvbXBsZXRpb25IYW5kbGVyKTsKIAogICAgIHVpbnQ2NF90IGFkZENoYWxs ZW5nZVRvQ2hhbGxlbmdlTWFwKGNvbnN0IENoYWxsZW5nZSYpOwogICAgIGJvb2wgc2hvdWxkQ29h bGVzY2VDaGFsbGVuZ2UodWludDY0X3QgcGFnZUlELCB1aW50NjRfdCBjaGFsbGVuZ2VJRCwgY29u c3QgV2ViQ29yZTo6QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmKSBjb25zdDsKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL1NoYXJlZC9BdXRoZW50aWNhdGlvbi9tYWMvQXV0aGVudGljYXRpb25NYW5hZ2Vy Lm1hYy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQXV0aGVudGljYXRp b24vbWFjL0F1dGhlbnRpY2F0aW9uTWFuYWdlci5tYWMubW0JKHJldmlzaW9uIDE5OTMwOSkKKysr IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BdXRoZW50aWNhdGlvbi9tYWMvQXV0aGVudGljYXRpb25N YW5hZ2VyLm1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcsNyBAQCB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiAvLyBGSVhNRTogVGhpcyBmdW5j dGlvbiBjcmVhdGVzIGFuIGlkZW50aXR5IGZyb20gYSBjZXJ0aWZpY2F0ZSwgd2hpY2ggc2hvdWxk IG5vdCBiZSBuZWVkZWQuIFdlIHNob3VsZCBwYXNzIGFuIGlkZW50aXR5IG92ZXIgSVBDIChhcyB3 ZSBkbyBvbiBpT1MpLgotYm9vbCBBdXRoZW50aWNhdGlvbk1hbmFnZXI6OnRyeVVzZUNlcnRpZmlj YXRlSW5mb0ZvckNoYWxsZW5nZShjb25zdCBBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYgY2hhbGxl bmdlLCBjb25zdCBDZXJ0aWZpY2F0ZUluZm8mIGNlcnRpZmljYXRlSW5mbykKK2Jvb2wgQXV0aGVu dGljYXRpb25NYW5hZ2VyOjp0cnlVc2VDZXJ0aWZpY2F0ZUluZm9Gb3JDaGFsbGVuZ2UoY29uc3Qg QXV0aGVudGljYXRpb25DaGFsbGVuZ2UmIGNoYWxsZW5nZSwgY29uc3QgQ2VydGlmaWNhdGVJbmZv JiBjZXJ0aWZpY2F0ZUluZm8sIENoYWxsZW5nZUNvbXBsZXRpb25IYW5kbGVyIGNvbXBsZXRpb25I YW5kbGVyKQogewogICAgIENGQXJyYXlSZWYgY2hhaW4gPSBjZXJ0aWZpY2F0ZUluZm8uY2VydGlm aWNhdGVDaGFpbigpOwogICAgIGlmICghY2hhaW4pCkBAIC01MCw3ICs1MCwxMCBAQCBib29sIEF1 dGhlbnRpY2F0aW9uTWFuYWdlcjo6dHJ5VXNlQ2VydGlmCiAgICAgT1NTdGF0dXMgcmVzdWx0ID0g U2VjSWRlbnRpdHlDcmVhdGVXaXRoQ2VydGlmaWNhdGUoTlVMTCwgKFNlY0NlcnRpZmljYXRlUmVm KUNGQXJyYXlHZXRWYWx1ZUF0SW5kZXgoY2hhaW4sIDApLCAmaWRlbnRpdHkpOwogICAgIGlmIChy ZXN1bHQgIT0gZXJyU2VjU3VjY2VzcykgewogICAgICAgICBMT0dfRVJST1IoIlVuYWJsZSB0byBj cmVhdGUgU2VjSWRlbnRpdHlSZWYgd2l0aCBjZXJ0aWZpY2F0ZSAtICVpIiwgcmVzdWx0KTsKLSAg ICAgICAgW2NoYWxsZW5nZS5zZW5kZXIoKSBjYW5jZWxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZTpj aGFsbGVuZ2UubnNVUkxBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSgpXTsKKyAgICAgICAgaWYgKGNv bXBsZXRpb25IYW5kbGVyKQorICAgICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoQXV0aGVudGlj YXRpb25DaGFsbGVuZ2VEaXNwb3NpdGlvbjo6Q2FuY2VsLCB7IH0pOworICAgICAgICBlbHNlCisg ICAgICAgICAgICBbY2hhbGxlbmdlLnNlbmRlcigpIGNhbmNlbEF1dGhlbnRpY2F0aW9uQ2hhbGxl bmdlOmNoYWxsZW5nZS5uc1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKCldOwogICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTYxLDcgKzY0LDEwIEBAIGJvb2wgQXV0aGVudGljYXRp b25NYW5hZ2VyOjp0cnlVc2VDZXJ0aWYKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjZXJ0aWZpY2F0ZXM6bnNDaGFpbgogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBw ZXJzaXN0ZW5jZTpOU1VSTENyZWRlbnRpYWxQZXJzaXN0ZW5jZU5vbmVdOwogCi0gICAgW2NoYWxs ZW5nZS5zZW5kZXIoKSB1c2VDcmVkZW50aWFsOmNyZWRlbnRpYWwgZm9yQXV0aGVudGljYXRpb25D aGFsbGVuZ2U6Y2hhbGxlbmdlLm5zVVJMQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoKV07CisgICAg aWYgKGNvbXBsZXRpb25IYW5kbGVyKQorICAgICAgICBjb21wbGV0aW9uSGFuZGxlcihBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZURpc3Bvc2l0aW9uOjpVc2VDcmVkZW50aWFsLCBDcmVkZW50aWFsKGNy ZWRlbnRpYWwpKTsKKyAgICBlbHNlCisgICAgICAgIFtjaGFsbGVuZ2Uuc2VuZGVyKCkgdXNlQ3Jl ZGVudGlhbDpjcmVkZW50aWFsIGZvckF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlOmNoYWxsZW5nZS5u c1VSTEF1dGhlbnRpY2F0aW9uQ2hhbGxlbmdlKCldOwogICAgIHJldHVybiB0cnVlOwogfQogCg==