156521 2016-04-12 15:12:29 -0700 CMake MiniBrowser should be an app bundle 2016-05-23 15:24:50 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1183263 0 achristensen 2016-04-12 15:12:29 -0700 CMake MiniBrowser should be an app bundle 1183264 1 276284 achristensen 2016-04-12 15:13:50 -0700 Created attachment 276284 Patch 1183460 2 276284 dbates 2016-04-13 11:11:55 -0700 Comment on attachment 276284 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276284&action=review Can we make use of <https://cmake.org/cmake/help/v3.0/prop_tgt/MACOSX_BUNDLE.html> or <https://cmake.org/cmake/help/v3.0/module/BundleUtilities.html> instead of building the app bundle by hand? > Tools/MiniBrowser/mac/CMakeLists.txt:31 > +set(_contents_dir ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/MiniBrowser.app/Contents) Can we come up with a better name for this variable? Maybe MiniBrowser_Contents_Directory? 1183466 3 276337 achristensen 2016-04-13 11:37:14 -0700 Created attachment 276337 Patch 1183633 4 276337 bfulgham 2016-04-13 22:09:03 -0700 Comment on attachment 276337 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276337&action=review r=me. > Tools/ChangeLog:11 > + CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it. This is just MiniBrowser. *JUST* MiniBrowser!!! >:-( 1183639 5 achristensen 2016-04-13 22:57:06 -0700 http://trac.webkit.org/changeset/199530 And I snuck in a build fix for JavaScriptCore. 276284 2016-04-12 15:13:50 -0700 2016-04-13 11:37:11 -0700 Patch bug-156521-20160412151400.patch text/plain 2742 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5OTM5MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTA0LTEyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgQ01ha2UgTWluaUJyb3dzZXIgc2hvdWxkIGJlIGFuIGFwcCBi dW5kbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NjUyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TWluaUJyb3dzZXIvbWFjL0NNYWtlTGlzdHMudHh0OgorICAgICAgICAqIE1pbmlCcm93c2VyL21h Yy9JbmZvLnBsaXN0OgorCiAyMDE2LTA0LTEyICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVs ZEBhcHBsZS5jb20+CiAKICAgICAgICAgW09TIFhdIEZsYWtleSBjcmFzaCBhZnRlciBTY3JvbGxB bmltYXRvck1hYyBkZXN0cnVjdGlvbgpJbmRleDogVG9vbHMvTWluaUJyb3dzZXIvbWFjL0NNYWtl TGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL21hYy9DTWFrZUxpc3Rz LnR4dAkocmV2aXNpb24gMTk5MzM5KQorKysgVG9vbHMvTWluaUJyb3dzZXIvbWFjL0NNYWtlTGlz dHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCwxOCBAQCBzZXQoTWluaUJyb3dzZXJf TElCUkFSSUVTCiAgICAgV2ViS2l0MgogKQogCitzZXQoX2NvbnRlbnRzX2RpciAke0NNQUtFX1JV TlRJTUVfT1VUUFVUX0RJUkVDVE9SWX0vTWluaUJyb3dzZXIuYXBwL0NvbnRlbnRzKQorbWFrZV9k aXJlY3RvcnkoJHtfY29udGVudHNfZGlyfS9NYWNPUykKK21ha2VfZGlyZWN0b3J5KCR7X2NvbnRl bnRzX2Rpcn0vUmVzb3VyY2VzKQorZmlsZShDT1BZICR7TUlOSUJST1dTRVJfRElSfS9JbmZvLnBs aXN0IERFU1RJTkFUSU9OICR7X2NvbnRlbnRzX2Rpcn0pCisKK2FkZF9jdXN0b21fdGFyZ2V0KEJy b3dzZXJXaW5kb3dOaWIgQ09NTUFORCBpYnRvb2wgLS1jb21waWxlICR7X2NvbnRlbnRzX2Rpcn0v UmVzb3VyY2VzL0Jyb3dzZXJXaW5kb3cubmliICR7TUlOSUJST1dTRVJfRElSfS9Ccm93c2VyV2lu ZG93LnhpYiBWRVJCQVRJTSkKK2FkZF9jdXN0b21fdGFyZ2V0KEV4dGVuc2lvbk1hbmFnZXJXaW5k b3dDb250cm9sbGVyTmliIENPTU1BTkQgaWJ0b29sIC0tY29tcGlsZSAke19jb250ZW50c19kaXJ9 L1Jlc291cmNlcy9FeHRlbnNpb25NYW5hZ2VyV2luZG93Q29udHJvbGxlci5uaWIgJHtNSU5JQlJP V1NFUl9ESVJ9L0V4dGVuc2lvbk1hbmFnZXJXaW5kb3dDb250cm9sbGVyLnhpYiBWRVJCQVRJTSkK K2FkZF9jdXN0b21fdGFyZ2V0KE1haW5NZW51TmliIENPTU1BTkQgaWJ0b29sIC0tY29tcGlsZSAk e19jb250ZW50c19kaXJ9L1Jlc291cmNlcy9NYWluTWVudS5uaWIgJHtNSU5JQlJPV1NFUl9ESVJ9 L01haW5NZW51LnhpYiBWRVJCQVRJTSkKKwogaW5jbHVkZV9kaXJlY3Rvcmllcygke01pbmlCcm93 c2VyX0lOQ0xVREVfRElSRUNUT1JJRVN9KQogYWRkX2V4ZWN1dGFibGUoTWluaUJyb3dzZXIgJHtN aW5pQnJvd3Nlcl9TT1VSQ0VTfSkKIHRhcmdldF9saW5rX2xpYnJhcmllcyhNaW5pQnJvd3NlciAk e01pbmlCcm93c2VyX0xJQlJBUklFU30pCisKK3NldF90YXJnZXRfcHJvcGVydGllcyhNaW5pQnJv d3NlciBQUk9QRVJUSUVTIFJVTlRJTUVfT1VUUFVUX0RJUkVDVE9SWSAiJHtfY29udGVudHNfZGly fS9NYWNPUyIpCithZGRfZGVwZW5kZW5jaWVzKE1pbmlCcm93c2VyIEJyb3dzZXJXaW5kb3dOaWIg RXh0ZW5zaW9uTWFuYWdlcldpbmRvd0NvbnRyb2xsZXJOaWIgTWFpbk1lbnVOaWIpCkluZGV4OiBU b29scy9NaW5pQnJvd3Nlci9tYWMvSW5mby5wbGlzdAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5p QnJvd3Nlci9tYWMvSW5mby5wbGlzdAkocmV2aXNpb24gMTk5MzM5KQorKysgVG9vbHMvTWluaUJy b3dzZXIvbWFjL0luZm8ucGxpc3QJKHdvcmtpbmcgY29weSkKQEAgLTUsNyArNSw3IEBACiAJPGtl eT5DRkJ1bmRsZURldmVsb3BtZW50UmVnaW9uPC9rZXk+CiAJPHN0cmluZz5FbmdsaXNoPC9zdHJp bmc+CiAJPGtleT5DRkJ1bmRsZUV4ZWN1dGFibGU8L2tleT4KLQk8c3RyaW5nPiR7RVhFQ1VUQUJM RV9OQU1FfTwvc3RyaW5nPgorCTxzdHJpbmc+TWluaUJyb3dzZXI8L3N0cmluZz4KIAk8a2V5PkNG QnVuZGxlSWNvbkZpbGU8L2tleT4KIAk8c3RyaW5nPk1pbmlCcm93c2VyPC9zdHJpbmc+CiAJPGtl eT5DRkJ1bmRsZUlkZW50aWZpZXI8L2tleT4KQEAgLTEzLDcgKzEzLDcgQEAKIAk8a2V5PkNGQnVu ZGxlSW5mb0RpY3Rpb25hcnlWZXJzaW9uPC9rZXk+CiAJPHN0cmluZz42LjA8L3N0cmluZz4KIAk8 a2V5PkNGQnVuZGxlTmFtZTwva2V5PgotCTxzdHJpbmc+JHtQUk9EVUNUX05BTUV9PC9zdHJpbmc+ CisJPHN0cmluZz5NaW5pQnJvd3Nlcjwvc3RyaW5nPgogCTxrZXk+Q0ZCdW5kbGVQYWNrYWdlVHlw ZTwva2V5PgogCTxzdHJpbmc+QVBQTDwvc3RyaW5nPgogCTxrZXk+Q0ZCdW5kbGVTaWduYXR1cmU8 L2tleT4K 276337 2016-04-13 11:37:14 -0700 2016-04-13 22:09:03 -0700 Patch bug-156521-20160413113725.patch text/plain 2832 achristensen SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5OTUwNikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA0LTEzICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdl YmtpdC5vcmc+CisKKyAgICAgICAgQ01ha2UgTWluaUJyb3dzZXIgc2hvdWxkIGJlIGFuIGFwcCBi dW5kbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NjUyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TWluaUJyb3dzZXIvbWFjL0NNYWtlTGlzdHMudHh0OgorICAgICAgICBNYWtlIGFuIGFwcCBidW5k bGUgYW5kIGNvbXBpbGUgbmlicy4KKyAgICAgICAgKiBNaW5pQnJvd3Nlci9tYWMvSW5mby5wbGlz dDoKKyAgICAgICAgQ01ha2UgZG9lc24ndCBrbm93IHdoYXQgdG8gZG8gd2l0aCA6cmZjMTAzNGlk ZW50aWZpZXIgYW5kIHRoZXJlJ3Mgbm8gcmVhc29uIHRvIGtlZXAgaXQuICBUaGlzIGlzIGp1c3Qg TWluaUJyb3dzZXIuCisKIDIwMTYtMDQtMTIgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CiAKICAgICAgICAgUHl0aG9uIHRlc3Qgd2Via2l0cHkuY29tbW9uLnN5c3RlbS5leGVj dXRpdmVfdW5pdHRlc3QuRXhlY3V0aXZlVGVzdC5zZXJpYWxfdGVzdF9raWxsX3Byb2Nlc3MgaXMg Zmxha3kKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL21hYy9DTWFrZUxpc3RzLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9tYWMvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDE5 OTMzOSkKKysrIFRvb2xzL01pbmlCcm93c2VyL21hYy9DTWFrZUxpc3RzLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMjgsNiArMjgsMTcgQEAgc2V0KE1pbmlCcm93c2VyX0xJQlJBUklFUwogICAgIFdl YktpdDIKICkKIAorc2V0KEVYRUNVVEFCTEVfTkFNRSBNaW5pQnJvd3NlcikKK3NldChQUk9EVUNU X05BTUUgTWluaUJyb3dzZXIpCisKK3NldChNaW5pQnJvd3Nlcl9Db250ZW50c19EaXJlY3Rvcnkg JHtDTUFLRV9SVU5USU1FX09VVFBVVF9ESVJFQ1RPUll9L01pbmlCcm93c2VyLmFwcC9Db250ZW50 cykKK21ha2VfZGlyZWN0b3J5KCR7TWluaUJyb3dzZXJfQ29udGVudHNfRGlyZWN0b3J5fS9SZXNv dXJjZXMpCithZGRfY3VzdG9tX3RhcmdldChCcm93c2VyV2luZG93TmliIENPTU1BTkQgaWJ0b29s IC0tY29tcGlsZSAke01pbmlCcm93c2VyX0NvbnRlbnRzX0RpcmVjdG9yeX0vUmVzb3VyY2VzL0Jy b3dzZXJXaW5kb3cubmliICR7TUlOSUJST1dTRVJfRElSfS9Ccm93c2VyV2luZG93LnhpYiBWRVJC QVRJTSkKK2FkZF9jdXN0b21fdGFyZ2V0KEV4dGVuc2lvbk1hbmFnZXJXaW5kb3dDb250cm9sbGVy TmliIENPTU1BTkQgaWJ0b29sIC0tY29tcGlsZSAke01pbmlCcm93c2VyX0NvbnRlbnRzX0RpcmVj dG9yeX0vUmVzb3VyY2VzL0V4dGVuc2lvbk1hbmFnZXJXaW5kb3dDb250cm9sbGVyLm5pYiAke01J TklCUk9XU0VSX0RJUn0vRXh0ZW5zaW9uTWFuYWdlcldpbmRvd0NvbnRyb2xsZXIueGliIFZFUkJB VElNKQorYWRkX2N1c3RvbV90YXJnZXQoTWFpbk1lbnVOaWIgQ09NTUFORCBpYnRvb2wgLS1jb21w aWxlICR7TWluaUJyb3dzZXJfQ29udGVudHNfRGlyZWN0b3J5fS9SZXNvdXJjZXMvTWFpbk1lbnUu bmliICR7TUlOSUJST1dTRVJfRElSfS9NYWluTWVudS54aWIgVkVSQkFUSU0pCisKIGluY2x1ZGVf ZGlyZWN0b3JpZXMoJHtNaW5pQnJvd3Nlcl9JTkNMVURFX0RJUkVDVE9SSUVTfSkKLWFkZF9leGVj dXRhYmxlKE1pbmlCcm93c2VyICR7TWluaUJyb3dzZXJfU09VUkNFU30pCithZGRfZXhlY3V0YWJs ZShNaW5pQnJvd3NlciBNQUNPU1hfQlVORExFICR7TWluaUJyb3dzZXJfU09VUkNFU30pCitzZXRf dGFyZ2V0X3Byb3BlcnRpZXMoTWluaUJyb3dzZXIgUFJPUEVSVElFUyBNQUNPU1hfQlVORExFX0lO Rk9fUExJU1QgJHtNSU5JQlJPV1NFUl9ESVJ9L0luZm8ucGxpc3QpCiB0YXJnZXRfbGlua19saWJy YXJpZXMoTWluaUJyb3dzZXIgJHtNaW5pQnJvd3Nlcl9MSUJSQVJJRVN9KQorYWRkX2RlcGVuZGVu Y2llcyhNaW5pQnJvd3NlciBCcm93c2VyV2luZG93TmliIEV4dGVuc2lvbk1hbmFnZXJXaW5kb3dD b250cm9sbGVyTmliIE1haW5NZW51TmliKQpJbmRleDogVG9vbHMvTWluaUJyb3dzZXIvbWFjL0lu Zm8ucGxpc3QKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvTWluaUJyb3dzZXIvbWFjL0luZm8ucGxpc3QJ KHJldmlzaW9uIDE5OTMzOSkKKysrIFRvb2xzL01pbmlCcm93c2VyL21hYy9JbmZvLnBsaXN0CSh3 b3JraW5nIGNvcHkpCkBAIC05LDcgKzksNyBAQAogCTxrZXk+Q0ZCdW5kbGVJY29uRmlsZTwva2V5 PgogCTxzdHJpbmc+TWluaUJyb3dzZXI8L3N0cmluZz4KIAk8a2V5PkNGQnVuZGxlSWRlbnRpZmll cjwva2V5PgotCTxzdHJpbmc+b3JnLndlYmtpdC4ke1BST0RVQ1RfTkFNRTpyZmMxMDM0aWRlbnRp Zmllcn08L3N0cmluZz4KKwk8c3RyaW5nPm9yZy53ZWJraXQuJHtQUk9EVUNUX05BTUV9PC9zdHJp bmc+CiAJPGtleT5DRkJ1bmRsZUluZm9EaWN0aW9uYXJ5VmVyc2lvbjwva2V5PgogCTxzdHJpbmc+ Ni4wPC9zdHJpbmc+CiAJPGtleT5DRkJ1bmRsZU5hbWU8L2tleT4K