156520 2016-04-12 14:27:33 -0700 Web Inspector: Dock controls are not available in toolbar if Web Inspector window leaves fullscreen 2020-05-22 17:06:06 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue giffypap79 graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1183244 0 joepeck 2016-04-12 14:27:33 -0700 * SUMMARY Dock controls are not available in toolbar if Web Inspector window leaves fullscreen * STEPS TO REPRODUCE 1. Launch Safari 2. Visit any webpage 3. Enter Full Screen mode 4. Via the "Develop" menu, enable the Web Inspector 5. Detach the Web Inspecor from browser window 6. When the Web Inspector is presented in Full Screen mode, bring it back to standard mode => Dock controls are missing in toolbar 1183245 1 joepeck 2016-04-12 14:27:45 -0700 <rdar://problem/22101106> 1183248 2 276277 joepeck 2016-04-12 14:30:00 -0700 Created attachment 276277 [PATCH] Proposed Fix 1183276 3 276277 commit-queue 2016-04-12 15:48:37 -0700 Comment on attachment 276277 [PATCH] Proposed Fix Clearing flags on attachment: 276277 Committed r199395: <http://trac.webkit.org/changeset/199395> 1183277 4 commit-queue 2016-04-12 15:48:41 -0700 All reviewed patches have been landed. Closing bug. 276277 2016-04-12 14:30:00 -0700 2016-04-12 15:48:37 -0700 [PATCH] Proposed Fix dock.patch text/plain 2150 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2MmI1MDY2Li40MzRjNWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTYtMDQtMTIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBEb2NrIGNvbnRyb2xzIGFyZSBub3QgYXZhaWxhYmxlIGlu IHRvb2xiYXIgaWYgV2ViIEluc3BlY3RvciB3aW5kb3cgbGVhdmVzIGZ1bGxzY3JlZW4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjUyMAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjIxMDExMDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFj Lm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DYW5BdHRh Y2gpOgorICAgICAgICBCZSBtb3JlIGV4cGxpY2l0IGFib3V0IHRoZSBhdHRhY2htZW50IHZpZXcg Y2hlY2suIEl0cyBpbnRlbnQKKyAgICAgICAgd2FzIHRvIHByZXZlbnQgYWxsb3dpbmcgYSAybmQg bGV2ZWwgaW5zcGVjdG9yIGZyb20gYXR0YWNoaW5nCisgICAgICAgIHRvIGEgMXN0IGxldmVsIGlu c3BlY3Rvci4gV2UgY2FuIHVzZSBhIHN0cm9uZ2VyIGNoZWNrLiBBbHNvLAorICAgICAgICByZW1v dmUgZGVwcmVjYXRlZCBwcmFnbWFzIGJ5IHN3aXRjaGluZyB0byBuZXcgdmFsdWUuCisKKzIwMTYt MDQtMTIgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBLZXlib2FyZCBzaG9ydGN1dCBmb3IgIkluc3BlY3QgRWxlbWVudCIgb25s eSB3b3JrcyB3aGVuIFdlYiBJbnNwZWN0b3IgaXMgb3Blbi4KICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTExMTE5MwogICAgICAgICA8cmRhcjovL3Byb2Js ZW0vMTMzMjU4ODk+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dl Ykluc3BlY3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJ bnNwZWN0b3JQcm94eU1hYy5tbQppbmRleCA0ODEyZTZmLi43ZjQzZjAzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KQEAg LTQ1NCwxNCArNDU0LDExIEBAIFdlYlBhZ2VQcm94eSogV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRm b3JtQ3JlYXRlSW5zcGVjdG9yUGFnZSgpCiAKIGJvb2wgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRm b3JtQ2FuQXR0YWNoKGJvb2wgd2ViUHJvY2Vzc0NhbkF0dGFjaCkKIHsKLSNwcmFnbWEgY2xhbmcg ZGlhZ25vc3RpYyBwdXNoCi0jcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3JlZCAiLVdkZXBy ZWNhdGVkLWRlY2xhcmF0aW9ucyIKLSAgICBpZiAoW21faW5zcGVjdG9yV2luZG93IHN0eWxlTWFz a10gJiBOU0Z1bGxTY3JlZW5XaW5kb3dNYXNrKQorICAgIGlmIChbbV9pbnNwZWN0b3JXaW5kb3cg c3R5bGVNYXNrXSAmIE5TV2luZG93U3R5bGVNYXNrRnVsbFNjcmVlbikKICAgICAgICAgcmV0dXJu IGZhbHNlOwotI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIHBvcAogCiAgICAgTlNWaWV3ICppbnNw ZWN0ZWRWaWV3ID0gaW5zcGVjdGVkUGFnZSgpLT5pbnNwZWN0b3JBdHRhY2htZW50VmlldygpOwot ICAgIGlmIChbaW5zcGVjdGVkVmlldyBpc0tpbmRPZkNsYXNzOltXS1ZpZXcgY2xhc3NdXSB8fCBb aW5zcGVjdGVkVmlldyBpc0tpbmRPZkNsYXNzOltXS1dlYlZpZXcgY2xhc3NdXSkKKyAgICBpZiAo W2luc3BlY3RlZFZpZXcgaXNLaW5kT2ZDbGFzczpbV0tXZWJJbnNwZWN0b3JXS1dlYlZpZXcgY2xh c3NdXSkKICAgICAgICAgcmV0dXJuIHdlYlByb2Nlc3NDYW5BdHRhY2g7CiAKICAgICBzdGF0aWMg Y29uc3QgZmxvYXQgbWluaW11bUF0dGFjaGVkSGVpZ2h0ID0gMjUwOwo=