156516 2016-04-12 13:58:33 -0700 AbstractValue should use the result type to filter structures 2016-04-12 14:52:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1183230 0 keith_miller 2016-04-12 13:58:33 -0700 AbstractValue should use the result type to filter structures 1183231 1 276273 keith_miller 2016-04-12 14:01:24 -0700 Created attachment 276273 Patch 1183233 2 276273 ggaren 2016-04-12 14:03:35 -0700 Comment on attachment 276273 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276273&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + When filtering filtering an AbstractValue with a SpeculatedType we would not filtering > Source/JavaScriptCore/ChangeLog:10 > + comment directly above said). This would cause us to crash if the our structure our 1183257 3 keith_miller 2016-04-12 14:52:02 -0700 Committed r199391: <http://trac.webkit.org/changeset/199391> 276273 2016-04-12 14:01:24 -0700 2016-04-12 14:03:35 -0700 Patch bug-156516-20160412140134.patch text/plain 3307 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl ZjRmNWJlYzcxYTlhODYwMjJjZjczYTI1ZjcwMWNiMGIwM2UwZTQ4Li5mMDdkNzlkNzM3NDI0MTA2 ZDE3NzIwNzY4OGJhMGQyZDUwOTdkZTJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxNi0wNC0xMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBBYnN0cmFjdFZhbHVlIHNob3VsZCB1c2UgdGhlIHJlc3VsdCB0eXBl IHRvIGZpbHRlciBzdHJ1Y3R1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTY1MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBXaGVuIGZpbHRlcmluZyBmaWx0ZXJpbmcgYW4gQWJzdHJhY3RWYWx1ZSB3 aXRoIGEgU3BlY3VsYXRlZFR5cGUgd2Ugd291bGQgbm90CisgICAgICAgIHVzZSB0aGUgbWVyZ2Vk IHR5cGUgd2hlbiBmaWx0ZXJpbmcgb3V0IHRoZSB2YWxpZCBzdHJ1Y3R1cmVzIChkZXNwaXRlIHdo YXQgdGhlCisgICAgICAgIGNvbW1lbnQgZGlyZWN0bHkgYWJvdmUgc2FpZCkuIFRoaXMgd291bGQg Y2F1c2UgdXMgdG8gY3Jhc2ggaWYgdGhlIG91ciBzdHJ1Y3R1cmUKKyAgICAgICAgc2V0IHdhcyBU b3AgYW5kIHRoZSB0d28gc3BlY3VsYXRlZCB0eXBlcyB3ZXJlIGRpZmZlcmVudCBraW5kcyBvZiBj ZWxscy4KKworICAgICAgICAqIGRmZy9ERkdBYnN0cmFjdFZhbHVlLmNwcDoKKyAgICAgICAgKEpT Qzo6REZHOjpBYnN0cmFjdFZhbHVlOjpmaWx0ZXIpOgorICAgICAgICAqIHRlc3RzL3N0cmVzcy9h aS1jb25zaXN0ZW5jeS1maWx0ZXItY2VsbHMuanM6IEFkZGVkLgorICAgICAgICAoZ2V0IHZhbHVl KToKKyAgICAgICAgKGF0dHJpYnV0ZS52YWx1ZS5nZXQgcmVjb3JkKToKKyAgICAgICAgKGF0dHJp YnV0ZS5hdHRycy5nZXQgdGhpcyk6CisgICAgICAgIChnZXQgZm9vKToKKyAgICAgICAgKGxldC50 aGlzVmFsdWUucmV0dXJuLnNlcmlhbGl6ZSk6CisgICAgICAgIChsZXQudGhpc1ZhbHVlLnRyYW5z Zm9ybUZvcik6CisKIDIwMTYtMDQtMDcgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBXZWIgQW5pbWF0aW9ucyBBUEkgdG8gRmVhdHVyZSBTdGF0dXMgUGFnZQpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBYnN0cmFjdFZhbHVlLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHQWJzdHJhY3RWYWx1ZS5jcHAKaW5kZXggYjZm Y2Y4OTkzNjQ5MDIyZjVkY2I1MjhjNGZkYTEyN2E2ZGMzODMxOC4uZGNlZDdjNWUwMDI0NjU2MjE0 OWM2NDcwMzRhZTBlYjMxNDFjNzg0NCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdBYnN0cmFjdFZhbHVlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0Fic3RyYWN0VmFsdWUuY3BwCkBAIC0zMjgsNyArMzI4LDcgQEAgRmlsdHJhdGlvblJlc3Vs dCBBYnN0cmFjdFZhbHVlOjpmaWx0ZXIoU3BlY3VsYXRlZFR5cGUgdHlwZSkKICAgICAvLyB0aGUg cGFzc2VkIHR5cGUgaXMgQXJyYXkuIEF0IHRoaXMgcG9pbnQgd2UnbGwgaGF2ZSAoTm9uZSwgVE9Q KS4gVGhlIGJlc3Qgd2F5CiAgICAgLy8gdG8gZW5zdXJlIHRoYXQgdGhlIHN0cnVjdHVyZSBmaWx0 ZXJpbmcgZG9lcyB0aGUgcmlnaHQgdGhpbmcgaXMgdG8gZmlsdGVyIG9uCiAgICAgLy8gdGhlIG5l dyB0eXBlIChOb25lKSByYXRoZXIgdGhhbiB0aGUgb25lIHBhc3NlZCAoQXJyYXkpLgotICAgIG1f c3RydWN0dXJlLmZpbHRlcih0eXBlKTsKKyAgICBtX3N0cnVjdHVyZS5maWx0ZXIobV90eXBlKTsK ICAgICBmaWx0ZXJBcnJheU1vZGVzQnlUeXBlKCk7CiAgICAgZmlsdGVyVmFsdWVCeVR5cGUoKTsK ICAgICByZXR1cm4gbm9ybWFsaXplQ2xhcml0eSgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9haS1jb25zaXN0ZW5jeS1maWx0ZXItY2VsbHMuanMgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2FpLWNvbnNpc3RlbmN5LWZpbHRlci1j ZWxscy5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi5jZTJmYWI2ZjYxMTZlNmYyNzI4NTZiMzE3NmEyZjE3M2RmOWVh MGQwCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy9haS1jb25zaXN0ZW5jeS1maWx0ZXItY2VsbHMuanMKQEAgLTAsMCArMSwzMCBAQAorZnVuY3Rp b24gZ2V0KHZhbHVlLCBwcm9wKSB7IHJldHVybiB2YWx1ZVtwcm9wXTsgfQorbm9JbmxpbmUoZ2V0 KTsKKworZnVuY3Rpb24gZm9vKHJlY29yZCwga2V5LCBhdHRyaWJ1dGUpIHsKKyAgICB2YXIgYXR0 cnMgPSBnZXQodGhpcywgJ2F0dHJzJyk7CisgICAgdmFyIHZhbHVlID0gZ2V0KHJlY29yZCwga2V5 KSwgdHlwZSA9IGF0dHJpYnV0ZS50eXBlOworCisgICAgaWYgKHR5cGUpIHsKKyAgICAgICAgdmFy IHRyYW5zZm9ybSA9IHRoaXMudHJhbnNmb3JtRm9yKHR5cGUpOworICAgICAgICB2YWx1ZSA9IHRy YW5zZm9ybS5zZXJpYWxpemUodmFsdWUpOworICAgIH0KKworICAgIGtleSA9IGF0dHJzICYmIGF0 dHJzW2tleV0gfHwgKHRoaXMua2V5Rm9yQXR0cmlidXRlID8gdGhpcy5rZXlGb3JBdHRyaWJ1dGUo a2V5KSA6IGtleSk7CisKKyAgICByZXR1cm4ge2tleTprZXksIHZhbHVlOnZhbHVlfTsKK30KK25v SW5saW5lKGZvbyk7CisKK2xldCBpID0gMDsKK2xldCB0aGlzVmFsdWUgPSB7dHJhbnNmb3JtRm9y OiBmdW5jdGlvbigpIHsgcmV0dXJuIHtzZXJpYWxpemU6IGZ1bmN0aW9uKCkgeyByZXR1cm4ge30g fX19fTsKK2xldCByZWNvcmQgPSB7a2V5OiAiaGVsbG8ifTsKK2xldCByZWNvcmQyID0ge2tleTog dHJ1ZX07CitsZXQga2V5ID0gImtleSI7CitsZXQgYXR0cmlidXRlID0ge3R5cGU6ICJ0eXBlIn07 Citmb3IgKDsgaSA8IDEwMDAwMDsgaSsrKSB7CisgICAgaWYgKGkgJSAyID09PSAwKQorICAgICAg ICBmb28uY2FsbCh0aGlzVmFsdWUsIHJlY29yZCwga2V5LCBhdHRyaWJ1dGUpOworICAgIGVsc2UK KyAgICAgICAgZm9vLmNhbGwodGhpc1ZhbHVlLCByZWNvcmQyLCBrZXksIGF0dHJpYnV0ZSk7Cit9 Cg==