156513 2016-04-12 13:18:16 -0700 Web Inspector: Show the normal Native icon for all Internal objects in Heap Snapshots 2016-04-12 14:35:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1183192 0 joepeck 2016-04-12 13:18:16 -0700 * SUMMARY Show the normal Native icon for all Internal objects in Heap Snapshots Currently we treat Internal objects not-associated with an individual page differently. We show a [?] icon. Treat them like any other Native object and show the [N] icon. 1183194 1 276266 joepeck 2016-04-12 13:18:58 -0700 Created attachment 276266 [PATCH] Proposed Fix 1183253 2 276266 commit-queue 2016-04-12 14:35:26 -0700 Comment on attachment 276266 [PATCH] Proposed Fix Clearing flags on attachment: 276266 Committed r199390: <http://trac.webkit.org/changeset/199390> 1183254 3 commit-queue 2016-04-12 14:35:31 -0700 All reviewed patches have been landed. Closing bug. 276266 2016-04-12 13:18:58 -0700 2016-04-12 14:35:26 -0700 [PATCH] Proposed Fix native.patch text/plain 1572 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI0ZDI5NzMuLjZhZjgwMmIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTA0LTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogU2hvdyB0 aGUgbm9ybWFsIE5hdGl2ZSBpY29uIGZvciBhbGwgSW50ZXJuYWwgb2JqZWN0cyBpbiBIZWFwIFNu YXBzaG90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU2NTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBTbmFwc2hvdENsdXN0ZXJDb250ZW50Vmlldy5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5IZWFwU25hcHNob3RDbHVzdGVyQ29udGVudFZpZXcuaWNv blN0eWxlQ2xhc3NOYW1lRm9yQ2xhc3NOYW1lKToKKyAgICAgICAgU2hvdyB0aGUgbmF0aXZlIGlj b24gZm9yIGludGVybmFsIG9iamVjdHMuCisKKzIwMTYtMDQtMTIgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBLZXlib2FyZCBz aG9ydGN1dCBmb3IgIkluc3BlY3QgRWxlbWVudCIgb25seSB3b3JrcyB3aGVuIFdlYiBJbnNwZWN0 b3IgaXMgb3Blbi4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTExMTE5MwogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTMzMjU4ODk+CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9IZWFwU25hcHNob3RD bHVzdGVyQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9IZWFwU25hcHNob3RDbHVzdGVyQ29udGVudFZpZXcuanMKaW5kZXggNWI5Y2EzNC4u MjVhMzRjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvSGVhcFNuYXBzaG90Q2x1c3RlckNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0hlYXBTbmFwc2hvdENsdXN0ZXJDb250ZW50 Vmlldy5qcwpAQCAtNTgsNyArNTgsNyBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90Q2x1c3Rl ckNvbnRlbnRWaWV3ID0gY2xhc3MgSGVhcFNuYXBzaG90Q2x1c3RlckNvbnRlbnRWaQogICAgIHN0 YXRpYyBpY29uU3R5bGVDbGFzc05hbWVGb3JDbGFzc05hbWUoY2xhc3NOYW1lLCBpbnRlcm5hbCkK ICAgICB7CiAgICAgICAgIGlmIChpbnRlcm5hbCkKLSAgICAgICAgICAgIHJldHVybiAidW5rbm93 biI7CisgICAgICAgICAgICByZXR1cm4gIm5hdGl2ZSI7CiAKICAgICAgICAgc3dpdGNoIChjbGFz c05hbWUpIHsKICAgICAgICAgY2FzZSAiT2JqZWN0IjoK