156503 2016-04-12 08:44:16 -0700 There is a race with the compiler thread and the main thread with result profiles 2016-04-13 20:23:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue ddkilzer fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1183062 0 saam 2016-04-12 08:44:16 -0700 ... 1183071 1 276239 saam 2016-04-12 09:20:31 -0700 Created attachment 276239 patch 1183139 2 276239 commit-queue 2016-04-12 11:38:10 -0700 Comment on attachment 276239 patch Clearing flags on attachment: 276239 Committed r199376: <http://trac.webkit.org/changeset/199376> 1183140 3 commit-queue 2016-04-12 11:38:15 -0700 All reviewed patches have been landed. Closing bug. 1183206 4 ddkilzer 2016-04-12 13:32:52 -0700 This caused the Windows Debug builds to fail: <https://build.webkit.org/builders/Apple%20Win%20Debug%20(Build)?numbuilds=50> C:\cygwin\home\buildbot\slave\win-debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4238): error C2039: 'isLocked': is not a member of 'WTF::NoLock' [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock.h(33): note: see declaration of 'WTF::NoLock' C:\cygwin\home\buildbot\slave\win-debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4256): error C2039: 'isLocked': is not a member of 'WTF::NoLock' [C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] C:\cygwin\home\buildbot\slave\win-debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock.h(33): note: see declaration of 'WTF::NoLock' However, I'm not sure why only Windows Debug builds are failing, and not any other platform. 1183209 5 ddkilzer 2016-04-12 13:38:03 -0700 (In reply to comment #4) > This caused the Windows Debug builds to fail: > > <https://build.webkit.org/builders/ > Apple%20Win%20Debug%20(Build)?numbuilds=50> > > C:\cygwin\home\buildbot\slave\win- > debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4238): error C2039: > 'isLocked': is not a member of 'WTF::NoLock' > [C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] > > C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock. > h(33): note: see declaration of 'WTF::NoLock' > C:\cygwin\home\buildbot\slave\win- > debug\build\Source\JavaScriptCore\bytecode\CodeBlock.cpp(4256): error C2039: > 'isLocked': is not a member of 'WTF::NoLock' > [C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\Source\JavaScriptCore\JavaScriptCore.vcxproj] > > C:\cygwin\home\buildbot\slave\win- > debug\build\WebKitBuild\Debug\DerivedSources\ForwardingHeaders\wtf/NoLock. > h(33): note: see declaration of 'WTF::NoLock' > > However, I'm not sure why only Windows Debug builds are failing, and not any > other platform. And 32-bit JSC (BuildAndTest) and LLInt CLoop (BuildAndTest) also fail to build due to the same error: <https://build.webkit.org/builders/Apple%20El%20Capitan%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50> <https://build.webkit.org/builders/Apple%20El%20Capitan%20LLINT%20CLoop%20(BuildAndTest)?numbuilds=50> <https://build.webkit.org/builders/Apple%20Yosemite%2032-bit%20JSC%20(BuildAndTest)?numbuilds=50> <https://build.webkit.org/builders/Apple%20Yosemite%20LLINT%20CLoop%20(BuildAndTest)?numbuilds=50> /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:4238:19: error: no member named 'isLocked' in 'WTF::NoLock' /Volumes/Data/slave/elcapitan-cloop-debug/build/Source/JavaScriptCore/bytecode/CodeBlock.cpp:4256:19: error: no member named 'isLocked' in 'WTF::NoLock' 1183221 6 saam 2016-04-12 13:48:25 -0700 Build should be fixed by: http://trac.webkit.org/changeset/199384 1183623 7 ddkilzer 2016-04-13 20:23:28 -0700 <rdar://problem/24718895> 276239 2016-04-12 09:20:31 -0700 2016-04-12 11:38:10 -0700 patch a-backup.diff text/plain 4673 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5MzU5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE2LTA0LTEyICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFRoZXJlIGlzIGEgcmFjZSB3aXRoIHRoZSBjb21waWxlciB0aHJlYWQgYW5kIHRoZSBtYWluIHRo cmVhZCB3aXRoIHJlc3VsdCBwcm9maWxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NTAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIGNvbXBpbGVyIHRocmVhZCBzaG91bGQgbm90IGJlIGFza2lu ZyBmb3IgYSByZXN1bHQKKyAgICAgICAgcHJvZmlsZSB3aGlsZSB0aGUgZXhlY3V0aW9uIHRocmVh ZCBpcyBjcmVhdGluZyBvbmUuCisgICAgICAgIFdlIG11c3QgZ3VhcmQgYWdhaW5zdCBzdWNoIHJh Y2VzIHdpdGggYSBsb2NrLgorCisgICAgICAgICogYnl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAg ICAgICAgKEpTQzo6Q29kZUJsb2NrOjpyZXN1bHRQcm9maWxlRm9yQnl0ZWNvZGVPZmZzZXQpOgor ICAgICAgICAoSlNDOjpDb2RlQmxvY2s6OmVuc3VyZVJlc3VsdFByb2ZpbGUpOgorICAgICAgICAo SlNDOjpDb2RlQmxvY2s6OmNhcGFiaWxpdHlMZXZlbCk6CisgICAgICAgICogYnl0ZWNvZGUvQ29k ZUJsb2NrLmg6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6Y291bGRUYWtlU2xvd0Nhc2UpOgor ICAgICAgICAoSlNDOjpDb2RlQmxvY2s6Om51bWJlck9mUmVzdWx0UHJvZmlsZXMpOgorICAgICAg ICAoSlNDOjpDb2RlQmxvY2s6OnNwZWNpYWxGYXN0Q2FzZVByb2ZpbGVDb3VudEZvckJ5dGVjb2Rl T2Zmc2V0KToKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjplbnN1cmVSZXN1bHRQcm9maWxlKTog RGVsZXRlZC4KKwogMjAxNi0wNC0xMiAgU2FhbSBiYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4K IAogICAgICAgICBXZSBpbmNvcnJlY3RseSBwYXJzZSBhcnJvdyBmdW5jdGlvbiBleHByZXNzaW9u cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5jcHAJ KHJldmlzaW9uIDE5OTM1MCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9Db2Rl QmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjI5LDYgKzQyMjksMTMgQEAgdW5zaWduZWQg Q29kZUJsb2NrOjpyYXJlQ2FzZVByb2ZpbGVDb3VudAogCiBSZXN1bHRQcm9maWxlKiBDb2RlQmxv Y2s6OnJlc3VsdFByb2ZpbGVGb3JCeXRlY29kZU9mZnNldChpbnQgYnl0ZWNvZGVPZmZzZXQpCiB7 CisgICAgQ29uY3VycmVudEpJVExvY2tlciBsb2NrZXIobV9sb2NrKTsKKyAgICByZXR1cm4gcmVz dWx0UHJvZmlsZUZvckJ5dGVjb2RlT2Zmc2V0KGxvY2tlciwgYnl0ZWNvZGVPZmZzZXQpOworfQor CitSZXN1bHRQcm9maWxlKiBDb2RlQmxvY2s6OnJlc3VsdFByb2ZpbGVGb3JCeXRlY29kZU9mZnNl dChjb25zdCBDb25jdXJyZW50SklUTG9ja2VyJiwgaW50IGJ5dGVjb2RlT2Zmc2V0KQoreworICAg IEFTU0VSVChtX2xvY2suaXNMb2NrZWQoKSk7CiAgICAgaWYgKCFtX2J5dGVjb2RlT2Zmc2V0VG9S ZXN1bHRQcm9maWxlSW5kZXhNYXApCiAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgIGF1dG8g aXRlcmF0b3IgPSBtX2J5dGVjb2RlT2Zmc2V0VG9SZXN1bHRQcm9maWxlSW5kZXhNYXAtPmZpbmQo Ynl0ZWNvZGVPZmZzZXQpOwpAQCAtNDIzNyw2ICs0MjQ0LDI4IEBAIFJlc3VsdFByb2ZpbGUqIENv ZGVCbG9jazo6cmVzdWx0UHJvZmlsZUYKICAgICByZXR1cm4gJm1fcmVzdWx0UHJvZmlsZXNbaXRl cmF0b3ItPnZhbHVlXTsKIH0KIAorCitSZXN1bHRQcm9maWxlKiBDb2RlQmxvY2s6OmVuc3VyZVJl c3VsdFByb2ZpbGUoaW50IGJ5dGVjb2RlT2Zmc2V0KQoreworICAgIENvbmN1cnJlbnRKSVRMb2Nr ZXIgbG9ja2VyKG1fbG9jayk7CisgICAgcmV0dXJuIGVuc3VyZVJlc3VsdFByb2ZpbGUobG9ja2Vy LCBieXRlY29kZU9mZnNldCk7Cit9CisKK1Jlc3VsdFByb2ZpbGUqIENvZGVCbG9jazo6ZW5zdXJl UmVzdWx0UHJvZmlsZShjb25zdCBDb25jdXJyZW50SklUTG9ja2VyJiBsb2NrZXIsIGludCBieXRl Y29kZU9mZnNldCkKK3sKKyAgICBBU1NFUlQobV9sb2NrLmlzTG9ja2VkKCkpOworICAgIFJlc3Vs dFByb2ZpbGUqIHByb2ZpbGUgPSByZXN1bHRQcm9maWxlRm9yQnl0ZWNvZGVPZmZzZXQobG9ja2Vy LCBieXRlY29kZU9mZnNldCk7CisgICAgaWYgKCFwcm9maWxlKSB7CisgICAgICAgIG1fcmVzdWx0 UHJvZmlsZXMuYXBwZW5kKFJlc3VsdFByb2ZpbGUoYnl0ZWNvZGVPZmZzZXQpKTsKKyAgICAgICAg cHJvZmlsZSA9ICZtX3Jlc3VsdFByb2ZpbGVzLmxhc3QoKTsKKyAgICAgICAgQVNTRVJUKCZtX3Jl c3VsdFByb2ZpbGVzLmxhc3QoKSA9PSAmbV9yZXN1bHRQcm9maWxlc1ttX3Jlc3VsdFByb2ZpbGVz LnNpemUoKSAtIDFdKTsKKyAgICAgICAgaWYgKCFtX2J5dGVjb2RlT2Zmc2V0VG9SZXN1bHRQcm9m aWxlSW5kZXhNYXApCisgICAgICAgICAgICBtX2J5dGVjb2RlT2Zmc2V0VG9SZXN1bHRQcm9maWxl SW5kZXhNYXAgPSBzdGQ6Om1ha2VfdW5pcXVlPEJ5dGVjb2RlT2Zmc2V0VG9SZXN1bHRQcm9maWxl SW5kZXhNYXA+KCk7CisgICAgICAgIG1fYnl0ZWNvZGVPZmZzZXRUb1Jlc3VsdFByb2ZpbGVJbmRl eE1hcC0+YWRkKGJ5dGVjb2RlT2Zmc2V0LCBtX3Jlc3VsdFByb2ZpbGVzLnNpemUoKSAtIDEpOwor ICAgIH0KKyAgICByZXR1cm4gcHJvZmlsZTsKK30KKwogI2lmIEVOQUJMRShKSVQpCiBERkc6OkNh cGFiaWxpdHlMZXZlbCBDb2RlQmxvY2s6OmNhcGFiaWxpdHlMZXZlbCgpCiB7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5oCShyZXZpc2lvbiAxOTkzNTAp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvQ29kZUJsb2NrLmgJKHdvcmtpbmcg Y29weSkKQEAgLTQzNiwyMSArNDM2LDExIEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIHZhbHVl ID49IE9wdGlvbnM6OmNvdWxkVGFrZVNsb3dDYXNlTWluaW11bUNvdW50KCk7CiAgICAgfQogCi0g ICAgUmVzdWx0UHJvZmlsZSogZW5zdXJlUmVzdWx0UHJvZmlsZShpbnQgYnl0ZWNvZGVPZmZzZXQp Ci0gICAgewotICAgICAgICBSZXN1bHRQcm9maWxlKiBwcm9maWxlID0gcmVzdWx0UHJvZmlsZUZv ckJ5dGVjb2RlT2Zmc2V0KGJ5dGVjb2RlT2Zmc2V0KTsKLSAgICAgICAgaWYgKCFwcm9maWxlKSB7 Ci0gICAgICAgICAgICBtX3Jlc3VsdFByb2ZpbGVzLmFwcGVuZChSZXN1bHRQcm9maWxlKGJ5dGVj b2RlT2Zmc2V0KSk7Ci0gICAgICAgICAgICBwcm9maWxlID0gJm1fcmVzdWx0UHJvZmlsZXMubGFz dCgpOwotICAgICAgICAgICAgQVNTRVJUKCZtX3Jlc3VsdFByb2ZpbGVzLmxhc3QoKSA9PSAmbV9y ZXN1bHRQcm9maWxlc1ttX3Jlc3VsdFByb2ZpbGVzLnNpemUoKSAtIDFdKTsKLSAgICAgICAgICAg IGlmICghbV9ieXRlY29kZU9mZnNldFRvUmVzdWx0UHJvZmlsZUluZGV4TWFwKQotICAgICAgICAg ICAgICAgIG1fYnl0ZWNvZGVPZmZzZXRUb1Jlc3VsdFByb2ZpbGVJbmRleE1hcCA9IHN0ZDo6bWFr ZV91bmlxdWU8Qnl0ZWNvZGVPZmZzZXRUb1Jlc3VsdFByb2ZpbGVJbmRleE1hcD4oKTsKLSAgICAg ICAgICAgIG1fYnl0ZWNvZGVPZmZzZXRUb1Jlc3VsdFByb2ZpbGVJbmRleE1hcC0+YWRkKGJ5dGVj b2RlT2Zmc2V0LCBtX3Jlc3VsdFByb2ZpbGVzLnNpemUoKSAtIDEpOwotICAgICAgICB9Ci0gICAg ICAgIHJldHVybiBwcm9maWxlOwotICAgIH0KKyAgICBSZXN1bHRQcm9maWxlKiBlbnN1cmVSZXN1 bHRQcm9maWxlKGludCBieXRlY29kZU9mZnNldCk7CisgICAgUmVzdWx0UHJvZmlsZSogZW5zdXJl UmVzdWx0UHJvZmlsZShjb25zdCBDb25jdXJyZW50SklUTG9ja2VyJiwgaW50IGJ5dGVjb2RlT2Zm c2V0KTsKICAgICB1bnNpZ25lZCBudW1iZXJPZlJlc3VsdFByb2ZpbGVzKCkgeyByZXR1cm4gbV9y ZXN1bHRQcm9maWxlcy5zaXplKCk7IH0KICAgICBSZXN1bHRQcm9maWxlKiByZXN1bHRQcm9maWxl Rm9yQnl0ZWNvZGVPZmZzZXQoaW50IGJ5dGVjb2RlT2Zmc2V0KTsKKyAgICBSZXN1bHRQcm9maWxl KiByZXN1bHRQcm9maWxlRm9yQnl0ZWNvZGVPZmZzZXQoY29uc3QgQ29uY3VycmVudEpJVExvY2tl ciYsIGludCBieXRlY29kZU9mZnNldCk7CiAKICAgICB1bnNpZ25lZCBzcGVjaWFsRmFzdENhc2VQ cm9maWxlQ291bnRGb3JCeXRlY29kZU9mZnNldChpbnQgYnl0ZWNvZGVPZmZzZXQpCiAgICAgewo=