156495 2016-04-11 22:23:49 -0700 Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer 2016-04-13 10:13:09 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin cdumez commit-queue esprehn+autocc kangil.han kondapallykalyan sam youennf oldest_to_newest 1182994 0 darin 2016-04-11 22:23:49 -0700 Remove UsePointersEvenForNonNullableObjectArguments from DataTransfer 1182995 1 276221 darin 2016-04-11 22:24:25 -0700 Created attachment 276221 Patch 1183059 2 276221 cdumez 2016-04-12 08:27:58 -0700 Comment on attachment 276221 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review > Source/WebCore/dom/DataTransfer.idl:41 > + void setDragImage(Element? image, long x, long y); Hmm, this does not match the spec: https://html.spec.whatwg.org/multipage/interaction.html#datatransfer 1183072 3 276221 darin 2016-04-12 09:20:39 -0700 Comment on attachment 276221 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276221&action=review >> Source/WebCore/dom/DataTransfer.idl:41 >> + void setDragImage(Element? image, long x, long y); > > Hmm, this does not match the spec: > https://html.spec.whatwg.org/multipage/interaction.html#datatransfer Our behavior of accepting null to mean we should remove/clear the drag image predates the spec by many years. It’s OK to change to match the specification, but we’d want to add regression tests and consider the backwards compatibility costs of making the change. 1183073 4 darin 2016-04-12 09:20:59 -0700 Maybe we should add a FIXME comment about matching the specification in the future? 1183076 5 cdumez 2016-04-12 09:24:42 -0700 (In reply to comment #4) > Maybe we should add a FIXME comment about matching the specification in the > future? Sound good to me. 1183416 6 276326 darin 2016-04-13 09:12:15 -0700 Created attachment 276326 Patch 1183421 7 276326 cdumez 2016-04-13 09:21:24 -0700 Comment on attachment 276326 Patch r=me 1183437 8 276326 commit-queue 2016-04-13 10:13:05 -0700 Comment on attachment 276326 Patch Clearing flags on attachment: 276326 Committed r199500: <http://trac.webkit.org/changeset/199500> 1183438 9 commit-queue 2016-04-13 10:13:09 -0700 All reviewed patches have been landed. Closing bug. 276221 2016-04-11 22:24:25 -0700 2016-04-13 09:12:12 -0700 Patch bug-156495-20160411222434.patch text/plain 1632 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE1ZmFhYmMxZDI4NzI2 NDRiOTY2MjYyZjMyMDdiN2UxZTU3YTdjYy4uNTFhZDk1MGEyNjVmYjcyMzE1MGVmZWQyMDg5MzQ4 OGU3NTk4ZTdhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE1IEBACiAyMDE2LTA0LTExICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW1vdmUgVXNlUG9pbnRlcnNF dmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHMgZnJvbSBEYXRhVHJhbnNmZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjQ5NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0RhdGFUcmFu c2Zlci5pZGw6IFJlbW92ZWQgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1 bWVudHMKKyAgICAgICAgYW5kIG1hcmtlZCB0aGUgZWxlbWVudCBhcmd1bWVudCB0byBzZXREcmFn SW1hZ2UgYXMgbnVsbGFibGUuCisKKzIwMTYtMDQtMTEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBw bGUuY29tPgorCiAgICAgICAgIFJlbW92ZSBVc2VQb2ludGVyc0V2ZW5Gb3JOb25OdWxsYWJsZU9i amVjdEFyZ3VtZW50cyBmcm9tIEhUTUxTZWxlY3RFbGVtZW50CiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY0NTgKIApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRGF0YVRy YW5zZmVyLmlkbAppbmRleCBmNmRiYmFjZjQ1NWM1YTc2MzMwZTIwZWFhZTVmYmZiMTliMDVmMmYw Li5hYWE4ZmU4OTM5YzhlZWU2NmMxOGEyOTIzMjQ3NjRlZGUyNmRiNjI5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9kb20vRGF0YVRyYW5zZmVyLmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vRGF0YVRyYW5zZmVyLmlkbApAQCAtMjcsNyArMjcsNiBAQAogICovCiAKIFsKLSAgICBVc2VQ b2ludGVyc0V2ZW5Gb3JOb25OdWxsYWJsZU9iamVjdEFyZ3VtZW50cywKICAgICBTa2lwVlRhYmxl VmFsaWRhdGlvbiwKIF0gaW50ZXJmYWNlIERhdGFUcmFuc2ZlciB7CiAgICAgYXR0cmlidXRlIERP TVN0cmluZyBkcm9wRWZmZWN0OwpAQCAtMzksNyArMzgsNyBAQAogICAgIHZvaWQgY2xlYXJEYXRh KG9wdGlvbmFsIERPTVN0cmluZyB0eXBlKTsKICAgICBET01TdHJpbmcgZ2V0RGF0YShET01TdHJp bmcgdHlwZSk7CiAgICAgdm9pZCBzZXREYXRhKERPTVN0cmluZyB0eXBlLCBET01TdHJpbmcgZGF0 YSk7Ci0gICAgdm9pZCBzZXREcmFnSW1hZ2UoRWxlbWVudCBpbWFnZSwgbG9uZyB4LCBsb25nIHkp OworICAgIHZvaWQgc2V0RHJhZ0ltYWdlKEVsZW1lbnQ/IGltYWdlLCBsb25nIHgsIGxvbmcgeSk7 CiAKICAgICBbQ29uZGl0aW9uYWw9REFUQV9UUkFOU0ZFUl9JVEVNU10gcmVhZG9ubHkgYXR0cmli dXRlIERhdGFUcmFuc2Zlckl0ZW1MaXN0IGl0ZW1zOwogfTsK 276326 2016-04-13 09:12:15 -0700 2016-04-13 10:13:05 -0700 Patch bug-156495-20160413091226.patch text/plain 1599 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5NDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmVjYjllMTlmY2U5ZmY4 MzM2NWUyOWQ0YjAxYjMxOTgzMjRiMDE1NS4uYTI5ZDJhMzVjZTkzOWU0NGJmZTU1YjJkYmJlNzk4 ZWNjY2IzZWExYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA0LTExICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgVXNlUG9pbnRlcnNF dmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHMgZnJvbSBEYXRhVHJhbnNmZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjQ5NQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZG9tL0RhdGFUcmFu c2Zlci5pZGw6IFJlbW92ZWQgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1 bWVudHMKKyAgICAgICAgYW5kIG1hcmtlZCB0aGUgZWxlbWVudCBhcmd1bWVudCB0byBzZXREcmFn SW1hZ2UgYXMgbnVsbGFibGUuCisKIDIwMTYtMDQtMTIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KIAogICAgICAgICBBdHRyLnZhbHVlIHNob3VsZCBub3QgYmUgbnVsbGFibGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9EYXRhVHJhbnNmZXIuaWRsIGIvU291cmNlL1dl YkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5pZGwKaW5kZXggZjZkYmJhY2Y0NTVjNWE3NjMzMGUyMGVh YWU1ZmJmYjE5YjA1ZjJmMC4uZTNlOTA0MmE3NzZlMjU4YmI4YTgyZjNmYWUzMzMxMGZkZTZmZTBk MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5pZGwKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5pZGwKQEAgLTI3LDcgKzI3LDYgQEAKICAq LwogCiBbCi0gICAgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHMs CiAgICAgU2tpcFZUYWJsZVZhbGlkYXRpb24sCiBdIGludGVyZmFjZSBEYXRhVHJhbnNmZXIgewog ICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgZHJvcEVmZmVjdDsKQEAgLTM5LDcgKzM4LDcgQEAKICAg ICB2b2lkIGNsZWFyRGF0YShvcHRpb25hbCBET01TdHJpbmcgdHlwZSk7CiAgICAgRE9NU3RyaW5n IGdldERhdGEoRE9NU3RyaW5nIHR5cGUpOwogICAgIHZvaWQgc2V0RGF0YShET01TdHJpbmcgdHlw ZSwgRE9NU3RyaW5nIGRhdGEpOwotICAgIHZvaWQgc2V0RHJhZ0ltYWdlKEVsZW1lbnQgaW1hZ2Us IGxvbmcgeCwgbG9uZyB5KTsKKyAgICB2b2lkIHNldERyYWdJbWFnZShFbGVtZW50PyBpbWFnZSwg bG9uZyB4LCBsb25nIHkpOyAvLyBGSVhNRTogRWxlbWVudCBhcmd1bWVudCBpcyBub3QgbnVsbGFi bGUgaW4gdGhlIEhUTUwgc3RhbmRhcmQuCiAKICAgICBbQ29uZGl0aW9uYWw9REFUQV9UUkFOU0ZF Ul9JVEVNU10gcmVhZG9ubHkgYXR0cmlidXRlIERhdGFUcmFuc2Zlckl0ZW1MaXN0IGl0ZW1zOwog fTsK