156493 2016-04-11 21:58:35 -0700 PolymorphicAccess::regenerate() shouldn't have to clone non-generated AccessCases 2016-04-13 12:05:01 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1182978 0 fpizlo 2016-04-11 21:58:35 -0700 ... 1183262 1 276283 fpizlo 2016-04-12 15:04:47 -0700 Created attachment 276283 the patch 1183286 2 276283 ggaren 2016-04-12 16:08:56 -0700 Comment on attachment 276283 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=276283&action=review r=me > Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:1571 > + found = true; > + break; Can we just return here? 1183471 3 fpizlo 2016-04-13 11:47:45 -0700 (In reply to comment #2) > Comment on attachment 276283 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=276283&action=review > > r=me > > > Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:1571 > > + found = true; > > + break; > > Can we just return here? Yup, good point. 1183479 4 fpizlo 2016-04-13 12:05:01 -0700 Landed in http://trac.webkit.org/changeset/199508 276283 2016-04-12 15:04:47 -0700 2016-04-12 16:08:56 -0700 the patch blah.patch text/plain 4359 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5MzkxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDE2LTA0LTEyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg UG9seW1vcnBoaWNBY2Nlc3M6OnJlZ2VuZXJhdGUoKSBzaG91bGRuJ3QgaGF2ZSB0byBjbG9uZSBu b24tZ2VuZXJhdGVkIEFjY2Vzc0Nhc2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTY0OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDbG9uaW5nIEFjY2Vzc0Nhc2VzIGlzIG9ubHkgbmVjZXNzYXJ5IGlm IHRoZXkgaG9sZCBzb21lIGFydGlmYWN0cyB0aGF0IGFyZSB1c2VkIGJ5IGNvZGUgdGhhdAorICAg ICAgICB0aGV5IGFscmVhZHkgZ2VuZXJhdGVkLiBTbywgaWYgdGhlIHN0YXRlIGlzIG5vdCBHZW5l cmF0ZWQsIHdlIGRvbid0IGhhdmUgdG8gYm90aGVyIHdpdGgKKyAgICAgICAgY2xvbmluZyB0aGVt LgorCisgICAgICAgIFRoaXMgc2hvdWxkIHNwZWVkIHVwIFBvbHltb3JwaGljQWNjZXNzIHJlZ2Vu ZXJhdGlvbiBhIGJpdCBtb3JlLgorCisgICAgICAgICogYnl0ZWNvZGUvUG9seW1vcnBoaWNBY2Nl c3MuY3BwOgorICAgICAgICAoSlNDOjpBY2Nlc3NDYXNlOjpjb21taXQpOgorICAgICAgICAoSlND OjpQb2x5bW9ycGhpY0FjY2Vzczo6cmVnZW5lcmF0ZSk6CisKIDIwMTYtMDQtMTIgIEtlaXRoIE1p bGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgQWJzdHJhY3RWYWx1ZSBz aG91bGQgdXNlIHRoZSByZXN1bHQgdHlwZSB0byBmaWx0ZXIgc3RydWN0dXJlcwpJbmRleDogU291 cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1BvbHltb3JwaGljQWNjZXNzLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvUG9seW1vcnBoaWNBY2Nlc3Mu Y3BwCShyZXZpc2lvbiAxOTkzODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUv UG9seW1vcnBoaWNBY2Nlc3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOTksNyArMzk5LDEwIEBA IHN0ZDo6dW5pcXVlX3B0cjxBY2Nlc3NDYXNlPiBBY2Nlc3NDYXNlOjoKIAogVmVjdG9yPFdhdGNo cG9pbnRTZXQqLCAyPiBBY2Nlc3NDYXNlOjpjb21taXQoVk0mIHZtLCBjb25zdCBJZGVudGlmaWVy JiBpZGVudCkKIHsKLSAgICBSRUxFQVNFX0FTU0VSVChtX3N0YXRlID09IFByaW1vcmRpYWwpOwor ICAgIC8vIEl0J3MgZmluZSB0byBjb21taXQgc29tZXRoaW5nIHRoYXQgaXMgYWxyZWFkeSBjb21t aXR0ZWQuIFRoYXQgYXJpc2VzIHdoZW4gd2Ugc3dpdGNoIHRvIHVzaW5nCisgICAgLy8gbmV3bHkg YWxsb2NhdGVkIHdhdGNocG9pbnRzLiBXaGVuIGl0IGhhcHBlbnMsIGl0J3Mgbm90IGVmZmljaWVu dCAtIGJ1dCB3ZSB0aGluayB0aGF0J3MgT0sKKyAgICAvLyBiZWNhdXNlIG1vc3QgQWNjZXNzQ2Fz ZXMgaGF2ZSBubyBleHRyYSB3YXRjaHBvaW50cyBhbnl3YXkuCisgICAgUkVMRUFTRV9BU1NFUlQo bV9zdGF0ZSA9PSBQcmltb3JkaWFsIHx8IG1fc3RhdGUgPT0gQ29tbWl0dGVkKTsKICAgICAKICAg ICBWZWN0b3I8V2F0Y2hwb2ludFNldCosIDI+IHJlc3VsdDsKICAgICAKQEAgLTE1NDYsMjggKzE1 NDksNDEgQEAgQWNjZXNzR2VuZXJhdGlvblJlc3VsdCBQb2x5bW9ycGhpY0FjY2VzcwogICAgIC8v IHRvIGJlIHVubXV0YXRlZC4gRm9yIHN1cmUsIHdlIHdhbnQgaXQgdG8gaGFuZyBvbnRvIGFueSBk YXRhIHN0cnVjdHVyZXMgdGhhdCBtYXkgYmUgcmVmZXJlbmNlZAogICAgIC8vIGZyb20gdGhlIGNv ZGUgb2YgdGhlIGN1cnJlbnQgc3R1YiAoYWthIHByZXZpb3VzKS4KICAgICBMaXN0VHlwZSBjYXNl czsKLSAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9saXN0LnNpemUoKTsgKytpKSB7Ci0g ICAgICAgIEFjY2Vzc0Nhc2UmIHNvbWVDYXNlID0gKm1fbGlzdFtpXTsKLSAgICAgICAgLy8gSWdu b3JlIGNhc2VzIHRoYXQgY2Fubm90IHBvc3NpYmx5IHN1Y2NlZWQgYW55bW9yZS4KLSAgICAgICAg aWYgKCFzb21lQ2FzZS5jb3VsZFN0aWxsU3VjY2VlZCgpKQotICAgICAgICAgICAgY29udGludWU7 Ci0gICAgICAgIAotICAgICAgICAvLyBGaWd1cmUgb3V0IGlmIHRoaXMgaXMgcmVwbGFjZWQgYnkg YW55IGxhdGVyIGNhc2UuCi0gICAgICAgIGJvb2wgZm91bmQgPSBmYWxzZTsKLSAgICAgICAgZm9y ICh1bnNpZ25lZCBqID0gaSArIDE7IGogPCBtX2xpc3Quc2l6ZSgpOyArK2opIHsKLSAgICAgICAg ICAgIGlmIChtX2xpc3Rbal0tPmNhblJlcGxhY2Uoc29tZUNhc2UpKSB7Ci0gICAgICAgICAgICAg ICAgZm91bmQgPSB0cnVlOwotICAgICAgICAgICAgICAgIGJyZWFrOworICAgIHVuc2lnbmVkIHNy Y0luZGV4ID0gMDsKKyAgICB1bnNpZ25lZCBkc3RJbmRleCA9IDA7CisgICAgd2hpbGUgKHNyY0lu ZGV4IDwgbV9saXN0LnNpemUoKSkgeworICAgICAgICBzdGQ6OnVuaXF1ZV9wdHI8QWNjZXNzQ2Fz ZT4gc29tZUNhc2UgPSBXVEZNb3ZlKG1fbGlzdFtzcmNJbmRleCsrXSk7CisgICAgICAgIAorICAg ICAgICAvLyBJZiB0aGUgY2FzZSBoYWQgYmVlbiBnZW5lcmF0ZWQsIHRoZW4gd2UgaGF2ZSB0byBr ZWVwIHRoZSBvcmlnaW5hbCBpbiBtX2xpc3QgaW4gY2FzZSB3ZQorICAgICAgICAvLyBmYWlsIHRv IHJlZ2VuZXJhdGUuIFRoYXQgY2FzZSBtYXkgaGF2ZSBkYXRhIHN0cnVjdHVyZXMgdGhhdCBhcmUg dXNlZCBieSB0aGUgY29kZSB0aGF0IGl0CisgICAgICAgIC8vIGhhZCBnZW5lcmF0ZWQuIElmIHRo ZSBjYXNlIGhhZCBub3QgYmVlbiBnZW5lcmF0ZWQsIHRoZW4gd2Ugd2FudCB0byByZW1vdmUgaXQg ZnJvbSBtX2xpc3QuCisgICAgICAgIGJvb2wgaXNHZW5lcmF0ZWQgPSBzb21lQ2FzZS0+c3RhdGUo KSA9PSBBY2Nlc3NDYXNlOjpHZW5lcmF0ZWQ7CisgICAgICAgIAorICAgICAgICAoWyZdICgpIHsK KyAgICAgICAgICAgIGlmICghc29tZUNhc2UtPmNvdWxkU3RpbGxTdWNjZWVkKCkpCisgICAgICAg ICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICAvLyBGaWd1cmUgb3V0IGlmIHRoaXMgaXMg cmVwbGFjZWQgYnkgYW55IGxhdGVyIGNhc2UuCisgICAgICAgICAgICBib29sIGZvdW5kID0gZmFs c2U7CisgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGogPSBzcmNJbmRleDsgaiA8IG1fbGlzdC5z aXplKCk7ICsraikgeworICAgICAgICAgICAgICAgIGlmIChtX2xpc3Rbal0tPmNhblJlcGxhY2Uo KnNvbWVDYXNlKSkgeworICAgICAgICAgICAgICAgICAgICBmb3VuZCA9IHRydWU7CisgICAgICAg ICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KLSAg ICAgICAgfQotICAgICAgICBpZiAoZm91bmQpCi0gICAgICAgICAgICBjb250aW51ZTsKKyAgICAg ICAgICAgIGlmIChmb3VuZCkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICAK KyAgICAgICAgICAgIGlmIChpc0dlbmVyYXRlZCkKKyAgICAgICAgICAgICAgICBjYXNlcy5hcHBl bmQoc29tZUNhc2UtPmNsb25lKCkpOworICAgICAgICAgICAgZWxzZQorICAgICAgICAgICAgICAg IGNhc2VzLmFwcGVuZChXVEZNb3ZlKHNvbWVDYXNlKSk7CisgICAgICAgIH0pKCk7CiAgICAgICAg IAotICAgICAgICAvLyBGSVhNRTogRG8gd2UgaGF2ZSB0byBjbG9uZSBjYXNlcyB0aGF0IGFyZW4n dCBnZW5lcmF0ZWQ/IE1heWJlIHdlIGNhbiBqdXN0IHRha2UgdGhvc2UKLSAgICAgICAgLy8gZnJv bSBtX2xpc3QsIHNpbmNlIHdlIGRvbid0IGhhdmUgdG8ga2VlcCB0aG9zZSBhbGl2ZSBpZiB3ZSBm YWlsLgotICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTU2NDkzCi0gICAgICAgIGNhc2VzLmFwcGVuZChzb21lQ2FzZS5jbG9uZSgpKTsKKyAgICAgICAg aWYgKGlzR2VuZXJhdGVkKQorICAgICAgICAgICAgbV9saXN0W2RzdEluZGV4KytdID0gV1RGTW92 ZShzb21lQ2FzZSk7CiAgICAgfQorICAgIG1fbGlzdC5yZXNpemUoZHN0SW5kZXgpOwogICAgIAog ICAgIGlmICh2ZXJib3NlKQogICAgICAgICBkYXRhTG9nKCJJbiByZWdlbmVyYXRlOiBjYXNlczog IiwgbGlzdER1bXAoY2FzZXMpLCAiXG4iKTsK