156491 2016-04-11 21:20:32 -0700 Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection 2016-04-11 22:49:47 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin cdumez commit-queue esprehn+autocc gyuyoung.kim kondapallykalyan sam youennf oldest_to_newest 1182967 0 darin 2016-04-11 21:20:32 -0700 Remove UsePointersEvenForNonNullableObjectArguments from HTMLOptionsCollection 1182968 1 276214 darin 2016-04-11 21:22:46 -0700 Created attachment 276214 Patch 1182973 2 276214 cdumez 2016-04-11 21:40:56 -0700 Comment on attachment 276214 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276214&action=review r=me > Source/WebCore/html/HTMLOptionsCollection.h:42 > + HTMLOptionElement* item(unsigned offset) const final; is this the pattern now? final seems redundant since the class already is final. 1182976 3 darin 2016-04-11 21:57:19 -0700 (In reply to comment #2) > > Source/WebCore/html/HTMLOptionsCollection.h:42 > > + HTMLOptionElement* item(unsigned offset) const final; > > is this the pattern now? > final seems redundant since the class already is final. This was discussed on webkit-dev: https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html That lats message is where the discussion ended. If you like we can debate it again. 1182986 4 cdumez 2016-04-11 22:04:11 -0700 (In reply to comment #3) > (In reply to comment #2) > > > Source/WebCore/html/HTMLOptionsCollection.h:42 > > > + HTMLOptionElement* item(unsigned offset) const final; > > > > is this the pattern now? > > final seems redundant since the class already is final. > > This was discussed on webkit-dev: > > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028018.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028019.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028021.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028020.html > https://lists.webkit.org/pipermail/webkit-dev/2016-March/028022.html > > That lats message is where the discussion ended. If you like we can debate > it again. I don't really mind it, I was merely curious. 1182999 5 276214 commit-queue 2016-04-11 22:49:41 -0700 Comment on attachment 276214 Patch Clearing flags on attachment: 276214 Committed r199335: <http://trac.webkit.org/changeset/199335> 1183001 6 commit-queue 2016-04-11 22:49:47 -0700 All reviewed patches have been landed. Closing bug. 276214 2016-04-11 21:22:46 -0700 2016-04-11 22:49:41 -0700 Patch bug-156491-20160411212255.patch text/plain 4284 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWE1ZmFhYmMxZDI4NzI2 NDRiOTY2MjYyZjMyMDdiN2UxZTU3YTdjYy4uOGQzZmY4ZDM3ZGNkMDRjNWIyOTlmM2M3ODQ3YmZl ZWNjNmQ5OTIxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE2LTA0LTExICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAorICAgICAgICBSZW1vdmUgVXNlUG9pbnRlcnNF dmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHMgZnJvbSBIVE1MT3B0aW9uc0NvbGxlY3Rp b24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjQ5 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRt bC9IVE1MT3B0aW9uc0NvbGxlY3Rpb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE9wdGlv bnNDb2xsZWN0aW9uOjphZGQpOiBUYWtlIGEgcmVmZXJlbmNlIGluc3RlYWQgb2YgYSBwb2ludGVy LgorICAgICAgICAqIGh0bWwvSFRNTE9wdGlvbnNDb2xsZWN0aW9uLmg6IFJlbW92ZWQgdW5uZWVk ZWQgZm9yd2FyZCBkZWNsYXJhdGlvbi4gQ2hhbmdlZAorICAgICAgICBhZGQgdG8gdGFrZSBhIHJl ZmVyZW5jZSBpbnN0ZWFkIG9mIGEgcG9pbnRlciBmb3IgdGhlIGVsZW1lbnQgdG8gYWRkLiBVc2Vk CisgICAgICAgIGZpbmFsIGluc3RlYWQgb2Ygb3ZlcnJpZGUgb24gdmlydHVhbCBmdW5jdGlvbnMu CisgICAgICAgICogaHRtbC9IVE1MT3B0aW9uc0NvbGxlY3Rpb24uaWRsOiBSZW1vdmVkIG5vdy11 bm5lZWRlZCBhdHRyaWJ1dGUKKyAgICAgICAgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVP YmplY3RBcmd1bWVudHM7IHRoZSBvbmx5IGZ1bmN0aW9uIGFmZmVjdGVkIHdhcworICAgICAgICBh ZGQsIGFuZCB0aGUgb3ZlcmxvYWRpbmcgY29kZSB3YXMgYWxyZWFkeSBjaGVja2luZyBmb3IgbnVs bC4KKworMjAxNi0wNC0xMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKICAgICAg ICAgUmVtb3ZlIFVzZVBvaW50ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzIGZy b20gSFRNTFNlbGVjdEVsZW1lbnQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1NjQ1OAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxPcHRpb25zQ29sbGVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPcHRpb25z Q29sbGVjdGlvbi5jcHAKaW5kZXggYzBkNjM4ZGU3OTllNzg0OTU5M2MwNGQ0MzBjOWMxY2E3ODkz NWU5NC4uNzcwMGEyNGM0MDFiNDdkYWU2MWFjZDY3NDQ5ZjNmY2E2NjhkNWIyOSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT3B0aW9uc0NvbGxlY3Rpb24uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9wdGlvbnNDb2xsZWN0aW9uLmNwcApAQCAtMzYsMTQgKzM2 LDEyIEBAIFJlZjxIVE1MT3B0aW9uc0NvbGxlY3Rpb24+IEhUTUxPcHRpb25zQ29sbGVjdGlvbjo6 Y3JlYXRlKEhUTUxTZWxlY3RFbGVtZW50JiBzZWxlCiAgICAgcmV0dXJuIGFkb3B0UmVmKCpuZXcg SFRNTE9wdGlvbnNDb2xsZWN0aW9uKHNlbGVjdCkpOwogfQogCi12b2lkIEhUTUxPcHRpb25zQ29s bGVjdGlvbjo6YWRkKEhUTUxFbGVtZW50KiBlbGVtZW50LCBIVE1MRWxlbWVudCogYmVmb3JlRWxl bWVudCwgRXhjZXB0aW9uQ29kZSYgZWMpCit2b2lkIEhUTUxPcHRpb25zQ29sbGVjdGlvbjo6YWRk KEhUTUxFbGVtZW50JiBlbGVtZW50LCBIVE1MRWxlbWVudCogYmVmb3JlRWxlbWVudCwgRXhjZXB0 aW9uQ29kZSYgZWMpCiB7Ci0gICAgaWYgKCFlbGVtZW50KQotICAgICAgICByZXR1cm47Ci0gICAg c2VsZWN0RWxlbWVudCgpLmFkZCgqZWxlbWVudCwgYmVmb3JlRWxlbWVudCwgZWMpOworICAgIHNl bGVjdEVsZW1lbnQoKS5hZGQoZWxlbWVudCwgYmVmb3JlRWxlbWVudCwgZWMpOwogfQogCi12b2lk IEhUTUxPcHRpb25zQ29sbGVjdGlvbjo6YWRkKEhUTUxFbGVtZW50KiBlbGVtZW50LCBpbnQgYmVm b3JlSW5kZXgsIEV4Y2VwdGlvbkNvZGUmIGVjKQordm9pZCBIVE1MT3B0aW9uc0NvbGxlY3Rpb246 OmFkZChIVE1MRWxlbWVudCYgZWxlbWVudCwgaW50IGJlZm9yZUluZGV4LCBFeGNlcHRpb25Db2Rl JiBlYykKIHsKICAgICBhZGQoZWxlbWVudCwgaXRlbShiZWZvcmVJbmRleCksIGVjKTsKIH0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9wdGlvbnNDb2xsZWN0aW9uLmggYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPcHRpb25zQ29sbGVjdGlvbi5oCmluZGV4IDJlZDYyMDY3 OWE3NWQ4NzZiYWZjNDZkYzRhYjEyMWQyZjExMGMwNDguLmQxZTE0Njc0ODEwNDMzZGRhZDc5Zjc5 YmY5MzRmMGFkNmQyMjY1MmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE9w dGlvbnNDb2xsZWN0aW9uLmgKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MT3B0aW9uc0Nv bGxlY3Rpb24uaApAQCAtMzAsOCArMzAsNiBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNs YXNzIEhUTUxPcHRpb25FbGVtZW50OwotCiB0eXBlZGVmIGludCBFeGNlcHRpb25Db2RlOwogCiBj bGFzcyBIVE1MT3B0aW9uc0NvbGxlY3Rpb24gZmluYWwgOiBwdWJsaWMgQ2FjaGVkSFRNTENvbGxl Y3Rpb248SFRNTE9wdGlvbnNDb2xsZWN0aW9uLCBDb2xsZWN0aW9uVHlwZVRyYWl0czxTZWxlY3RP cHRpb25zPjo6dHJhdmVyc2FsVHlwZT4gewpAQCAtNDEsMTEgKzM5LDExIEBAIHB1YmxpYzoKICAg ICBIVE1MU2VsZWN0RWxlbWVudCYgc2VsZWN0RWxlbWVudCgpIHsgcmV0dXJuIGRvd25jYXN0PEhU TUxTZWxlY3RFbGVtZW50Pihvd25lck5vZGUoKSk7IH0KICAgICBjb25zdCBIVE1MU2VsZWN0RWxl bWVudCYgc2VsZWN0RWxlbWVudCgpIGNvbnN0IHsgcmV0dXJuIGRvd25jYXN0PEhUTUxTZWxlY3RF bGVtZW50Pihvd25lck5vZGUoKSk7IH0KIAotICAgIEhUTUxPcHRpb25FbGVtZW50KiBpdGVtKHVu c2lnbmVkIG9mZnNldCkgY29uc3Qgb3ZlcnJpZGU7Ci0gICAgSFRNTE9wdGlvbkVsZW1lbnQqIG5h bWVkSXRlbShjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUpIGNvbnN0IG92ZXJyaWRlOworICAgIEhU TUxPcHRpb25FbGVtZW50KiBpdGVtKHVuc2lnbmVkIG9mZnNldCkgY29uc3QgZmluYWw7CisgICAg SFRNTE9wdGlvbkVsZW1lbnQqIG5hbWVkSXRlbShjb25zdCBBdG9taWNTdHJpbmcmIG5hbWUpIGNv bnN0IGZpbmFsOwogCi0gICAgdm9pZCBhZGQoSFRNTEVsZW1lbnQqLCBIVE1MRWxlbWVudCogYmVm b3JlRWxlbWVudCwgRXhjZXB0aW9uQ29kZSYpOwotICAgIHZvaWQgYWRkKEhUTUxFbGVtZW50Kiwg aW50IGJlZm9yZUluZGV4LCBFeGNlcHRpb25Db2RlJik7CisgICAgdm9pZCBhZGQoSFRNTEVsZW1l bnQmLCBIVE1MRWxlbWVudCogYmVmb3JlRWxlbWVudCwgRXhjZXB0aW9uQ29kZSYpOworICAgIHZv aWQgYWRkKEhUTUxFbGVtZW50JiwgaW50IGJlZm9yZUluZGV4LCBFeGNlcHRpb25Db2RlJik7CiAg ICAgdm9pZCByZW1vdmUoaW50IGluZGV4KTsKICAgICB2b2lkIHJlbW92ZShIVE1MT3B0aW9uRWxl bWVudCYpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPcHRpb25zQ29s bGVjdGlvbi5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxPcHRpb25zQ29sbGVjdGlvbi5p ZGwKaW5kZXggOWM4Y2I5Njk4YzBmYmE0MjMzNDEyOTI1YjcyNDA2MjdmNjc0ZmU4Ni4uYmFlOThi MGM1MTE2M2M0ZjRhN2IzYWY3Y2U1YTcwNWViMmU5YTIzZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaHRtbC9IVE1MT3B0aW9uc0NvbGxlY3Rpb24uaWRsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2h0bWwvSFRNTE9wdGlvbnNDb2xsZWN0aW9uLmlkbApAQCAtMjEsNyArMjEsNiBAQAogWwogICAg IEpTR2VuZXJhdGVUb05hdGl2ZU9iamVjdCwKICAgICBDdXN0b21JbmRleGVkU2V0dGVyLAotICAg IFVzZVBvaW50ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzLAogICAgIEdlbmVy YXRlSXNSZWFjaGFibGU9SW1wbE93bmVyTm9kZVJvb3QsCiBdIGludGVyZmFjZSBIVE1MT3B0aW9u c0NvbGxlY3Rpb24gOiBIVE1MQ29sbGVjdGlvbiB7CiAgICAgYXR0cmlidXRlIGxvbmcgc2VsZWN0 ZWRJbmRleDsK