156488 2016-04-11 19:43:52 -0700 putImageData needs to premultiply input 2016-04-11 19:57:26 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino dino jonlee sabouhallawa webkit-bug-importer oldest_to_newest 1182926 0 dino 2016-04-11 19:43:52 -0700 I made a mistake in r187534, where I updated putImageData to use the Accelerate framework. The iOS path accidentally unpremultiplied the incoming data, rather than premultiplying it. 1182927 1 webkit-bug-importer 2016-04-11 19:44:17 -0700 <rdar://problem/25672675> 1182929 2 dino 2016-04-11 19:45:11 -0700 <rdar://problem/23119884> 1182930 3 276201 dino 2016-04-11 19:49:08 -0700 Created attachment 276201 Patch 1182931 4 jonlee 2016-04-11 19:51:28 -0700 What's the impact on the Animometer Images test? 1182932 5 dino 2016-04-11 19:52:36 -0700 (In reply to comment #4) > What's the impact on the Animometer Images test? Should be zero. We're still doing the same sets of operations, just multiplying rather than dividing. And this is iOS only. 1182934 6 dino 2016-04-11 19:57:26 -0700 Committed r199330: <http://trac.webkit.org/changeset/199330> 276201 2016-04-11 19:49:08 -0700 2016-04-11 19:53:34 -0700 Patch bug-156488-20160412124916.patch text/plain 5056 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MjM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDI5OWU3MmVjOTQ3YTdi MjVhOGRmYzc2ZWYzYTRlNTk3ZjgxMmQyMy4uYTU1NDVmNTM0NTIwNzFlYzczODYwNzhmZDE3ZjM0 NTc3MWExMTY5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA0LTExICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBwdXRJbWFnZURhdGEgbmVlZHMg dG8gcHJlbXVsdGlwbHkgaW5wdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1NjQ4OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjU2NzI2NzU+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBtYWRlIGEg bWlzdGFrZSBpbiByMTg3NTM0IGFzIEkgd2FzIGNvbnZlcnRpbmcgZ2V0IGFuZCBwdXRJbWFnZURh dGEKKyAgICAgICAgdG8gdXNlIEFjY2VsZXJhdGUuIFRoZSBpbmNvbWluZyBkYXRhIGlzIHVubXVs dGlwbGllZCwgYW5kIHNob3VsZAorICAgICAgICBiZSBwcmVtdWx0aXBsaWVkIGJlZm9yZSBjb3B5 aW5nIGludG8gdGhlIGJhY2tpbmcgc3RvcmUuIEkgd2FzCisgICAgICAgIGFjY2lkZW50YWxseSB1 bm11bHRpcGx5aW5nIHVubXVsdGlwbGllZCBkYXRhLCB3aGljaCBjYXVzZWQKKyAgICAgICAgc29t ZSBwcmV0dHkgcHN5Y2hvZGVsaWMgcmVzdWx0cy4KKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZh cy9wdXRJbWFnZURhdGEtdW5tdWx0aXBsaWVkLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NnL0ltYWdlQnVmZmVyRGF0YUNHLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdl QnVmZmVyRGF0YTo6cHV0RGF0YSk6IENhbGwgcHJlbXVsdGlwbHksIG5vdCB1bnByZW11bHRpcGx5 LgorCiAyMDE2LTA0LTA4ICBCZXRoIERha2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAg ICBGaXggbGVha3MgaW4gV2ViQVZNZWRpYVNlbGVjdGlvbk9wdGlvbk1hYyBhbmQgV2ViUGxheWJh Y2tDb250cm9sc01hbmFnZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2NnL0ltYWdlQnVmZmVyRGF0YUNHLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2NnL0ltYWdlQnVmZmVyRGF0YUNHLmNwcAppbmRleCBlMWFjNDU0YmQzNzJmMjI3 MTYzMWRlOGU2NWE0ZDNjNjUzNjJiNjUyLi5mYTYzNGM4NmM0MzQ1YmUxYmU3ZWI1NjU3MDhkNjQ3 YWEwYTlkYzI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j Zy9JbWFnZUJ1ZmZlckRhdGFDRy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2cvSW1hZ2VCdWZmZXJEYXRhQ0cuY3BwCkBAIC02NCw3ICs2NCw2IEBAIHN0YXRpYyB2 b2lkIHVucHJlbXVsdGlwbHlCdWZmZXJEYXRhKGNvbnN0IHZJbWFnZV9CdWZmZXImIHNyYywgY29u c3QgdkltYWdlX0J1ZmZlCiAgICAgdkltYWdlUGVybXV0ZUNoYW5uZWxzX0FSR0I4ODg4KCZkZXN0 LCAmZGVzdCwgbWFwLCBrdkltYWdlTm9GbGFncyk7CiB9CiAKLSNpZiAhUExBVEZPUk0oSU9TX1NJ TVVMQVRPUikKIHN0YXRpYyB2b2lkIHByZW11bHRpcGx5QnVmZmVyRGF0YShjb25zdCB2SW1hZ2Vf QnVmZmVyJiBzcmMsIGNvbnN0IHZJbWFnZV9CdWZmZXImIGRlc3QpCiB7CiAgICAgQVNTRVJUKHNy Yy5kYXRhKTsKQEAgLTc3LDcgKzc2LDYgQEAgc3RhdGljIHZvaWQgcHJlbXVsdGlwbHlCdWZmZXJE YXRhKGNvbnN0IHZJbWFnZV9CdWZmZXImIHNyYywgY29uc3QgdkltYWdlX0J1ZmZlciYKICAgICBj b25zdCB1aW50OF90IG1hcFs0XSA9IHsgMiwgMSwgMCwgMyB9OwogICAgIHZJbWFnZVBlcm11dGVD aGFubmVsc19BUkdCODg4OCgmZGVzdCwgJmRlc3QsIG1hcCwga3ZJbWFnZU5vRmxhZ3MpOwogfQot I2VuZGlmIC8vICFQTEFURk9STShJT1NfU0lNVUxBVE9SKQogI2VuZGlmIC8vIFVTRV9BUkdCMzIg fHwgVVNFKElPU1VSRkFDRV9DQU5WQVNfQkFDS0lOR19TVE9SRSkKIAogI2lmICFQTEFURk9STShJ T1NfU0lNVUxBVE9SKQpAQCAtNDEyLDcgKzQxMCw3IEBAIHZvaWQgSW1hZ2VCdWZmZXJEYXRhOjpw dXREYXRhKFVpbnQ4Q2xhbXBlZEFycmF5KiYgc291cmNlLCBjb25zdCBJbnRTaXplJiBzb3VyY2VT CiAgICAgICAgICAgICBkZXN0LmRhdGEgPSBkZXN0Um93czsKIAogI2lmIFVTRV9BUkdCMzIKLSAg ICAgICAgICAgIHVucHJlbXVsdGlwbHlCdWZmZXJEYXRhKHNyYywgZGVzdCk7CisgICAgICAgICAg ICBwcmVtdWx0aXBseUJ1ZmZlckRhdGEoc3JjLCBkZXN0KTsKICNlbHNlCiAgICAgICAgICAgICBp ZiAocmVzb2x1dGlvblNjYWxlICE9IDEpIHsKICAgICAgICAgICAgICAgICBhZmZpbmVXYXJwQnVm ZmVyRGF0YShzcmMsIGRlc3QsIHJlc29sdXRpb25TY2FsZSk7CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzcxOTNjMDE2N2Fk MjMzODU3Nzk3ZWEwNDVmMzdmZDRjMzU5N2M3Mi4uZmU3ZGQzMDEyOWY3ODgyZDA2ZWU0MjRiYzVl YzE0MDJjNzg2ZGJhMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA0LTExICBEZWFuIEph Y2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBwdXRJbWFnZURhdGEgbmVlZHMgdG8g cHJlbXVsdGlwbHkgaW5wdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1NjQ4OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjU2NzI2NzU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdHMgdGhhdCBw dXRJbWFnZURhdGEgaXMgdGFraW5nIHVubXVsdGlwbGllZCBkYXRhLAorICAgICAgICBwcmVtdWx0 aXBseWluZyBpdCwgdGhlbiBjb3B5aW5nIGludG8gdGhlIGJhY2tpbmcgc3RvcmUuCisKKyAgICAg ICAgKiBmYXN0L2NhbnZhcy9wdXRJbWFnZURhdGEtdW5tdWx0aXBsaWVkLWV4cGVjdGVkLmh0bWw6 IEFkZGVkLgorICAgICAgICAqIGZhc3QvY2FudmFzL3B1dEltYWdlRGF0YS11bm11bHRpcGxpZWQu aHRtbDogQWRkZWQuCisKIDIwMTYtMDQtMDggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KIAogICAgICAgICBSZWRlZmluaW5nIGEgbWV0aG9kIG9mIHRoZSBzYW1lIG5hbWUg aGl0cyBhbiBhc3NlcnRpb24KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3B1 dEltYWdlRGF0YS11bm11bHRpcGxpZWQtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL3B1dEltYWdlRGF0YS11bm11bHRpcGxpZWQtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5jOGVmZWIzN2Y0NGQ0YTU3YmUwYTExNWI2ZmI5NDQyOTU4ZmNlODJiCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvcHV0SW1hZ2VEYXRhLXVubXVsdGlwbGllZC1l eHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMjAgQEAKKzxzdHlsZT4KKyAgICBjYW52YXMgeworICAg ICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgfQorPC9zdHls ZT4KKzxzY3JpcHQ+CisgICAgZnVuY3Rpb24gcnVuKCkgeworICAgICAgICB2YXIgYyA9IGRvY3Vt ZW50LnF1ZXJ5U2VsZWN0b3IoImNhbnZhcyIpOworICAgICAgICBjLndpZHRoID0gMTsKKyAgICAg ICAgYy5oZWlnaHQgPSAxOworICAgICAgICB2YXIgY3R4ID0gYy5nZXRDb250ZXh0KCIyZCIpOwor CisgICAgICAgIGN0eC5maWxsU3R5bGUgPSAicmdiYSgyNTUsIDE4MCwgMCwgIiArIDE2My8yNTUg KyAiKSI7CisgICAgICAgIGN0eC5maWxsUmVjdCgwLCAwLCAxLCAxKTsKKyAgICB9CisKKyAgICB3 aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigibG9hZCIsIHJ1biwgZmFsc2UpOworPC9zY3JpcHQ+Cis8 Y2FudmFzPjwvY2FudmFzPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvcHV0 SW1hZ2VEYXRhLXVubXVsdGlwbGllZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvcHV0 SW1hZ2VEYXRhLXVubXVsdGlwbGllZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmIzYzg3MTM2MDY2YzJiNjQ1 MWFlNzEzYjEwMTUyMjAwYWVjZWU1YjAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L2NhbnZhcy9wdXRJbWFnZURhdGEtdW5tdWx0aXBsaWVkLmh0bWwKQEAgLTAsMCArMSwyNCBA QAorPHN0eWxlPgorICAgIGNhbnZhcyB7CisgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAg aGVpZ2h0OiAxMDBweDsKKyAgICB9Cis8L3N0eWxlPgorPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBy dW4oKSB7CisgICAgICAgIHZhciBjID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiY2FudmFzIik7 CisgICAgICAgIGMud2lkdGggPSAxOworICAgICAgICBjLmhlaWdodCA9IDE7CisgICAgICAgIHZh ciBjdHggPSBjLmdldENvbnRleHQoIjJkIik7CisKKyAgICAgICAgdmFyIGRhdGEgPSBjdHguY3Jl YXRlSW1hZ2VEYXRhKDEsIDEpOworICAgICAgICBkYXRhLmRhdGFbMF0gPSAweGZmOworICAgICAg ICBkYXRhLmRhdGFbMV0gPSAweGI0OworICAgICAgICBkYXRhLmRhdGFbMl0gPSAweDAwOworICAg ICAgICBkYXRhLmRhdGFbM10gPSAweGEzOworICAgICAgICBjdHgucHV0SW1hZ2VEYXRhKGRhdGEs IDAsIDApOworICAgIH0KKworICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCJsb2FkIiwgcnVu LCBmYWxzZSk7Cis8L3NjcmlwdD4KKzxjYW52YXM+PC9jYW52YXM+Cg==