156481 2016-04-11 16:17:37 -0700 MIPS: add MacroAssemblerMIPS::store8(TrustedImm32,ImplicitAddress) 2016-04-12 10:27:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Other Linux RESOLVED FIXED P2 Normal --- 1 guijemont webkit-unassigned annulen commit-queue guijemont jbriance keith_miller mark.lam msaboff saam oldest_to_newest 1182865 0 guijemont 2016-04-11 16:17:37 -0700 This method with this signature is used by r199075, and therefore WebKit doesn't build on MIPS since then. 1182870 1 276186 guijemont 2016-04-11 16:27:40 -0700 Created attachment 276186 Patch Patch that implement that store8(). 1183040 2 jbriance 2016-04-12 06:37:45 -0700 Looks good to me 1183099 3 276186 commit-queue 2016-04-12 10:27:00 -0700 Comment on attachment 276186 Patch Clearing flags on attachment: 276186 Committed r199372: <http://trac.webkit.org/changeset/199372> 1183100 4 commit-queue 2016-04-12 10:27:04 -0700 All reviewed patches have been landed. Closing bug. 276186 2016-04-11 16:27:40 -0700 2016-04-12 10:27:00 -0700 Patch bug-156481-20160411182749.patch text/plain 2504 guijemont U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5Mjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz MzY4ODg5YWRmNjViZWVhNmUyNmQ0YzkwM2RkYTg1MjU3ZmU2MGVhLi5hNTc1NGFjYjdlMzE2YzJj ZjVjNWU1YjYzMDY3Nzg0YzRmMmIyYTY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wNC0xMSAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxp YS5jb20+CisKKyAgICAgICAgTUlQUzogYWRkIE1hY3JvQXNzZW1ibGVyTUlQUzo6c3RvcmU4KFRy dXN0ZWRJbW0zMixJbXBsaWNpdEFkZHJlc3MpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY0ODEKKworICAgICAgICBUaGlzIG1ldGhvZCB3aXRoIHRo aXMgc2lnbmF0dXJlIGlzIHVzZWQgYnkgcjE5OTA3NSwgYW5kIHRoZXJlZm9yZQorICAgICAgICBX ZWJLaXQgZG9lc24ndCBidWlsZCBvbiBNSVBTIHNpbmNlIHRoZW4uCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJNSVBTLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6c3RvcmU4KToKKwog MjAxNi0wNC0xMSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBqcC5zb255LmNvbT4K IAogICAgICAgICBbQ01ha2VdIE1ha2UgRk9MREVSIHByb3BlcnR5IElOSEVSSVRFRApkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMu aCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgK aW5kZXggNTgxZDAzZmQwOGYwZTc1NjBmYzBiOTMzMTUyNTFmOWU3ZjNjN2I2OC4uYzU3NGNiMDFm ZDJjYmUxMjc0NTEzYzJmZWM5MDdmOWE5OTNlNzk5MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCkBAIC0xMDU1LDYgKzEw NTUsMzMgQEAgcHVibGljOgogICAgICAgICB9CiAgICAgfQogCisgICAgdm9pZCBzdG9yZTgoVHJ1 c3RlZEltbTMyIGltbSwgSW1wbGljaXRBZGRyZXNzIGFkZHJlc3MpCisgICAgeworICAgICAgICBp ZiAoYWRkcmVzcy5vZmZzZXQgPj0gLTMyNzY4ICYmIGFkZHJlc3Mub2Zmc2V0IDw9IDMyNzY3Cisg ICAgICAgICAgICAmJiAhbV9maXhlZFdpZHRoKSB7CisgICAgICAgICAgICBpZiAoIWltbS5tX3Zh bHVlKQorICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVyLnNiKE1JUFNSZWdpc3RlcnM6Onplcm8s IGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5vZmZzZXQpOworICAgICAgICAgICAgZWxzZSB7CisgICAg ICAgICAgICAgICAgbW92ZShpbW0sIGltbVRlbXBSZWdpc3Rlcik7CisgICAgICAgICAgICAgICAg bV9hc3NlbWJsZXIuc2IoaW1tVGVtcFJlZ2lzdGVyLCBhZGRyZXNzLmJhc2UsIGFkZHJlc3Mub2Zm c2V0KTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIC8qCisg ICAgICAgICAgICAgICAgbHVpICAgICBhZGRyVGVtcCwgKG9mZnNldCArIDB4ODAwMCkgPj4gMTYK KyAgICAgICAgICAgICAgICBhZGR1ICAgIGFkZHJUZW1wLCBhZGRyVGVtcCwgYmFzZQorICAgICAg ICAgICAgICAgIHNiICAgICAgaW1tVGVtcCwgKG9mZnNldCAmIDB4ZmZmZikoYWRkclRlbXApCisg ICAgICAgICAgICAgICovCisgICAgICAgICAgICBtX2Fzc2VtYmxlci5sdWkoYWRkclRlbXBSZWdp c3RlciwgKGFkZHJlc3Mub2Zmc2V0ICsgMHg4MDAwKSA+PiAxNik7CisgICAgICAgICAgICBtX2Fz c2VtYmxlci5hZGR1KGFkZHJUZW1wUmVnaXN0ZXIsIGFkZHJUZW1wUmVnaXN0ZXIsIGFkZHJlc3Mu YmFzZSk7CisgICAgICAgICAgICBpZiAoIWltbS5tX3ZhbHVlICYmICFtX2ZpeGVkV2lkdGgpCisg ICAgICAgICAgICAgICAgbV9hc3NlbWJsZXIuc2IoTUlQU1JlZ2lzdGVyczo6emVybywgYWRkclRl bXBSZWdpc3RlciwgYWRkcmVzcy5vZmZzZXQpOworICAgICAgICAgICAgZWxzZSB7CisgICAgICAg ICAgICAgICAgbW92ZShpbW0sIGltbVRlbXBSZWdpc3Rlcik7CisgICAgICAgICAgICAgICAgbV9h c3NlbWJsZXIuc2IoaW1tVGVtcFJlZ2lzdGVyLCBhZGRyVGVtcFJlZ2lzdGVyLCBhZGRyZXNzLm9m ZnNldCk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICB9CisKICAgICB2b2lkIHN0b3Jl MTYoUmVnaXN0ZXJJRCBzcmMsIEJhc2VJbmRleCBhZGRyZXNzKQogICAgIHsKICAgICAgICAgaWYg KGFkZHJlc3Mub2Zmc2V0ID49IC0zMjc2OCAmJiBhZGRyZXNzLm9mZnNldCA8PSAzMjc2Nwo=