156479 2016-04-11 16:02:05 -0700 REGRESSION(r198909): made double-click-and-drag on text drag instead of highlighting (Requested by alexchristensen_ on #webkit). 2016-04-11 16:19:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 155746 1 commit-queue commit-queue darin tonikitoo oldest_to_newest 1182857 0 commit-queue 2016-04-11 16:02:05 -0700 http://trac.webkit.org/changeset/198909 broke the build: made double-click-and-drag on text drag instead of highlighting (Requested by alexchristensen_ on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1182858 1 276184 commit-queue 2016-04-11 16:02:33 -0700 Created attachment 276184 ROLLOUT of r198909 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1182868 2 276184 achristensen 2016-04-11 16:19:15 -0700 Comment on attachment 276184 ROLLOUT of r198909 Committed manually. This reverted the bug in https://bugs.webkit.org/show_bug.cgi?id=155390 276184 2016-04-11 16:02:33 -0700 2016-04-11 16:19:15 -0700 ROLLOUT of r198909 bug-156479-20160411160242.patch text/plain 5767 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjFlNzNkZDNkNjc4NDdh OTE5OGMxYjZlZjNhY2E2MTBmMWYyYmJkNS4uYjkwOTA2MzYwNmIwZWRiM2ZhYWI3YjBjNjM0MmY2 MzQ4YTU1YWUwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA0LTExICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMTk4OTA5LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU2NDc5CisKKyAgICAgICAgbWFkZSBkb3VibGUtY2xpY2stYW5kLWRy YWcgb24gdGV4dCBkcmFnIGluc3RlYWQgb2YKKyAgICAgICAgaGlnaGxpZ2h0aW5nIChSZXF1ZXN0 ZWQgYnkgYWxleGNocmlzdGVuc2VuXyBvbiAjd2Via2l0KS4KKworICAgICAgICBSZXZlcnRlZCBj aGFuZ2VzZXQ6CisKKyAgICAgICAgImV2ZW50TWF5U3RhcnREcmFnKCkgZG9lcyBub3QgY2hlY2sg Zm9yIHNoaWZ0S2V5IG9yCisgICAgICAgIGlzT3ZlckxpbmsiCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTU3NDYKKyAgICAgICAgaHR0cDovL3RyYWMu d2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTk4OTA5CisKIDIwMTYtMDQtMTEgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbV2ViSURMXSBBZGQgc3VwcG9ydCBmb3IgW0lt cGxlbWVudGVkQXNdIGZvciBFdmVudEhhbmRsZXIgYXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9F dmVudEhhbmRsZXIuY3BwCmluZGV4IGJmODFlZTRkZWRhYzQ4NTk1YWUwNDUzMGVjYzFmNzhjNzc3 Y2ExYmUuLmJjMWI0MGU2MWMyMDYyNDBkYWM0ZjUzZDQ1NzAxNzZiNWRlZDMxODEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0V2ZW50SGFuZGxlci5jcHAKQEAgLTczNSwyMiArNzM1LDYgQEAgc3RhdGljIGlu bGluZSBib29sIGNhbk1vdXNlRG93blN0YXJ0U2VsZWN0KE5vZGUqIG5vZGUpCiAgICAgcmV0dXJu IG5vZGUtPmNhblN0YXJ0U2VsZWN0aW9uKCkgfHwgUG9zaXRpb246Om5vZGVJc1VzZXJTZWxlY3RB bGwobm9kZSk7CiB9CiAKLSNpZiBFTkFCTEUoRFJBR19TVVBQT1JUKQotc3RhdGljIGJvb2wgaXNT aW5nbGVNb3VzZURvd25PbkxpbmtPckltYWdlKGNvbnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJl c3VsdHMmIGV2ZW50KQotewotICAgIGF1dG8mIHBsYXRmb3JtRXZlbnQgPSBldmVudC5ldmVudCgp OwotICAgIGlmIChwbGF0Zm9ybUV2ZW50LnR5cGUoKSAhPSBQbGF0Zm9ybUV2ZW50OjpNb3VzZVBy ZXNzZWQgfHwgcGxhdGZvcm1FdmVudC5idXR0b24oKSAhPSBMZWZ0QnV0dG9uIHx8IHBsYXRmb3Jt RXZlbnQuY2xpY2tDb3VudCgpICE9IDEpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIHJl dHVybiBldmVudC5pc092ZXJMaW5rKCkgfHwgZXZlbnQuaGl0VGVzdFJlc3VsdCgpLmltYWdlKCk7 Ci19Ci0KLXN0YXRpYyBib29sIGV2ZW50TWF5U3RhcnREcmFnSW50ZXJuYWwoY29uc3QgTW91c2VF dmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgZXZlbnQpCi17Ci0gICAgcmV0dXJuICFldmVudC5ldmVu dCgpLnNoaWZ0S2V5KCkgfHwgaXNTaW5nbGVNb3VzZURvd25PbkxpbmtPckltYWdlKGV2ZW50KTsK LX0KLSNlbmRpZgotCiBib29sIEV2ZW50SGFuZGxlcjo6aGFuZGxlTW91c2VQcmVzc0V2ZW50KGNv bnN0IE1vdXNlRXZlbnRXaXRoSGl0VGVzdFJlc3VsdHMmIGV2ZW50KQogewogI2lmIEVOQUJMRShE UkFHX1NVUFBPUlQpCkBAIC03NzYsNyArNzYwLDEzIEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpoYW5k bGVNb3VzZVByZXNzRXZlbnQoY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYgZXZl CiAgICAgbV9tb3VzZURvd25NYXlTdGFydFNlbGVjdCA9IGNhbk1vdXNlRG93blN0YXJ0U2VsZWN0 KGV2ZW50LnRhcmdldE5vZGUoKSkgJiYgIWV2ZW50LnNjcm9sbGJhcigpOwogICAgIAogI2lmIEVO QUJMRShEUkFHX1NVUFBPUlQpCi0gICAgbV9tb3VzZURvd25NYXlTdGFydERyYWcgPSBldmVudE1h eVN0YXJ0RHJhZ0ludGVybmFsKGV2ZW50KTsKKyAgICAvLyBDYXJlZnVsIHRoYXQgdGhlIGRyYWcg c3RhcnRpbmcgbG9naWMgc3RheXMgaW4gc3luYyB3aXRoIGV2ZW50TWF5U3RhcnREcmFnKCkKKyAg ICAvLyBGSVhNRTogZXZlbnRNYXlTdGFydERyYWcoKSBkb2VzIG5vdCBjaGVjayBmb3Igc2hpZnQg a2V5IHByZXNzLCBsaW5rIG9yIGltYWdlIGV2ZW50IHRhcmdldHMuCisgICAgLy8gQnVnOiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU1MzkwCisKKyAgICAvLyBTaW5n bGUgbW91c2UgZG93biBvbiBsaW5rcyBvciBpbWFnZXMgY2FuIGFsd2F5cyB0cmlnZ2VyIGRyYWct bi1kcm9wLgorICAgIGJvb2wgaXNNb3VzZURvd25PbkxpbmtPckltYWdlID0gZXZlbnQuaXNPdmVy TGluaygpIHx8IGV2ZW50LmhpdFRlc3RSZXN1bHQoKS5pbWFnZSgpOworICAgIG1fbW91c2VEb3du TWF5U3RhcnREcmFnID0gc2luZ2xlQ2xpY2sgJiYgKCFldmVudC5ldmVudCgpLnNoaWZ0S2V5KCkg fHwgaXNNb3VzZURvd25PbkxpbmtPckltYWdlKTsKICNlbmRpZgogCiAgICAgbV9tb3VzZURvd25X YXNTaW5nbGVDbGlja0luU2VsZWN0aW9uID0gZmFsc2U7CkBAIC04MjQsMTQgKzgxNCw2IEBAIGJv b2wgRXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnQoY29uc3QgTW91c2VFdmVudFdp dGhIaXRUZXN0UmVzdWx0cyYgZXZlCiAgICAgcmV0dXJuIHN3YWxsb3dFdmVudDsKIH0KIAotc3Rh dGljIExheW91dFBvaW50IGRvY3VtZW50UG9pbnRGb3JXaW5kb3dQb2ludChGcmFtZSYgZnJhbWUs IGNvbnN0IEludFBvaW50JiB3aW5kb3dQb2ludCkKLXsKLSAgICBGcmFtZVZpZXcqIHZpZXcgPSBm cmFtZS52aWV3KCk7Ci0gICAgLy8gRklYTUU6IElzIGl0IHJlYWxseSBPSyB0byB1c2UgdGhlIHdy b25nIGNvb3JkaW5hdGVzIGhlcmUgd2hlbiB2aWV3IGlzIDA/Ci0gICAgLy8gSGlzdG9yaWNhbGx5 IHRoZSBjb2RlIHdvdWxkIGp1c3QgY3Jhc2g7IHRoaXMgaXMgY2xlYXJseSBubyB3b3JzZSB0aGFu IHRoYXQuCi0gICAgcmV0dXJuIHZpZXcgPyB2aWV3LT53aW5kb3dUb0NvbnRlbnRzKHdpbmRvd1Bv aW50KSA6IHdpbmRvd1BvaW50OwotfQotCiAjaWYgRU5BQkxFKERSQUdfU1VQUE9SVCkKIGJvb2wg RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZURyYWdnZWRFdmVudChjb25zdCBNb3VzZUV2ZW50V2l0 aEhpdFRlc3RSZXN1bHRzJiBldmVudCkKIHsKQEAgLTg3Niw3ICs4NTgsNyBAQCBib29sIEV2ZW50 SGFuZGxlcjo6aGFuZGxlTW91c2VEcmFnZ2VkRXZlbnQoY29uc3QgTW91c2VFdmVudFdpdGhIaXRU ZXN0UmVzdWx0cyYgZQogICAgIHVwZGF0ZVNlbGVjdGlvbkZvck1vdXNlRHJhZyhldmVudC5oaXRU ZXN0UmVzdWx0KCkpOwogICAgIHJldHVybiB0cnVlOwogfQotCisgICAgCiBib29sIEV2ZW50SGFu ZGxlcjo6ZXZlbnRNYXlTdGFydERyYWcoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50JiBldmVudCkg Y29uc3QKIHsKICAgICAvLyBUaGlzIGlzIGEgcHJlLWZsaWdodCBjaGVjayBvZiB3aGV0aGVyIHRo ZSBldmVudCBtaWdodCBsZWFkIHRvIGEgZHJhZyBiZWluZyBzdGFydGVkLiAgQmUgY2FyZWZ1bApA QCAtODg2LDYgKzg2OCw5IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpldmVudE1heVN0YXJ0RHJhZyhj b25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQmIGV2ZW50KSBjb25zdAogICAgIGlmICghcmVuZGVyVmll dykKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCisgICAgaWYgKGV2ZW50LmJ1dHRvbigpICE9IExl ZnRCdXR0b24gfHwgZXZlbnQuY2xpY2tDb3VudCgpICE9IDEpCisgICAgICAgIHJldHVybiBmYWxz ZTsKKwogICAgIEZyYW1lVmlldyogdmlldyA9IG1fZnJhbWUudmlldygpOwogICAgIGlmICghdmll dykKICAgICAgICAgcmV0dXJuIGZhbHNlOwpAQCAtODk0LDE1ICs4NzksMTAgQEAgYm9vbCBFdmVu dEhhbmRsZXI6OmV2ZW50TWF5U3RhcnREcmFnKGNvbnN0IFBsYXRmb3JtTW91c2VFdmVudCYgZXZl bnQpIGNvbnN0CiAgICAgaWYgKCFwYWdlKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBI aXRUZXN0UmVxdWVzdCByZXF1ZXN0KEhpdFRlc3RSZXF1ZXN0OjpSZWFkT25seSB8IEhpdFRlc3RS ZXF1ZXN0OjpEaXNhbGxvd1NoYWRvd0NvbnRlbnQpOwotICAgIExheW91dFBvaW50IGRvY3VtZW50 UG9pbnQgPSBkb2N1bWVudFBvaW50Rm9yV2luZG93UG9pbnQobV9mcmFtZSwgZXZlbnQucG9zaXRp b24oKSk7Ci0gICAgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyBtb3VzZUV2ZW50ID0gbV9m cmFtZS5kb2N1bWVudCgpLT5wcmVwYXJlTW91c2VFdmVudChyZXF1ZXN0LCBkb2N1bWVudFBvaW50 LCBldmVudCk7Ci0gICAgaWYgKCFldmVudE1heVN0YXJ0RHJhZ0ludGVybmFsKG1vdXNlRXZlbnQp KQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICB1cGRhdGVEcmFnU291cmNlQWN0aW9uc0Fs bG93ZWQoKTsKLQotICAgIEhpdFRlc3RSZXN1bHQgcmVzdWx0ID0gbW91c2VFdmVudC5oaXRUZXN0 UmVzdWx0KCk7CisgICAgSGl0VGVzdFJlcXVlc3QgcmVxdWVzdChIaXRUZXN0UmVxdWVzdDo6UmVh ZE9ubHkgfCBIaXRUZXN0UmVxdWVzdDo6RGlzYWxsb3dTaGFkb3dDb250ZW50KTsKKyAgICBIaXRU ZXN0UmVzdWx0IHJlc3VsdCh2aWV3LT53aW5kb3dUb0NvbnRlbnRzKGV2ZW50LnBvc2l0aW9uKCkp KTsKKyAgICByZW5kZXJWaWV3LT5oaXRUZXN0KHJlcXVlc3QsIHJlc3VsdCk7CiAgICAgRHJhZ1N0 YXRlIHN0YXRlOwogICAgIHJldHVybiByZXN1bHQuaW5uZXJFbGVtZW50KCkgJiYgcGFnZS0+ZHJh Z0NvbnRyb2xsZXIoKS5kcmFnZ2FibGVFbGVtZW50KCZtX2ZyYW1lLCByZXN1bHQuaW5uZXJFbGVt ZW50KCksIHJlc3VsdC5yb3VuZGVkUG9pbnRJbklubmVyTm9kZUZyYW1lKCksIHN0YXRlKTsKIH0K QEAgLTE1OTUsNiArMTU3NSwxNCBAQCB2b2lkIEV2ZW50SGFuZGxlcjo6YXV0b0hpZGVDdXJzb3JU aW1lckZpcmVkKCkKIH0KICNlbmRpZgogCitzdGF0aWMgTGF5b3V0UG9pbnQgZG9jdW1lbnRQb2lu dEZvcldpbmRvd1BvaW50KEZyYW1lJiBmcmFtZSwgY29uc3QgSW50UG9pbnQmIHdpbmRvd1BvaW50 KQoreworICAgIEZyYW1lVmlldyogdmlldyA9IGZyYW1lLnZpZXcoKTsKKyAgICAvLyBGSVhNRTog SXMgaXQgcmVhbGx5IE9LIHRvIHVzZSB0aGUgd3JvbmcgY29vcmRpbmF0ZXMgaGVyZSB3aGVuIHZp ZXcgaXMgMD8KKyAgICAvLyBIaXN0b3JpY2FsbHkgdGhlIGNvZGUgd291bGQganVzdCBjcmFzaDsg dGhpcyBpcyBjbGVhcmx5IG5vIHdvcnNlIHRoYW4gdGhhdC4KKyAgICByZXR1cm4gdmlldyA/IHZp ZXctPndpbmRvd1RvQ29udGVudHMod2luZG93UG9pbnQpIDogd2luZG93UG9pbnQ7Cit9CisKIHN0 YXRpYyBTY3JvbGxiYXIqIHNjcm9sbGJhckZvck1vdXNlRXZlbnQoY29uc3QgTW91c2VFdmVudFdp dGhIaXRUZXN0UmVzdWx0cyYgbW91c2VFdmVudCwgRnJhbWVWaWV3KiB2aWV3KQogewogICAgIGlm ICh2aWV3KSB7Cg==