156471 2016-04-11 11:49:09 -0700 Build MiniBrowser with CMake on Mac 2016-04-12 00:19:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen bfulgham cdumez dbates oldest_to_newest 1182751 0 achristensen 2016-04-11 11:49:09 -0700 Build MiniBrowser with CMake on Mac 1182754 1 276160 achristensen 2016-04-11 11:50:05 -0700 Created attachment 276160 Patch 1182856 2 276160 dbates 2016-04-11 16:01:18 -0700 Comment on attachment 276160 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=276160&action=review > Tools/MiniBrowser/mac/CMakeLists.txt:3 > +add_definitions("-include MiniBrowser_Prefix.pch -DWEBCORE_EXPORT=") Can you elaborate on the purpose of defining WEBCORE_EXPORT to be the empty string? > Tools/MiniBrowser/mac/CMakeLists.txt:12 > + ${MINIBROWSER_DIR}/AppDelegate.m > + ${MINIBROWSER_DIR}/BrowserWindowController.m > + ${MINIBROWSER_DIR}/ExtensionManagerWindowController.m > + ${MINIBROWSER_DIR}/main.m > + ${MINIBROWSER_DIR}/SettingsController.m > + ${MINIBROWSER_DIR}/WK1BrowserWindowController.m > + ${MINIBROWSER_DIR}/WK2BrowserWindowController.m Please sort these entries according to the UNIX sort command. 1183007 3 achristensen 2016-04-12 00:19:37 -0700 Committed with a FIXME for the WEBCORE_EXPORT to http://trac.webkit.org/changeset/199338 276160 2016-04-11 11:50:05 -0700 2016-04-11 16:01:18 -0700 Patch bug-156471-20160411115014.patch text/plain 4658 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTI1NykKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA0LTExICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQnVpbGQgTWlu aUJyb3dzZXIgd2l0aCBDTWFrZSBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1NjQ3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogRGF0YWJhc2VQcm9jZXNzL0RhdGFiYXNlUHJvY2Vzcy5tZXNz YWdlcy5pbjoKKwogMjAxNi0wNC0wOCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIFByb2dyZXNzIHRvd2FyZHMgcnVubmluZyBDTWFrZSBXZWJL aXQyIG9uIE1hYwpJbmRleDogU291cmNlL1dlYktpdDIvRGF0YWJhc2VQcm9jZXNzL0RhdGFiYXNl UHJvY2Vzcy5tZXNzYWdlcy5pbgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9EYXRhYmFz ZVByb2Nlc3MvRGF0YWJhc2VQcm9jZXNzLm1lc3NhZ2VzLmluCShyZXZpc2lvbiAxOTkyNTUpCisr KyBTb3VyY2UvV2ViS2l0Mi9EYXRhYmFzZVByb2Nlc3MvRGF0YWJhc2VQcm9jZXNzLm1lc3NhZ2Vz LmluCSh3b3JraW5nIGNvcHkpCkBAIC0zMiw3ICszMiw5IEBAIG1lc3NhZ2VzIC0+IERhdGFiYXNl UHJvY2VzcyBMZWdhY3lSZWNlaXYKICAgICBGZXRjaFdlYnNpdGVEYXRhKFdlYkNvcmU6OlNlc3Np b25JRCBzZXNzaW9uSUQsIE9wdGlvblNldDxXZWJLaXQ6OldlYnNpdGVEYXRhVHlwZT4gd2Vic2l0 ZURhdGFUeXBlcywgdWludDY0X3QgY2FsbGJhY2tJRCkKICAgICBEZWxldGVXZWJzaXRlRGF0YShX ZWJDb3JlOjpTZXNzaW9uSUQgc2Vzc2lvbklELCBPcHRpb25TZXQ8V2ViS2l0OjpXZWJzaXRlRGF0 YVR5cGU+IHdlYnNpdGVEYXRhVHlwZXMsIHN0ZDo6Y2hyb25vOjpzeXN0ZW1fY2xvY2s6OnRpbWVf cG9pbnQgbW9kaWZpZWRTaW5jZSwgdWludDY0X3QgY2FsbGJhY2tJRCkKICAgICBEZWxldGVXZWJz aXRlRGF0YUZvck9yaWdpbnMoV2ViQ29yZTo6U2Vzc2lvbklEIHNlc3Npb25JRCwgT3B0aW9uU2V0 PFdlYktpdDo6V2Vic2l0ZURhdGFUeXBlPiB3ZWJzaXRlRGF0YVR5cGVzLCBWZWN0b3I8V2ViQ29y ZTo6U2VjdXJpdHlPcmlnaW5EYXRhPiBvcmlnaW5zLCB1aW50NjRfdCBjYWxsYmFja0lEKQorI2lm IEVOQUJMRShJTkRFWEVEX0RBVEFCQVNFKQogICAgIEdyYW50U2FuZGJveEV4dGVuc2lvbnNGb3JC bG9icyhWZWN0b3I8U3RyaW5nPiBwYXRocywgV2ViS2l0OjpTYW5kYm94RXh0ZW5zaW9uOjpIYW5k bGVBcnJheSBleHRlbnNpb25zKQorI2VuZGlmCiB9CiAKICNlbmRpZiAvLyBFTkFCTEUoREFUQUJB U0VfUFJPQ0VTUykKSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE5OTI5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBj b3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA0LTExICBBbGV4IENocmlzdGVuc2VuICA8YWNo cmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQnVpbGQgTWluaUJyb3dzZXIgd2l0aCBD TWFrZSBvbiBNYWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NjQ3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvQ01ha2VMaXN0 cy50eHQ6CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvUGxhdGZvcm1XaW4uY21ha2U6CisgICAg ICAgICogTWluaUJyb3dzZXIvbWFjL0NNYWtlTGlzdHMudHh0OiBBZGRlZC4KKwogMjAxNi0wNC0x MSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBqcC5zb255LmNvbT4KIAogICAgICAg ICBbQ01ha2VdIE1ha2UgRk9MREVSIHByb3BlcnR5IElOSEVSSVRFRApJbmRleDogVG9vbHMvQ01h a2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9u IDE5OTI1NSkKKysrIFRvb2xzL0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2 ICszNiw3IEBAIGVuZGlmICgpCiBpZiAoQVBQTEUpCiAgICAgYWRkX3N1YmRpcmVjdG9yeShEdW1w UmVuZGVyVHJlZSkKICAgICBhZGRfc3ViZGlyZWN0b3J5KFdlYktpdFRlc3RSdW5uZXIpCisgICAg YWRkX3N1YmRpcmVjdG9yeShNaW5pQnJvd3Nlci9tYWMpCiBlbmRpZiAoKQogCiBpZiAoRU5BQkxF X1dFQktJVDIgQU5EIEVOQUJMRV9BUElfVEVTVFMpCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJl ZS9DTWFrZUxpc3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9DTWFr ZUxpc3RzLnR4dAkocmV2aXNpb24gMTk5MjU1KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvQ01h a2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEzLDcgKzEzLDYgQEAgc2V0KER1bXBSZW5k ZXJUcmVlX1NPVVJDRVMKIAogc2V0KER1bXBSZW5kZXJUcmVlX0xJQlJBUklFUwogICAgIEphdmFT Y3JpcHRDb3JlCi0gICAgV1RGCiAgICAgV2ViQ29yZVRlc3RTdXBwb3J0CiApCiAKSW5kZXg6IFRv b2xzL0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtV2luLmNtYWtlCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0R1bXBSZW5kZXJUcmVlL1BsYXRmb3JtV2luLmNtYWtlCShyZXZpc2lvbiAxOTkyNTUpCisrKyBU b29scy9EdW1wUmVuZGVyVHJlZS9QbGF0Zm9ybVdpbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAt NzksNiArNzksNyBAQCBsaXN0KEFQUEVORCBEdW1wUmVuZGVyVHJlZV9JTkNMVURFX0RJUkVDCiAp CiAKIGxpc3QoQVBQRU5EIER1bXBSZW5kZXJUcmVlX0xJQlJBUklFUworICAgIFdURgogICAgIFdl YktpdAogICAgIHNobHdhcGkKICkKSW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL21hYy9DTWFrZUxp c3RzLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9tYWMvQ01ha2VMaXN0cy50 eHQJKHJldmlzaW9uIDApCisrKyBUb29scy9NaW5pQnJvd3Nlci9tYWMvQ01ha2VMaXN0cy50eHQJ KHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwzMiBAQAorc2V0KE1JTklCUk9XU0VSX0RJUiAiJHtU T09MU19ESVJ9L01pbmlCcm93c2VyL21hYyIpCisKK2FkZF9kZWZpbml0aW9ucygiLWluY2x1ZGUg TWluaUJyb3dzZXJfUHJlZml4LnBjaCAtRFdFQkNPUkVfRVhQT1JUPSIpCisKK3NldChNaW5pQnJv d3Nlcl9TT1VSQ0VTCisgICAgJHtNSU5JQlJPV1NFUl9ESVJ9L0FwcERlbGVnYXRlLm0KKyAgICAk e01JTklCUk9XU0VSX0RJUn0vQnJvd3NlcldpbmRvd0NvbnRyb2xsZXIubQorICAgICR7TUlOSUJS T1dTRVJfRElSfS9FeHRlbnNpb25NYW5hZ2VyV2luZG93Q29udHJvbGxlci5tCisgICAgJHtNSU5J QlJPV1NFUl9ESVJ9L21haW4ubQorICAgICR7TUlOSUJST1dTRVJfRElSfS9TZXR0aW5nc0NvbnRy b2xsZXIubQorICAgICR7TUlOSUJST1dTRVJfRElSfS9XSzFCcm93c2VyV2luZG93Q29udHJvbGxl ci5tCisgICAgJHtNSU5JQlJPV1NFUl9ESVJ9L1dLMkJyb3dzZXJXaW5kb3dDb250cm9sbGVyLm0K KyAgICAke1RPT0xTX0RJUn0vTWluaUJyb3dzZXIvTUJUb29sYmFySXRlbS5tCisgICAgJHtUT09M U19ESVJ9L01pbmlCcm93c2VyL01pbmlCcm93c2VyV2ViUHJvY2Vzc1BsdWdpbi5tCispCisKK3Nl dChNaW5pQnJvd3Nlcl9JTkNMVURFX0RJUkVDVE9SSUVTCisgICAgJHtDTUFLRV9CSU5BUllfRElS fQorICAgICR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlCisgICAgJHtERVJJVkVEX1NPVVJDRVNf RElSfQorICAgICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vRm9yd2FyZGluZ0hlYWRlcnMKKyAgICAk e0ZPUldBUkRJTkdfSEVBREVSU19ESVJ9CisgICAgJHtNSU5JQlJPV1NFUl9ESVJ9CispCisKK3Nl dChNaW5pQnJvd3Nlcl9MSUJSQVJJRVMKKyAgICBXZWJLaXQyCispCisKK2luY2x1ZGVfZGlyZWN0 b3JpZXMoJHtNaW5pQnJvd3Nlcl9JTkNMVURFX0RJUkVDVE9SSUVTfSkKK2FkZF9leGVjdXRhYmxl KE1pbmlCcm93c2VyICR7TWluaUJyb3dzZXJfU09VUkNFU30pCit0YXJnZXRfbGlua19saWJyYXJp ZXMoTWluaUJyb3dzZXIgJHtNaW5pQnJvd3Nlcl9MSUJSQVJJRVN9KQo=