156467 2016-04-11 10:41:18 -0700 Unify selectionStartEnd() methods. 2016-04-11 10:41:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 zalan webkit-unassigned simon.fraser oldest_to_newest 1182725 0 zalan 2016-04-11 10:41:18 -0700 see https://bugs.webkit.org/show_bug.cgi?id=156448#c5 > Source/WebCore/rendering/InlineTextBox.cpp:607 > + renderer().selectionStartEnd(selectionStart, selectionEnd); Peculiar that this uses two out arguments and doesn’t even have get in its name. Should fix that. > Source/WebCore/rendering/InlineTextBox.h:123 > + std::pair<int, int> selectionStartEnd() const; In other cases like this we sometimes use structures with names for the members rather than using a tuple. Sure would be nice to get rid of some those pairs of local variables and arguments using the same structure. void SelectionSubtreeRoot::selectionStartEndPositions(int& startPos, int& endPos) const void RenderObject::selectionStartEnd(int& spos, int& epos) const std::pair<int, int> InlineTextBox::selectionStartEnd() const