15645 2007-10-23 16:53:21 -0700 WebKit fails to render <use> example in SVG 1.1 spec 2007-12-03 10:58:54 -0800 1 1 1 Unclassified WebKit SVG 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://www.w3.org/TR/SVG/images/struct/Use04.svg NeedsReduction P2 Normal --- 1 eric zimmermann zimmermann oldest_to_newest 59275 0 eric 2007-10-23 16:53:21 -0700 WebKit fails to render <use> example in SVG 1.1 spec http://www.w3.org/TR/SVG/images/struct/Use04.svg is the file http://www.w3.org/TR/SVG/struct.html#UseElement explains the file I haven't looked at why we fail yet. 62275 1 zimmermann 2007-11-25 05:09:43 -0800 Removing rule 8, makes it work as expected: /* rule 8 */ g > path { visibility: hidden } Investigating soon. 62276 2 zimmermann 2007-11-25 05:15:57 -0800 Ok, found the culprit: <path> is referenced by the <use> element. In our generated tree the <path> will be a direct child element of <g> (which replaces the <use> in the generated tree). Though the spec cleary states: Rules 7 and 8: CSS selectors only apply to the formal document tree, not on the generated tree; thus, these selectors will not yield a match. We need to support this. (while reminding ourselves that class & id selectors etc. still need to work within the generated subtree) 63037 3 17657 zimmermann 2007-12-02 17:00:31 -0800 Created attachment 17657 Initial patch 63082 4 17657 eric 2007-12-02 21:48:48 -0800 Comment on attachment 17657 Initial patch This needs to include landing the test case. I think this is otherwise right, but hyatt really should have a look. 63083 5 17657 hyatt 2007-12-02 21:50:04 -0800 Comment on attachment 17657 Initial patch r=me 63162 6 zimmermann 2007-12-03 10:58:54 -0800 Landed in r28357. 17657 2007-12-02 17:00:31 -0800 2007-12-02 21:50:04 -0800 Initial patch FixSVGCSSSelectors.diff text/plain 2508 zimmermann SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI4MzI0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDctMTIt MDIgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlczogaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NDUgKFdlYktpdCBmYWlscyB0byByZW5kZXIg PHVzZT4gZXhhbXBsZSBpbiBTVkcgMS4xIHNwZWMpCisgICAgICAgIERvbid0IGFsbG93IHNlbGVj dG9ycyB0byBpbnRlcmZlcmUgd2l0aCB0aGUgU1ZHIHNoYWRvdyB0cmVlICg8dXNlPiBpbnRlcm5h bCBub24tZXhwb3NlZCB0cmVlKS4KKworICAgICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0eWxlU2VsZWN0b3I6OmNoZWNrU2VsZWN0b3IpOgor CiAyMDA3LTEyLTAyICBCcmFkeSBFaWRzb24gPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhcmluCkluZGV4OiBjc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCShyZXZpc2lvbiAyODMyMCkKKysrIGNz cy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI0MSw3ICsxMjQxLDgg QEAgYm9vbCBDU1NTdHlsZVNlbGVjdG9yOjpjaGVja1NlbGVjdG9yKENTUwogCiAgICAgLy8gQ2hl Y2sgdGhlIHNlbGVjdG9yCiAgICAgU2VsZWN0b3JNYXRjaCBtYXRjaCA9IGNoZWNrU2VsZWN0b3Io c2VsLCBlbGVtZW50LCB0cnVlLCBmYWxzZSk7Ci0gICAgaWYgKG1hdGNoICE9IFNlbGVjdG9yTWF0 Y2hlcykgcmV0dXJuIGZhbHNlOworICAgIGlmIChtYXRjaCAhPSBTZWxlY3Rvck1hdGNoZXMpCisg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIGlmIChwc2V1ZG9TdHlsZSAhPSBSZW5kZXJTdHls ZTo6Tk9QU0VVRE8gJiYgcHNldWRvU3R5bGUgIT0gZHluYW1pY1BzZXVkbykKICAgICAgICAgcmV0 dXJuIGZhbHNlOwpAQCAtMTI1NCw4ICsxMjU1LDE1IEBAIGJvb2wgQ1NTU3R5bGVTZWxlY3Rvcjo6 Y2hlY2tTZWxlY3RvcihDU1MKIC8vICogU2VsZWN0b3JNYXRjaGVzICAgICAgICAgLSB0aGUgc2Vs ZWN0b3IgbWF0Y2hlcyB0aGUgZWxlbWVudCBlCiAvLyAqIFNlbGVjdG9yRmFpbHNMb2NhbGx5ICAg IC0gdGhlIHNlbGVjdG9yIGZhaWxzIGZvciB0aGUgZWxlbWVudCBlCiAvLyAqIFNlbGVjdG9yRmFp bHNDb21wbGV0ZWx5IC0gdGhlIHNlbGVjdG9yIGZhaWxzIGZvciBlIGFuZCBhbnkgc2libGluZyBv ciBhbmNlc3RvciBvZiBlCi1DU1NTdHlsZVNlbGVjdG9yOjpTZWxlY3Rvck1hdGNoIENTU1N0eWxl U2VsZWN0b3I6OmNoZWNrU2VsZWN0b3IoQ1NTU2VsZWN0b3IqIHNlbCwgRWxlbWVudCAqZSwgYm9v bCBpc0FuY2VzdG9yLCBib29sIGlzU3ViU2VsZWN0b3IpCitDU1NTdHlsZVNlbGVjdG9yOjpTZWxl Y3Rvck1hdGNoIENTU1N0eWxlU2VsZWN0b3I6OmNoZWNrU2VsZWN0b3IoQ1NTU2VsZWN0b3IqIHNl bCwgRWxlbWVudCogZSwgYm9vbCBpc0FuY2VzdG9yLCBib29sIGlzU3ViU2VsZWN0b3IpCiB7Cisj aWYgRU5BQkxFKFNWRykKKyAgICAvLyBTcGVjOiBDU1MyIHNlbGVjdG9ycyBjYW5ub3QgYmUgYXBw bGllZCB0byB0aGUgKGNvbmNlcHR1YWxseSkgY2xvbmVkIERPTSB0cmVlCisgICAgLy8gYmVjYXVz ZSBpdHMgY29udGVudHMgYXJlIG5vdCBwYXJ0IG9mIHRoZSBmb3JtYWwgZG9jdW1lbnQgc3RydWN0 dXJlLgorICAgIGlmIChlLT5pc1NWR0VsZW1lbnQoKSAmJiBlLT5pc1NoYWRvd05vZGUoKSkKKyAg ICAgICAgcmV0dXJuIFNlbGVjdG9yRmFpbHNDb21wbGV0ZWx5OworI2VuZGlmCisKICAgICAvLyBm aXJzdCBzZWxlY3RvciBoYXMgdG8gbWF0Y2gKICAgICBpZiAoIWNoZWNrT25lU2VsZWN0b3Ioc2Vs LCBlLCBpc0FuY2VzdG9yLCBpc1N1YlNlbGVjdG9yKSkKICAgICAgICAgcmV0dXJuIFNlbGVjdG9y RmFpbHNMb2NhbGx5OwpAQCAtMTI2NSw3ICsxMjczLDggQEAgQ1NTU3R5bGVTZWxlY3Rvcjo6U2Vs ZWN0b3JNYXRjaCBDU1NTdHlsZQogCiAgICAgLy8gUHJlcGFyZSBuZXh0IHNlbAogICAgIHNlbCA9 IHNlbC0+bV90YWdIaXN0b3J5OwotICAgIGlmICghc2VsKSByZXR1cm4gU2VsZWN0b3JNYXRjaGVz OworICAgIGlmICghc2VsKQorICAgICAgICByZXR1cm4gU2VsZWN0b3JNYXRjaGVzOwogCiAgICAg aWYgKHJlbGF0aW9uICE9IENTU1NlbGVjdG9yOjpTdWJTZWxlY3RvcikKICAgICAgICAgLy8gQmFp bC1vdXQgaWYgdGhpcyBzZWxlY3RvciBpcyBpcnJlbGV2YW50IGZvciB0aGUgcHNldWRvU3R5bGUK