156411 2016-04-08 11:45:57 -0700 JSContext Inspector: Fix asserts and uncaught exception showing Timeline Tab 2016-04-08 12:40:51 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1182235 0 joepeck 2016-04-08 11:45:57 -0700 * SUMMARY Fix asserts and uncaught exception showing Timeline Tab in the JSContext inspector. 1182236 1 webkit-bug-importer 2016-04-08 11:46:23 -0700 <rdar://problem/25629802> 1182237 2 276021 joepeck 2016-04-08 11:47:48 -0700 Created attachment 276021 [PATCH] Proposed Fix 1182260 3 276021 commit-queue 2016-04-08 12:40:48 -0700 Comment on attachment 276021 [PATCH] Proposed Fix Clearing flags on attachment: 276021 Committed r199241: <http://trac.webkit.org/changeset/199241> 1182261 4 commit-queue 2016-04-08 12:40:51 -0700 All reviewed patches have been landed. Closing bug. 276021 2016-04-08 11:47:48 -0700 2016-04-08 12:40:48 -0700 [PATCH] Proposed Fix jscontext.patch text/plain 3203 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDc0YjVjN2QuLmQyODA4NTEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA0LTA4ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgSlNDb250ZXh0IEluc3BlY3Rvcjog Rml4IGFzc2VydHMgYW5kIHVuY2F1Z2h0IGV4Y2VwdGlvbiBzaG93aW5nIFRpbWVsaW5lIFRhYgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2NDExCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLk92ZXJ2aWV3VGltZWxpbmVWaWV3KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5PdmVydmll d1RpbWVsaW5lVmlldy5wcm90b3R5cGUuY2xvc2VkKToKKyAgICAgICAgR3JhY2VmdWxseSBoYW5k bGUgaWYgd2UgZG8gbm90IGhhdmUgYSBOZXR3b3JrIFRpbWVsaW5lLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlRpbWVsaW5lVGFiQ29udGVudFZpZXcucHJvdG90eXBlLl9jaGFuZ2VWaWV3TW9k ZSk6CisgICAgICAgIFRoaXMgZnVuY3Rpb24gaXMgYWx3YXlzIGNhbGxlZCBieSB0aGUgY29uc3Ry dWN0b3IsIHNvIHRoZSBhc3NlcnQKKyAgICAgICAgaXMgbm90IHVzZWZ1bCBzaW5jZSBpdCBjYW4g YmUgY2FsbGVkIHdoZW4gRlBTIGlzIG5vdCBzdXBwb3J0ZWQuCisKIDIwMTYtMDQtMDggIE1hdHQg QmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF0 dGVtcHRpbmcgdG8gZGlzbWlzcyBhIHBvcG92ZXIgdGhhdCBpcyBhbHJlYWR5IGJlaW5nIGRpc21p c3NlZCBjYXVzZXMgYW4gZXJyb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMKaW5k ZXggNWIyOWViNC4uNDE1NDFkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMK QEAgLTU0LDcgKzU0LDggQEAgV2ViSW5zcGVjdG9yLk92ZXJ2aWV3VGltZWxpbmVWaWV3ID0gY2xh c3MgT3ZlcnZpZXdUaW1lbGluZVZpZXcgZXh0ZW5kcyBXZWJJbnNwZWMKICAgICAgICAgdGhpcy5h ZGRTdWJ2aWV3KHRoaXMuX2RhdGFHcmlkKTsKIAogICAgICAgICB0aGlzLl9uZXR3b3JrVGltZWxp bmUgPSByZWNvcmRpbmcudGltZWxpbmVzLmdldChXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmQu VHlwZS5OZXR3b3JrKTsKLSAgICAgICAgdGhpcy5fbmV0d29ya1RpbWVsaW5lLmFkZEV2ZW50TGlz dGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5lLkV2ZW50LlJlY29yZEFkZGVkLCB0aGlzLl9uZXR3 b3JrVGltZWxpbmVSZWNvcmRBZGRlZCwgdGhpcyk7CisgICAgICAgIGlmICh0aGlzLl9uZXR3b3Jr VGltZWxpbmUpCisgICAgICAgICAgICB0aGlzLl9uZXR3b3JrVGltZWxpbmUuYWRkRXZlbnRMaXN0 ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmUuRXZlbnQuUmVjb3JkQWRkZWQsIHRoaXMuX25ldHdv cmtUaW1lbGluZVJlY29yZEFkZGVkLCB0aGlzKTsKIAogICAgICAgICByZWNvcmRpbmcuYWRkRXZl bnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcuRXZlbnQuU291cmNlQ29k ZVRpbWVsaW5lQWRkZWQsIHRoaXMuX3NvdXJjZUNvZGVUaW1lbGluZUFkZGVkLCB0aGlzKTsKICAg ICAgICAgcmVjb3JkaW5nLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVj b3JkaW5nLkV2ZW50Lk1hcmtlckFkZGVkLCB0aGlzLl9tYXJrZXJBZGRlZCwgdGhpcyk7CkBAIC04 NSw3ICs4Niw4IEBAIFdlYkluc3BlY3Rvci5PdmVydmlld1RpbWVsaW5lVmlldyA9IGNsYXNzIE92 ZXJ2aWV3VGltZWxpbmVWaWV3IGV4dGVuZHMgV2ViSW5zcGVjCiAKICAgICBjbG9zZWQoKQogICAg IHsKLSAgICAgICAgdGhpcy5fbmV0d29ya1RpbWVsaW5lLnJlbW92ZUV2ZW50TGlzdGVuZXIobnVs bCwgbnVsbCwgdGhpcyk7CisgICAgICAgIGlmICh0aGlzLl9uZXR3b3JrVGltZWxpbmUpCisgICAg ICAgICAgICB0aGlzLl9uZXR3b3JrVGltZWxpbmUucmVtb3ZlRXZlbnRMaXN0ZW5lcihudWxsLCBu dWxsLCB0aGlzKTsKICAgICAgICAgdGhpcy5fcmVjb3JkaW5nLnJlbW92ZUV2ZW50TGlzdGVuZXIo bnVsbCwgbnVsbCwgdGhpcyk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVUYWJDb250ZW50 Vmlldy5qcwppbmRleCBkZWNiNWZmLi4wOTM4OWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVRhYkNvbnRlbnRWaWV3LmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lVGFi Q29udGVudFZpZXcuanMKQEAgLTQ5Niw4ICs0OTYsNiBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVU YWJDb250ZW50VmlldyA9IGNsYXNzIFRpbWVsaW5lVGFiQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJ bgogCiAgICAgX2NoYW5nZVZpZXdNb2RlKG1vZGUsIHNlbGVjdGVkQnlVc2VyKQogICAgIHsKLSAg ICAgICAgY29uc29sZS5hc3NlcnQoV2ViSW5zcGVjdG9yLkZQU0luc3RydW1lbnQuc3VwcG9ydGVk KCkpOwotCiAgICAgICAgIGlmICh0aGlzLl92aWV3TW9kZSA9PT0gbW9kZSkKICAgICAgICAgICAg IHJldHVybjsKIAo=