156400 2016-04-08 03:15:45 -0700 Touching any IDL files rebuilds all bindings in CMake Ninja build 2016-04-10 18:50:28 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=117708 P2 Normal --- 1 fujii webkit-unassigned achristensen andersca bfulgham cdumez cgarcia commit-queue ggaren oldest_to_newest 1182123 0 fujii 2016-04-08 03:15:45 -0700 Touching any IDL files rebuilds all bindings in CMake Ninja build preprocess-idls.pl has a function WriteFileIfChanged not to update files unnecessary to be updated. preprocess-idls.pl outputs four files supplemental_dependency.tmp, DOMWindowConstructors.idl, WorkerGlobalScopeConstructors.idl and DedicatedWorkerGlobalScopeConstructors.idl. WriteFileIfChanged works only for DedicatedWorkerGlobalScopeConstructors.idl. It does not work due to flaky results of 'keys'. Results of 'keys' are flaky, should be processed by 'sort'. I tested with GTK port Ninja build: > ./Tools/Scripts/build-webkit --gtk > touch Source/WebCore/dom/Document.idl 1182124 1 275989 fujii 2016-04-08 03:28:49 -0700 Created attachment 275989 Patch 1182189 2 275989 bfulgham 2016-04-08 10:15:27 -0700 Comment on attachment 275989 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275989&action=review > Source/WebCore/ChangeLog:11 > + Sort results of 'keys'. While this patch doesn't seem risky, I'm not sure I understand why this helps. Clearly your change makes the order of file processing consistent, which is probably a good thing, but It's not obvious to me why this stops us from rebuilding all bindings. 1182198 3 275989 bfulgham 2016-04-08 10:34:35 -0700 Comment on attachment 275989 Patch Questions aside, I can confirm that this also fixes my Windows regeneration problem, so THANK YOU! 1182225 4 275989 commit-queue 2016-04-08 11:28:27 -0700 Comment on attachment 275989 Patch Clearing flags on attachment: 275989 Committed r199237: <http://trac.webkit.org/changeset/199237> 1182226 5 commit-queue 2016-04-08 11:28:34 -0700 All reviewed patches have been landed. Closing bug. 1182582 6 fujii 2016-04-10 18:50:28 -0700 Thank you for reviewing my patch. (In reply to comment #2) > but It's not obvious to me why this stops us > from rebuilding all bindings. 1) supplemental_dependency.tmp depens on all IDL 2) All bindgs depnds on supplemental_dependency.tmp In Source/WebCore/CMakeLists.txt: > add_custom_command( > OUTPUT ${SUPPLEMENTAL_DEPENDENCY_FILE} ${WINDOW_CONSTRUCTORS_FILE} ${WORKERGLOBALSCOPE_CONSTRUCTORS_FILE} ${DEDICATEDWORKERGLOBALSCOPE_CONSTRUCTORS_FILE} > DEPENDS ${WEBCORE_DIR}/bindings/scripts/preprocess-idls.pl ${SCRIPTS_PREPROCESS_IDLS} ${WebCore_IDL_FILES} ${ObjC_Bindings_IDL_FILES} ${WebCoreTestSupport_IDL_FILES} ${WEBCORE_DIR}/CMakeLists.txt > COMMAND ${PERL_EXECUTABLE} -I${WEBCORE_DIR}/bindings/scripts ${WEBCORE_DIR}/bindings/scripts/preprocess-idls.pl --defines "${FEATURE_DEFINES_JAVASCRIPT}" --idlFilesList ${IDL_FILES_TMP} --supplementalDependencyFile ${SUPPLEMENTAL_DEPENDENCY_FILE} --windowConstructorsFile ${WINDOW_CONSTRUCTORS_FILE} --workerGlobalScopeConstructorsFile ${WORKERGLOBALSCOPE_CONSTRUCTORS_FILE} > --dedicatedWorkerGlobalScopeConstructorsFile ${DEDICATEDWORKERGLOBALSCOPE_CONSTRUCTORS_FILE} > VERBATIM) > GENERATE_BINDINGS(WebCore_DERIVED_SOURCES > "${WebCore_IDL_FILES}" > "${WEBCORE_DIR}" > "${IDL_INCLUDES}" > "${FEATURE_DEFINES_JAVASCRIPT}" > ${DERIVED_SOURCES_WEBCORE_DIR} JS JS cpp > ${IDL_ATTRIBUTES_FILE} > ${SUPPLEMENTAL_DEPENDENCY_FILE} > ${ADDITIONAL_BINDINGS_DEPENDENCIES}) 275989 2016-04-08 03:28:49 -0700 2016-04-08 11:28:27 -0700 Patch bug-156400-20160408192852.patch text/plain 2730 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIxZmYzNmI5YzlmYTE4 MGNkMmE1MGVhMmU4MzQ2YTBmYmUyY2ExYy4uZjUwOWRkZTY0M2Y0YzcxYWIxYWVlOWUzYzNkOWZh NjdkZjZiMzViZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA0LTA4ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQGpwLnNvbnkuY29tPgorCisgICAgICAgIFRvdWNo aW5nIGFueSBJREwgZmlsZXMgcmVidWlsZHMgYWxsIGJpbmRpbmdzIGluIENNYWtlIE5pbmphIGJ1 aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTY0 MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGJp bmRpbmdzL3NjcmlwdHMvcHJlcHJvY2Vzcy1pZGxzLnBsOgorICAgICAgICAoR2VuZXJhdGVDb25z dHJ1Y3RvckF0dHJpYnV0ZSk6CisgICAgICAgIFdyaXRlRmlsZUlmQ2hhbmdlZCBkb2VzIG5vdCB3 b3JrIGR1ZSB0byBmbGFreSByZXN1bHRzIG9mICdrZXlzJy4KKyAgICAgICAgU29ydCByZXN1bHRz IG9mICdrZXlzJy4KKwogMjAxNi0wNC0wNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgRm9udEZhY2VTZXQgYmluZGluZyBkb2VzIG5vdCBoYW5kbGUgbnVsbCBjb3Jy ZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvcHJlcHJv Y2Vzcy1pZGxzLnBsIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNz LWlkbHMucGwKaW5kZXggNjlmZDMxYzEzMGM0ZDIzNTkyYzgxYmVkZmQ3ZGE5OTJkMzhkMWFjNC4u OTVmODI5ZDcwYzI5NDg1NzkyZDRhN2UwNGI0ZTdkZGZmMmExODBkOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzLWlkbHMucGwKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9wcmVwcm9jZXNzLWlkbHMucGwKQEAgLTc3LDcg Kzc3LDcgQEAgbXkgJGRlZGljYXRlZFdvcmtlckdsb2JhbFNjb3BlQ29uc3RydWN0b3JzQ29kZSA9 ICIiOwogbXkgJWlkbEZpbGVIYXNoID0gbWFwIHsgJF8sIDEgfSBAaWRsRmlsZXM7CiAKICMgUG9w dWxhdGUgJGlkbEZpbGVUb0ludGVyZmFjZU5hbWUgYW5kICRpbnRlcmZhY2VOYW1lVG9JZGxGaWxl LgotZm9yZWFjaCBteSAkaWRsRmlsZSAoa2V5cyAlaWRsRmlsZUhhc2gpIHsKK2ZvcmVhY2ggbXkg JGlkbEZpbGUgKHNvcnQga2V5cyAlaWRsRmlsZUhhc2gpIHsKICAgICBteSAkZnVsbFBhdGggPSBD d2Q6OnJlYWxwYXRoKCRpZGxGaWxlKTsKICAgICBteSAkaW50ZXJmYWNlTmFtZSA9IGZpbGVwYXJz ZShiYXNlbmFtZSgkaWRsRmlsZSksICIuaWRsIik7CiAgICAgJGlkbEZpbGVUb0ludGVyZmFjZU5h bWV7JGZ1bGxQYXRofSA9ICRpbnRlcmZhY2VOYW1lOwpAQCAtMTMxLDcgKzEzMSw3IEBAIEdlbmVy YXRlUGFydGlhbEludGVyZmFjZSgiV29ya2VyR2xvYmFsU2NvcGUiLCAkd29ya2VyR2xvYmFsU2Nv cGVDb25zdHJ1Y3RvcnNDb2RlCiBHZW5lcmF0ZVBhcnRpYWxJbnRlcmZhY2UoIkRlZGljYXRlZFdv cmtlckdsb2JhbFNjb3BlIiwgJGRlZGljYXRlZFdvcmtlckdsb2JhbFNjb3BlQ29uc3RydWN0b3Jz Q29kZSwgJGRlZGljYXRlZFdvcmtlckdsb2JhbFNjb3BlQ29uc3RydWN0b3JzRmlsZSk7CiAKICMg UmVzb2x2ZXMgcGFydGlhbCBpbnRlcmZhY2VzIGFuZCBpbXBsZW1lbnRzIGRlcGVuZGVuY2llcy4K LWZvcmVhY2ggbXkgJGlkbEZpbGUgKGtleXMgJXN1cHBsZW1lbnRhbERlcGVuZGVuY2llcykgewor Zm9yZWFjaCBteSAkaWRsRmlsZSAoc29ydCBrZXlzICVzdXBwbGVtZW50YWxEZXBlbmRlbmNpZXMp IHsKICAgICBteSAkYmFzZUZpbGVzID0gJHN1cHBsZW1lbnRhbERlcGVuZGVuY2llc3skaWRsRmls ZX07CiAgICAgZm9yZWFjaCBteSAkYmFzZUZpbGUgKEB7JGJhc2VGaWxlc30pIHsKICAgICAgICAg bXkgJHRhcmdldElkbEZpbGUgPSAkaW50ZXJmYWNlTmFtZVRvSWRsRmlsZXskYmFzZUZpbGV9OwpA QCAtMjI3LDcgKzIyNyw3IEBAIHN1YiBHZW5lcmF0ZUNvbnN0cnVjdG9yQXR0cmlidXRlCiAKICAg ICBteSAkY29kZSA9ICIgICAgIjsKICAgICBteSBAZXh0ZW5kZWRBdHRyaWJ1dGVzTGlzdDsKLSAg ICBmb3JlYWNoIG15ICRhdHRyaWJ1dGVOYW1lIChrZXlzICV7JGV4dGVuZGVkQXR0cmlidXRlc30p IHsKKyAgICBmb3JlYWNoIG15ICRhdHRyaWJ1dGVOYW1lIChzb3J0IGtleXMgJXskZXh0ZW5kZWRB dHRyaWJ1dGVzfSkgewogICAgICAgbmV4dCB1bmxlc3MgKCRhdHRyaWJ1dGVOYW1lIGVxICJDb25k aXRpb25hbCIgfHwgJGF0dHJpYnV0ZU5hbWUgZXEgIkVuYWJsZWRBdFJ1bnRpbWUiIHx8ICRhdHRy aWJ1dGVOYW1lIGVxICJFbmFibGVkQnlTZXR0aW5nIik7CiAgICAgICBteSAkZXh0ZW5kZWRBdHRy aWJ1dGUgPSAkYXR0cmlidXRlTmFtZTsKICAgICAgICRleHRlbmRlZEF0dHJpYnV0ZSAuPSAiPSIg LiAkZXh0ZW5kZWRBdHRyaWJ1dGVzLT57JGF0dHJpYnV0ZU5hbWV9IHVubGVzcyAkZXh0ZW5kZWRB dHRyaWJ1dGVzLT57JGF0dHJpYnV0ZU5hbWV9IGVxICJWQUxVRV9JU19NSVNTSU5HIjsK