156396 2016-04-08 00:53:13 -0700 Remove unneeded UsePointersEvenForNonNullableObjectArguments from event classes 2019-02-06 09:03:28 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin cdumez commit-queue esprehn+autocc kangil.han kondapallykalyan sam youennf oldest_to_newest 1182090 0 darin 2016-04-08 00:53:13 -0700 Remove unneeded UsePointersEvenForNonNullableObjectArguments from event classes 1182091 1 275983 darin 2016-04-08 00:53:40 -0700 Created attachment 275983 Patch 1182094 2 darin 2016-04-08 01:10:28 -0700 If these were needed, then removing them without changing the C++ DOM code would cause a build failure. Successful builds will demonstrate the keywords were not needed. 1182095 3 youennf 2016-04-08 01:14:24 -0700 r=me. Thanks for cleaning this. (In reply to comment #2) > If these were needed, then removing them without changing the C++ DOM code > would cause a build failure. Successful builds will demonstrate the keywords > were not needed. Yes, the binding generator is handling the case of these parameters (not marked as nullable, but optional with undefined as default). 1182112 4 275983 commit-queue 2016-04-08 02:04:17 -0700 Comment on attachment 275983 Patch Clearing flags on attachment: 275983 Committed r199224: <http://trac.webkit.org/changeset/199224> 1182113 5 commit-queue 2016-04-08 02:04:22 -0700 All reviewed patches have been landed. Closing bug. 1502974 6 lforschler 2019-02-06 09:03:28 -0800 Mass moving XML DOM bugs to the "DOM" Component. 275983 2016-04-08 00:53:40 -0700 2016-04-08 02:04:17 -0700 Patch bug-156396-20160408005344.patch text/plain 5180 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIxZmYzNmI5YzlmYTE4 MGNkMmE1MGVhMmU4MzQ2YTBmYmUyY2ExYy4uMjMzZDA5ZjNlNWQ1YTA3YjIwMGIyMTIyNjQ0MWVh NTdlOWUwNWMwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA0LTA4ICBEYXJp biBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWVkZWQgVXNl UG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHMgZnJvbSBldmVudCBjbGFz c2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTYz OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRv bS9Db21wb3NpdGlvbkV2ZW50LmlkbDoKKyAgICAgICAgKiBkb20vS2V5Ym9hcmRFdmVudC5pZGw6 CisgICAgICAgICogZG9tL01vdXNlRXZlbnQuaWRsOgorICAgICAgICAqIGRvbS9NdXRhdGlvbkV2 ZW50LmlkbDoKKyAgICAgICAgKiBkb20vVGV4dEV2ZW50LmlkbDoKKyAgICAgICAgKiBkb20vVG91 Y2hFdmVudC5pZGw6CisgICAgICAgICogZG9tL1VJRXZlbnQuaWRsOgorICAgICAgICAqIGRvbS9X aGVlbEV2ZW50LmlkbDoKKyAgICAgICAgUmVtb3ZlZCBVc2VQb2ludGVyc0V2ZW5Gb3JOb25OdWxs YWJsZU9iamVjdEFyZ3VtZW50cywgd2hpY2ggd2FzIGhhdmluZyBubyBlZmZlY3QuCisKIDIwMTYt MDQtMDcgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEZvbnRGYWNl U2V0IGJpbmRpbmcgZG9lcyBub3QgaGFuZGxlIG51bGwgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vQ29tcG9zaXRpb25FdmVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9k b20vQ29tcG9zaXRpb25FdmVudC5pZGwKaW5kZXggZGQzODYzOGVkMDdkNzIxMWJjYzFhZmRkMDhi MzYyMzk3NjFmZjUwYS4uNWM2YTE5N2FkNDZmZTNmZDgyMGY3OTAxZjBkNWQyYjdkNTUwYjc4YyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0NvbXBvc2l0aW9uRXZlbnQuaWRsCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Db21wb3NpdGlvbkV2ZW50LmlkbApAQCAtMjYsNyArMjYsNiBA QAogWwogICAgIENvbnN0cnVjdG9yQ29uZGl0aW9uYWw9RE9NNF9FVkVOVFNfQ09OU1RSVUNUT1Is CiAgICAgQ29uc3RydWN0b3JUZW1wbGF0ZT1FdmVudCwKLSAgICBVc2VQb2ludGVyc0V2ZW5Gb3JO b25OdWxsYWJsZU9iamVjdEFyZ3VtZW50cywKIF0gaW50ZXJmYWNlIENvbXBvc2l0aW9uRXZlbnQg OiBVSUV2ZW50IHsKIAogICAgIFtJbml0aWFsaXplZEJ5RXZlbnRDb25zdHJ1Y3Rvcl0gcmVhZG9u bHkgYXR0cmlidXRlIERPTVN0cmluZyBkYXRhOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZG9tL0tleWJvYXJkRXZlbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL0tleWJvYXJkRXZlbnQu aWRsCmluZGV4IGVhNGI1Y2ZlNTU4NWUzYjZkMzBhNWMyYjI0MjFmMmJkNjZiZmViYmIuLjU1MDcx N2I2MzYwNzE4NGY0NjJmOGUyZDM2NzVmYzAzMDRhMzllMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9LZXlib2FyZEV2ZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vS2V5 Ym9hcmRFdmVudC5pZGwKQEAgLTIxLDcgKzIxLDYgQEAKIFsKICAgICBDb25zdHJ1Y3RvckNvbmRp dGlvbmFsPURPTTRfRVZFTlRTX0NPTlNUUlVDVE9SLAogICAgIENvbnN0cnVjdG9yVGVtcGxhdGU9 RXZlbnQsCi0gICAgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVudHMs CiBdIGludGVyZmFjZSBLZXlib2FyZEV2ZW50IDogVUlFdmVudCB7CiAKICNpZiAhZGVmaW5lZChM QU5HVUFHRV9KQVZBU0NSSVBUKSB8fCAhTEFOR1VBR0VfSkFWQVNDUklQVApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL01vdXNlRXZlbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL01v dXNlRXZlbnQuaWRsCmluZGV4IDA1M2MxZjM2YzE1NWQyYjkxNDQyODM1ZjUwZGE0OWI3OWM2Zjll YmIuLmQzODhmMzRjODkxOTYxOTczODg1ODdhM2I1NDA4ZWYwMzE4MWU2M2UgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Nb3VzZUV2ZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9k b20vTW91c2VFdmVudC5pZGwKQEAgLTIwLDcgKzIwLDYgQEAKIFsKICAgICBDb25zdHJ1Y3RvckNv bmRpdGlvbmFsPURPTTRfRVZFTlRTX0NPTlNUUlVDVE9SLAogICAgIENvbnN0cnVjdG9yVGVtcGxh dGU9RXZlbnQsCi0gICAgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVu dHMsCiAgICAgRG9Ob3RDaGVja0NvbnN0YW50cywKIF0gaW50ZXJmYWNlIE1vdXNlRXZlbnQgOiBV SUV2ZW50IHsKICNpZiBkZWZpbmVkKExBTkdVQUdFX0pBVkFTQ1JJUFQpICYmIExBTkdVQUdFX0pB VkFTQ1JJUFQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbkV2ZW50Lmlk bCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9NdXRhdGlvbkV2ZW50LmlkbAppbmRleCBhZDU1OWM1MmE5 MjMzN2EyYjc5NDRhYzJmOTdjZjI5OTlmYjZmNmMwLi41NGI1MjQxMGU1YzFjZTNhMjg2NTVkY2Q4 NjZkYzU5MGQxZjE4M2YzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vTXV0YXRpb25F dmVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL011dGF0aW9uRXZlbnQuaWRsCkBAIC0x OCw5ICsxOCw3IEBACiAgKi8KIAogLy8gSW50cm9kdWNlZCBpbiBET00gTGV2ZWwgMjoKLVsKLSAg ICBVc2VQb2ludGVyc0V2ZW5Gb3JOb25OdWxsYWJsZU9iamVjdEFyZ3VtZW50cywKLV0gaW50ZXJm YWNlIE11dGF0aW9uRXZlbnQgOiBFdmVudCB7CitpbnRlcmZhY2UgTXV0YXRpb25FdmVudCA6IEV2 ZW50IHsKIAogICAgIC8vIGF0dHJDaGFuZ2VUeXBlCiAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQg TU9ESUZJQ0FUSU9OID0gMTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9UZXh0RXZl bnQuaWRsIGIvU291cmNlL1dlYkNvcmUvZG9tL1RleHRFdmVudC5pZGwKaW5kZXggMTg3Njg0NzRi NTg1MDU2ZDM2ODgxNGU0MzIxZDRlZDcyZjE3OWUyMi4uOThiNTkxYmQ5OTk3Yzc3YjllZTZlYWVk MTUxYzY5MzQwZmY0OGQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1RleHRFdmVu dC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1RleHRFdmVudC5pZGwKQEAgLTI0LDkgKzI0 LDcgQEAKICAqLwogCiAvLyBJbnRyb2R1Y2VkIGluIERPTSBMZXZlbCAzOgotWwotICAgIFVzZVBv aW50ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzLAotXSBpbnRlcmZhY2UgVGV4 dEV2ZW50IDogVUlFdmVudCB7CitpbnRlcmZhY2UgVGV4dEV2ZW50IDogVUlFdmVudCB7CiAKICAg ICByZWFkb25seSBhdHRyaWJ1dGUgRE9NU3RyaW5nIGRhdGE7CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Ub3VjaEV2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ub3VjaEV2 ZW50LmlkbAppbmRleCA0ZWJkZWE3N2M1NDc2NzQzYmUyNThmMTFhOWQzMTQ2ZjI0ZTZlNjdiLi4w N2NlNzQ3YTYwNDM3MDNiOWNjZGY2MjhhMGUyNzlmYjBiMjUyYTUyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vVG91Y2hFdmVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1Rv dWNoRXZlbnQuaWRsCkBAIC0yNSw3ICsyNSw2IEBACiAKIFsKICAgICBDb25kaXRpb25hbD1UT1VD SF9FVkVOVFMsCi0gICAgVXNlUG9pbnRlcnNFdmVuRm9yTm9uTnVsbGFibGVPYmplY3RBcmd1bWVu dHMsCiBdIGludGVyZmFjZSBUb3VjaEV2ZW50IDogVUlFdmVudCB7CiAgICAgcmVhZG9ubHkgYXR0 cmlidXRlIFRvdWNoTGlzdCB0b3VjaGVzOwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBUb3VjaExp c3QgdGFyZ2V0VG91Y2hlczsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9VSUV2ZW50 LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9VSUV2ZW50LmlkbAppbmRleCBhZWUwNTczZGM3MjNh NGQ5Yjg2NDNkMmI3YmE1ZWM5N2MzZTc0YzNjLi43ZDMzZWYyOTdmNzkwOTAzZGQ1OWQ0NGE1MWYx NWE4ODlhNWEzZmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vVUlFdmVudC5pZGwK KysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1VJRXZlbnQuaWRsCkBAIC0yMCw3ICsyMCw2IEBACiBb CiAgICAgQ29uc3RydWN0b3JDb25kaXRpb25hbD1ET000X0VWRU5UU19DT05TVFJVQ1RPUiwKICAg ICBDb25zdHJ1Y3RvclRlbXBsYXRlPUV2ZW50LAotICAgIFVzZVBvaW50ZXJzRXZlbkZvck5vbk51 bGxhYmxlT2JqZWN0QXJndW1lbnRzLAogXSBpbnRlcmZhY2UgVUlFdmVudCA6IEV2ZW50IHsKICAg ICBbSW5pdGlhbGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01X aW5kb3cgdmlldzsKICAgICBbSW5pdGlhbGl6ZWRCeUV2ZW50Q29uc3RydWN0b3JdIHJlYWRvbmx5 IGF0dHJpYnV0ZSBsb25nIGRldGFpbDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9X aGVlbEV2ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9XaGVlbEV2ZW50LmlkbAppbmRleCBh MTE5MzM4NzFhZDJjMjg4NDAxMzY1YzM1ZWE4NTZmMzk2ZDVjYjE5Li42ODc5NjZhZGJhZTU1MmEz OWRmYmQ5Y2I5NThmYjNiYzc0MTAxOTBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20v V2hlZWxFdmVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1doZWVsRXZlbnQuaWRsCkBA IC0yMyw3ICsyMyw2IEBACiBbCiAgICAgQ29uc3RydWN0b3JDb25kaXRpb25hbD1ET000X0VWRU5U U19DT05TVFJVQ1RPUiwKICAgICBDb25zdHJ1Y3RvclRlbXBsYXRlPUV2ZW50LAotICAgIFVzZVBv aW50ZXJzRXZlbkZvck5vbk51bGxhYmxlT2JqZWN0QXJndW1lbnRzLAogXSBpbnRlcmZhY2UgV2hl ZWxFdmVudCA6IE1vdXNlRXZlbnQgewogICAgIC8vIERlbHRhTW9kZUNvZGUKICAgICBjb25zdCB1 bnNpZ25lZCBsb25nICAgICAgICAgICAgICBET01fREVMVEFfUElYRUwgPSAweDAwOwo=