156376 2016-04-07 16:31:26 -0700 [css-grid] Remove unnecessary iteration in populateGridPositions loop 2016-04-08 01:01:09 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfernandez jfernandez commit-queue darin esprehn+autocc glenn kondapallykalyan rego simon.fraser svillar oldest_to_newest 1181963 0 jfernandez 2016-04-07 16:31:26 -0700 The loop implemented in the populateGridPositions has an incorrect limit and the last operation is overwritten in the next line of code after the loop. Even that it does o cause a bug, it makes no sense and needs to be changed. 1181967 1 275955 jfernandez 2016-04-07 16:36:47 -0700 Created attachment 275955 Patch 1182092 2 275955 commit-queue 2016-04-08 01:01:05 -0700 Comment on attachment 275955 Patch Clearing flags on attachment: 275955 Committed r199222: <http://trac.webkit.org/changeset/199222> 1182093 3 commit-queue 2016-04-08 01:01:09 -0700 All reviewed patches have been landed. Closing bug. 275955 2016-04-07 16:36:47 -0700 2016-04-08 01:01:05 -0700 Patch bug-156376-20160408013649.patch text/plain 3402 jfernandez U3VidmVyc2lvbiBSZXZpc2lvbjogMTk3NzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzcwNGEwZDUyMDg1Y2Y5 NzVkYWUwNGQwYTBlYmI5ODQyYmQyOWYxNy4uZTI1ZmMzZTZmM2MyYmRkODBjZjAwZjhkYjQ2OWU5 NGYxYmRhMjFmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA0LTA3ICBKYXZp ZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gUmVtb3ZlIHVubmVjZXNzYXJ5IGl0ZXJhdGlvbiBpbiBwb3B1bGF0ZUdyaWRQb3NpdGlvbnMg bG9vcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2 Mzc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHBvcHVsYXRlR3JpZFBvc2l0aW9ucyBsb29wIGxpbWl0IHdhcyBzZXQgdG8gJ2xhc3RMaW5lJy4g SG93ZXZlciwgdGhlCisgICAgICAgIHRoZSBwb3NpdGlvbiBvZiBsYXN0IHRyYWNrJ3Mgc3RhcnQg bGluZSBpcyB1cGRhdGVkIGFmdGVyIHRoZSBsb29wLCBzaW5jZQorICAgICAgICBpdCBkb2VzIG5v dCBmb2xsb3cgdGhlIHNhbWUgcGF0dGVybjsgaXQgZG9lcyBub3QgaGF2ZSBhIGNvbnRlbnQKKyAg ICAgICAgZGlzdHJpYnV0aW9uIG9mZnNldC4KKworICAgICAgICBTbywgc2luY2Ugd2UgYXJlIGVz c2VudGlhbGx5IG92ZXJ3cml0aW5nIHRoZSB2YWx1ZSBzdG9yZWQgaW4gdGhlIGxhc3QKKyAgICAg ICAgaXRlcmF0aW9uLCB3ZSBjYW4ganVzdCBsb3dlciB0aGUgbG9vcCBsaW1pdC4KKworICAgICAg ICBObyBuZXcgdGVzdHMgYWRkZWQsIGJlY2F1c2UgdGhlcmUgaXMgbm8gY2hhbmdlIGluIHRoZSBm dW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyR3JpZDo6cG9wdWxhdGVHcmlkUG9zaXRpb25zKToKKwogMjAx Ni0wMy0wOCAgWW91ZW5uIEZhYmxldCAgPHlvdWVubi5mYWJsZXRAY3JmLmNhbm9uLmZyPgogCiAg ICAgICAgIFtGZXRjaCBBUEldIEltcGxlbWVudCBmZXRjaCBza2VsZXRvbgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCmluZGV4IDY2ZGUyMzAyMmYxZGM1NjljZjMyYjMxNzBm ZDA1MDY4MjU2ZWY2YzIuLjYyOTYxODBmMjFmY2I0N2Y1NTcxYjQ1NTNmMzdjMWNkZjVjMTg5Y2Qg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJHcmlkLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3JpZC5jcHAKQEAgLTE1NzQsNiArMTU3 NCw5IEBAIHZvaWQgUmVuZGVyR3JpZDo6cG9wdWxhdGVHcmlkUG9zaXRpb25zKEdyaWRTaXppbmdE YXRhJiBzaXppbmdEYXRhKQogICAgIC8vIEZJWE1FOiBUaGlzIHdpbGwgYWZmZWN0IHRoZSBjb21w dXRlZCBzdHlsZSB2YWx1ZSBvZiBncmlkIHRyYWNrcyBzaXplLCBzaW5jZSB3ZSBhcmUKICAgICAv LyB1c2luZyB0aGVzZSBwb3NpdGlvbnMgdG8gY29tcHV0ZSB0aGVtLgogCisgICAgLy8gVGhlIGdy aWQgY29udGFpbmVyJ3MgZnJhbWUgZWxlbWVudHMgKGJvcmRlciwgcGFkZGluZyBhbmQgPGNvbnRl bnQtcG9zaXRpb24+IG9mZnNldCkgYXJlIHNlbnNpYmxlIHRvIHRoZQorICAgIC8vIGlubGluZS1h eGlzIGZsb3cgZGlyZWN0aW9uLiBIb3dldmVyLCBjb2x1bW4gbGluZXMgcG9zaXRpb25zIGFyZSAn ZGlyZWN0aW9uJyB1bmF3YXJlLiBUaGlzIHNpbXBsaWZpY2F0aW9uCisgICAgLy8gYWxsb3dzIHVz IHRvIHVzZSB0aGUgc2FtZSBpbmRleGVzIHRvIGlkZW50aWZ5IHRoZSBjb2x1bW5zIGluZGVwZW5k ZW50bHkgb24gdGhlIGlubGluZS1heGlzIGRpcmVjdGlvbi4KICAgICB1bnNpZ25lZCBudW1iZXJP ZlRyYWNrcyA9IHNpemluZ0RhdGEuY29sdW1uVHJhY2tzLnNpemUoKTsKICAgICB1bnNpZ25lZCBu dW1iZXJPZkxpbmVzID0gbnVtYmVyT2ZUcmFja3MgKyAxOwogICAgIHVuc2lnbmVkIGxhc3RMaW5l ID0gbnVtYmVyT2ZMaW5lcyAtIDE7CkBAIC0xNTgyLDcgKzE1ODUsNyBAQCB2b2lkIFJlbmRlckdy aWQ6OnBvcHVsYXRlR3JpZFBvc2l0aW9ucyhHcmlkU2l6aW5nRGF0YSYgc2l6aW5nRGF0YSkKICAg ICBMYXlvdXRVbml0IHRyYWNrR2FwID0gZ3V0dGVyc1NpemUoRm9yQ29sdW1ucywgMik7CiAgICAg bV9jb2x1bW5Qb3NpdGlvbnMucmVzaXplKG51bWJlck9mTGluZXMpOwogICAgIG1fY29sdW1uUG9z aXRpb25zWzBdID0gYm9yZGVyQW5kUGFkZGluZ1N0YXJ0KCkgKyBvZmZzZXQucG9zaXRpb25PZmZz ZXQ7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGxhc3RMaW5lOyArK2kpCisgICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IG5leHRUb0xhc3RMaW5lOyArK2kpCiAgICAgICAgIG1fY29s dW1uUG9zaXRpb25zW2kgKyAxXSA9IG1fY29sdW1uUG9zaXRpb25zW2ldICsgb2Zmc2V0LmRpc3Ry aWJ1dGlvbk9mZnNldCArIHNpemluZ0RhdGEuY29sdW1uVHJhY2tzW2ldLmJhc2VTaXplKCkgKyB0 cmFja0dhcDsKICAgICBtX2NvbHVtblBvc2l0aW9uc1tsYXN0TGluZV0gPSBtX2NvbHVtblBvc2l0 aW9uc1tuZXh0VG9MYXN0TGluZV0gKyBzaXppbmdEYXRhLmNvbHVtblRyYWNrc1tuZXh0VG9MYXN0 TGluZV0uYmFzZVNpemUoKTsKIApAQCAtMTU5NCw3ICsxNTk3LDcgQEAgdm9pZCBSZW5kZXJHcmlk Ojpwb3B1bGF0ZUdyaWRQb3NpdGlvbnMoR3JpZFNpemluZ0RhdGEmIHNpemluZ0RhdGEpCiAgICAg dHJhY2tHYXAgPSBndXR0ZXJzU2l6ZShGb3JSb3dzLCAyKTsKICAgICBtX3Jvd1Bvc2l0aW9ucy5y ZXNpemUobnVtYmVyT2ZMaW5lcyk7CiAgICAgbV9yb3dQb3NpdGlvbnNbMF0gPSBib3JkZXJBbmRQ YWRkaW5nQmVmb3JlKCkgKyBvZmZzZXQucG9zaXRpb25PZmZzZXQ7Ci0gICAgZm9yICh1bnNpZ25l ZCBpID0gMDsgaSA8IGxhc3RMaW5lOyArK2kpCisgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8 IG5leHRUb0xhc3RMaW5lOyArK2kpCiAgICAgICAgIG1fcm93UG9zaXRpb25zW2kgKyAxXSA9IG1f cm93UG9zaXRpb25zW2ldICsgb2Zmc2V0LmRpc3RyaWJ1dGlvbk9mZnNldCArIHNpemluZ0RhdGEu cm93VHJhY2tzW2ldLmJhc2VTaXplKCkgKyB0cmFja0dhcDsKICAgICBtX3Jvd1Bvc2l0aW9uc1ts YXN0TGluZV0gPSBtX3Jvd1Bvc2l0aW9uc1tuZXh0VG9MYXN0TGluZV0gKyBzaXppbmdEYXRhLnJv d1RyYWNrc1tuZXh0VG9MYXN0TGluZV0uYmFzZVNpemUoKTsKIH0K