156371 2016-04-07 15:21:28 -0700 Web Inspector: ProfileView source links are off by 1 line, worse in pretty printed code 2016-04-07 16:28:13 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1181926 0 joepeck 2016-04-07 15:21:28 -0700 * SUMMARY ProfileView source links are off by 1 line, worse in pretty printed code. * TEST <script> function runFor(ms) { var until = Date.now() + ms; while (Date.now() < until); } function doWork() { runFor(200); } setTimeout(() => { doWork() }, 0); </script> * STEPS TO REPRODUCE 1. Inspect test page 2. Timeline record it doing work 3. Show Profile View 4. Jump to "runFor" => off by 1, it highlights the line with `until` and not `runFor` * NOTES - Protocol produces 1-based line numbers, but SourceCodeLocation expects 0-based. 1181927 1 webkit-bug-importer 2016-04-07 15:22:19 -0700 <rdar://problem/25612513> 1181928 2 275946 joepeck 2016-04-07 15:22:40 -0700 Created attachment 275946 [PATCH] Proposed Fix 1181960 3 275946 commit-queue 2016-04-07 16:28:09 -0700 Comment on attachment 275946 [PATCH] Proposed Fix Clearing flags on attachment: 275946 Committed r199201: <http://trac.webkit.org/changeset/199201> 1181961 4 commit-queue 2016-04-07 16:28:13 -0700 All reviewed patches have been landed. Closing bug. 275946 2016-04-07 15:22:40 -0700 2016-04-07 16:28:09 -0700 [PATCH] Proposed Fix 0-based.patch text/plain 4171 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDk1NThiNGIuLjkyZWZmYmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA0LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJvZmls ZVZpZXcgc291cmNlIGxpbmtzIGFyZSBvZmYgYnkgMSBsaW5lLCB3b3JzZSBpbiBwcmV0dHkgcHJp bnRlZCBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTYzNzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGluc3BlY3Rvci9wcm90b2NvbC9TY3JpcHRQcm9maWxlci5qc29uOgorICAgICAgICBDbGFy aWZ5IHRoYXQgdGhlc2UgbG9jYXRpb25zIGFyZSAxLWJhc2VkLgorCiAyMDE2LTA0LTA3ICBLZWl0 aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlIHNob3VsZCBz dXBwb3J0IHRoZSBhYmlsaXR5IHRvIGRvIGEgbm9uLWVmZmVjdGZ1bCBnZXRCeUlkCmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL1NjcmlwdFByb2Zp bGVyLmpzb24gYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL1Njcmlw dFByb2ZpbGVyLmpzb24KaW5kZXggOTc4ZDdmZi4uMzdlNWI3NyAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9wcm90b2NvbC9TY3JpcHRQcm9maWxlci5qc29uCisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvU2NyaXB0UHJvZmls ZXIuanNvbgpAQCAtMjAsOCArMjAsOCBAQAogICAgICAgICAgICAgImlkIjogIkV4cHJlc3Npb25M b2NhdGlvbiIsCiAgICAgICAgICAgICAidHlwZSI6ICJvYmplY3QiLAogICAgICAgICAgICAgInBy b3BlcnRpZXMiOiBbCi0gICAgICAgICAgICAgICAgeyAibmFtZSI6ICJsaW5lIiwgInR5cGUiOiAi aW50ZWdlciIgfSwKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogImNvbHVtbiIsICJ0eXBlIjog ImludGVnZXIiIH0KKyAgICAgICAgICAgICAgICB7ICJuYW1lIjogImxpbmUiLCAidHlwZSI6ICJp bnRlZ2VyIiwgImRlc2NyaXB0aW9uIjogIjEtYmFzZWQuIiB9LAorICAgICAgICAgICAgICAgIHsg Im5hbWUiOiAiY29sdW1uIiwgInR5cGUiOiAiaW50ZWdlciIsICJkZXNjcmlwdGlvbiI6ICIxLWJh c2VkLiIgfQogICAgICAgICAgICAgXQogICAgICAgICB9LAogICAgICAgICB7CkBAIC0zMCw4ICsz MCw4IEBACiAgICAgICAgICAgICAicHJvcGVydGllcyI6IFsKICAgICAgICAgICAgICAgICB7ICJu YW1lIjogInNvdXJjZUlEIiwgIiRyZWYiOiAiRGVidWdnZXIuU2NyaXB0SWQiLCAiZGVzY3JpcHRp b24iOiAiVW5pcXVlIHNjcmlwdCBpZGVudGlmaWVyLiIgfSwKICAgICAgICAgICAgICAgICB7ICJu YW1lIjogIm5hbWUiLCAidHlwZSI6ICJzdHJpbmciLCAiZGVzY3JpcHRpb24iOiAiQSBkaXNwbGF5 YWJsZSBuYW1lIGZvciB0aGUgc3RhY2sgZnJhbWUuIGkuZSBmdW5jdGlvbiBuYW1lLCAocHJvZ3Jh bSksIGV0Yy4iIH0sCi0gICAgICAgICAgICAgICAgeyAibmFtZSI6ICJsaW5lIiwgInR5cGUiOiAi aW50ZWdlciIgfSwKLSAgICAgICAgICAgICAgICB7ICJuYW1lIjogImNvbHVtbiIsICJ0eXBlIjog ImludGVnZXIiIH0sCisgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJsaW5lIiwgInR5cGUiOiAi aW50ZWdlciIsICJkZXNjcmlwdGlvbiI6ICItMSBpZiB1bmF2YWlsYWJsZS4gMS1iYXNlZCBpZiBh dmFpbGFibGUuIiB9LAorICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiY29sdW1uIiwgInR5cGUi OiAiaW50ZWdlciIsICJkZXNjcmlwdGlvbiI6ICItMSBpZiB1bmF2YWlsYWJsZS4gMS1iYXNlZCBp ZiBhdmFpbGFibGUuIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAidXJsIiwgInR5cGUi OiAic3RyaW5nIiB9LAogICAgICAgICAgICAgICAgIHsgIm5hbWUiOiAiZXhwcmVzc2lvbkxvY2F0 aW9uIiwgIiRyZWYiOiAiRXhwcmVzc2lvbkxvY2F0aW9uIiwgIm9wdGlvbmFsIjogdHJ1ZSB9CiAg ICAgICAgICAgICBdCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1OGU2ZDJmLi5mMTk2MGMz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxNi0wNC0wNyAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFByb2ZpbGVWaWV3IHNvdXJjZSBsaW5rcyBhcmUgb2ZmIGJ5IDEgbGluZSwgd29yc2Ug aW4gcHJldHR5IHByaW50ZWQgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU2MzcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Byb2ZpbGVEYXRhR3JpZE5vZGUu anM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZURhdGFHcmlkTm9kZS5wcm90b3R5cGUu X2Rpc3BsYXlDb250ZW50KToKKyAgICAgICAgU3dpdGNoIHRoZSAxLWJhc2VkIGxvY2F0aW9ucyBp biB0aGUgQ0NUIGRhdGEgc3RydWN0dXJlIHRvIDAtYmFzZWQgZm9yIFNvdXJjZUNvZGVMb2NhdGlv bi4KKworMjAxNi0wNC0wNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgor CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluc3BlY3RvciBoYW5ncyB3aGVuIHRyeWluZyB0byB2 aWV3IGEgbGFyZ2UgWEhSIHJlc291cmNlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNDQxMDcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzIwNjY5NDYz PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv UHJvZmlsZURhdGFHcmlkTm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1Byb2ZpbGVEYXRhR3JpZE5vZGUuanMKaW5kZXggMTVmY2UwYy4uZjFmNzRmNyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUHJv ZmlsZURhdGFHcmlkTm9kZS5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Qcm9maWxlRGF0YUdyaWROb2RlLmpzCkBAIC0yMjAsNyArMjIwLDggQEAgV2Vi SW5zcGVjdG9yLlByb2ZpbGVEYXRhR3JpZE5vZGUgPSBjbGFzcyBQcm9maWxlRGF0YUdyaWROb2Rl IGV4dGVuZHMgV2ViSW5zcGVjdG8KIAogICAgICAgICBsZXQgc2NyaXB0ID0gV2ViSW5zcGVjdG9y LmRlYnVnZ2VyTWFuYWdlci5zY3JpcHRGb3JJZGVudGlmaWVyKHRoaXMuX25vZGUuc291cmNlSUQp OwogICAgICAgICBpZiAoc2NyaXB0ICYmIHNjcmlwdC51cmwgJiYgdGhpcy5fbm9kZS5saW5lID49 IDAgJiYgdGhpcy5fbm9kZS5jb2x1bW4gPj0gMCkgewotICAgICAgICAgICAgbGV0IHNvdXJjZUNv ZGVMb2NhdGlvbiA9IHNjcmlwdC5jcmVhdGVTb3VyY2VDb2RlTG9jYXRpb24odGhpcy5fbm9kZS5s aW5lLCB0aGlzLl9ub2RlLmNvbHVtbik7CisgICAgICAgICAgICAvLyBDb252ZXJ0IGZyb20gMS1i YXNlZCBsaW5lIGFuZCBjb2x1bW4gdG8gMC1iYXNlZC4KKyAgICAgICAgICAgIGxldCBzb3VyY2VD b2RlTG9jYXRpb24gPSBzY3JpcHQuY3JlYXRlU291cmNlQ29kZUxvY2F0aW9uKHRoaXMuX25vZGUu bGluZSAtIDEsIHRoaXMuX25vZGUuY29sdW1uIC0gMSk7CiAKICAgICAgICAgICAgIGxldCBsb2Nh dGlvbkVsZW1lbnQgPSBmcmFnbWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50 KCJzcGFuIikpOwogICAgICAgICAgICAgbG9jYXRpb25FbGVtZW50LmNsYXNzTGlzdC5hZGQoImxv Y2F0aW9uIik7Cg==