156357 2016-04-07 13:28:59 -0700 Invalid assertion inside DebuggerScope::getOwnPropertySlot 2016-04-28 11:40:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak ysuzuki oldest_to_newest 1181830 0 saam 2016-04-07 13:28:59 -0700 The Type Profiler might profile JS code that uses DebuggerScope and accesses properties on it. Therefore, it may have a DebuggerScope object in its log. Objects in the log are subject to having their getOwnPropertySlot method called. Therefore, the DebuggerScope might not always be in a valid state when this happens. The assertion is therefore invalid. 1181831 1 275923 saam 2016-04-07 13:31:40 -0700 Created attachment 275923 patch 1181834 2 275923 keith_miller 2016-04-07 13:33:30 -0700 Comment on attachment 275923 patch r=me 1181877 3 275923 commit-queue 2016-04-07 14:25:22 -0700 Comment on attachment 275923 patch Clearing flags on attachment: 275923 Committed r199182: <http://trac.webkit.org/changeset/199182> 1181878 4 commit-queue 2016-04-07 14:25:26 -0700 All reviewed patches have been landed. Closing bug. 1188331 5 mark.lam 2016-04-28 11:40:20 -0700 <rdar://problem/20790971> 275923 2016-04-07 13:31:40 -0700 2016-04-07 14:25:22 -0700 patch a-backup.diff text/plain 1743 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5MTc1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE2LTA0LTA3ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IEludmFsaWQgYXNzZXJ0aW9uIGluc2lkZSBEZWJ1Z2dlclNjb3BlOjpnZXRPd25Qcm9wZXJ0eVNs b3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjM1 NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBU eXBlIFByb2ZpbGVyIG1pZ2h0IHByb2ZpbGUgSlMgY29kZSB0aGF0IHVzZXMgRGVidWdnZXJTY29w ZSBhbmQgYWNjZXNzZXMgcHJvcGVydGllcworICAgICAgICBvbiBpdC4gVGhlcmVmb3JlLCBpdCBt YXkgaGF2ZSBhIERlYnVnZ2VyU2NvcGUgb2JqZWN0IGluIGl0cyBsb2cuIE9iamVjdHMgaW4gdGhl IGxvZworICAgICAgICBhcmUgc3ViamVjdCB0byBoYXZpbmcgdGhlaXIgZ2V0T3duUHJvcGVydHlT bG90IG1ldGhvZCBjYWxsZWQuIFRoZXJlZm9yZSwgdGhlIERlYnVnZ2VyU2NvcGUKKyAgICAgICAg bWlnaHQgbm90IGFsd2F5cyBiZSBpbiBhIHZhbGlkIHN0YXRlIHdoZW4gaXRzIGdldE93blByb3Bl cnR5U2xvdCBtZXRob2QgaXMgY2FsbGVkLgorICAgICAgICBUaGVyZWZvcmUsIHRoZSBhc3NlcnRp b24gaW52YWxpZC4KKworICAgICAgICAqIGRlYnVnZ2VyL0RlYnVnZ2VyU2NvcGUuY3BwOgorICAg ICAgICAoSlNDOjpEZWJ1Z2dlclNjb3BlOjpnZXRPd25Qcm9wZXJ0eVNsb3QpOgorCiAyMDE2LTA0 LTA3ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdl IHNob3VsZCBzdXBwb3J0IHRoZSBhYmlsaXR5IHRvIGRvIGEgbm9uLWVmZmVjdGZ1bCBnZXRCeUlk CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdnZXIvRGVidWdnZXJTY29wZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RlYnVnZ2VyL0RlYnVnZ2VyU2Nv cGUuY3BwCShyZXZpc2lvbiAxOTkxNzUpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVidWdn ZXIvRGVidWdnZXJTY29wZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTcwLDcgKzcwLDYgQEAgU3Ry aW5nIERlYnVnZ2VyU2NvcGU6OmNsYXNzTmFtZShjb25zdCBKUwogYm9vbCBEZWJ1Z2dlclNjb3Bl OjpnZXRPd25Qcm9wZXJ0eVNsb3QoSlNPYmplY3QqIG9iamVjdCwgRXhlY1N0YXRlKiBleGVjLCBQ cm9wZXJ0eU5hbWUgcHJvcGVydHlOYW1lLCBQcm9wZXJ0eVNsb3QmIHNsb3QpCiB7CiAgICAgRGVi dWdnZXJTY29wZSogc2NvcGUgPSBqc0Nhc3Q8RGVidWdnZXJTY29wZSo+KG9iamVjdCk7Ci0gICAg QVNTRVJUKHNjb3BlLT5pc1ZhbGlkKCkpOwogICAgIGlmICghc2NvcGUtPmlzVmFsaWQoKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogICAgIEpTT2JqZWN0KiB0aGlzT2JqZWN0ID0gSlNTY29wZTo6 b2JqZWN0QXRTY29wZShzY29wZS0+anNTY29wZSgpKTsK