156341 2016-04-07 08:38:40 -0700 [JSC] Enable Concurrent JIT by default 2016-04-08 00:08:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki benjamin bugs-noreply calvaris cdumez cmarcelo commit-queue fpizlo ggaren gyuyoung.kim keith_miller mark.lam mcatanzaro msaboff ossy saam oldest_to_newest 1181681 0 ysuzuki 2016-04-07 08:38:40 -0700 [JSCOnly] Enable Concurrent JIT 1181686 1 275890 ysuzuki 2016-04-07 08:50:09 -0700 Created attachment 275890 Patch 1181688 2 275890 ossy 2016-04-07 08:55:41 -0700 Comment on attachment 275890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275890&action=review > Source/WTF/wtf/Platform.h:773 > #if (OS(DARWIN) || PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64) > #define ENABLE_CONCURRENT_JIT 1 > #endif > +#if !(ENABLE(DFG_JIT) && USE(JSVALUE64)) > +#undef ENABLE_CONCURRENT_JIT > +#define ENABLE_CONCURRENT_JIT 0 > +#endif Shouldn't we enable concurrent JIT always if ENABLE(DFG_JIT) && USE(JSVALUE64) ? Is there any platform disabling concurrent JIT intentionally? 1181696 3 275890 ysuzuki 2016-04-07 09:24:20 -0700 Comment on attachment 275890 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275890&action=review Thanks. >> Source/WTF/wtf/Platform.h:773 >> +#endif > > Shouldn't we enable concurrent JIT always if ENABLE(DFG_JIT) && USE(JSVALUE64) ? > Is there any platform disabling concurrent JIT intentionally? I've checked which port uses the concurrent JIT. OS(DARWIN) covers OSX and IOS. (And maybe, it includes IOS Simulator). PLATFORM(WIN) covers the Windows environment including Apple Win and WinCairo. And PLATFORM(EFL) & PLATFORM(GTK) covers the other existing ports. So, if I counted correctly, it seems that all the ports now uses the concurrent JIT, right? 1181826 4 ysuzuki 2016-04-07 13:18:54 -0700 Is there any port that does not want to enable Concurrent JIT when DFG & JSVALUE64 are enabled? If there is nothing, I'll attempt to change `(OS(DARWIN) || PLATFORM(EFL) || PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64)` to `ENABLE(DFG_JIT) && USE(JSVALUE64)`. 1181829 5 fpizlo 2016-04-07 13:24:05 -0700 (In reply to comment #4) > Is there any port that does not want to enable Concurrent JIT when DFG & > JSVALUE64 are enabled? > If there is nothing, I'll attempt to change `(OS(DARWIN) || PLATFORM(EFL) || > PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64)` to > `ENABLE(DFG_JIT) && USE(JSVALUE64)`. OK! 1181837 6 ysuzuki 2016-04-07 13:40:35 -0700 (In reply to comment #5) > (In reply to comment #4) > > Is there any port that does not want to enable Concurrent JIT when DFG & > > JSVALUE64 are enabled? > > If there is nothing, I'll attempt to change `(OS(DARWIN) || PLATFORM(EFL) || > > PLATFORM(GTK) || PLATFORM(WIN)) && ENABLE(DFG_JIT) && USE(JSVALUE64)` to > > `ENABLE(DFG_JIT) && USE(JSVALUE64)`. > > OK! That's nice! 1181838 7 275924 ysuzuki 2016-04-07 13:42:34 -0700 Created attachment 275924 Patch 1182077 8 ysuzuki 2016-04-08 00:08:22 -0700 Committed r199218: <http://trac.webkit.org/changeset/199218> 275890 2016-04-07 08:50:09 -0700 2016-04-07 13:42:30 -0700 Patch bug-156341-20160408005011.patch text/plain 3593 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMwYWIwNjk0MTYyYmY3MTQyNDg5YTcw ZTM3NWI5Njk2NDlkNGE3YjEuLjI2Y2U0OTU2MWRmNTE5Mzg5ZmIyNGY4MGZhMGUzOWVlNjI1ZTk0 OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTYtMDQtMDcgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW0pTQ09ubHldIEVuYWJsZSBDb25jdXJyZW50 IEpJVAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2 MzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3 dGYvUGxhdGZvcm0uaDoKKwogMjAxNi0wNC0wNiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUu Y29tPgogCiAgICAgICAgIEpTQyBzaG91bGQgaGF2ZSBhIHNpbXBsZSB3YXkgb2YgZ2F0aGVyaW5n IElDIHN0YXRpc3RpY3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9T b3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4IGRkM2RjMWRkYzMxMjliZDg4ZTFhYTE1MTA0 OWQ5MzQxMjEzNDIxYjMuLmRjZWQyNTQyN2QwOTA4NDM3YmUzNTE1M2MzM2QwNTcyYTEzMmNkZjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaApAQCAtNzY3LDYgKzc2NywxMCBAQAogI2lmIChPUyhEQVJXSU4pIHx8IFBM QVRGT1JNKEVGTCkgfHwgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShXSU4pKSAmJiBFTkFCTEUo REZHX0pJVCkgJiYgVVNFKEpTVkFMVUU2NCkKICNkZWZpbmUgRU5BQkxFX0NPTkNVUlJFTlRfSklU IDEKICNlbmRpZgorI2lmICEoRU5BQkxFKERGR19KSVQpICYmIFVTRShKU1ZBTFVFNjQpKQorI3Vu ZGVmIEVOQUJMRV9DT05DVVJSRU5UX0pJVAorI2RlZmluZSBFTkFCTEVfQ09OQ1VSUkVOVF9KSVQg MAorI2VuZGlmCiAKIC8qIFRoaXMgY29udHJvbHMgd2hldGhlciBCMyBpcyBidWlsdC4gSXQgd2ls bCBub3QgYmUgdXNlZCB1bmxlc3MgRlRMX1VTRVNfQjMgaXMgZW5hYmxlZC4gKi8KICNpZiBFTkFC TEUoRlRMX0pJVCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFr ZSBiL1NvdXJjZS9jbWFrZS9XZWJLaXRGZWF0dXJlcy5jbWFrZQppbmRleCBlYTdjMjU3MjJiMmI5 ZTk5YmQ4OTJjMGZmZDg5NmJhMmRkNTc2OWQ5Li5jM2M0MGM3NjFlM2U5NDAwYTI2NDk4MzU3MjUx ODA1M2I4OWU4NGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0RmVhdHVyZXMuY21h a2UKKysrIGIvU291cmNlL2NtYWtlL1dlYktpdEZlYXR1cmVzLmNtYWtlCkBAIC03MSw2ICs3MSw3 IEBAIG1hY3JvKFdFQktJVF9PUFRJT05fQkVHSU4pCiAgICAgV0VCS0lUX09QVElPTl9ERUZJTkUo RU5BQkxFX0NBTlZBU19QQVRIICJUb2dnbGUgQ2FudmFzIFBhdGggc3VwcG9ydCIgUFJJVkFURSBP TikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ0FOVkFTX1BST1hZICJUb2dnbGUg Q2FudmFzUHJveHkgc3VwcG9ydCIgUFJJVkFURSBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZJ TkUoRU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HICJUb2dnbGUgTWVzc2FnZUNoYW5uZWwgYW5kIE1l c3NhZ2VQb3J0IHN1cHBvcnQiIFBSSVZBVEUgT04pCisgICAgV0VCS0lUX09QVElPTl9ERUZJTkUo RU5BQkxFX0NPTkNVUlJFTlRfSklUICJFbmFibGUgQ29uY3VycmVudCBKSVQgY29tcGlsYXRpb24g c3VwcG9ydCIgUFJJVkFURSBPTikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ09O VEVOVF9GSUxURVJJTkcgIlRvZ2dsZSBjb250ZW50IGZpbHRlcmluZyBzdXBwb3J0IiBQUklWQVRF IE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RFRklORShFTkFCTEVfQ09OVEVYVF9NRU5VUyAiVG9n Z2xlIENvbnRleHQgTWVudSBzdXBwb3J0IiBQUklWQVRFIE9OKQogICAgIFdFQktJVF9PUFRJT05f REVGSU5FKEVOQUJMRV9DUkVERU5USUFMX1NUT1JBR0UgIlRvZ2dsZSBDcmVkZW50aWFsIFN0b3Jh Z2Ugc3VwcG9ydCIgUFJJVkFURSBPRkYpCkBAIC0yMTEsNiArMjEyLDcgQEAgbWFjcm8oV0VCS0lU X09QVElPTl9CRUdJTikKICAgICBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVfREZHX0pJVCBF TkFCTEVfSklUKQogICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9GVExfSklUIEVOQUJM RV9ERkdfSklUKQogICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9TQU1QTElOR19QUk9G SUxFUiBFTkFCTEVfSklUKQorICAgIFdFQktJVF9PUFRJT05fREVQRU5EKEVOQUJMRV9DT05DVVJS RU5UX0pJVCBFTkFCTEVfREZHX0pJVCkKICAgICBXRUJLSVRfT1BUSU9OX0RFUEVORChFTkFCTEVf TUVESUFfQ09OVFJPTFNfU0NSSVBUIEVOQUJMRV9WSURFTykKICAgICBXRUJLSVRfT1BUSU9OX0RF UEVORChFTkFCTEVfVklERU9fVFJBQ0sgRU5BQkxFX1ZJREVPKQogICAgIFdFQktJVF9PUFRJT05f REVQRU5EKEVOQUJMRV9UT1VDSF9TTElERVIgRU5BQkxFX1RPVUNIX0VWRU5UUykKZGlmZiAtLWdp dCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4NGYxYzA5ZDMyOWMyZWFiZjQ4MGE0NDM1 ODRhZGQ2ZWFlNjRlYjFlLi5iNDlhYTc4MGI4ZjIxMjU3NWQyOGQxYzUwODI5MDVkMjIyOGZlNmVh IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTYtMDQtMDcgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CisKKyAg ICAgICAgW0pTQ09ubHldIEVuYWJsZSBDb25jdXJyZW50IEpJVAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2MzQxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZm91bmQgdGhhdCBDb25jdXJyZW50IEpJ VCBjb21waWxhdGlvbiBpcyBkaXNhYmxlZCBpbiBKU0NPbmx5IGVudmlyb25tZW50CisgICAgICAg IHNpbmNlIFBsYXRmb3JtLmggZXhwbGljaXRseSBzcGVjaWZpZXMgdGhlIHBvcnRzIGVuYWJsaW5n IENvbmN1cnJlbnQgSklULgorCisgICAgICAgIEluc3RlYWQgb2YgYWRkaW5nIFBMQVRGT1JNKEpT Q09OTFkpLCB0aGlzIHBhdGNoIGFkZHMgYSBuZXcgV2ViS2l0IG9wdGlvbgorICAgICAgICBFTkFC TEVfQ09OQ1VSUkVOVF9KSVQgaW4gQ01ha2UuIEFuZCBlbmFibGUgaXQgYnkgZGVmYXVsdC4KKyAg ICAgICAgU2luY2UgV0lOLCBEQVJXSU4sIEdUSywgYW5kIEVGTCBhbHJlYWR5IGVuYWJsZSBpdCwg aXQgb25seSBhZmZlY3RzIEpTQ09ubHkgcG9ydC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9X ZWJLaXRGZWF0dXJlcy5jbWFrZToKKwogMjAxNi0wNC0wNiAgQWxleCBDaHJpc3RlbnNlbiAgPGFj aHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBDTWFrZSBEdW1wUmVuZGVyVHJl ZQo= 275924 2016-04-07 13:42:34 -0700 2016-04-07 13:43:01 -0700 Patch bug-156341-20160408054237.patch text/plain 1364 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDMwYWIwNjk0MTYyYmY3MTQyNDg5YTcw ZTM3NWI5Njk2NDlkNGE3YjEuLmJkMTI4OGI0MGU2ZWZkODEyMDc0ZmExNTg3ZTk5OWY3MWM5ZmQ0 M2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDQtMDcgIFl1c3VrZSBTdXp1a2kgIDx1dGF0 YW5lLnRlYUBnbWFpbC5jb20+CisKKyAgICAgICAgW0pTQ10gRW5hYmxlIENvbmN1cnJlbnQgSklU IGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NjM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIGVuYWJsZSBDb25jdXJyZW50IEpJVCBieSBkZWZhdWx0IHdoZW4gREZHIEpJVCBhbmQg SlNWQUxVRTY0IGFyZSBlbmFibGVkLgorICAgICAgICBUaGlzIGNoYW5nZSBvZmZlcnMgQ29uY3Vy cmVudCBKSVQgdG8gdGhlIEpTQ09ubHkgcG9ydC4KKworICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5o OgorCiAyMDE2LTA0LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAg ICAgSlNDIHNob3VsZCBoYXZlIGEgc2ltcGxlIHdheSBvZiBnYXRoZXJpbmcgSUMgc3RhdGlzdGlj cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9XVEYvd3Rm L1BsYXRmb3JtLmgKaW5kZXggZGQzZGMxZGRjMzEyOWJkODhlMWFhMTUxMDQ5ZDkzNDEyMTM0MjFi My4uMTY3OWIzNTZlNGQyNDQ2ZTVmZWMxNWJjZmJjMTlhNmMyMWJiNDhlMyAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o CkBAIC03NjQsNyArNzY0LDcgQEAKICAgIHZhbHVlcyBnZXQgc3RvcmVkIHRvIGF0b21pY2FsbHku IFRoaXMgaXMgdHJpdmlhbGx5IHRydWUgb24gNjQtYml0IHBsYXRmb3JtcywKICAgIGJ1dCBub3Qg dHJ1ZSBhdCBhbGwgb24gMzItYml0IHBsYXRmb3JtcyB3aGVyZSB2YWx1ZXMgYXJlIGNvbXBvc2Vk IG9mIHR3bwogICAgc2VwYXJhdGUgc3ViLXZhbHVlcy4gKi8KLSNpZiAoT1MoREFSV0lOKSB8fCBQ TEFURk9STShFRkwpIHx8IFBMQVRGT1JNKEdUSykgfHwgUExBVEZPUk0oV0lOKSkgJiYgRU5BQkxF KERGR19KSVQpICYmIFVTRShKU1ZBTFVFNjQpCisjaWYgRU5BQkxFKERGR19KSVQpICYmIFVTRShK U1ZBTFVFNjQpCiAjZGVmaW5lIEVOQUJMRV9DT05DVVJSRU5UX0pJVCAxCiAjZW5kaWYKIAo=