156339 2016-04-07 05:16:59 -0700 FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header is visible 2016-04-07 07:22:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned barraclough commit-queue jeffm kling sam simon.fraser webkit-bug-importer oldest_to_newest 1181646 0 koivisto 2016-04-07 05:16:59 -0700 FrameView::qualifiesAsVisuallyNonEmpty() returns false when loading a Google search results page before search results are loaded, even though the header at the top of the page has been rendered. Google's current design shows a 60 pixel high header almost instantly, with the actual search results coming in later. 1181647 1 koivisto 2016-04-07 05:17:37 -0700 <rdar://problem/24491381> 1181650 2 275884 koivisto 2016-04-07 05:22:58 -0700 Created attachment 275884 patch 1181659 3 275884 kling 2016-04-07 06:04:50 -0700 Comment on attachment 275884 patch Sweet hax. r=me 1181666 4 275884 commit-queue 2016-04-07 07:22:13 -0700 Comment on attachment 275884 patch Clearing flags on attachment: 275884 Committed r199155: <http://trac.webkit.org/changeset/199155> 1181667 5 commit-queue 2016-04-07 07:22:18 -0700 All reviewed patches have been landed. Closing bug. 275884 2016-04-07 05:22:58 -0700 2016-04-07 07:22:13 -0700 patch visually-non-empty-threshold-jeff.patch text/plain 1755 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTE1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA0LTA3ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBGcmFtZVZpZXc6OnF1YWxpZmll c0FzVmlzdWFsbHlOb25FbXB0eSgpIHJldHVybnMgZmFsc2Ugd2hlbiBsb2FkaW5nIGEgR29vZ2xl IHNlYXJjaCByZXN1bHRzIHBhZ2UgYmVmb3JlIHNlYXJjaCByZXN1bHRzIGFyZSBsb2FkZWQsIGV2 ZW4gdGhvdWdoIHRoZSBoZWFkZXIgaXMgdmlzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2MzM5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NDQ5MTM4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBQYXRjaCBieSBKZWZmIE1pbGxlci4KKworICAgICAgICBKZWZmJ3MgdGVzdGluZyBpbmRpY2F0 ZXMgbG93ZXJpbmcgdGhlIGRvY3VtZW50IGhlaWdodCB0aHJlc2hvbGQgaW1wcm92ZXMgdGhpbmdz IHZpc3VhbGx5IGR1cmluZyBwYWdlIGxvYWRpbmcuCisKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmll dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OnF1YWxpZmllc0FzVmlzdWFsbHlO b25FbXB0eSk6CisKKyAgICAgICAgICAgIExvd2VyIGRvY3VtZW50IGhlaWdodCB0aHJlc2hvbGQg dG8gZnJvbSAyMDAgdG8gNDggcGl4ZWxzLgorCiAyMDE2LTA0LTA3ICBBbnR0aSBLb2l2aXN0byAg PGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBTaGFkb3cgRE9NOiBJbXBsZW1lbnQgZGlzcGxh eTogY29udGVudHMgZm9yIHNsb3RzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmll dy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCShy ZXZpc2lvbiAxOTkwOTcpCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTQyNTcsNyArNDI1Nyw4IEBAIGJvb2wgRnJhbWVWaWV3OjpxdWFsaWZp ZXNBc1Zpc3VhbGx5Tm9uRW0KICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICAvLyBSZXF1aXJl IHRoZSBkb2N1bWVudCB0byBncm93IGEgYml0LgotICAgIHN0YXRpYyBjb25zdCBpbnQgZG9jdW1l bnRIZWlnaHRUaHJlc2hvbGQgPSAyMDA7CisgICAgLy8gVXNpbmcgYSB2YWx1ZSBvZiA0OCBhbGxv d3MgdGhlIGhlYWRlciBvbiBHb29nbGUncyBzZWFyY2ggcGFnZSB0byByZW5kZXIgaW1tZWRpYXRl bHkgYmVmb3JlIHNlYXJjaCByZXN1bHRzIHBvcHVsYXRlIGxhdGVyLgorICAgIHN0YXRpYyBjb25z dCBpbnQgZG9jdW1lbnRIZWlnaHRUaHJlc2hvbGQgPSA0ODsKICAgICBMYXlvdXRSZWN0IG92ZXJm bG93UmVjdCA9IGRvY3VtZW50RWxlbWVudC0+cmVuZGVyQm94KCktPmxheW91dE92ZXJmbG93UmVj dCgpOwogICAgIGlmIChzbmFwcGVkSW50UmVjdChvdmVyZmxvd1JlY3QpLmhlaWdodCgpIDwgZG9j dW1lbnRIZWlnaHRUaHJlc2hvbGQpCiAgICAgICAgIHJldHVybiBmYWxzZTsK