156338 2016-04-07 05:02:45 -0700 Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported 2016-04-12 07:56:09 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tpopela webkit-unassigned achristensen commit-queue dbates lforschler mcatanzaro webkit-bug-importer oldest_to_newest 1181642 0 tpopela 2016-04-07 05:02:45 -0700 When building from checkout on s390(x) or ppc(64) the build will fail as we are adding "-march=pentium4 -msse2 -mfpmath=sse " into CXXFLAGS in webkitdirs.pm. We need to avoid this step for these architectures. 1181643 1 275882 tpopela 2016-04-07 05:05:40 -0700 Created attachment 275882 Proposed patch 1181644 2 275882 mcatanzaro 2016-04-07 05:13:02 -0700 Comment on attachment 275882 Proposed patch I think it would be better to check for i[3,4,5,6]86 to decide whether to add those build flags, so that we don't need to grow this conditional for every imaginable arch. 1181648 3 275882 mcatanzaro 2016-04-07 05:20:31 -0700 Comment on attachment 275882 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=275882&action=review > Tools/Scripts/webkitdirs.pm:2019 > $ENV{'CXXFLAGS'} = "-march=pentium4 -msse2 -mfpmath=sse " . ($ENV{'CXXFLAGS'} || ""); Actually note that since it uses sse2, these flags only work on i686. 1181649 4 webkit-bug-importer 2016-04-07 05:21:51 -0700 <rdar://problem/25599643> 1181669 5 tpopela 2016-04-07 07:38:30 -0700 (In reply to comment #3) > Comment on attachment 275882 [details] > Proposed patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=275882&action=review > > > Tools/Scripts/webkitdirs.pm:2019 > > $ENV{'CXXFLAGS'} = "-march=pentium4 -msse2 -mfpmath=sse " . ($ENV{'CXXFLAGS'} || ""); > > Actually note that since it uses sse2, these flags only work on i686. So this would effectively leave us with: - if ($architecture ne "x86_64" && !isARM() && !isCrossCompilation() && !isAnyWindows()) { + if ($architecture eq "i686" && !isCrossCompilation() && !isAnyWindows()) { but I don't know whether this could break anything for Apple port. 1182442 6 achristensen 2016-04-08 23:09:54 -0700 I don't think this will cause a problem for the Mac cmake work. If it causes a problem we will fix it, but my initial cmake work is only for x86_64 1182566 7 mcatanzaro 2016-04-10 15:45:04 -0700 (In reply to comment #5) > So this would effectively leave us with: > > - if ($architecture ne "x86_64" && !isARM() && !isCrossCompilation() && > !isAnyWindows()) { > + if ($architecture eq "i686" && !isCrossCompilation() && > !isAnyWindows()) { > > but I don't know whether this could break anything for Apple port. Let's indeed go with this. If it unexpectedly breaks something, we can simply revert it and use your original patch instead. 1183021 8 276225 tpopela 2016-04-12 01:58:57 -0700 Created attachment 276225 Modify the CXXFLAGS just on i686 1183050 9 276225 commit-queue 2016-04-12 07:56:05 -0700 Comment on attachment 276225 Modify the CXXFLAGS just on i686 Clearing flags on attachment: 276225 Committed r199350: <http://trac.webkit.org/changeset/199350> 1183051 10 commit-queue 2016-04-12 07:56:09 -0700 All reviewed patches have been landed. Closing bug. 275882 2016-04-07 05:05:40 -0700 2016-04-12 01:58:48 -0700 Proposed patch bug-156338-20160407140541.patch text/plain 1871 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTY2Nzg1NDllZWQ3MWYxMmMxNTQ2NGZmNDg5NDM3NTM3 ZjgyZjRjNS4uNTU4MDY3MDE5MzIyNTI3YzEzZTg1MDYyODQxMjcyNjE2OGQxYTg0ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTA0LTA3ICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAg ICAgICAgQWRkIHN1cHBvcnQgZm9yIHMzOTAoeCkgYW5kIHBwYyg2NCkgaW50byB3ZWJraXRkaXJz LnBtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTYz MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEb24n dCB0cnkgdG8gYWRkIHRoZSAiLW1hcmNoPXBlbnRpdW00IC1tc3NlMiAtbWZwbWF0aD1zc2UgIiBm b3IKKyAgICAgICAgczM5MCh4KSBhbmQgcHBjKDY0KSBhcmNoZXMsIG90aGVyd2lzZSB0aGUgYnVp bGQgd2lsbCBmYWlsLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAg ICAoaXNQUEMpOgorICAgICAgICAoaXNTMzkwKToKKyAgICAgICAgKGdlbmVyYXRlQnVpbGRTeXN0 ZW1Gcm9tQ01ha2VQcm9qZWN0KToKKwogMjAxNi0wNC0wNiAgQ2hhbmdTZW9rIE9oICA8Y2hhbmdz ZW9rQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgVXBkYXRlIG15IHByaW1hcnkg ZW1haWwgYWRkcmVzcyBhbmQgZXhwZXJ0aXNlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGY3NjZhNzUz MTU5Nzc1ZGZmM2JlYTNlODdkMzVjMmE3YTBkZWZiZTguLjg3ZTMwMmExMTQyOWQ2MWY4YmJmNDk4 Y2EyYWIxMmQ3N2YyZDU5NjQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTEyMjAsNiArMTIyMCwxNSBA QCBzdWIgaXNBUk0oKQogewogICAgIHJldHVybiAoJENvbmZpZ3thcmNobmFtZX0gPX4gL15hcm1b dlwtXS8pIHx8ICgkQ29uZmlne2FyY2huYW1lfSA9fiAvXmFhcmNoNjRbdlwtXS8pOwogfQorc3Vi IGlzUFBDKCkKK3sKKyAgICByZXR1cm4gKCRDb25maWd7YXJjaG5hbWV9ID1+IC9ecHBjWzY0XS8p OworfQorCitzdWIgaXNTMzkwKCkKK3sKKyAgICByZXR1cm4gKCRDb25maWd7YXJjaG5hbWV9ID1+ IC9eczM5MFt4XS8pOworfQogCiBzdWIgaXNYODZfNjQoKQogewpAQCAtMjAwNiw3ICsyMDE1LDcg QEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQcm9qZWN0CiAgICAgIyBDb21waWxl ciBvcHRpb25zIHRvIGtlZXAgZmxvYXRpbmcgcG9pbnQgdmFsdWVzIGNvbnNpc3RlbnQKICAgICAj IGJldHdlZW4gMzItYml0IGFuZCA2NC1iaXQgYXJjaGl0ZWN0dXJlcy4KICAgICBkZXRlcm1pbmVB cmNoaXRlY3R1cmUoKTsKLSAgICBpZiAoJGFyY2hpdGVjdHVyZSBuZSAieDg2XzY0IiAmJiAhaXNB Uk0oKSAmJiAhaXNDcm9zc0NvbXBpbGF0aW9uKCkgJiYgIWlzQW55V2luZG93cygpKSB7CisgICAg aWYgKCRhcmNoaXRlY3R1cmUgbmUgIng4Nl82NCIgJiYgIWlzQVJNKCkgJiYgIWlzUFBDKCkgJiYg IWlzUzM5MCgpICYmICFpc0Nyb3NzQ29tcGlsYXRpb24oKSAmJiAhaXNBbnlXaW5kb3dzKCkpIHsK ICAgICAgICAgJEVOVnsnQ1hYRkxBR1MnfSA9ICItbWFyY2g9cGVudGl1bTQgLW1zc2UyIC1tZnBt YXRoPXNzZSAiIC4gKCRFTlZ7J0NYWEZMQUdTJ30gfHwgIiIpOwogICAgIH0KIAo= 276225 2016-04-12 01:58:57 -0700 2016-04-12 07:56:05 -0700 Modify the CXXFLAGS just on i686 bug-156338-20160412105905.patch text/plain 1651 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTY2Nzg1NDllZWQ3MWYxMmMxNTQ2NGZmNDg5NDM3NTM3 ZjgyZjRjNS4uNjdmMDNhYjdhMTBjMGFkZTlmNDhmNGI5Mzk3NzhiNDA4MTdmNWVjMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE2LTA0LTEyICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAg ICAgICAgTW9kaWZ5IHRoZSBDWFhGTEFHUyBpbiB3ZWJraXRkaXJzLnBtIGp1c3Qgb24gYXJjaGl0 ZWN0dXJlcyB3aGVyZSB0aGUgZmxhZ3MgYXJlIHN1cHBvcnRlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2MzM4CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIHRoZSAiLW1hcmNoPXBlbnRpdW00IC1t c3NlMiAtbWZwbWF0aD1zc2UgIiBpbnRvIHRoZSBDWFhGTEFHUyBqdXN0CisgICAgICAgIGZvciB0 aGUgaTY4NiB3aGVyZSBpdCBpcyBzdXBwb3J0ZWQgYW5kIG5vdCBmb3Igb3RoZXIgYXJjaGl0ZWN0 dXJlcworICAgICAgICAoc3VjaCBhcyBzMzkwKHgpIGFuZCBwcGMoNjQpKSB3aGVyZSB0aGUgYnVp bGQgd2lsbCBmYWlsIHdpdGggdGhlc2UKKyAgICAgICAgQ1hYRkxBR1MuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNN YWtlUHJvamVjdCk6CisKIDIwMTYtMDQtMDYgIENoYW5nU2VvayBPaCAgPGNoYW5nc2Vva0B3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIFVwZGF0ZSBteSBwcmltYXJ5IGVtYWlsIGFk ZHJlc3MgYW5kIGV4cGVydGlzZS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBmNzY2YTc1MzE1OTc3NWRm ZjNiZWEzZTg3ZDM1YzJhN2EwZGVmYmU4Li5hNmRkYTgxYzJmNmE2YzU4OTI0NjRmYzQ2ODM0YzM0 ODhjMjIzODNhIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC0yMDA2LDcgKzIwMDYsNyBAQCBzdWIgZ2Vu ZXJhdGVCdWlsZFN5c3RlbUZyb21DTWFrZVByb2plY3QKICAgICAjIENvbXBpbGVyIG9wdGlvbnMg dG8ga2VlcCBmbG9hdGluZyBwb2ludCB2YWx1ZXMgY29uc2lzdGVudAogICAgICMgYmV0d2VlbiAz Mi1iaXQgYW5kIDY0LWJpdCBhcmNoaXRlY3R1cmVzLgogICAgIGRldGVybWluZUFyY2hpdGVjdHVy ZSgpOwotICAgIGlmICgkYXJjaGl0ZWN0dXJlIG5lICJ4ODZfNjQiICYmICFpc0FSTSgpICYmICFp c0Nyb3NzQ29tcGlsYXRpb24oKSAmJiAhaXNBbnlXaW5kb3dzKCkpIHsKKyAgICBpZiAoJGFyY2hp dGVjdHVyZSBlcSAiaTY4NiIgJiYgIWlzQ3Jvc3NDb21waWxhdGlvbigpICYmICFpc0FueVdpbmRv d3MoKSkgewogICAgICAgICAkRU5WeydDWFhGTEFHUyd9ID0gIi1tYXJjaD1wZW50aXVtNCAtbXNz ZTIgLW1mcG1hdGg9c3NlICIgLiAoJEVOVnsnQ1hYRkxBR1MnfSB8fCAiIik7CiAgICAgfQogCg==