156332 2016-04-07 01:15:28 -0700 [CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again 2016-04-07 09:37:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii webkit-unassigned achristensen bfulgham cdumez commit-queue darin oldest_to_newest 1181608 0 fujii 2016-04-07 01:15:28 -0700 [CMake][Win] Generating autoversion.h of WebKitGUID is triggered again and again In Source/WebKit/PlatformWin.cmake: > add_custom_command( > OUTPUT ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h > WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} > COMMAND ${PERL_EXECUTABLE} ${WEBKIT_LIBRARIES_DIR}/tools/scripts/auto-version.pl ${DERIVED_SOURCES_WEBKIT_DIR} > VERBATIM) The output path is not ${DERIVED_SOURCES_WEBKIT_DIR}/autoversion.h, but ${DERIVED_SOURCES_WEBKIT_DIR}/include/autoversion.h. Then Visual Studio thinks the output file deos not exist yet and trigger the command. 1181610 1 275870 fujii 2016-04-07 01:33:45 -0700 Created attachment 275870 Patch 1181685 2 275870 bfulgham 2016-04-07 08:46:10 -0700 Comment on attachment 275870 Patch Oh! Thank you for noticing this. r=me. 1181691 3 achristensen 2016-04-07 09:03:47 -0700 Wow, I looked at this over and over again and couldn't see the problem. Thanks! 1181700 4 275870 commit-queue 2016-04-07 09:37:42 -0700 Comment on attachment 275870 Patch Clearing flags on attachment: 275870 Committed r199158: <http://trac.webkit.org/changeset/199158> 1181701 5 commit-queue 2016-04-07 09:37:46 -0700 All reviewed patches have been landed. Closing bug. 275870 2016-04-07 01:33:45 -0700 2016-04-07 09:37:42 -0700 Patch bug-156332-20160407173347.patch text/plain 1572 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMyYWZhNTY2MDU1ZDNlOTJk NDRmMzIzMjkyNGVmN2I3MDI0NzA4MzEuLjliMmRkYjVhODdlZDU3Y2Y2OTU0ZDAxZjA3MGI5ZDEx NjBmZmZkMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDQtMDcgIEZ1amlpIEhp cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAanAuc29ueS5jb20+CisKKyAgICAgICAgW0NNYWtlXVtX aW5dIEdlbmVyYXRpbmcgYXV0b3ZlcnNpb24uaCBvZiBXZWJLaXRHVUlEIGlzIHRyaWdnZXJlZCBh Z2FpbiBhbmQgYWdhaW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE1NjMzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogUGxhdGZvcm1XaW4uY21ha2U6CisgICAgICAgIENvcnJlY3QgdGhlIG91dHB1dCBw YXRoIG9mIGF1dG92ZXJzaW9uLmguCisKIDIwMTYtMDQtMDYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggQ01ha2UgRHVtcFJlbmRlclRy ZWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UgYi9Tb3VyY2Uv V2ViS2l0L1BsYXRmb3JtV2luLmNtYWtlCmluZGV4IGUwM2M5YjBiYjkxOWIzNjdmMDYyYjQ0YzU4 NDQyNjAwZWY3ZDA5NmQuLjIzODhkYzAzZjc0MWU2ZTJkYjUxY2UwMWJhMWI2NjJlMTFlZjc5MWMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm1XaW4uY21ha2UKKysrIGIvU291cmNl L1dlYktpdC9QbGF0Zm9ybVdpbi5jbWFrZQpAQCAtMzY2LDExICszNjYsMTEgQEAgc2V0KFdFQktJ VF9JRExfREVQRU5ERU5DSUVTCiAgICAgd2luL0ludGVyZmFjZXMvQWNjZXNzaWJsZTIvQWNjZXNz aWJsZVRleHQuaWRsCiAgICAgd2luL0ludGVyZmFjZXMvQWNjZXNzaWJsZTIvQWNjZXNzaWJsZVRl eHQyLmlkbAogICAgIHdpbi9JbnRlcmZhY2VzL0FjY2Vzc2libGUyL0lBMkNvbW1vblR5cGVzLmlk bAotICAgICIke0RFUklWRURfU09VUkNFU19XRUJLSVRfRElSfS9hdXRvdmVyc2lvbi5oIgorICAg ICIke0RFUklWRURfU09VUkNFU19XRUJLSVRfRElSfS9pbmNsdWRlL2F1dG92ZXJzaW9uLmgiCiAp CiAKIGFkZF9jdXN0b21fY29tbWFuZCgKLSAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfV0VC S0lUX0RJUn0vYXV0b3ZlcnNpb24uaAorICAgIE9VVFBVVCAke0RFUklWRURfU09VUkNFU19XRUJL SVRfRElSfS9pbmNsdWRlL2F1dG92ZXJzaW9uLmgKICAgICBXT1JLSU5HX0RJUkVDVE9SWSAke0NN QUtFX1NPVVJDRV9ESVJ9CiAgICAgQ09NTUFORCAke1BFUkxfRVhFQ1VUQUJMRX0gJHtXRUJLSVRf TElCUkFSSUVTX0RJUn0vdG9vbHMvc2NyaXB0cy9hdXRvLXZlcnNpb24ucGwgJHtERVJJVkVEX1NP VVJDRVNfV0VCS0lUX0RJUn0KICAgICBWRVJCQVRJTSkK