156325 2016-04-06 18:00:35 -0700 Page tiles are missing when graphics acceleration is unavailable 2016-04-06 18:47:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser benjamin cdumez cmarcelo commit-queue simon.fraser oldest_to_newest 1181497 0 simon.fraser 2016-04-06 18:00:35 -0700 Page tiles are missing when graphics acceleration is unavailable 1181498 1 275840 simon.fraser 2016-04-06 18:03:56 -0700 Created attachment 275840 Patch 1181499 2 275840 thorton 2016-04-06 18:06:35 -0700 Comment on attachment 275840 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275840&action=review > Source/WebCore/platform/graphics/ca/TileController.cpp:504 > + // IOSurface::maximumSize() can return { INT_MAX, INT_MAX } when hardware acceleration is unavailable, so clamp to a reasonable value. > + const int kMaxAllowableTileSize = 32 * 1024; > + surfaceSizeLimit = surfaceSizeLimit.shrunkTo({ kMaxAllowableTileSize, kMaxAllowableTileSize }); I wonder if we can make it so that the IOSurface wrapper makes it harder to get this wrong, instead of depending on callers to do work to get it right. 1181510 3 simon.fraser 2016-04-06 18:21:20 -0700 https://trac.webkit.org/r199130 1181518 4 simon.fraser 2016-04-06 18:47:15 -0700 Windows build fix in https://trac.webkit.org/r199133 275840 2016-04-06 18:03:56 -0700 2016-04-06 18:06:35 -0700 Patch bug-156325-20160406180358.patch text/plain 6262 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDU3Y2ZlY2JlNGQ3OTVmZGZmOGY0NDZh NGY2NTU5ZGQyYWZlYWI0Y2IuLmQ5NWIzZGViMDM2NTJmZTliYzQ4NTY3NzdkMjlhY2VhNTliOWM3 YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDQtMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUGFnZSB0aWxlcyBhcmUgbWlzc2luZyB3aGVu IGdyYXBoaWNzIGFjY2VsZXJhdGlvbiBpcyB1bmF2YWlsYWJsZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2MzI1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvTWF0aEV4dHJhcy5oOgorICAgICAg ICAoY2xhbXBUb0ludGVnZXIpOgorCiAyMDE2LTA0LTA1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBvcGVyYXRvcj09IGFuZCBvcGVy YXRvciE9IGZvciBPcHRpb25hbDw+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDgyMWU5YWVlMzgwMjU1NzliY2Rj N2E2MmY1NDcyYTk0NDllZmVjNS4uNTYxM2ZjZDQzNGZlNjM1YWNjNzVjZGI5NzNjYTEyNjNlYjI4 YTRkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDMwIEBACiAyMDE2LTA0LTA2ICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCisgICAgICAgIFBhZ2UgdGlsZXMgYXJlIG1p c3Npbmcgd2hlbiBncmFwaGljcyBhY2NlbGVyYXRpb24gaXMgdW5hdmFpbGFibGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjMyNQorICAgICAgICBy ZGFyOi8vcHJvYmxlbS8yNTU4NzQ3NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdoZW4gZ3JhcGhpY3MgYWNjZWxlcmF0aW9uIGlzIHVuYXZhaWxhYmxl IG9uIE1hYyAoZS5nLiBpbiBhIFZNIG9yIHdoZW4gcnVubmluZyBmcm9tCisgICAgICAgIHRoZSBy ZWNvdmVyeSBwYXJ0aXRpb24pLCBwYWdlIGNvbnRlbnRzIHdlcmUgbWlzc2luZy4gVGhpcyBpcyBi ZWNhdXNlCisgICAgICAgIElPU3VyZmFjZUdldFByb3BlcnR5TWF4aW11bShrSU9TdXJmYWNlV2lk dGgpIGFuZCBJT1N1cmZhY2VHZXRQcm9wZXJ0eU1heGltdW0oa0lPU3VyZmFjZUhlaWdodCkKKyAg ICAgICAgcmV0dXJuZWQgSU5UX01BWCwgY2F1c2luZyB1cyB0byBjb21wdXRlIGEgdGlsZSBzaXpl IG9mIDB4MC4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSBjbGFtcGluZyB0byBhIG1heCB0aWxl IHNpemUgb2YgMzJLIHggMzJLIGFuZCBpZ25vcmluZyBhIHJlcG9ydGVkIGxpbWl0IG9mIHsgMCwg MCB9LgorICAgICAgICAKKyAgICAgICAgUmVuYW1lIGtHaWFudFRpbGVTaXplIHRvIGJldHRlciBk ZXNjcmliZSBpdHMgcHVycG9zZS4KKyAgICAgICAgCisgICAgICAgIEFkZCBjb3JyZWN0IGNsYW1w aW5nIGluIElPU3VyZmFjZTo6bWF4aW11bVNpemUoKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2NhL1RpbGVDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRpbGVDb250 cm9sbGVyOjp0aWxlU2l6ZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUNv bnRyb2xsZXIuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZhY2Uu bW06CisgICAgICAgIChJT1N1cmZhY2U6Om1heGltdW1TaXplKToKKworMjAxNi0wNC0wNiAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBBdm9pZCB1c2lu ZyBhbiB1bmVuZ2FnZWQgT3B0aW9uYWw8RmxvYXRSZWN0PiB3aGVuIHBvc2l0aW9uaW5nIHRoZSB0 aWxlZCBzY3JvbGxpbmcgaW5kaWNhdG9yCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTYzMTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvTWF0 aEV4dHJhcy5oIGIvU291cmNlL1dURi93dGYvTWF0aEV4dHJhcy5oCmluZGV4IGU0Mzk5ZjhiNTlh YmY0ZGNkYjYwMGE0M2RiOGQ2OGRlYmUxZjgyMTYuLmM1YmYyNWNkMzk4NDM0ZDA1YjFmNWU2MzEy OGVhOTA1OGM1MGQ4ZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01hdGhFeHRyYXMuaAor KysgYi9Tb3VyY2UvV1RGL3d0Zi9NYXRoRXh0cmFzLmgKQEAgLTE5MCw2ICsxOTAsMTUgQEAgaW5s aW5lIGludCBjbGFtcFRvSW50ZWdlcih1bnNpZ25lZCB4KQogICAgIHJldHVybiBzdGF0aWNfY2Fz dDxpbnQ+KHgpOwogfQogCitpbmxpbmUgaW50IGNsYW1wVG9JbnRlZ2VyKHNpemVfdCB4KQorewor ICAgIGNvbnN0IHNpemVfdCBpbnRNYXggPSBzdGF0aWNfY2FzdDxzaXplX3Q+KHN0ZDo6bnVtZXJp Y19saW1pdHM8aW50Pjo6bWF4KCkpOworCisgICAgaWYgKHggPj0gaW50TWF4KQorICAgICAgICBy ZXR1cm4gc3RkOjpudW1lcmljX2xpbWl0czxpbnQ+OjptYXgoKTsKKyAgICByZXR1cm4gc3RhdGlj X2Nhc3Q8aW50Pih4KTsKK30KKwogaW5saW5lIGJvb2wgaXNXaXRoaW5JbnRSYW5nZShmbG9hdCB4 KQogewogICAgIHJldHVybiB4ID4gc3RhdGljX2Nhc3Q8ZmxvYXQ+KHN0ZDo6bnVtZXJpY19saW1p dHM8aW50Pjo6bWluKCkpICYmIHggPCBzdGF0aWNfY2FzdDxmbG9hdD4oc3RkOjpudW1lcmljX2xp bWl0czxpbnQ+OjptYXgoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYS9UaWxlQ29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYS9UaWxlQ29udHJvbGxlci5jcHAKaW5kZXggNGRmNmVmYmU0MDFjMzZlNDQyZDVj ZWM1ZGU3MTNjZWViZDQyYmMxZC4uNDQ4OTQxNDg2N2ZmYTJlNzU5MmJkMjQyZGRmNDZhZGRkYjFi MzdhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGls ZUNvbnRyb2xsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nh L1RpbGVDb250cm9sbGVyLmNwcApAQCAtNDkzLDExICs0OTMsMjAgQEAgSW50U2l6ZSBUaWxlQ29u dHJvbGxlcjo6dGlsZVNpemUoKSBjb25zdAogICAgIGlmIChtX2luTGl2ZVJlc2l6ZSB8fCBtX3Rp bGVTaXplTG9ja2VkKQogICAgICAgICByZXR1cm4gdGlsZUdyaWQoKS50aWxlU2l6ZSgpOwogCi0g ICAgSW50U2l6ZSBtYXhUaWxlU2l6ZShrR2lhbnRUaWxlU2l6ZSwga0dpYW50VGlsZVNpemUpOwor ICAgIGNvbnN0IGludCBrTG93ZXN0Q29tbW9uRGVub21pbmF0b3JNYXhUaWxlU2l6ZSA9IDQgKiAx MDI0OworICAgIEludFNpemUgbWF4VGlsZVNpemUoa0xvd2VzdENvbW1vbkRlbm9taW5hdG9yTWF4 VGlsZVNpemUsIGtMb3dlc3RDb21tb25EZW5vbWluYXRvck1heFRpbGVTaXplKTsKKwogI2lmIFVT RShJT1NVUkZBQ0UpCiAgICAgSW50U2l6ZSBzdXJmYWNlU2l6ZUxpbWl0ID0gSU9TdXJmYWNlOjpt YXhpbXVtU2l6ZSgpOwotICAgIHN1cmZhY2VTaXplTGltaXQuc2NhbGUoMSAvIG1fZGV2aWNlU2Nh bGVGYWN0b3IpOwotICAgIG1heFRpbGVTaXplID0gbWF4VGlsZVNpemUuc2hydW5rVG8oc3VyZmFj ZVNpemVMaW1pdCk7CisgICAgCisgICAgLy8gSU9TdXJmYWNlOjptYXhpbXVtU2l6ZSgpIGNhbiBy ZXR1cm4geyBJTlRfTUFYLCBJTlRfTUFYIH0gd2hlbiBoYXJkd2FyZSBhY2NlbGVyYXRpb24gaXMg dW5hdmFpbGFibGUsIHNvIGNsYW1wIHRvIGEgcmVhc29uYWJsZSB2YWx1ZS4KKyAgICBjb25zdCBp bnQga01heEFsbG93YWJsZVRpbGVTaXplID0gMzIgKiAxMDI0OworICAgIHN1cmZhY2VTaXplTGlt aXQgPSBzdXJmYWNlU2l6ZUxpbWl0LnNocnVua1RvKHsga01heEFsbG93YWJsZVRpbGVTaXplLCBr TWF4QWxsb3dhYmxlVGlsZVNpemUgfSk7CisgICAgCisgICAgaWYgKCFzdXJmYWNlU2l6ZUxpbWl0 LmlzWmVybygpKSB7CisgICAgICAgIHN1cmZhY2VTaXplTGltaXQuc2NhbGUoMSAvIG1fZGV2aWNl U2NhbGVGYWN0b3IpOworICAgICAgICBtYXhUaWxlU2l6ZSA9IG1heFRpbGVTaXplLnNocnVua1Rv KHN1cmZhY2VTaXplTGltaXQpOworICAgIH0KICNlbmRpZgogICAgIAogICAgIGlmIChvd25pbmdH cmFwaGljc0xheWVyKCktPnBsYXRmb3JtQ0FMYXllclVzZUdpYW50VGlsZXMoKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL1RpbGVDb250cm9sbGVyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9UaWxlQ29udHJvbGxlci5oCmlu ZGV4IGEyMWEwYmI3YjcwMGNjZDQxNmRlY2NhMGJlMjM0NWY1NjUxMzRjMmYuLmQxYTI0Y2ViNGVl MzFlMmVhOTQ0MzgzNTYxNDgxY2Q0Yzg2ZjQyMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2NhL1RpbGVDb250cm9sbGVyLmgKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2EvVGlsZUNvbnRyb2xsZXIuaApAQCAtNDksOSArNDksNiBA QCBjbGFzcyBUaWxlR3JpZDsKIHR5cGVkZWYgVmVjdG9yPFJldGFpblB0cjxQbGF0Zm9ybUxheWVy Pj4gUGxhdGZvcm1MYXllckxpc3Q7CiAKIGNvbnN0IGludCBrRGVmYXVsdFRpbGVTaXplID0gNTEy OwotLy8gVGhpcyBpcyBhbiBleHBlcmltZW50YWwgdmFsdWUgZm9yIGRlYnVnZ2luZyBhbmQgZXZh bHVhdGluZyB0aGUgb3ZlcmhlYWQgd2hpY2ggbWF5IGJlCi0vLyBpbmN1cnJlZCBkdWUgdG8gYSBs YXJnZSB0aWxlIHNpemUuCi1jb25zdCBpbnQga0dpYW50VGlsZVNpemUgPSA0MDk2OwogCiBjbGFz cyBUaWxlQ29udHJvbGxlciBmaW5hbCA6IHB1YmxpYyBUaWxlZEJhY2tpbmcgewogICAgIFdURl9N QUtFX05PTkNPUFlBQkxFKFRpbGVDb250cm9sbGVyKTsgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1 cmZhY2UubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9JT1N1cmZh Y2UubW0KaW5kZXggZDZkOTc4MGQ1MDVkZmZkMWRjZDllNjU4MmZiNjNlNzJjM2IzMzNjNi4uMjFl ZTVjNmNkMzI5YzhhNjcwOThlZjI1ZTU0MGE4Yjk0MTBiOTRjMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvSU9TdXJmYWNlLm1tCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NvY29hL0lPU3VyZmFjZS5tbQpAQCAtMzYsNiAr MzYsNyBAQAogI2ltcG9ydCAiSW1hZ2VCdWZmZXJEYXRhQ0cuaCIKICNpbXBvcnQgIk1hY2hTZW5k UmlnaHQuaCIKICNpbXBvcnQgPHd0Zi9Bc3NlcnRpb25zLmg+CisjaW1wb3J0IDx3dGYvTWF0aEV4 dHJhcy5oPgogCiAjaWYgUExBVEZPUk0oSU9TKQogLy8gTW92ZSB0aGlzIGludG8gdGhlIFNQSSBo ZWFkZXIgb25jZSBpdCdzIHBvc3NpYmxlIHRvIHB1dCBpbnNpZGUgdGhlIEFQUExFX0lOVEVSTkFM X1NESyBibG9jay4KQEAgLTIzOSw3ICsyNDAsNyBAQCBJT1N1cmZhY2U6OklPU3VyZmFjZShJT1N1 cmZhY2VSZWYgc3VyZmFjZSwgQ29sb3JTcGFjZSBjb2xvclNwYWNlKQogCiBJbnRTaXplIElPU3Vy ZmFjZTo6bWF4aW11bVNpemUoKQogewotICAgIEludFNpemUgbWF4U2l6ZShJT1N1cmZhY2VHZXRQ cm9wZXJ0eU1heGltdW0oa0lPU3VyZmFjZVdpZHRoKSwgSU9TdXJmYWNlR2V0UHJvcGVydHlNYXhp bXVtKGtJT1N1cmZhY2VIZWlnaHQpKTsKKyAgICBJbnRTaXplIG1heFNpemUoY2xhbXBUb0ludGVn ZXIoSU9TdXJmYWNlR2V0UHJvcGVydHlNYXhpbXVtKGtJT1N1cmZhY2VXaWR0aCkpLCBjbGFtcFRv SW50ZWdlcihJT1N1cmZhY2VHZXRQcm9wZXJ0eU1heGltdW0oa0lPU3VyZmFjZUhlaWdodCkpKTsK ICNpZiBQTEFURk9STShJT1MpCiAgICAgLy8gTWF0Y2ggbGltaXRzIGltcG9zZWQgYnkgQ0EuIEZJ WE1FOiBzaG91bGQgaGF2ZSBBUEkgZm9yIHRoaXMgPHJkYXI6Ly9wcm9ibGVtLzI1NDU0MTQ4Pgog ICAgIGNvbnN0IGludCBpT1NNYXhTdXJmYWNlRGltZW5zaW9uID0gOCAqIDEwMjQ7Cg==