156297 2016-04-06 11:20:02 -0700 Add ASSERT_WITH_SECURITY_IMPLICATION when a float box is referenced by multiple RootInlineBoxes. 2016-04-06 13:04:03 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser webkit-bug-importer oldest_to_newest 1181304 0 zalan 2016-04-06 11:20:02 -0700 SSIA. 1181306 1 275787 zalan 2016-04-06 11:22:56 -0700 Created attachment 275787 Patch 1181307 2 webkit-bug-importer 2016-04-06 11:24:01 -0700 <rdar://problem/25580844> 1181311 3 275789 zalan 2016-04-06 11:26:44 -0700 Created attachment 275789 Patch 1181354 4 275789 bfulgham 2016-04-06 12:08:59 -0700 Comment on attachment 275789 Patch r=me. 1181379 5 275789 commit-queue 2016-04-06 13:04:00 -0700 Comment on attachment 275789 Patch Clearing flags on attachment: 275789 Committed r199113: <http://trac.webkit.org/changeset/199113> 1181380 6 commit-queue 2016-04-06 13:04:03 -0700 All reviewed patches have been landed. Closing bug. 275787 2016-04-06 11:22:56 -0700 2016-04-06 11:23:16 -0700 Patch bug-156297-20160406112258.patch text/plain 3353 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNjMjRjZWQ0ZjU2NTQy Njg5NmYzZTI5ZDc1N2U2MzJhMmE4NGJhYy4uMDIzOTgzZjk2MjgxZWQ0YTI0OGY4NmM0MzY3NDE0 YTQwNjYxOTRkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA0LTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEFTU0VSVF9XSVRIX1NF Q1VSSVRZX0lNUExJQ0FUSU9OIHdoZW4gYSBmbG9hdCBib3ggaXMgcmVmZXJlbmNlZCBieSBtdWx0 aXBsZSBSb290SW5saW5lQm94ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTYyOTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTZWUgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTk5MTAx CisKKyAgICAgICAgTm8gY2hhbmdlIGluIGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckJsb2NrRmxvdzo6YXBwZW5kRmxvYXRpbmdPYmplY3RUb0xhc3RMaW5lKToKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6cmVhdHRhY2hDbGVhbkxpbmVGbG9hdHMpOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjpkZXRlcm1pbmVTdGFydFBvc2l0aW9uKToKKwog MjAxNi0wNC0wNiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBD UkFTSCBpbiAtW1dlYkNvcmVOU1VSTFNlc3Npb24gdGFza0NvbXBsZXRlZDpdCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tMaW5lTGF5b3V0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCmluZGV4IGJj M2QxZmMwZjNjNDVkNWU1ZWU2YTA3MWRiNDZmY2Q5ZWE2ZDZjY2EuLjMxYzBlYzU0MzNiYTExOTk5 ZTlhZWU1YzBjYjc1YzZmMWE1NTU0ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCkBAIC0xMDYwLDcgKzEwNjAsNyBAQCBpbmxp bmUgQmlkaVJ1biogUmVuZGVyQmxvY2tGbG93OjpoYW5kbGVUcmFpbGluZ1NwYWNlcyhCaWRpUnVu TGlzdDxCaWRpUnVuPiYgYmlkaQogCiB2b2lkIFJlbmRlckJsb2NrRmxvdzo6YXBwZW5kRmxvYXRp bmdPYmplY3RUb0xhc3RMaW5lKEZsb2F0aW5nT2JqZWN0KiBmbG9hdGluZ09iamVjdCkKIHsKLSAg ICBBU1NFUlQoIWZsb2F0aW5nT2JqZWN0LT5vcmlnaW5hdGluZ0xpbmUoKSk7CisgICAgQVNTRVJU X1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIWZsb2F0aW5nT2JqZWN0LT5vcmlnaW5hdGluZ0xp bmUoKSk7CiAgICAgZmxvYXRpbmdPYmplY3QtPnNldE9yaWdpbmF0aW5nTGluZShsYXN0Um9vdEJv eCgpKTsKICAgICBsYXN0Um9vdEJveCgpLT5hcHBlbmRGbG9hdChmbG9hdGluZ09iamVjdC0+cmVu ZGVyZXIoKSk7CiB9CkBAIC0xNTMxLDExICsxNTMxLDExIEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93 OjpyZWF0dGFjaENsZWFuTGluZUZsb2F0cyhSb290SW5saW5lQm94JiBjbGVhbkxpbmUsIExheW91 dFVuCiAgICAgICAgIGF1dG8qIGZsb2F0aW5nT2JqZWN0ID0gaW5zZXJ0RmxvYXRpbmdPYmplY3Qo KmZsb2F0aW5nQm94KTsKICAgICAgICAgaWYgKGlzRmlyc3RDbGVhbkxpbmUgJiYgZmxvYXRpbmdP YmplY3QtPm9yaWdpbmF0aW5nTGluZSgpKSB7CiAgICAgICAgICAgICAvLyBGbG9hdCBib3ggZG9l cyBub3QgYmVsb25nIHRvIHRoaXMgbGluZSBhbnltb3JlLgotICAgICAgICAgICAgQVNTRVJUKGNs ZWFuTGluZS5wcmV2Um9vdEJveCgpID09IGZsb2F0aW5nT2JqZWN0LT5vcmlnaW5hdGluZ0xpbmUo KSk7CisgICAgICAgICAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNBVElPTihjbGVhbkxp bmUucHJldlJvb3RCb3goKSA9PSBmbG9hdGluZ09iamVjdC0+b3JpZ2luYXRpbmdMaW5lKCkpOwog ICAgICAgICAgICAgY2xlYW5MaW5lLnJlbW92ZUZsb2F0KCpmbG9hdGluZ0JveCk7CiAgICAgICAg ICAgICBjb250aW51ZTsKICAgICAgICAgfQotICAgICAgICBBU1NFUlQoIWZsb2F0aW5nT2JqZWN0 LT5vcmlnaW5hdGluZ0xpbmUoKSk7CisgICAgICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJ Q0FUSU9OKCFmbG9hdGluZ09iamVjdC0+b3JpZ2luYXRpbmdMaW5lKCkpOwogICAgICAgICBmbG9h dGluZ09iamVjdC0+c2V0T3JpZ2luYXRpbmdMaW5lKCZjbGVhbkxpbmUpOwogICAgICAgICBzZXRM b2dpY2FsSGVpZ2h0KGxvZ2ljYWxUb3BGb3JDaGlsZCgqZmxvYXRpbmdCb3gpIC0gbWFyZ2luQmVm b3JlRm9yQ2hpbGQoKmZsb2F0aW5nQm94KSArIGRlbHRhKTsKICAgICAgICAgcG9zaXRpb25OZXdG bG9hdHMoKTsKQEAgLTE4NTksNyArMTg1OSw3IEBAIFJvb3RJbmxpbmVCb3gqIFJlbmRlckJsb2Nr Rmxvdzo6ZGV0ZXJtaW5lU3RhcnRQb3NpdGlvbihMaW5lTGF5b3V0U3RhdGUmIGxheW91dFN0CiAg ICAgICAgICAgICAgICAgZm9yIChhdXRvIGl0ID0gY2xlYW5MaW5lRmxvYXRzLT5iZWdpbigpLCBl bmQgPSBjbGVhbkxpbmVGbG9hdHMtPmVuZCgpOyBpdCAhPSBlbmQ7ICsraXQpIHsKICAgICAgICAg ICAgICAgICAgICAgUmVuZGVyQm94KiBmbG9hdGluZ0JveCA9ICppdDsKICAgICAgICAgICAgICAg ICAgICAgRmxvYXRpbmdPYmplY3QqIGZsb2F0aW5nT2JqZWN0ID0gaW5zZXJ0RmxvYXRpbmdPYmpl Y3QoKmZsb2F0aW5nQm94KTsKLSAgICAgICAgICAgICAgICAgICAgQVNTRVJUKCFmbG9hdGluZ09i amVjdC0+b3JpZ2luYXRpbmdMaW5lKCkpOworICAgICAgICAgICAgICAgICAgICBBU1NFUlRfV0lU SF9TRUNVUklUWV9JTVBMSUNBVElPTighZmxvYXRpbmdPYmplY3QtPm9yaWdpbmF0aW5nTGluZSgp KTsKICAgICAgICAgICAgICAgICAgICAgZmxvYXRpbmdPYmplY3QtPnNldE9yaWdpbmF0aW5nTGlu ZShsaW5lKTsKICAgICAgICAgICAgICAgICAgICAgc2V0TG9naWNhbEhlaWdodChsb2dpY2FsVG9w Rm9yQ2hpbGQoKmZsb2F0aW5nQm94KSAtIG1hcmdpbkJlZm9yZUZvckNoaWxkKCpmbG9hdGluZ0Jv eCkpOwogICAgICAgICAgICAgICAgICAgICBwb3NpdGlvbk5ld0Zsb2F0cygpOwo= 275789 2016-04-06 11:26:44 -0700 2016-04-06 13:04:00 -0700 Patch bug-156297-20160406112646.patch text/plain 3388 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNjMjRjZWQ0ZjU2NTQy Njg5NmYzZTI5ZDc1N2U2MzJhMmE4NGJhYy4uNjU4NjBhMWZmMDhmMjI4YmZmZTM0OTUxOTQzOTE5 MDQxZGU0MTI0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA0LTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIEFTU0VSVF9XSVRIX1NF Q1VSSVRZX0lNUExJQ0FUSU9OIHdoZW4gYSBmbG9hdCBib3ggaXMgcmVmZXJlbmNlZCBieSBtdWx0 aXBsZSBSb290SW5saW5lQm94ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTYyOTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1NTgwODQ0Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNlZSBodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8xOTkxMDEKKworICAgICAgICBObyBjaGFuZ2Ug aW4gZnVuY3Rpb25hbGl0eS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVM YXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93OjphcHBlbmRGbG9h dGluZ09iamVjdFRvTGFzdExpbmUpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tGbG93 OjpyZWF0dGFjaENsZWFuTGluZUZsb2F0cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9j a0Zsb3c6OmRldGVybWluZVN0YXJ0UG9zaXRpb24pOgorCiAyMDE2LTA0LTA2ICBKZXIgTm9ibGUg IDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIENSQVNIIGluIC1bV2ViQ29yZU5TVVJM U2Vzc2lvbiB0YXNrQ29tcGxldGVkOl0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrTGluZUxheW91dC5jcHAKaW5kZXggYmMzZDFmYzBmM2M0NWQ1ZTVlZTZhMDcx ZGI0NmZjZDllYTZkNmNjYS4uMzFjMGVjNTQzM2JhMTE5OTllOWFlZTVjMGNiNzVjNmYxYTU1NTQ4 MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxh eW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrTGluZUxh eW91dC5jcHAKQEAgLTEwNjAsNyArMTA2MCw3IEBAIGlubGluZSBCaWRpUnVuKiBSZW5kZXJCbG9j a0Zsb3c6OmhhbmRsZVRyYWlsaW5nU3BhY2VzKEJpZGlSdW5MaXN0PEJpZGlSdW4+JiBiaWRpCiAK IHZvaWQgUmVuZGVyQmxvY2tGbG93OjphcHBlbmRGbG9hdGluZ09iamVjdFRvTGFzdExpbmUoRmxv YXRpbmdPYmplY3QqIGZsb2F0aW5nT2JqZWN0KQogewotICAgIEFTU0VSVCghZmxvYXRpbmdPYmpl Y3QtPm9yaWdpbmF0aW5nTGluZSgpKTsKKyAgICBBU1NFUlRfV0lUSF9TRUNVUklUWV9JTVBMSUNB VElPTighZmxvYXRpbmdPYmplY3QtPm9yaWdpbmF0aW5nTGluZSgpKTsKICAgICBmbG9hdGluZ09i amVjdC0+c2V0T3JpZ2luYXRpbmdMaW5lKGxhc3RSb290Qm94KCkpOwogICAgIGxhc3RSb290Qm94 KCktPmFwcGVuZEZsb2F0KGZsb2F0aW5nT2JqZWN0LT5yZW5kZXJlcigpKTsKIH0KQEAgLTE1MzEs MTEgKzE1MzEsMTEgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OnJlYXR0YWNoQ2xlYW5MaW5lRmxv YXRzKFJvb3RJbmxpbmVCb3gmIGNsZWFuTGluZSwgTGF5b3V0VW4KICAgICAgICAgYXV0byogZmxv YXRpbmdPYmplY3QgPSBpbnNlcnRGbG9hdGluZ09iamVjdCgqZmxvYXRpbmdCb3gpOwogICAgICAg ICBpZiAoaXNGaXJzdENsZWFuTGluZSAmJiBmbG9hdGluZ09iamVjdC0+b3JpZ2luYXRpbmdMaW5l KCkpIHsKICAgICAgICAgICAgIC8vIEZsb2F0IGJveCBkb2VzIG5vdCBiZWxvbmcgdG8gdGhpcyBs aW5lIGFueW1vcmUuCi0gICAgICAgICAgICBBU1NFUlQoY2xlYW5MaW5lLnByZXZSb290Qm94KCkg PT0gZmxvYXRpbmdPYmplY3QtPm9yaWdpbmF0aW5nTGluZSgpKTsKKyAgICAgICAgICAgIEFTU0VS VF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKGNsZWFuTGluZS5wcmV2Um9vdEJveCgpID09IGZs b2F0aW5nT2JqZWN0LT5vcmlnaW5hdGluZ0xpbmUoKSk7CiAgICAgICAgICAgICBjbGVhbkxpbmUu cmVtb3ZlRmxvYXQoKmZsb2F0aW5nQm94KTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICB9Ci0gICAgICAgIEFTU0VSVCghZmxvYXRpbmdPYmplY3QtPm9yaWdpbmF0aW5nTGluZSgpKTsK KyAgICAgICAgQVNTRVJUX1dJVEhfU0VDVVJJVFlfSU1QTElDQVRJT04oIWZsb2F0aW5nT2JqZWN0 LT5vcmlnaW5hdGluZ0xpbmUoKSk7CiAgICAgICAgIGZsb2F0aW5nT2JqZWN0LT5zZXRPcmlnaW5h dGluZ0xpbmUoJmNsZWFuTGluZSk7CiAgICAgICAgIHNldExvZ2ljYWxIZWlnaHQobG9naWNhbFRv cEZvckNoaWxkKCpmbG9hdGluZ0JveCkgLSBtYXJnaW5CZWZvcmVGb3JDaGlsZCgqZmxvYXRpbmdC b3gpICsgZGVsdGEpOwogICAgICAgICBwb3NpdGlvbk5ld0Zsb2F0cygpOwpAQCAtMTg1OSw3ICsx ODU5LDcgQEAgUm9vdElubGluZUJveCogUmVuZGVyQmxvY2tGbG93OjpkZXRlcm1pbmVTdGFydFBv c2l0aW9uKExpbmVMYXlvdXRTdGF0ZSYgbGF5b3V0U3QKICAgICAgICAgICAgICAgICBmb3IgKGF1 dG8gaXQgPSBjbGVhbkxpbmVGbG9hdHMtPmJlZ2luKCksIGVuZCA9IGNsZWFuTGluZUZsb2F0cy0+ ZW5kKCk7IGl0ICE9IGVuZDsgKytpdCkgewogICAgICAgICAgICAgICAgICAgICBSZW5kZXJCb3gq IGZsb2F0aW5nQm94ID0gKml0OwogICAgICAgICAgICAgICAgICAgICBGbG9hdGluZ09iamVjdCog ZmxvYXRpbmdPYmplY3QgPSBpbnNlcnRGbG9hdGluZ09iamVjdCgqZmxvYXRpbmdCb3gpOwotICAg ICAgICAgICAgICAgICAgICBBU1NFUlQoIWZsb2F0aW5nT2JqZWN0LT5vcmlnaW5hdGluZ0xpbmUo KSk7CisgICAgICAgICAgICAgICAgICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9O KCFmbG9hdGluZ09iamVjdC0+b3JpZ2luYXRpbmdMaW5lKCkpOwogICAgICAgICAgICAgICAgICAg ICBmbG9hdGluZ09iamVjdC0+c2V0T3JpZ2luYXRpbmdMaW5lKGxpbmUpOwogICAgICAgICAgICAg ICAgICAgICBzZXRMb2dpY2FsSGVpZ2h0KGxvZ2ljYWxUb3BGb3JDaGlsZCgqZmxvYXRpbmdCb3gp IC0gbWFyZ2luQmVmb3JlRm9yQ2hpbGQoKmZsb2F0aW5nQm94KSk7CiAgICAgICAgICAgICAgICAg ICAgIHBvc2l0aW9uTmV3RmxvYXRzKCk7Cg==