156278 2016-04-05 21:47:30 -0700 Web Inspector: Do not create CodeMirror color/gradient markers in JavaScript resources 2016-06-04 23:51:40 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1181161 0 joepeck 2016-04-05 21:47:30 -0700 * SUMMARY Do not create CodeMirror color/gradient markers in JavaScript resources. * TEST var red = "foo"; * STEPS TO REPRODUCE 1. Inspect test page 2. Show JavaScript resource with a variable name that is a CSS color name 3. Hover variable name => Get color marker * NOTES Performance is poor. Creating markers for JavaScript resources doesn't make sense either. Logging time it took to generate markers on the JavaScript resources on apple.com: MARKERS 43ms MARKERS 807ms MARKERS 58ms MARKERS 285ms MARKERS 824ms MARKERS 134ms This can be completely eliminated. 1181162 1 webkit-bug-importer 2016-04-05 21:47:41 -0700 <rdar://problem/25570404> 1181163 2 275751 joepeck 2016-04-05 21:48:40 -0700 Created attachment 275751 [PATCH] Proposed Fix 1181184 3 275751 commit-queue 2016-04-05 22:45:16 -0700 Comment on attachment 275751 [PATCH] Proposed Fix Clearing flags on attachment: 275751 Committed r199095: <http://trac.webkit.org/changeset/199095> 1181185 4 commit-queue 2016-04-05 22:45:21 -0700 All reviewed patches have been landed. Closing bug. 1199348 5 joepeck 2016-06-04 23:51:40 -0700 *** Bug 129629 has been marked as a duplicate of this bug. *** 275751 2016-04-05 21:48:40 -0700 2016-04-05 22:45:16 -0700 [PATCH] Proposed Fix markers.patch text/plain 2106 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMzMDU2Y2YuLjY4MGY2YTMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA0LTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRG8gbm90 IGNyZWF0ZSBDb2RlTWlycm9yIGNvbG9yL2dyYWRpZW50IG1hcmtlcnMgaW4gSmF2YVNjcmlwdCBy ZXNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1NjI3OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjU1NzA0MDQ+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdz L1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUNv ZGVUZXh0RWRpdG9yLnByb3RvdHlwZS5faGFzU3R5bGVTaGVldENvbnRlbnRzKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlVGV4dEVkaXRvci5wcm90b3R5cGUuX3VwZGF0ZUVkaXRh YmxlTWFya2Vycyk6CisgICAgICAgIE9ubHkgc3BlbmQgdGhlIHRpbWUgdG8gY3JlYXRlIHN0eWxl IG1hcmtlcnMgZm9yIHN0eWxlIHNoZWV0IGNvbnRlbnRzLgorCiAyMDE2LTA0LTA0ICBKb3NlcGgg UGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog SW1wcm92ZSBKYXZhU2NyaXB0IHByZXR0eSBwcmludGluZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4 dEVkaXRvci5qcwppbmRleCBkZWI1Y2Q3Li44ZTQ3Yzg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2Rl VGV4dEVkaXRvci5qcwpAQCAtMTU3MywxMSArMTU3MywyMiBAQCBXZWJJbnNwZWN0b3IuU291cmNl Q29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRlbmRzIFdlYklu c3BlYwogICAgICAgICB0aGlzLl9tb3VzZUlzT3ZlclBvcG92ZXIgPSB0aGlzLl9wb3BvdmVyLmVs ZW1lbnQuY29udGFpbnMoZXZlbnQucmVsYXRlZFRhcmdldCk7CiAgICAgfQogCisgICAgX2hhc1N0 eWxlU2hlZXRDb250ZW50cygpCisgICAgeworICAgICAgICBsZXQgbWltZVR5cGUgPSB0aGlzLm1p bWVUeXBlOworICAgICAgICByZXR1cm4gbWltZVR5cGUgPT09ICJ0ZXh0L2NzcyIKKyAgICAgICAg ICAgIHx8IG1pbWVUeXBlID09PSAidGV4dC94LWxlc3MiCisgICAgICAgICAgICB8fCBtaW1lVHlw ZSA9PT0gInRleHQveC1zYXNzIgorICAgICAgICAgICAgfHwgbWltZVR5cGUgPT09ICJ0ZXh0L3gt c2NzcyI7CisgICAgfQorCiAgICAgX3VwZGF0ZUVkaXRhYmxlTWFya2VycyhyYW5nZSkKICAgICB7 Ci0gICAgICAgIHRoaXMuY3JlYXRlQ29sb3JNYXJrZXJzKHJhbmdlKTsKLSAgICAgICAgdGhpcy5j cmVhdGVHcmFkaWVudE1hcmtlcnMocmFuZ2UpOwotICAgICAgICB0aGlzLmNyZWF0ZUN1YmljQmV6 aWVyTWFya2VycyhyYW5nZSk7CisgICAgICAgIGlmICh0aGlzLl9oYXNTdHlsZVNoZWV0Q29udGVu dHMoKSkgeworICAgICAgICAgICAgdGhpcy5jcmVhdGVDb2xvck1hcmtlcnMocmFuZ2UpOworICAg ICAgICAgICAgdGhpcy5jcmVhdGVHcmFkaWVudE1hcmtlcnMocmFuZ2UpOworICAgICAgICAgICAg dGhpcy5jcmVhdGVDdWJpY0Jlemllck1hcmtlcnMocmFuZ2UpOworICAgICAgICB9CiAKICAgICAg ICAgdGhpcy5fdXBkYXRlVG9rZW5UcmFja2luZ0NvbnRyb2xsZXJTdGF0ZSgpOwogICAgIH0K