15627 2007-10-22 14:21:13 -0700 Avoid moving floats into integer registers in jsNumber() for 3% speedup on SunSpider 2007-10-22 14:37:35 -0700 1 1 1 Unclassified WebKit Tools / Tests 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED P3 Normal --- 1 mjs mjs oldest_to_newest 59190 0 mjs 2007-10-22 14:21:13 -0700 JSImmediate::fromDouble() called from jsNumber() does moves from floating point to integer registers to check for loss of precision in a way that safely covers NaN. It is faster to do a floating point compare and a special check for NaN. 59193 1 16809 mjs 2007-10-22 14:35:42 -0700 Created attachment 16809 patch 16809 2007-10-22 14:35:42 -0700 2007-10-22 14:36:47 -0700 patch faster-jsNumber.patch.txt text/plain 1395 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI2ODky KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDctMTAt MjIgIE1hY2llaiBTdGFjaG93aWFrICA8bWpzQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gQXZvaWQgbW92aW5nIGZs b2F0cyBpbnRvIGludGVnZXIgcmVnaXN0ZXJzIGluIGpzTnVtYmVyKCkgZm9yIDMlIHNwZWVkdXAg b24gU3VuU3BpZGVyCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1NjI3CisKKyAgICAgICAgKiBranMvSlNJbW1lZGlhdGUuaDoKKyAgICAgICAgKEtKUzo6 SlNJbW1lZGlhdGU6OmZyb21Eb3VibGUpOiBBdm9pZCBtb3ZpbmcgZmxvYXRzIHRvIGludGVnZXIK KyAgICAgICAgcmVnaXN0ZXJzIHNpbmNlIHRoaXMgaXMgdmVyeSBzbG93LgorCiAyMDA3LTEwLTIy ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBF cmljIFNlaWRlbC4KSW5kZXg6IGtqcy9KU0ltbWVkaWF0ZS5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGtqcy9K U0ltbWVkaWF0ZS5oCShyZXZpc2lvbiAyNjg5MikKKysrIGtqcy9KU0ltbWVkaWF0ZS5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNTQsMTAgKzE1NCw5IEBAIHRlbXBsYXRlPD4gc3RydWN0IEpTSW1tZWRp YXRlOjpGUEJpdFZhbHUKICAgICAgICAgICAgIHJldHVybiAwOwogCiAgICAgICAgIC8vIGNoZWNr IGZvciBkYXRhIGxvc3MgZnJvbSBjb252ZXJzaW9uIHRvIGZsb2F0Ci0gICAgICAgIERvdWJsZVVu aW9uIGRvdWJsZVVuaW9uMSwgZG91YmxlVW5pb24yOwotICAgICAgICBkb3VibGVVbmlvbjEuYXNE b3VibGUgPSBmbG9hdFVuaW9uLmFzRmxvYXQ7Ci0gICAgICAgIGRvdWJsZVVuaW9uMi5hc0RvdWJs ZSA9IGQ7Ci0gICAgICAgIGlmIChkb3VibGVVbmlvbjEuYXNCaXRzICE9IGRvdWJsZVVuaW9uMi5h c0JpdHMpCisgICAgICAgIC8vIFRoZSBkID09IGQgY2hlY2sgaXMgdG8gYWxsb3cgTmFOIC0gaXQg ZG9lcyBub3QKKyAgICAgICAgLy8gY29tcGFyZSBlcXVhbCB0byBpdHNlbGYsIGJ1dCB3ZSBkbyB3 YW50IHRvIGFsbG93IGl0CisgICAgICAgIGlmIChmbG9hdFVuaW9uLmFzRmxvYXQgIT0gZCAmJiBk ID09IGQpCiAgICAgICAgICAgICByZXR1cm4gMDsKIAogICAgICAgICByZXR1cm4gdGFnKGZsb2F0 VW5pb24uYXNCaXRzLCBOdW1iZXJUeXBlKTsK