156258 2016-04-05 16:11:21 -0700 Web Inspector: Command-Option-R opens Inspector details sidebar or Responsive Design Mode, should only do one 2022-03-01 02:44:02 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1181023 0 timothy 2016-04-05 16:11:21 -0700 The short cut Cmd + Opt + R is mapped to Responsive mode but if the Web Inspector is open then the right side bar toggles open and shut with the same Cmd + Opt + R shortcut. The computer doesn't go into Responsive mode. One has to close the inspector, and then use the shortcut else use the dropdown menu. Steps to Reproduce: 1. Open Safari 2. Open any webpage 3. Open the Web Inspector 4. Press the shortcut Cmd + Opt + R (it will toggle the details sidebar) 5. Close Web inspector (unnecessary step) 6. Press Cmd + Opt + R for responsive mode. <rdar://problem/25483871> 1181028 1 275710 timothy 2016-04-05 16:15:47 -0700 Created attachment 275710 Patch 1181030 2 275710 joepeck 2016-04-05 16:17:10 -0700 Comment on attachment 275710 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275710&action=review Seems fine > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: Command-Option-R opens Inspector details sidebar or Respinsive Design Mode, should only do one Typo: Respinsive => "Responsive" 1181033 3 timothy 2016-04-05 16:20:47 -0700 https://trac.webkit.org/r199082 275710 2016-04-05 16:15:47 -0700 2022-03-01 02:44:02 -0800 Patch bug-156258-20160405161547.patch text/plain 2839 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MDUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBj Zjc0MGE0OTQyMGNlY2MyZDkyNWM1MjIyNzA3YjUxZjJhYzFhZWRiLi4xMzE0YzdlZmMyMmUwOWM2 Nzk0MDlhMmM5NmU5MTkyMzViZmFiNmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNi0wNC0wNSAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogQ29tbWFuZC1PcHRpb24tUiBvcGVucyBJbnNw ZWN0b3IgZGV0YWlscyBzaWRlYmFyIG9yIFJlc3BpbnNpdmUgRGVzaWduIE1vZGUsIHNob3VsZCBv bmx5IGRvIG9uZQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTYyNTgKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjU0ODM4NzEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLmNvbnRlbnRMb2FkZWQpOiBDaGFuZ2Ug c2hvcnRjdXRzIHRvIENvbW1hbmQtT3B0aW9uLTAgYW5kIENvbW1hbmQtU2hpZnQtMC4KKwogMjAx Ni0wNC0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAg IFVuY2F1Z2h0IEV4Y2VwdGlvbjogRXJyb3I6IENhbid0IG1ha2UgYSBDb250ZW50VmlldyBmb3Ig YW4gdW5rbm93biByZXByZXNlbnRlZE9iamVjdCAoQXBwbGljYXRpb25DYWNoZU1hbmlmZXN0KQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWlu LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmlu ZGV4IDM3NzJhZjRmMDM5MDU4ZWI4MmMzOGVlZjVjMjdiZmUwMjVhNDlmNDQuLmNkNzgxMDQxMmE5 ZDY4M2EzY2ViNTc3MmVkMGIyZWEyMzhiZTMzZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTI1Nyw4ICsyNTcsOCBAQCBXZWJJ bnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKIAogICAgIHRoaXMub3BlblJlc291 cmNlS2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChX ZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kIHwgV2ViSW5zcGVj dG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuU2hpZnQsICJPIiwgdGhpcy5fc2hvd09wZW5S ZXNvdXJjZURpYWxvZy5iaW5kKHRoaXMpKTsKIAotICAgIHRoaXMubmF2aWdhdGlvblNpZGViYXJL ZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0KFdlYklu c3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2wgfCBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5PcHRpb24sICJMIiwgdGhpcy50b2dn bGVOYXZpZ2F0aW9uU2lkZWJhci5iaW5kKHRoaXMpKTsKLSAgICB0aGlzLmRldGFpbHNTaWRlYmFy S2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuT3B0aW9uLCAiUiIsIHRoaXMudG9n Z2xlRGV0YWlsc1NpZGViYXIuYmluZCh0aGlzKSk7CisgICAgdGhpcy5uYXZpZ2F0aW9uU2lkZWJh cktleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCB8IFdl Ykluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLlNoaWZ0LCAiMCIsIHRoaXMudG9n Z2xlTmF2aWdhdGlvblNpZGViYXIuYmluZCh0aGlzKSk7CisgICAgdGhpcy5kZXRhaWxzU2lkZWJh cktleWJvYXJkU2hvcnRjdXQgPSBuZXcgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2Vi SW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCB8IFdl Ykluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLk9wdGlvbiwgIjAiLCB0aGlzLnRv Z2dsZURldGFpbHNTaWRlYmFyLmJpbmQodGhpcykpOwogCiAgICAgdGhpcy5faW5jcmVhc2Vab29t S2V5Ym9hcmRTaG9ydGN1dCA9IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sLCBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXkuUGx1cywgdGhpcy5faW5jcmVhc2Vab29tLmJp bmQodGhpcykpOwogICAgIHRoaXMuX2RlY3JlYXNlWm9vbUtleWJvYXJkU2hvcnRjdXQgPSBuZXcg V2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRjdXQoV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQuTW9kaWZpZXIuQ29tbWFuZE9yQ29udHJvbCwgV2ViSW5zcGVjdG9yLktleWJvYXJkU2hvcnRj dXQuS2V5Lk1pbnVzLCB0aGlzLl9kZWNyZWFzZVpvb20uYmluZCh0aGlzKSk7Cg==