156249 2016-04-05 14:07:12 -0700 Correct applicationWillTerminate logic for ResourceLoadStatistics 2016-04-05 18:31:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Mac All RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen aestes bfulgham commit-queue webkit-bug-importer oldest_to_newest 1180968 0 bfulgham 2016-04-05 14:07:12 -0700 The "applicationWillTerminate" logic for the ResourceLoadStatistics code can cause a crash when exiting. 1180969 1 bfulgham 2016-04-05 14:08:14 -0700 <rdar://problem/25179611> 1180972 2 275694 bfulgham 2016-04-05 14:13:57 -0700 Created attachment 275694 Patch 1181113 3 275694 commit-queue 2016-04-05 18:31:17 -0700 Comment on attachment 275694 Patch Clearing flags on attachment: 275694 Committed r199088: <http://trac.webkit.org/changeset/199088> 1181114 4 commit-queue 2016-04-05 18:31:20 -0700 All reviewed patches have been landed. Closing bug. 275694 2016-04-05 14:13:57 -0700 2016-04-05 18:31:17 -0700 Patch bug-156249-20160405141358.patch text/plain 2918 bfulgham SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTA3MSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE2LTA0LTA1ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgorCisgICAgICAgIENvcnJlY3QgYXBwbGljYXRp b25XaWxsVGVybWluYXRlIGxvZ2ljIGZvciBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTYyNDkKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI1MTc5NjExPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBhcHBsaWNhdGlvbldpbGxUZXJtaW5hdGUgaGFuZGxpbmcg Zm9yIFJlc291cmNlTG9hZFN0YXRpc3RpY3MgaW5jb3JyZWN0bHkKKyAgICAgICAgYXNzdW1lcyB0 aGF0IGEgUmVzb3VyY2VMb2FkU3RhdGlzdGljcyBvYmplY3Qgd2lsbCBhbHdheXMgYmUgcHJlc2Vu dC4KKyAgICAgICAgMS4gVGhlIHRlcm1pbmF0aW9uIGhhbmRsaW5nIGZvciAnZGF0YVN0b3Jlc1dp dGhTdG9yYWdlTWFuYWdlcnMnIHNob3VsZCBiZQorICAgICAgICAgICBjYWxsaW5nICdhcHBsaWNh dGlvbldpbGxUZXJtaW5hdGUnIG9uIGFueSBSZXNvdXJjZUxvYWRTdGF0aXN0aWNzCisgICAgICAg ICAgIG9iamVjdHMgYXR0YWNoZWQgdG8gdGhlIGRhdGFTdG9yZS4KKyAgICAgICAgMi4gcGxhdGZv cm1Jbml0aWFsaXplIHNob3VsZCBudWxsLWNoZWNrIGJlZm9yZSBhdHRlbXB0aW5nIHRvIGRpc3Bh dGNoLgorICAgICAgICAzLiBwbGF0Zm9ybURlc3Ryb3kgc2hvdWxkIG51bGwgY2hlY2sgYmVmb3Jl IGF0dGVtcHRpbmcgdG8gZGlzcGF0Y2guCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2Vic2l0ZURh dGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJz aXRlRGF0YVN0b3JlOjpwbGF0Zm9ybUluaXRpYWxpemUpOiAKKyAgICAgICAgKFdlYktpdDo6V2Vi c2l0ZURhdGFTdG9yZTo6cGxhdGZvcm1EZXN0cm95KTogSW52b2tlICdhcHBsaWNhdGlvbldpbGxU ZXJtaW5hdGUnIG9uCisgICAgICAgIG1fcmVzb3VyY2VMb2FkU3RhdGlzdGljcyBpZiBwcmVzZW50 LgorCiAyMDE2LTA0LTA1ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CiAKICAg ICAgICAgW1dlYkdMMl0gVHVybiB0aGUgRU5BQkxFX1dFQkdMMiBmbGFnIG9uCkluZGV4OiBTb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvQ29jb2EvV2Vic2l0ZURhdGFTdG9yZUNv Y29hLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJzaXRlRGF0 YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3JlQ29jb2EubW0JKHJldmlzaW9uIDE5OTA2NCkKKysrIFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9Db2NvYS9XZWJzaXRlRGF0YVN0b3Jl Q29jb2EubW0JKHdvcmtpbmcgY29weSkKQEAgLTYwLDIwICs2MCwyNSBAQCB2b2lkIFdlYnNpdGVE YXRhU3RvcmU6OnBsYXRmb3JtSW5pdGlhbGl6CiAgICAgICAgIE5TU3RyaW5nICpub3RpZmljYXRp b25OYW1lID0gVUlBcHBsaWNhdGlvbldpbGxUZXJtaW5hdGVOb3RpZmljYXRpb247CiAjZW5kaWYK ICAgICAgICAgdGVybWluYXRpb25PYnNlcnZlciA9IFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVm YXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXJGb3JOYW1lOm5vdGlmaWNhdGlvbk5hbWUgb2JqZWN0Om5p bCBxdWV1ZTpuaWwgdXNpbmdCbG9jazpeKE5TTm90aWZpY2F0aW9uICpub3RlKSB7Ci0gICAgICAg ICAgICBmb3IgKGF1dG8mIGRhdGFTdG9yZSA6IGRhdGFTdG9yZXNXaXRoU3RvcmFnZU1hbmFnZXJz KCkpCisgICAgICAgICAgICBmb3IgKGF1dG8mIGRhdGFTdG9yZSA6IGRhdGFTdG9yZXNXaXRoU3Rv cmFnZU1hbmFnZXJzKCkpIHsKICAgICAgICAgICAgICAgICBkYXRhU3RvcmUtPm1fc3RvcmFnZU1h bmFnZXItPmFwcGxpY2F0aW9uV2lsbFRlcm1pbmF0ZSgpOwotCi0gICAgICAgICAgICBtX3Jlc291 cmNlTG9hZFN0YXRpc3RpY3MtPmFwcGxpY2F0aW9uV2lsbFRlcm1pbmF0ZSgpOworICAgICAgICAg ICAgICAgIGlmIChkYXRhU3RvcmUtPm1fcmVzb3VyY2VMb2FkU3RhdGlzdGljcykKKyAgICAgICAg ICAgICAgICAgICAgZGF0YVN0b3JlLT5tX3Jlc291cmNlTG9hZFN0YXRpc3RpY3MtPmFwcGxpY2F0 aW9uV2lsbFRlcm1pbmF0ZSgpOworICAgICAgICAgICAgfQogICAgICAgICB9XTsKICAgICB9CiAK ICAgICBBU1NFUlQoIWRhdGFTdG9yZXNXaXRoU3RvcmFnZU1hbmFnZXJzKCkuY29udGFpbnModGhp cykpOwogICAgIGRhdGFTdG9yZXNXaXRoU3RvcmFnZU1hbmFnZXJzKCkuYXBwZW5kKHRoaXMpOwot ICAgIG1fcmVzb3VyY2VMb2FkU3RhdGlzdGljcy0+cmVhZERhdGFGcm9tRGlza0lmTmVlZGVkKCk7 CisgICAgaWYgKG1fcmVzb3VyY2VMb2FkU3RhdGlzdGljcykKKyAgICAgICAgbV9yZXNvdXJjZUxv YWRTdGF0aXN0aWNzLT5yZWFkRGF0YUZyb21EaXNrSWZOZWVkZWQoKTsKIH0KIAogdm9pZCBXZWJz aXRlRGF0YVN0b3JlOjpwbGF0Zm9ybURlc3Ryb3koKQogeworICAgIGlmIChtX3Jlc291cmNlTG9h ZFN0YXRpc3RpY3MpCisgICAgICAgIG1fcmVzb3VyY2VMb2FkU3RhdGlzdGljcy0+YXBwbGljYXRp b25XaWxsVGVybWluYXRlKCk7CisKICAgICBpZiAoIW1fc3RvcmFnZU1hbmFnZXIpCiAgICAgICAg IHJldHVybjsKIAo=