156229 2016-04-04 22:34:56 -0700 [Curl][Soup] Fix the build after r199039 2016-04-05 00:04:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong bfulgham commit-queue gyuyoung.kim oldest_to_newest 1180712 0 hs85.jeong 2016-04-04 22:34:56 -0700 https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/27374/steps/compile-webkit/logs/stdio ../../Source/WebCore/Modules/websockets/WebSocketChannel.cpp: In member function ‘virtual void WebCore::WebSocketChannel::connect(const WebCore::URL&, const WTF::String&)’: ../../Source/WebCore/Modules/websockets/WebSocketChannel.cpp:113:142: error: no matching function for call to ‘WebCore::SocketStreamHandle::create(const WebCore::URL&, WebCore::WebSocketChannel*, WebCore::NetworkingContext&, bool)’ m_handle = SocketStreamHandle::create(m_handshake->url(), this, *networkingContext, (page ? page->usesEphemeralSession() : false)); ^ In file included from ../../Source/WebCore/Modules/websockets/WebSocketChannel.cpp:52:0: ../../Source/WebCore/platform/network/soup/SocketStreamHandle.h:53:47: note: candidate: static WTF::PassRefPtr<WebCore::SocketStreamHandle> WebCore::SocketStreamHandle::create(const WebCore::URL&, WebCore::SocketStreamHandleClient*, WebCore::NetworkingContext&) static PassRefPtr<SocketStreamHandle> create(const URL& url, SocketStreamHandleClient* client, NetworkingContext&) { return adoptRef(new SocketStreamHandle(url, client)); } ^ ../../Source/WebCore/platform/network/soup/SocketStreamHandle.h:53:47: note: candidate expects 3 arguments, 4 provided In file included from ../../Source/WebCore/Modules/websockets/WebSocketChannel.cpp:52:0: ../../Source/WebCore/platform/network/soup/SocketStreamHandle.h:54:47: note: candidate: static WTF::PassRefPtr<WebCore::SocketStreamHandle> WebCore::SocketStreamHandle::create(GSocketConnection*, WebCore::SocketStreamHandleClient*) static PassRefPtr<SocketStreamHandle> create(GSocketConnection* socketConnection, SocketStreamHandleClient* client) { return adoptRef(new SocketStreamHandle(socketConnection, client)); } ^ ../../Source/WebCore/platform/network/soup/SocketStreamHandle.h:54:47: note: candidate expects 2 arguments, 4 provided 1180713 1 275641 hs85.jeong 2016-04-04 22:36:37 -0700 Created attachment 275641 Patch 1180738 2 275641 commit-queue 2016-04-05 00:04:32 -0700 Comment on attachment 275641 Patch Clearing flags on attachment: 275641 Committed r199053: <http://trac.webkit.org/changeset/199053> 1180739 3 commit-queue 2016-04-05 00:04:37 -0700 All reviewed patches have been landed. Closing bug. 275641 2016-04-04 22:36:37 -0700 2016-04-05 00:04:32 -0700 Patch bug-156229-20160405143635.patch text/plain 2641 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5OTA0MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA0LTA0ICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbQ3VybF1bU291cF0g Rml4IHRoZSBidWlsZCBhZnRlciByMTk5MDM5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNTYyMjkgCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvU29ja2V0U3RyZWFt SGFuZGxlLmg6CisgICAgICAgIChXZWJDb3JlOjpTb2NrZXRTdHJlYW1IYW5kbGU6OmNyZWF0ZSk6 CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvY2tldFN0cmVhbUhhbmRsZS5oOgor ICAgICAgICAoV2ViQ29yZTo6U29ja2V0U3RyZWFtSGFuZGxlOjpjcmVhdGUpOgorCiAyMDE2LTA0 LTA0ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJsb2Nr IHBsYWludGV4dCBXZWJTb2NrZXQgcmVxdWVzdHMgdG8gZG9tYWlucyB1bmRlciBIU1RTLgpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1NvY2tldFN0cmVhbUhhbmRs ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9T b2NrZXRTdHJlYW1IYW5kbGUuaAkocmV2aXNpb24gMTk5MDQwKQorKysgU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL1NvY2tldFN0cmVhbUhhbmRsZS5oCSh3b3JraW5nIGNvcHkp CkBAIC01NCw3ICs1NCw3IEBAIGNsYXNzIFNvY2tldFN0cmVhbUhhbmRsZUNsaWVudDsKIAogY2xh c3MgU29ja2V0U3RyZWFtSGFuZGxlIDogcHVibGljIFRocmVhZFNhZmVSZWZDb3VudGVkPFNvY2tl dFN0cmVhbUhhbmRsZT4sIHB1YmxpYyBTb2NrZXRTdHJlYW1IYW5kbGVCYXNlIHsKIHB1YmxpYzoK LSAgICBzdGF0aWMgUmVmPFNvY2tldFN0cmVhbUhhbmRsZT4gY3JlYXRlKGNvbnN0IFVSTCYgdXJs LCBTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQqIGNsaWVudCwgTmV0d29ya2luZ0NvbnRleHQmKSB7 IHJldHVybiBhZG9wdFJlZigqbmV3IFNvY2tldFN0cmVhbUhhbmRsZSh1cmwsIGNsaWVudCkpOyB9 CisgICAgc3RhdGljIFJlZjxTb2NrZXRTdHJlYW1IYW5kbGU+IGNyZWF0ZShjb25zdCBVUkwmIHVy bCwgU29ja2V0U3RyZWFtSGFuZGxlQ2xpZW50KiBjbGllbnQsIE5ldHdvcmtpbmdDb250ZXh0Jiwg Ym9vbCkgeyByZXR1cm4gYWRvcHRSZWYoKm5ldyBTb2NrZXRTdHJlYW1IYW5kbGUodXJsLCBjbGll bnQpKTsgfQogCiAgICAgdmlydHVhbCB+U29ja2V0U3RyZWFtSGFuZGxlKCk7CiAKSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGUuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU29ja2V0 U3RyZWFtSGFuZGxlLmgJKHJldmlzaW9uIDE5OTA0MCkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Tb2NrZXRTdHJlYW1IYW5kbGUuaAkod29ya2luZyBjb3B5KQpAQCAt NTAsNyArNTAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBjbGFzcyBTb2NrZXRTdHJl YW1IYW5kbGUgOiBwdWJsaWMgUmVmQ291bnRlZDxTb2NrZXRTdHJlYW1IYW5kbGU+LCBwdWJsaWMg U29ja2V0U3RyZWFtSGFuZGxlQmFzZSB7CiAgICAgcHVibGljOgotICAgICAgICBzdGF0aWMgUGFz c1JlZlB0cjxTb2NrZXRTdHJlYW1IYW5kbGU+IGNyZWF0ZShjb25zdCBVUkwmIHVybCwgU29ja2V0 U3RyZWFtSGFuZGxlQ2xpZW50KiBjbGllbnQsIE5ldHdvcmtpbmdDb250ZXh0JikgeyByZXR1cm4g YWRvcHRSZWYobmV3IFNvY2tldFN0cmVhbUhhbmRsZSh1cmwsIGNsaWVudCkpOyB9CisgICAgICAg IHN0YXRpYyBQYXNzUmVmUHRyPFNvY2tldFN0cmVhbUhhbmRsZT4gY3JlYXRlKGNvbnN0IFVSTCYg dXJsLCBTb2NrZXRTdHJlYW1IYW5kbGVDbGllbnQqIGNsaWVudCwgTmV0d29ya2luZ0NvbnRleHQm LCBib29sKSB7IHJldHVybiBhZG9wdFJlZihuZXcgU29ja2V0U3RyZWFtSGFuZGxlKHVybCwgY2xp ZW50KSk7IH0KICAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8U29ja2V0U3RyZWFtSGFuZGxlPiBj cmVhdGUoR1NvY2tldENvbm5lY3Rpb24qIHNvY2tldENvbm5lY3Rpb24sIFNvY2tldFN0cmVhbUhh bmRsZUNsaWVudCogY2xpZW50KSB7IHJldHVybiBhZG9wdFJlZihuZXcgU29ja2V0U3RyZWFtSGFu ZGxlKHNvY2tldENvbm5lY3Rpb24sIGNsaWVudCkpOyB9CiAKICAgICAgICAgdmlydHVhbCB+U29j a2V0U3RyZWFtSGFuZGxlKCk7Cg==