156189 2016-04-04 16:56:20 -0700 Make FrameView's exposedRect an Optional<> 2016-04-04 21:04:43 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1180577 0 simon.fraser 2016-04-04 16:56:20 -0700 Make FrameView's exposedRect an Optional<> 1180579 1 275592 simon.fraser 2016-04-04 16:57:17 -0700 Created attachment 275592 Patch 1180581 2 275592 thorton 2016-04-04 16:58:08 -0700 Comment on attachment 275592 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275592&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:462 > + FloatRect visibleRect = m_clipLayer ? FloatRect({ 0, 0 }, frameView.unscaledVisibleContentSizeIncludingObscuredArea()) : frameView.visibleContentRect(); Technically I think you can get away without the 0, 0 but I don't know if you should. 1180678 3 275592 commit-queue 2016-04-04 21:04:40 -0700 Comment on attachment 275592 Patch Clearing flags on attachment: 275592 Committed r199038: <http://trac.webkit.org/changeset/199038> 1180679 4 commit-queue 2016-04-04 21:04:43 -0700 All reviewed patches have been landed. Closing bug. 275592 2016-04-04 16:57:17 -0700 2016-04-04 21:04:40 -0700 Patch bug-156189-20160404165723.patch text/plain 5884 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4OTYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTUyMGZlMzFjZmUyZGU3 ZWI1NjAwOTJjNWU1MzI1OTNlYmFmZjQyMS4uNmJjZThmMWRhY2FmMjUxMDlmZDU3ZjMyYjU4OWY0 Y2I1MDBmNjk3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA0LTA0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgRnJhbWVW aWV3J3MgZXhwb3NlZFJlY3QgYW4gT3B0aW9uYWw8PgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2MTg5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiB0ZXN0aW5nIGFnYWluc3QgaXNJbmZp bml0ZSgpLCBtYWtlIEZyYW1lVmlldzo6ZXhwb3NlZFJlY3QoKSBhbmQgdGhlCisgICAgICAgIG1l bWJlciB2YXJpYWJsZSBhbiBPcHRpb25hbDxGbG9hdFJlY3Q+LgorCisgICAgICAgICogcGFnZS9G cmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpzZXRFeHBvc2VkUmVj dCk6CisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu ZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNvbXB1dGVUaWxlQ292ZXJh Z2UpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpmbHVzaFBlbmRpbmdMYXllckNo YW5nZXMpOgorCiAyMDE2LTA0LTAxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEJhY2tkcm9wIEZpbHRlciBzaG91bGQgcmVwYWludCB3aGVuIGNoYW5n ZWQgdmlhIHNjcmlwdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDJjMTBiOGU0M2Iz YmVmZjM3YjFmYjFiNjRmNTZmNTY0OWJmODlhZDUuLmNjYmViMzlhZjJlMjM2N2JiMDdjMTFlNWZh YWJhZjkxNGRmMTVlZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTIwNyw3ICsy MDcsNiBAQCBGcmFtZVZpZXc6OkZyYW1lVmlldyhGcmFtZSYgZnJhbWUpCiAgICAgLCBtX2RlbGF5 ZWRTY3JvbGxFdmVudFRpbWVyKCp0aGlzLCAmRnJhbWVWaWV3OjpzZW5kU2Nyb2xsRXZlbnQpCiAg ICAgLCBtX2lzVHJhY2tpbmdSZXBhaW50cyhmYWxzZSkKICAgICAsIG1fc2hvdWxkVXBkYXRlV2hp bGVPZmZzY3JlZW4odHJ1ZSkKLSAgICAsIG1fZXhwb3NlZFJlY3QoRmxvYXRSZWN0OjppbmZpbml0 ZVJlY3QoKSkKICAgICAsIG1fZGVmZXJTZXROZWVkc0xheW91dENvdW50KDApCiAgICAgLCBtX3Nl dE5lZWRzTGF5b3V0V2FzRGVmZXJyZWQoZmFsc2UpCiAgICAgLCBtX3NwZWN1bGF0aXZlVGlsaW5n RW5hYmxlZChmYWxzZSkKQEAgLTQ5MTAsOCArNDkwOSw5IEBAIHZvaWQgRnJhbWVWaWV3Ojpub3Rp ZnlXaWRnZXRzKFdpZGdldE5vdGlmaWNhdGlvbiBub3RpZmljYXRpb24pCiAKIHZvaWQgRnJhbWVW aWV3OjpzZXRFeHBvc2VkUmVjdChGbG9hdFJlY3QgZXhwb3NlZFJlY3QpCiB7Ci0gICAgaWYgKG1f ZXhwb3NlZFJlY3QgPT0gZXhwb3NlZFJlY3QpCisgICAgaWYgKG1fZXhwb3NlZFJlY3QgJiYgbV9l eHBvc2VkUmVjdC52YWx1ZSgpID09IGV4cG9zZWRSZWN0KQogICAgICAgICByZXR1cm47CisKICAg ICBtX2V4cG9zZWRSZWN0ID0gZXhwb3NlZFJlY3Q7CiAKICAgICAvLyBGSVhNRTogV2Ugc2hvdWxk IHN1cHBvcnQgY2xpcHBpbmcgdG8gdGhlIGV4cG9zZWQgcmVjdCBmb3Igc3ViZnJhbWVzIGFzIHdl bGwuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oIGIvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAppbmRleCAyNTI5YTQ5NjFhNjUwMDBmZjY3MjE2Mjgy YjRjOTUwNTAxYWY5ODhjLi5jOGU4NGM1ZTU3YWE2OTY5MTUyOGM5YmU5MjZkYmM1NGU1Y2Q4NTRm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmgKQEAgLTU0Myw3ICs1NDMsNyBAQCBwdWJsaWM6CiAg ICAgLy8gY2xpcHBpbmcgYnkgb3RoZXIgVUkgZWxlbWVudHMpLCB3aGVyZWFzIHZpc2libGVDb250 ZW50UmVjdCBpcwogICAgIC8vIGludGVybmFsIHRvIFdlYkNvcmUgYW5kIGRvZXNuJ3QgcmVzcGVj dCB0aG9zZSB0aGluZ3MuCiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBzZXRFeHBvc2VkUmVjdChG bG9hdFJlY3QpOwotICAgIEZsb2F0UmVjdCBleHBvc2VkUmVjdCgpIGNvbnN0IHsgcmV0dXJuIG1f ZXhwb3NlZFJlY3Q7IH0KKyAgICBPcHRpb25hbDxGbG9hdFJlY3Q+IGV4cG9zZWRSZWN0KCkgY29u c3QgeyByZXR1cm4gbV9leHBvc2VkUmVjdDsgfQogCiAjaWYgRU5BQkxFKENTU19TQ1JPTExfU05B UCkKICAgICB2b2lkIHVwZGF0ZVNuYXBPZmZzZXRzKCkgb3ZlcnJpZGU7CkBAIC03NTQsNyArNzU0 LDcgQEAgcHJpdmF0ZToKIAogICAgIGJvb2wgbV9zaG91bGRVcGRhdGVXaGlsZU9mZnNjcmVlbjsK IAotICAgIEZsb2F0UmVjdCBtX2V4cG9zZWRSZWN0OworICAgIE9wdGlvbmFsPEZsb2F0UmVjdD4g bV9leHBvc2VkUmVjdDsKIAogICAgIHVuc2lnbmVkIG1fZGVmZXJTZXROZWVkc0xheW91dENvdW50 OwogICAgIGJvb2wgbV9zZXROZWVkc0xheW91dFdhc0RlZmVycmVkOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcAppbmRleCBlMDRhZWQ2NzJjYTVk OWY2MjYyOTg0NzE4YjA4ZjY5NThjNjI3ZWEzLi5kZWFlZTdjYzU1MDUzZTU1ZmM5YTdlZDNiMWY1 OWZiYjRmYWQwMzIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5 ZXJCYWNraW5nLmNwcApAQCAtMjI2LDcgKzIyNiw3IEBAIHN0YXRpYyBUaWxlZEJhY2tpbmc6OlRp bGVDb3ZlcmFnZSBjb21wdXRlVGlsZUNvdmVyYWdlKFJlbmRlckxheWVyQmFja2luZyogYmFja2lu CiAgICAgVGlsZWRCYWNraW5nOjpUaWxlQ292ZXJhZ2UgdGlsZUNvdmVyYWdlID0gVGlsZWRCYWNr aW5nOjpDb3ZlcmFnZUZvclZpc2libGVBcmVhOwogICAgIGJvb2wgdXNlTWluaW1hbFRpbGVzRHVy aW5nTGl2ZVJlc2l6ZSA9IGZyYW1lVmlldy5pbkxpdmVSZXNpemUoKTsKICAgICBpZiAoZnJhbWVW aWV3LnNwZWN1bGF0aXZlVGlsaW5nRW5hYmxlZCgpICYmICF1c2VNaW5pbWFsVGlsZXNEdXJpbmdM aXZlUmVzaXplKSB7Ci0gICAgICAgIGJvb2wgY2xpcHNUb0V4cG9zZWRSZWN0ID0gIWZyYW1lVmll dy5leHBvc2VkUmVjdCgpLmlzSW5maW5pdGUoKTsKKyAgICAgICAgYm9vbCBjbGlwc1RvRXhwb3Nl ZFJlY3QgPSBzdGF0aWNfY2FzdDxib29sPihmcmFtZVZpZXcuZXhwb3NlZFJlY3QoKSk7CiAgICAg ICAgIGlmIChmcmFtZVZpZXcuaG9yaXpvbnRhbFNjcm9sbGJhck1vZGUoKSAhPSBTY3JvbGxiYXJB bHdheXNPZmYgfHwgY2xpcHNUb0V4cG9zZWRSZWN0KQogICAgICAgICAgICAgdGlsZUNvdmVyYWdl IHw9IFRpbGVkQmFja2luZzo6Q292ZXJhZ2VGb3JIb3Jpem9udGFsU2Nyb2xsaW5nOwogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCmlu ZGV4IGUwMmNmMWQyMzUzYzU5NGQwYmU1OWQxNzU3ZTM3ZTZiNjFlYzVjZmYuLjM1YWQ2NjMzMjZk NmY3NTdmMGQxYThjZmMyM2ZhZDEyNWVhODg4NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC01OSw2ICs1OSw3IEBACiAj aW5jbHVkZSAiU2Nyb2xsaW5nQ29uc3RyYWludHMuaCIKICNpbmNsdWRlICJTY3JvbGxpbmdDb29y ZGluYXRvci5oIgogI2luY2x1ZGUgIlNldHRpbmdzLmgiCisjaW5jbHVkZSAiVGV4dFN0cmVhbS5o IgogI2luY2x1ZGUgIlRpbGVkQmFja2luZy5oIgogI2luY2x1ZGUgIlRyYW5zZm9ybVN0YXRlLmgi CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CkBAIC00NTgsMTIgKzQ1OSwxMiBAQCB2b2lk IFJlbmRlckxheWVyQ29tcG9zaXRvcjo6Zmx1c2hQZW5kaW5nTGF5ZXJDaGFuZ2VzKGJvb2wgaXNG bHVzaFJvb3QpCiAgICAgICAgIHJvb3RMYXllci0+Zmx1c2hDb21wb3NpdGluZ1N0YXRlKGV4cG9z ZWRSZWN0LCBmcmFtZVZpZXcudmlld3BvcnRJc1N0YWJsZSgpKTsKICNlbHNlCiAgICAgICAgIC8v IEhhdmluZyBhIG1fY2xpcExheWVyIGluZGljYXRlcyB0aGF0IHdlJ3JlIGRvaW5nIHNjcm9sbGlu ZyB2aWEgR3JhcGhpY3NMYXllcnMuCi0gICAgICAgIEludFJlY3QgdmlzaWJsZVJlY3QgPSBtX2Ns aXBMYXllciA/IEludFJlY3QoSW50UG9pbnQoKSwgZnJhbWVWaWV3LnVuc2NhbGVkVmlzaWJsZUNv bnRlbnRTaXplSW5jbHVkaW5nT2JzY3VyZWRBcmVhKCkpIDogZnJhbWVWaWV3LnZpc2libGVDb250 ZW50UmVjdCgpOwotICAgICAgICBpZiAoIWZyYW1lVmlldy5leHBvc2VkUmVjdCgpLmlzSW5maW5p dGUoKSkKLSAgICAgICAgICAgIHZpc2libGVSZWN0LmludGVyc2VjdChJbnRSZWN0KGZyYW1lVmll dy5leHBvc2VkUmVjdCgpKSk7CisgICAgICAgIEZsb2F0UmVjdCB2aXNpYmxlUmVjdCA9IG1fY2xp cExheWVyID8gRmxvYXRSZWN0KHsgMCwgMCB9LCBmcmFtZVZpZXcudW5zY2FsZWRWaXNpYmxlQ29u dGVudFNpemVJbmNsdWRpbmdPYnNjdXJlZEFyZWEoKSkgOiBmcmFtZVZpZXcudmlzaWJsZUNvbnRl bnRSZWN0KCk7CiAKLSAgICAgICAgTE9HKENvbXBvc2l0aW5nLCAiUmVuZGVyTGF5ZXJDb21wb3Np dG9yICVwIGZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlcyglZCkgJWQsICVkLCAlZHglZCAoc3RhYmxl IHZpZXdwb3J0ICVkKSIsIHRoaXMsIGlzRmx1c2hSb290LAotICAgICAgICAgICAgdmlzaWJsZVJl Y3QueCgpLCB2aXNpYmxlUmVjdC55KCksIHZpc2libGVSZWN0LndpZHRoKCksIHZpc2libGVSZWN0 LmhlaWdodCgpLCBmcmFtZVZpZXcudmlld3BvcnRJc1N0YWJsZSgpKTsKKyAgICAgICAgaWYgKGZy YW1lVmlldy5leHBvc2VkUmVjdCgpKQorICAgICAgICAgICAgdmlzaWJsZVJlY3QuaW50ZXJzZWN0 KGZyYW1lVmlldy5leHBvc2VkUmVjdCgpLnZhbHVlKCkpOworCisgICAgICAgIExPR19XSVRIX1NU UkVBTShDb21wb3NpdGluZywgIHN0cmVhbSA8PCAiUmVuZGVyTGF5ZXJDb21wb3NpdG9yICIgPDwg dGhpcyA8PCAiIGZsdXNoUGVuZGluZ0xheWVyQ2hhbmdlcygiIDw8IGlzRmx1c2hSb290IDw8ICIp ICIgPDwgdmlzaWJsZVJlY3QgPDwgIiAoc3RhYmxlIHZpZXdwb3J0ICIgPDwgZnJhbWVWaWV3LnZp ZXdwb3J0SXNTdGFibGUoKSA8PCAiKSIpOwogICAgICAgICByb290TGF5ZXItPmZsdXNoQ29tcG9z aXRpbmdTdGF0ZSh2aXNpYmxlUmVjdCwgZnJhbWVWaWV3LnZpZXdwb3J0SXNTdGFibGUoKSk7CiAj ZW5kaWYKICAgICB9Cg==