156187 2016-04-04 16:27:43 -0700 jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989 2016-04-06 18:50:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 156324 1 ryanhaddad saam ap commit-queue ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1180562 0 ryanhaddad 2016-04-04 16:27:43 -0700 jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing after <https://trac.webkit.org/changeset/198989> <https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29/builds/5485> ** The following JSC stress test failures have been introduced: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: Regression test for https://webkit.org/b/141098. Make sure eval() properly handles running out of stack space. This test should run without crashing. jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: PASS Exception: RangeError: Maximum call stack size exceeded. jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: Timed out after 339.000000 seconds! jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 1 0x10ce84410 WTFCrash jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 2 0x10bd5612e timeoutThreadMain(void*) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 3 0x10cef0ab9 WTF::createThread(void (*)(void*), void*, char const*)::$_0::operator()() const jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 4 0x10cef0a8c std::__1::__function::__func<WTF::createThread(void (*)(void*), void*, char const*)::$_0, std::__1::allocator<WTF::createThread(void (*)(void*), void*, char const*)::$_0>, void ()>::operator()() jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 5 0x10c77cf1a std::__1::function<void ()>::operator()() const jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 6 0x10ceef7de WTF::threadEntryPoint(void*) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 7 0x10cef1041 WTF::wtfThreadEntryPoint(void*) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 8 0x7fff9bd3305a _pthread_body jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 9 0x7fff9bd32fd7 _pthread_body jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: 10 0x7fff9bd303ed thread_start jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: test_script_31075: line 2: 95529 Segmentation fault: 11 ( "$@" ../../../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --useConcurrentJIT\=false --thresholdForJITAfterWarmUp\=100 --thresholdForJITAfterWarmUp\=10 --thresholdForJITSoon\=10 --thresholdForOptimizeAfterWarmUp\=20 --thresholdForOptimizeAfterLongWarmUp\=20 --thresholdForOptimizeSoon\=20 --thresholdForFTLOptimizeAfterWarmUp\=20 --thresholdForFTLOptimizeSoon\=20 --maximumEvalCacheableSourceLength\=150000 resources/standalone-pre.js regress-141098.js resources/standalone-post.js ) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit: ERROR: Unexpected exit code: 139 FAIL: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-dfg-eager-no-cjit jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: Regression test for https://webkit.org/b/141098. Make sure eval() properly handles running out of stack space. This test should run without crashing. jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: PASS Exception: RangeError: Maximum call stack size exceeded. jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: Timed out after 339.000000 seconds! jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 1 0x102e8d410 WTFCrash jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 2 0x101d5f12e timeoutThreadMain(void*) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 3 0x102ef9ab9 WTF::createThread(void (*)(void*), void*, char const*)::$_0::operator()() const jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 4 0x102ef9a8c std::__1::__function::__func<WTF::createThread(void (*)(void*), void*, char const*)::$_0, std::__1::allocator<WTF::createThread(void (*)(void*), void*, char const*)::$_0>, void ()>::operator()() jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 5 0x102785f1a std::__1::function<void ()>::operator()() const jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 6 0x102ef87de WTF::threadEntryPoint(void*) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 7 0x102efa041 WTF::wtfThreadEntryPoint(void*) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 8 0x7fff9bd3305a _pthread_body jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 9 0x7fff9bd32fd7 _pthread_body jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: 10 0x7fff9bd303ed thread_start jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: test_script_31078: line 2: 95553 Segmentation fault: 11 ( "$@" ../../../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --testTheFTL\=true --useFTLJIT\=true --useConcurrentJIT\=false --thresholdForJITAfterWarmUp\=100 --thresholdForJITAfterWarmUp\=10 --thresholdForJITSoon\=10 --thresholdForOptimizeAfterWarmUp\=20 --thresholdForOptimizeAfterLongWarmUp\=20 --thresholdForOptimizeSoon\=20 --thresholdForFTLOptimizeAfterWarmUp\=20 --thresholdForFTLOptimizeSoon\=20 --maximumEvalCacheableSourceLength\=150000 resources/standalone-pre.js regress-141098.js resources/standalone-post.js ) jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit: ERROR: Unexpected exit code: 139 FAIL: jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-ftl-eager-no-cjit 1180564 1 saam 2016-04-04 16:30:17 -0700 I'll look into this 1180854 2 ryanhaddad 2016-04-05 09:56:27 -0700 *** Bug 156239 has been marked as a duplicate of this bug. *** 1180894 3 275679 saam 2016-04-05 11:42:38 -0700 Created attachment 275679 patch 1180897 4 275679 mark.lam 2016-04-05 11:43:52 -0700 Comment on attachment 275679 patch LGTM too. 1180901 5 saam 2016-04-05 11:47:34 -0700 I'm going to try to test/repro locally first. 1180911 6 saam 2016-04-05 12:13:02 -0700 I can't repro locally. Let's land this speculatively and see if it fixes things. 1180933 7 275679 commit-queue 2016-04-05 13:05:06 -0700 Comment on attachment 275679 patch Clearing flags on attachment: 275679 Committed r199070: <http://trac.webkit.org/changeset/199070> 1180934 8 commit-queue 2016-04-05 13:05:10 -0700 All reviewed patches have been landed. Closing bug. 1181263 9 ryanhaddad 2016-04-06 09:27:04 -0700 r199070 does not appear to have resolved the issue, as the tests are still timing out: <https://build.webkit.org/builders/Apple%20Yosemite%20Debug%20JSC%20%28Tests%29/builds/5514> 1181495 10 275839 saam 2016-04-06 17:51:21 -0700 Created attachment 275839 patch attempt #2 at preventing the timeout. For the record, the timeout is purely because the test runs out of time on a busy machine. When giving the test infinite time to run, it takes about 4 minutes to finish. 1181496 11 275839 keith_miller 2016-04-06 17:52:21 -0700 Comment on attachment 275839 patch r=me 1181523 12 275839 commit-queue 2016-04-06 18:50:14 -0700 Comment on attachment 275839 patch Clearing flags on attachment: 275839 Committed r199135: <http://trac.webkit.org/changeset/199135> 1181524 13 commit-queue 2016-04-06 18:50:18 -0700 All reviewed patches have been landed. Closing bug. 275679 2016-04-05 11:42:38 -0700 2016-04-06 17:51:21 -0700 patch c-backup.diff text/plain 1307 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5MDY0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE2LTA0LTA1ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IGpzYy1sYXlvdXQtdGVzdHMueWFtbC9qcy9zY3JpcHQtdGVzdHMvcmVncmVzcy0xNDEwOTguanMg ZmFpbGluZyBvbiBZb3NlbWl0ZSBEZWJ1ZyBhZnRlciByMTk4OTg5CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTYxODcKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgc3BlY3VsYXRpdmUgZml4 LiBMZXRzIHNlZSBpZiB0aGUgcHJldmVudHMgdGhlIHRpbWVvdXQuCisKKyAgICAgICAgKiBwYXJz ZXIvUGFyc2VyLmNwcDoKKyAgICAgICAgKEpTQzo6UGFyc2VyPExleGVyVHlwZT46OnBhcnNlU3Rh dGVtZW50TGlzdEl0ZW0pOgorCiAyMDE2LTA0LTA1ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0Bh cHBsZS5jb20+CiAKICAgICAgICAgW1dlYkdMMl0gVHVybiB0aGUgRU5BQkxFX1dFQkdMMiBmbGFn IG9uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCShyZXZpc2lv biAxOTkwNjQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTU0Miw2ICs1NDIsOSBAQCB0ZW1wbGF0ZSA8Y2xhc3MgVHJlZUJ1aWxk ZXI+IFRyZWVTdGF0ZW1lCiB7CiAgICAgLy8gVGhlIGdyYW1tYXIgaXMgZG9jdW1lbnRlZCBoZXJl OgogICAgIC8vIGh0dHA6Ly93d3cuZWNtYS1pbnRlcm5hdGlvbmFsLm9yZy9lY21hLTI2Mi82LjAv aW5kZXguaHRtbCNzZWMtc3RhdGVtZW50cworCisgICAgZmFpbElmU3RhY2tPdmVyZmxvdygpOwor CiAgICAgRGVwdGhNYW5hZ2VyIHN0YXRlbWVudERlcHRoKCZtX3N0YXRlbWVudERlcHRoKTsKICAg ICBtX3N0YXRlbWVudERlcHRoKys7CiAgICAgVHJlZVN0YXRlbWVudCByZXN1bHQgPSAwOwo= 275839 2016-04-06 17:51:21 -0700 2016-04-06 18:50:14 -0700 patch a-backup.diff text/plain 2302 saam SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5OTEyNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE2LTA0LTA2ICBTYWFtIGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgor CisgICAgICAgIGpzYy1sYXlvdXQtdGVzdHMueWFtbC9qcy9zY3JpcHQtdGVzdHMvcmVncmVzcy0x NDEwOTguanMgZmFpbGluZyBvbiBZb3NlbWl0ZSBEZWJ1ZyBhZnRlciByMTk4OTg5CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTYxODcKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWpz Yy1zdHJlc3MtdGVzdHM6CisKIDIwMTYtMDQtMDYgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0 ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBDb21waWxlIFdlYktpdFRlc3RSdW5uZXIgd2l0 aCBDTWFrZSBvbiBNYWMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVzdHMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkocmV2aXNp b24gMTk5MTEzKQorKysgVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwkod29ya2lu ZyBjb3B5KQpAQCAtMTEyNSw2ICsxMTI1LDE1IEBAIGRlZiBkZWZhdWx0UnVuTGF5b3V0VGVzdAog ICAgIGVuZAogZW5kCiAKK2RlZiBub0VhZ2VyTm9Ob0xMSW50VGVzdHNSdW5MYXlvdXRUZXN0Cisg ICAgcnVuTGF5b3V0VGVzdERlZmF1bHQKKyAgICBpZiAkaml0VGVzdHMKKyAgICAgICAgcnVuTGF5 b3V0VGVzdE5vQ0pJVAorICAgICAgICBydW5MYXlvdXRUZXN0RGVmYXVsdEZUTAorICAgICAgICBy dW5MYXlvdXRUZXN0RlRMTm9DSklUCisgICAgZW5kCitlbmQKKwogZGVmIG5vTm9MTEludFJ1bkxh eW91dFRlc3QKICAgICBydW5MYXlvdXRUZXN0RGVmYXVsdAogICAgIGlmICRqaXRUZXN0cwpJbmRl eDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5n ZUxvZwkocmV2aXNpb24gMTk5MTEzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTYtMDQtMDYgIFNhYW0gYmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CisKKyAgICAgICAganNjLWxheW91dC10ZXN0cy55YW1sL2pzL3NjcmlwdC10 ZXN0cy9yZWdyZXNzLTE0MTA5OC5qcyBmYWlsaW5nIG9uIFlvc2VtaXRlIERlYnVnIGFmdGVyIHIx OTg5ODkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 NjE4NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog anMvc2NyaXB0LXRlc3RzL3JlZ3Jlc3MtMTQxMDk4LmpzOgorCiAyMDE2LTA0LTA2ICBTYW0gV2Vp bmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgd2luZG93LkNTUyBzaG91bGQgYmUgYSBj b25zdHJ1Y3RvciB3aXRoIHN0YXRpYyBmdW5jdGlvbnMKSW5kZXg6IExheW91dFRlc3RzL2pzL3Nj cmlwdC10ZXN0cy9yZWdyZXNzLTE0MTA5OC5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9q cy9zY3JpcHQtdGVzdHMvcmVncmVzcy0xNDEwOTguanMJKHJldmlzaW9uIDE5OTExMykKKysrIExh eW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9yZWdyZXNzLTE0MTA5OC5qcwkod29ya2luZyBjb3B5 KQpAQCAtMSw0ICsxLDQgQEAKLS8vQCBub05vTExJbnRSdW5MYXlvdXRUZXN0IGlmICRhcmNoaXRl Y3R1cmUgPT0gImFybSIgYW5kICRob3N0T1MgPT0gImRhcndpbiIKKy8vQCBub0VhZ2VyTm9Ob0xM SW50VGVzdHNSdW5MYXlvdXRUZXN0CiAKIGRlc2NyaXB0aW9uKCJSZWdyZXNzaW9uIHRlc3QgZm9y IGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE0MTA5OC4gTWFrZSBzdXJlIGV2YWwoKSBwcm9wZXJseSBo YW5kbGVzIHJ1bm5pbmcgb3V0IG9mIHN0YWNrIHNwYWNlLiBUaGlzIHRlc3Qgc2hvdWxkIHJ1biB3 aXRob3V0IGNyYXNoaW5nLiIpOwogCg==