156181 2016-04-04 13:52:33 -0700 [JSC][x86] Fix an assertion in MacroAssembler::branch8() 2016-04-04 15:12:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin commit-queue ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1180483 0 benjamin 2016-04-04 13:52:33 -0700 [JSC][x86] Fix an assertion in MacroAssembler::branch8() 1180484 1 275567 benjamin 2016-04-04 13:54:32 -0700 Created attachment 275567 Patch 1180495 2 275567 ggaren 2016-04-04 14:23:05 -0700 Comment on attachment 275567 Patch r=me 1180499 3 ggaren 2016-04-04 14:24:33 -0700 Maybe an even better version would be: static_cast<int8_t>(right.m_value) == right.m_value. 1180506 4 benjamin 2016-04-04 14:46:10 -0700 (In reply to comment #3) > Maybe an even better version would be: static_cast<int8_t>(right.m_value) == > right.m_value. IMHO, that's shorter but the explicit version is clearer. 1180523 5 275567 commit-queue 2016-04-04 15:12:18 -0700 Comment on attachment 275567 Patch Clearing flags on attachment: 275567 Committed r199025: <http://trac.webkit.org/changeset/199025> 1180524 6 commit-queue 2016-04-04 15:12:23 -0700 All reviewed patches have been landed. Closing bug. 275567 2016-04-04 13:54:32 -0700 2016-04-04 15:12:18 -0700 Patch bug-156181-20160404135435.patch text/plain 1734 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTk5MDE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NGYwNjIwZDBlYzc0ZDYxYTY1MjFmMWQ5MjMwMGViODBhMzBjMzk1Li4zYTA3NTdmMzcxYTVmMTZm Njk4M2UwZDRiZmE1ZTQ3MTVkMDg2MTVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNi0wNC0wNCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxl LmNvbT4KKworICAgICAgICBbSlNDXVt4ODZdIEZpeCBhbiBhc3NlcnRpb24gaW4gTWFjcm9Bc3Nl bWJsZXI6OmJyYW5jaDgoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU2MTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaDoKKyAgICAgICAg KEpTQzo6TWFjcm9Bc3NlbWJsZXJYODZDb21tb246OmJyYW5jaDgpOgorICAgICAgICBUaGUgdGVz dCB3YXMgd3JvbmcgYmVjYXVzZSB2YWxpZCBuZWdhdGl2ZSBudW1iZXJzIGhhdmUgb25lcworICAg ICAgICBpbiB0aGUgdG9wIGJpdHMuCisKKyAgICAgICAgSSByZXBsYWNlZCB0aGUgYXNzZXJ0aW9u IHRvIGJlIGV4cGxpY2l0IGFib3V0IHRoZSB2YWxpZCByYW5nZS4KKwogMjAxNi0wNC0wNCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJlZ3Jlc3Npb24ocjE5NjE0 NSk6IENyYXNoIGluIGdldE93blByb3BlcnR5RGVzY3JpcHRvciBvbiBodHRwOi8vd3d3Lmhpc3Rv cnkuY29tL3Nob3dzL3Zpa2luZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaAppbmRleCA5NDY1ZDkyMTU5MzZj MzZhNjgyMjllNzBlOGNlNzFlMTIyYjNjNWFlLi5kNjc4NWQ4ZDE1YjI0Y2IxZGM2ZjY2N2EzZGU5 ZjljOTliZTllOTc4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyWDg2Q29tbW9uLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCkBAIC0yMjI4LDcgKzIyMjgsNyBAQCBw dWJsaWM6CiAKICAgICBKdW1wIGJyYW5jaDgoUmVsYXRpb25hbENvbmRpdGlvbiBjb25kLCBCYXNl SW5kZXggbGVmdCwgVHJ1c3RlZEltbTMyIHJpZ2h0KQogICAgIHsKLSAgICAgICAgQVNTRVJUKCEo cmlnaHQubV92YWx1ZSAmIDB4RkZGRkZGMDApKTsKKyAgICAgICAgQVNTRVJUKHN0ZDo6bnVtZXJp Y19saW1pdHM8aW50OF90Pjo6bWluKCkgPD0gcmlnaHQubV92YWx1ZSAmJiByaWdodC5tX3ZhbHVl IDw9IHN0ZDo6bnVtZXJpY19saW1pdHM8aW50OF90Pjo6bWF4KCkpOwogCiAgICAgICAgIG1fYXNz ZW1ibGVyLmNtcGJfaW0ocmlnaHQubV92YWx1ZSwgbGVmdC5vZmZzZXQsIGxlZnQuYmFzZSwgbGVm dC5pbmRleCwgbGVmdC5zY2FsZSk7CiAgICAgICAgIHJldHVybiBKdW1wKG1fYXNzZW1ibGVyLmpD Qyh4ODZDb25kaXRpb24oY29uZCkpKTsK