<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>156168</bug_id>
          
          <creation_ts>2016-04-04 09:23:26 -0700</creation_ts>
          <short_desc>CopiedBlock should be 16kB</short_desc>
          <delta_ts>2016-04-06 23:41:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Geoffrey Garen">ggaren</reporter>
          <assigned_to name="Geoffrey Garen">ggaren</assigned_to>
          <cc>barraclough</cc>
    
    <cc>benjamin</cc>
    
    <cc>commit-queue</cc>
    
    <cc>keith_miller</cc>
    
    <cc>kling</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>saam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1180384</commentid>
    <comment_count>0</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-04 09:23:26 -0700</bug_when>
    <thetext>CopiedBlock should be 16kB</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180385</commentid>
    <comment_count>1</comment_count>
      <attachid>275551</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-04 09:29:28 -0700</bug_when>
    <thetext>Created attachment 275551
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180391</commentid>
    <comment_count>2</comment_count>
      <attachid>275551</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2016-04-04 09:43:04 -0700</bug_when>
    <thetext>Comment on attachment 275551
Patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180439</commentid>
    <comment_count>3</comment_count>
      <attachid>275551</attachid>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-04 11:51:15 -0700</bug_when>
    <thetext>Comment on attachment 275551
Patch

cq+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180449</commentid>
    <comment_count>4</comment_count>
      <attachid>275551</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-04 12:41:32 -0700</bug_when>
    <thetext>Comment on attachment 275551
Patch

Clearing flags on attachment: 275551

Committed r199016: &lt;http://trac.webkit.org/changeset/199016&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180450</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-04 12:41:36 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180757</commentid>
    <comment_count>6</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2016-04-05 00:41:22 -0700</bug_when>
    <thetext>Something really curious happened with this: https://arewefastyet.com/#machine=29&amp;view=single&amp;suite=kraken&amp;subtest=beat-detection

Any idea how to get back this win without the other regressions?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180866</commentid>
    <comment_count>7</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-05 10:52:16 -0700</bug_when>
    <thetext>Rolled out in &lt;http://trac.webkit.org/changeset/199032&gt;.

&quot;Regressed Octane and Kraken on the perf bots.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180872</commentid>
    <comment_count>8</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-05 10:58:11 -0700</bug_when>
    <thetext>&gt; Any idea how to get back this win without the other regressions?

I might be able to bring it back. I didn&apos;t quite do it the best way the first time because I forgot to consider aligned allocation requests, which still take the slow path.

I don&apos;t understand that graph though -- what does it say?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1181533</commentid>
    <comment_count>9</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-06 19:08:17 -0700</bug_when>
    <thetext>Committed r199125: &lt;http://trac.webkit.org/changeset/199125&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1181562</commentid>
    <comment_count>10</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-06 20:33:46 -0700</bug_when>
    <thetext>Rolled out in &lt;http://trac.webkit.org/changeset/199145&gt;.

&quot;Perf bots are down, so I can&apos;t re-land this right now.&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1181603</commentid>
    <comment_count>11</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2016-04-06 23:41:31 -0700</bug_when>
    <thetext>On Octane, there&apos;s no regression.

On Kraken:

    1% speedup on Mac Pro
    1% speedup on iPhone (+/- !%)
    1% regression on MacBook Pro
    1% regression on MacBook Air

That&apos;s enough of a mixed review that I think I&apos;ll leave this alone for now.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>275551</attachid>
            <date>2016-04-04 09:29:28 -0700</date>
            <delta_ts>2016-04-04 12:41:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-156168-20160404092934.patch</filename>
            <type>text/plain</type>
            <size>1537</size>
            <attacher name="Geoffrey Garen">ggaren</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291
cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTk5MDA3KQorKysgU291cmNl
L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA
CisyMDE2LTA0LTA0ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg
ICAgQ29waWVkQmxvY2sgc2hvdWxkIGJlIDE2a0IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjE2OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E
WSAoT09QUyEpLgorCisgICAgICAgIE1hcmtlZEJsb2NrIGlzIDE2a0IsIGFuZCBibWFsbG9jJ3Mg
bGFyZ2VzdCBmYXN0LXBhdGggYWxsb2NhdGlvbiBpcyAxNmtCLAorICAgICAgICBhbmQgdGhlIGxh
cmdlc3QgcGFnZSBzaXplIG9uIEFwcGxlIGRldmljZXMgaXMgMTZrQiAtLSBzbyB0aGlzIGNoYW5n
ZQorICAgICAgICBzaG91bGQgaW1wcm92ZSBzaGFyaW5nIGFuZCByZWN5Y2xpbmcgYW5kIGtlZXAg
dXMgb24gdGhlIGZhc3QgcGF0aCBtb3JlLgorCisgICAgICAgIDMya0IgaXMgYWxzbyBzdXBlciBh
Z2dyby4gQXQgMTZrQiwgd2Ugc3VwcG9ydCBhbGxvY2F0aW9ucyB1cCB0byA4a0IsCisgICAgICAg
IHdoaWNoIGNvdmVycyA5OS4zJSBvZiBhbGxvY2F0aW9ucyBvbiBmYWNlYm9vay5jb20uIFRoZSAz
MmtCIGJsb2NrIHNpemUKKyAgICAgICAgb25seSBjb3ZlcmVkIGFuIGFkZGl0aW9uYWwgMC4yJSBv
ZiBhbGxvY2F0aW9ucy4KKworICAgICAgICAqIGhlYXAvQ29waWVkQmxvY2suaDoKKwogMjAxNi0w
NC0wNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAg
ICAgUkVHUkVTU0lPTihyMTk4NzkyKTogW0dUS10gSW5zcGVjdG9yIGNyYXNoZXMgaW4gSW5zcGVj
dG9yOjpQcm90b2NvbDo6Z2V0RW51bUNvbnN0YW50VmFsdWUgc2luY2UgcjE5ODc5MgpJbmRleDog
U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvQ29waWVkQmxvY2suaAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT
b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRCbG9jay5oCShyZXZpc2lvbiAxOTkwMDcp
CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Db3BpZWRCbG9jay5oCSh3b3JraW5nIGNv
cHkpCkBAIC03OSw3ICs3OSw3IEBAIHB1YmxpYzoKICAgICBzaXplX3Qgc2l6ZSgpOwogICAgIHNp
emVfdCBjYXBhY2l0eSgpOwogCi0gICAgc3RhdGljIGNvbnN0IHNpemVfdCBibG9ja1NpemUgPSAz
MiAqIEtCOworICAgIHN0YXRpYyBjb25zdCBzaXplX3QgYmxvY2tTaXplID0gMTYgKiBLQjsKIAog
ICAgIGJvb2wgaGFzV29ya0xpc3QoKTsKICAgICBDb3B5V29ya0xpc3QmIHdvcmtMaXN0KCk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>