156161 2016-04-04 02:16:10 -0700 Add missing EABI_32BIT_DUMMY_ARG arguments for some callOperation(J_JITOperation_EGReoJ, ...) overloads 2016-04-05 00:59:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan commit-queue fpizlo keith_miller mark.lam msaboff ossy saam ysuzuki oldest_to_newest 1180314 0 zan 2016-04-04 02:16:10 -0700 Add missing EABI_32BIT_DUMMY_ARG arguments for some callOperation(J_JITOperation_EGReoJ, ...) overloads 1180323 1 275542 zan 2016-04-04 02:27:03 -0700 Created attachment 275542 Patch 1180345 2 275542 ysuzuki 2016-04-04 05:10:34 -0700 Comment on attachment 275542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275542&action=review Nice catch! > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1742 > + m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3Payload, arg3Tag); Is SH4_32BIT_DUMMY_ARG necessary here too? (BTW, at a glance, there are several missing SH4_32BIT_DUMMY_ARG. I'm not sure there are any active users of SH4 port...) > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1854 > + m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3Payload, arg3Tag); Ditto. 1180735 3 275542 zan 2016-04-04 23:29:25 -0700 Comment on attachment 275542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275542&action=review >> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:1742 >> + m_jit.setupArgumentsWithExecState(arg1, arg2, EABI_32BIT_DUMMY_ARG arg3Payload, arg3Tag); > > Is SH4_32BIT_DUMMY_ARG necessary here too? > (BTW, at a glance, there are several missing SH4_32BIT_DUMMY_ARG. I'm not sure there are any active users of SH4 port...) I don't know. The comment for SH4_32BIT_DUMMY_ARG suggests yes, but in that case there are a lot of these dummy args missing already, and I'm not aware of any public builder testing for this configuration. Not being able to test on this platform makes me reluctant to try and put args into the proper places. 1180736 4 275542 zan 2016-04-04 23:30:07 -0700 Comment on attachment 275542 Patch Clearing flags on attachment: 275542 Committed r199052: <http://trac.webkit.org/changeset/199052> 1180737 5 zan 2016-04-04 23:30:16 -0700 All reviewed patches have been landed. Closing bug. 275542 2016-04-04 02:27:03 -0700 2016-04-04 23:30:07 -0700 Patch bug-156161-20160404022707.patch text/plain 2676 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4OTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 NDNiZTg5NGZlZjhkZDg3MTgxMzVkZTQ1NzRlNGZlNTNlNTc0NzNkLi5iNGEyODBmMTlhODQ0MmE5 OGQ2YWRmYjgzZDI1ZjUzN2Y2OWFlNTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0wNC0wNCAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5j b20+CisKKyAgICAgICAgQWRkIG1pc3NpbmcgRUFCSV8zMkJJVF9EVU1NWV9BUkcgYXJndW1lbnRz IGZvciBzb21lIGNhbGxPcGVyYXRpb24oSl9KSVRPcGVyYXRpb25fRUdSZW9KLCAuLi4pIG92ZXJs b2FkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2 MTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjE5 NzY0MSBhZGRlZCBhIGNvdXBsZSBvZiBjYWxsT3BlcmF0aW9uKEpfSklUT3BlcmF0aW9uX0VHUmVv SiwgLi4uKSBvdmVybG9hZHMKKyAgICAgICAgdGhhdCBoYW5kbGUgYXJndW1lbnRzIHNwbGl0IGlu dG8gdGhlIHRhZyBhbmQgdGhlIHBheWxvYWQuIFRoZSB0d28gd2VyZSBzcGxpdAorICAgICAgICBi ZXR3ZWVuIHRoZSBsYXN0IGFyZ3VtZW50IHJlZ2lzdGVyIGFuZCB0aGUgc3RhY2sgb24gMzItYml0 IEFSTSBFQUJJIHN5c3RlbXMsCisgICAgICAgIGNhdXNpbmcgaW5jb3JyZWN0IGJlaGF2aW9yLgor CisgICAgICAgIEFkZGluZyBFQUJJXzMyQklUX0RVTU1ZX0FSRyBwdXNoZXMgdGhlIHRhZyBhbmQg cGF5bG9hZCB0b2dldGhlciBvbnRvIHRoZQorICAgICAgICBzdGFjaywgcmVtb3ZpbmcgdGhlIGlz c3VlLgorCisgICAgICAgICogZGZnL0RGR1NwZWN1bGF0aXZlSklULmg6CisgICAgICAgIChKU0M6 OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNhbGxPcGVyYXRpb24pOgorCiAyMDE2LTA0LTAzICBTYWFt IGJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIEltcGxlbWVudCBBbm5leCBC LjMuMyBmdW5jdGlvbiBob2lzdGluZyBydWxlcyBmb3IgZnVuY3Rpb24gY29kZQpkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVC5oCmluZGV4IGE2ZjkwYzdkMDc2 Zjc1MmY2ZDM2ZjdhZmU3NmU0ZTZjNmI1OGVhNzYuLjNhZDkxNzU2ZWRiYzQzZGQ4MWE0MDEzNDVh NDZlMTg5YzY3MmUzYzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH U3BlY3VsYXRpdmVKSVQuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1NwZWN1 bGF0aXZlSklULmgKQEAgLTE3MzksNyArMTczOSw3IEBAIHB1YmxpYzoKICAgICB9CiAgICAgSklU Q29tcGlsZXI6OkNhbGwgY2FsbE9wZXJhdGlvbihKX0pJVE9wZXJhdGlvbl9FR1Jlb0ogb3BlcmF0 aW9uLCBHUFJSZWcgcmVzdWx0VGFnLCBHUFJSZWcgcmVzdWx0UGF5bG9hZCwgR1BSUmVnIGFyZzEs IEdQUlJlZyBhcmcyLCBHUFJSZWcgYXJnM1RhZywgR1BSUmVnIGFyZzNQYXlsb2FkKQogICAgIHsK LSAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKGFyZzEsIGFyZzIsIGFy ZzNQYXlsb2FkLCBhcmczVGFnKTsKKyAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVudHNXaXRoRXhl Y1N0YXRlKGFyZzEsIGFyZzIsIEVBQklfMzJCSVRfRFVNTVlfQVJHIGFyZzNQYXlsb2FkLCBhcmcz VGFnKTsKICAgICAgICAgcmV0dXJuIGFwcGVuZENhbGxTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1 bHRQYXlsb2FkLCByZXN1bHRUYWcpOwogICAgIH0KICAgICBKSVRDb21waWxlcjo6Q2FsbCBjYWxs T3BlcmF0aW9uKEpfSklUT3BlcmF0aW9uX0VHUmVvSnNzIG9wZXJhdGlvbiwgR1BSUmVnIHJlc3Vs dFRhZywgR1BSUmVnIHJlc3VsdFBheWxvYWQsIEdQUlJlZyBhcmcxLCBHUFJSZWcgYXJnMiwgR1BS UmVnIGFyZzMpCkBAIC0xODUxLDcgKzE4NTEsNyBAQCBwdWJsaWM6CiAgICAgfQogICAgIEpJVENv bXBpbGVyOjpDYWxsIGNhbGxPcGVyYXRpb24oU19KSVRPcGVyYXRpb25fRUdSZW9KIG9wZXJhdGlv biwgR1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFyZzEsIEdQUlJlZyBhcmcyLCBHUFJSZWcgYXJnM1Rh ZywgR1BSUmVnIGFyZzNQYXlsb2FkKQogICAgIHsKLSAgICAgICAgbV9qaXQuc2V0dXBBcmd1bWVu dHNXaXRoRXhlY1N0YXRlKGFyZzEsIGFyZzIsIGFyZzNQYXlsb2FkLCBhcmczVGFnKTsKKyAgICAg ICAgbV9qaXQuc2V0dXBBcmd1bWVudHNXaXRoRXhlY1N0YXRlKGFyZzEsIGFyZzIsIEVBQklfMzJC SVRfRFVNTVlfQVJHIGFyZzNQYXlsb2FkLCBhcmczVGFnKTsKICAgICAgICAgcmV0dXJuIGFwcGVu ZENhbGxTZXRSZXN1bHQob3BlcmF0aW9uLCByZXN1bHQpOwogICAgIH0KICAgICBKSVRDb21waWxl cjo6Q2FsbCBjYWxsT3BlcmF0aW9uKFNfSklUT3BlcmF0aW9uX0VHUmVvSnNzIG9wZXJhdGlvbiwg R1BSUmVnIHJlc3VsdCwgR1BSUmVnIGFyZzEsIEdQUlJlZyBhcmcyLCBHUFJSZWcgYXJnMykK