<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>156151</bug_id>
          
          <creation_ts>2016-04-03 17:06:41 -0700</creation_ts>
          <short_desc>prepare-ChangeLog set endl incorrectly</short_desc>
          <delta_ts>2016-04-04 15:54:30 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Bill Ming">mbbill</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>lforschler</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1180241</commentid>
    <comment_count>0</comment_count>
    <who name="Bill Ming">mbbill</who>
    <bug_when>2016-04-03 17:06:41 -0700</bug_when>
    <thetext>prepare-Changelog tried to detect line endings based on the target file format, normally the ChangeLog file is in unix (&apos;\n&apos;) line endings, and the perl script will prepare content with each line appended with a &apos;\n&apos;, but when writing to the file, perl will try to convert line endings with the platform&apos;s native line endings and result in changing the whole file into dos format.
setting the binmode can fix this issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180242</commentid>
    <comment_count>1</comment_count>
      <attachid>275518</attachid>
    <who name="Bill Ming">mbbill</who>
    <bug_when>2016-04-03 17:09:26 -0700</bug_when>
    <thetext>Created attachment 275518
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180546</commentid>
    <comment_count>2</comment_count>
      <attachid>275518</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-04 15:54:26 -0700</bug_when>
    <thetext>Comment on attachment 275518
Patch

Clearing flags on attachment: 275518

Committed r199029: &lt;http://trac.webkit.org/changeset/199029&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1180547</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2016-04-04 15:54:30 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>275518</attachid>
            <date>2016-04-03 17:09:26 -0700</date>
            <delta_ts>2016-04-04 15:54:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-156151-20160403170955.patch</filename>
            <type>text/plain</type>
            <size>1313</size>
            <attacher name="Bill Ming">mbbill</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4OTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjY5Mjg5MDcyOThiYTAxODRhMThlZGYwN2Q0OTUzODE3
NTI3YjVjYS4uMTNiNTg3OWE5MzM1YTlmZjQxZjZhZTlkZGRhYzkxYjhiNjcwNGQwZSAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy
IEBACisyMDE2LTA0LTAzICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgorCisgICAgICAg
IHByZXBhcmUtQ2hhbmdlTG9nIHNldCBlbmRsIGluY29ycmVjdGx5LgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2MTUxCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUb29scy9TY3JpcHRzL3ByZXBhcmUt
Q2hhbmdlTG9nOgorCiAyMDE2LTA0LTAzICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+
CiAKICAgICAgICAgVXNlIHRoZSBjb3JyZWN0IHZhbHVlIGZvciB0aGUgZmlyc3QgbmlnaHRseSBi
dWlsZCB3aXRoIGZyYW1ld29ya3MgYnVpbHQgZm9yIE9TIFggMTAuMTEuCmRpZmYgLS1naXQgYS9U
b29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nIGIvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNo
YW5nZUxvZwppbmRleCBjODllYWUxMGYyOTY2NGNhZTRmZjVjYjZkNDQyYTViNjdlZThmYWRjLi40
MGMyYjczOWM2ZDllYmVjZTY1NjliMmMyZjIzMzI2MzZlOGQyZjAyIDEwMDc1NQotLS0gYS9Ub29s
cy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1D
aGFuZ2VMb2cKQEAgLTYwOSw2ICs2MDksNyBAQCBzdWIgZ2VuZXJhdGVOZXdDaGFuZ2VMb2dzKCQk
JCQkJCQkJCQkJCQkKQogICAgICAgICAgICAgICAgICRlbmRsID0gIiQxIjsKICAgICAgICAgICAg
IH0KICAgICAgICAgICAgIG9wZW4gQ0hBTkdFX0xPRywgIj4gJHtjaGFuZ2VMb2dQYXRofSIgb3Ig
ZGllICJDb3VsZCBub3Qgd3JpdGUgJHtjaGFuZ2VMb2dQYXRofVxuLiI7CisgICAgICAgICAgICBi
aW5tb2RlKENIQU5HRV9MT0cpOwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgb3BlbiBD
SEFOR0VfTE9HLCAiPi0iIG9yIGRpZSAiQ291bGQgbm90IHdyaXRlIHRvIFNURE9VVFxuLiI7CiAg
ICAgICAgICAgICBwcmludCBzdWJzdHIoJHByZWZpeCwgMCwgbGVuZ3RoKCRwcmVmaXgpIC0gMSkg
LiAiOlxuXG4iIHVubGVzcyAoc2NhbGFyIEAkcHJlZml4ZXMpID09IDEgJiYgISRkZWxpbWl0ZXJz
Owo=
</data>

          </attachment>
      

    </bug>

</bugzilla>