156150 2016-04-03 16:36:15 -0700 [win] DumpRenderTree failed to launch 2016-04-04 20:54:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mbbill webkit-unassigned achristensen commit-queue glenn lforschler ossy oldest_to_newest 1180238 0 mbbill 2016-04-03 16:36:15 -0700 DumpRenderTree failed to launch when I tried to run webkit tests. It's because WEBKIT_LIBRARIES environment is not included in 'env' passing to the launcher. 1180239 1 275517 mbbill 2016-04-03 16:39:43 -0700 Created attachment 275517 Patch 1180515 2 275517 achristensen 2016-04-04 14:58:20 -0700 Comment on attachment 275517 Patch Hmmm, I'd like to get rid of our required use of the WEBKIT_LIBRARIES environment variable. Is there any way you could modify DLLLauncherMain.cpp instead to work without it? 1180525 3 mbbill 2016-04-04 15:12:49 -0700 I'm thinking of that too. That may need another bigger patch to completely get rid of the WEBKIT_LIBRARIES environment variable because the reference to it is not just limited to this. Shall I modify DLLLauncherMain.cpp for this patch first and then deal with other ones in another commit? 1180526 4 achristensen 2016-04-04 15:14:08 -0700 We still want to use the WEBKIT_LIBRARIES environment variable if it exists, because the Windows Early Warning System bots use it, but I don't want to require it for someone to just build and run WebKit on a new machine. 1180527 5 mbbill 2016-04-04 15:19:05 -0700 So the logic should be like, if the environment exists, use it; if not, use a hard-coded path, am I right? 1180528 6 mbbill 2016-04-04 15:19:34 -0700 hard-coded relative path by the way. 1180565 7 mbbill 2016-04-04 16:31:38 -0700 After digging into the launcher code, I think it would be a little bit nasty to hard-code a relative path there. Either minibrowser.exe or dumprendertree.exe could be anywhere depend on user settings, so it doesn't make too much sense to put a 'default' dll path over there. Actually the 'default' path could also change, considering that user can say 'yes' or 'no' when asked by webkit-patch script if he would like to put all build results into a branch name folder 1180656 8 275517 achristensen 2016-04-04 20:03:47 -0700 Comment on attachment 275517 Patch I guess this is good. If the WEBKIT_LIBRARIES variable is set, use it. That's what this patch does. Honestly, I usually copy all the WinCairoRequirements dlls into the build directory manually. 1180670 9 275517 commit-queue 2016-04-04 20:54:53 -0700 Comment on attachment 275517 Patch Clearing flags on attachment: 275517 Committed r199036: <http://trac.webkit.org/changeset/199036> 1180671 10 commit-queue 2016-04-04 20:54:57 -0700 All reviewed patches have been landed. Closing bug. 275517 2016-04-03 16:39:43 -0700 2016-04-04 20:54:53 -0700 Patch bug-156150-20160403164012.patch text/plain 1114 mbbill U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4OTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjY5Mjg5MDcyOThiYTAxODRhMThlZGYwN2Q0OTUzODE3 NTI3YjVjYS4uNTY1M2MxOWNmODQ2YmYwOTFlMWUxZjkwNTM1OGY3NWYwZDQyM2U1YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTA0LTAzICBCaWxsIE1pbmcgIDxtYmJpbGxAZ21haWwuY29tPgorCisgICAgICAg IFt3aW5dIHJ1bi13ZWJraXQtdGVzdHMgZmFpbGVkIHRvIGxhdW5jaCBEdW1wUmVuZGVyVHJlZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU2MTUwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weToKKwogMjAxNi0wNC0wMyAgRGFuIEJlcm5zdGVp biAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSB0aGUgY29ycmVjdCB2YWx1ZSBmb3Ig dGhlIGZpcnN0IG5pZ2h0bHkgYnVpbGQgd2l0aCBmcmFtZXdvcmtzIGJ1aWx0IGZvciBPUyBYIDEw LjExLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQppbmRleCA5MThmNjI2ZTJlZmM5OTEx ODdjNjc1NjdkNmNhZDZkNDUwNDFiNTliLi5kMDk1MDNjMjM4N2U1M2RmMjNkYzU1MTVhZmU0ZWU0 MDhkN2E4ZWYwIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5w eQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvYmFzZS5weQpAQCAtODU0LDYgKzg1 NCw3IEBAIGNsYXNzIFBvcnQob2JqZWN0KToKICAgICAgICAgICAgICdQQVRIJywKICAgICAgICAg ICAgICdTWVNURU1EUklWRScsCiAgICAgICAgICAgICAnU1lTVEVNUk9PVCcsCisgICAgICAgICAg ICAnV0VCS0lUX0xJQlJBUklFUycsCiAKICAgICAgICAgICAgICMgTW9zdCBwb3J0cyAoPyk6CiAg ICAgICAgICAgICAnV0VCS0lUX1RFU1RGT05UUycsCg==