156139 2016-04-02 14:52:57 -0700 Uncaught Exception: Error: Can't make a ContentView for an unknown representedObject (ApplicationCacheManifest) 2016-04-04 22:20:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build Mac OS X 10.11 RESOLVED FIXED InRadar P2 Normal --- 1 dbates joepeck bburg commit-queue graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1180109 0 dbates 2016-04-02 14:52:57 -0700 ------- Auto-generated details: Inspected URL: https://webkit.org/demos/sticky-notes/ Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/602.1.27+ (KHTML, like Gecko) Uncaught exceptions: - Error: Can't make a ContentView for an unknown representedObject. (at ContentView.js:149:86) ------- * STEPS TO REPRODUCE 1. Visit <https://webkit.org/demos/sticky-notes/>. 2. Inspect the page. I am using a release build of WebKit r198972. 1180110 1 webkit-bug-importer 2016-04-02 14:53:22 -0700 <rdar://problem/25511926> 1180575 2 joepeck 2016-04-04 16:46:01 -0700 I was able to reproduce. Improving the error message, I see two issues: NavigationSidebarPanel.js:234:26: CONSOLE ERROR Error: TreeElement.representedObject is missing a saveIdentityToCookie implementation. TreeElement.constructor: class ApplicationCacheManifestTreeElement extends WebInspector.StorageTreeElement ContentView.js:149:132" CONSOLE ERROR Error: Can't make a ContentView for an unknown representedObject of type: ApplicationCacheManifest 1180580 3 275593 joepeck 2016-04-04 16:58:06 -0700 Created attachment 275593 [PATCH] Proposed Fix 1180584 4 275593 timothy 2016-04-04 17:03:20 -0700 Comment on attachment 275593 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=275593&action=review > Source/WebInspectorUI/UserInterface/Views/ContentView.js:149 > + throw new Error("Can't make a ContentView for an unknown representedObject of type: " + representedObject.constructor.name); Good call! 1180710 5 275593 commit-queue 2016-04-04 22:20:38 -0700 Comment on attachment 275593 [PATCH] Proposed Fix Clearing flags on attachment: 275593 Committed r199041: <http://trac.webkit.org/changeset/199041> 1180711 6 commit-queue 2016-04-04 22:20:42 -0700 All reviewed patches have been landed. Closing bug. 275593 2016-04-04 16:58:06 -0700 2016-04-04 22:20:38 -0700 [PATCH] Proposed Fix applicationcache.patch text/plain 5185 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDMyNzdhY2MuLmI4MzNmZTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDE2LTA0LTA0ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBF cnJvcjogQ2FuJ3QgbWFrZSBhIENvbnRlbnRWaWV3IGZvciBhbiB1bmtub3duIHJlcHJlc2VudGVk T2JqZWN0IChBcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3QpCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTYxMzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzI1NTExOTI2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5Db250ZW50Vmlldy5jcmVhdGVGcm9tUmVwcmVzZW50ZWRPYmplY3QpOgorICAgICAg ICBJbXByb3ZlIHRoZSBlcnJvciBtZXNzYWdlIHRvIGdldCB0aGUgbmFtZSBvZiB0aGUgcmVwcmVz ZW50ZWQgb2JqZWN0LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9u U2lkZWJhclBhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLk5hdmlnYXRpb25TaWRlYmFy UGFuZWwucHJvdG90eXBlLl9pc1RyZWVFbGVtZW50V2l0aG91dFJlcHJlc2VudGVkT2JqZWN0KToK KyAgICAgICAgVHJlYXQgQXBwbGljYXRpb25DYWNoZU1hbmlmZXN0VHJlZUVsZW1lbnQgbGlrZSBv dGhlciBIb3N0IGVsZW1lbnRzLiBOb3RoaW5nIHRvIHNhdmUvc2hvdy4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvQXBwbGljYXRpb25DYWNoZU1hbmlmZXN0VHJlZUVsZW1lbnQuanM6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQXBwbGljYXRpb25DYWNoZU1hbmlmZXN0VHJlZUVsZW1l bnQpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YWJhc2VIb3N0VHJlZUVsZW1l bnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGF0YWJhc2VIb3N0VHJlZUVsZW1lbnQpOgor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvSW5kZXhlZERhdGFiYXNlSG9zdFRyZWVFbGVt ZW50LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkluZGV4ZWREYXRhYmFzZUhvc3RUcmVlRWxl bWVudCk6CisgICAgICAgIEF1dG8tZXhwYW5kIHRoZXNlIGZvbGRlcnMsIGFzIHRoZXkgYXJlIG5v dCB1c2VmdWwgd2hlbiBjb2xsYXBzZWQuCisKKzIwMTYtMDQtMDQgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBVbmNhdWdodCBl eGNlcHRpb24gaW4gQ1NTIHdpdGggc3RyaW5nICJjb25zdHJ1Y3RvciIgKFdlYkluc3BlY3Rvci5D b2xvci5mcm9tU3RyaW5nKCkpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTYxODMKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI1NTM5Mjc5PgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXBwbGlj YXRpb25DYWNoZU1hbmlmZXN0VHJlZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9BcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RUcmVlRWxlbWVudC5q cwppbmRleCA4MDU2NTc2Li4yN2E5NWM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9BcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3RUcmVlRWxlbWVu dC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BcHBs aWNhdGlvbkNhY2hlTWFuaWZlc3RUcmVlRWxlbWVudC5qcwpAQCAtMzAsNiArMzAsOSBAQCBXZWJJ bnNwZWN0b3IuQXBwbGljYXRpb25DYWNoZU1hbmlmZXN0VHJlZUVsZW1lbnQgPSBjbGFzcyBBcHBs aWNhdGlvbkNhY2hlTWFuaWZlcwogICAgICAgICBjb25zb2xlLmFzc2VydChyZXByZXNlbnRlZE9i amVjdCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5BcHBsaWNhdGlvbkNhY2hlTWFuaWZlc3QpOwog CiAgICAgICAgIHN1cGVyKCJhcHBsaWNhdGlvbi1jYWNoZS1tYW5pZmVzdCIsICIiLCByZXByZXNl bnRlZE9iamVjdCk7CisKKyAgICAgICAgdGhpcy5oYXNDaGlsZHJlbiA9IHRydWU7CisgICAgICAg IHRoaXMuZXhwYW5kZWQgPSB0cnVlOwogICAgIH0KIAogICAgIC8vIFB1YmxpYwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29udGVudFZpZXcu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmll dy5qcwppbmRleCAwNGFlOWIzLi5mNGY0ZGUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qcwpAQCAtMTQ2LDcg KzE0Niw3IEBAIFdlYkluc3BlY3Rvci5Db250ZW50VmlldyA9IGNsYXNzIENvbnRlbnRWaWV3IGV4 dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKIAogICAgICAgICBjb25zb2xlLmFzc2VydCghV2ViSW5z cGVjdG9yLkNvbnRlbnRWaWV3LmlzVmlld2FibGUocmVwcmVzZW50ZWRPYmplY3QpKTsKIAotICAg ICAgICB0aHJvdyBuZXcgRXJyb3IoIkNhbid0IG1ha2UgYSBDb250ZW50VmlldyBmb3IgYW4gdW5r bm93biByZXByZXNlbnRlZE9iamVjdC4iKTsKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJDYW4n dCBtYWtlIGEgQ29udGVudFZpZXcgZm9yIGFuIHVua25vd24gcmVwcmVzZW50ZWRPYmplY3Qgb2Yg dHlwZTogIiArIHJlcHJlc2VudGVkT2JqZWN0LmNvbnN0cnVjdG9yLm5hbWUpOwogICAgIH0KIAog ICAgIHN0YXRpYyBjb250ZW50Vmlld0ZvclJlcHJlc2VudGVkT2JqZWN0KHJlcHJlc2VudGVkT2Jq ZWN0LCBvbmx5RXhpc3RpbmcsIGV4dHJhQXJndW1lbnRzKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YWJhc2VIb3N0VHJlZUVsZW1lbnQu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhYmFzZUhv c3RUcmVlRWxlbWVudC5qcwppbmRleCA4NWJjNzBkLi5hMzU1ZGYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhYmFzZUhvc3RUcmVlRWxl bWVudC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9E YXRhYmFzZUhvc3RUcmVlRWxlbWVudC5qcwpAQCAtMzIsNiArMzIsNyBAQCBXZWJJbnNwZWN0b3Iu RGF0YWJhc2VIb3N0VHJlZUVsZW1lbnQgPSBjbGFzcyBEYXRhYmFzZUhvc3RUcmVlRWxlbWVudCBl eHRlbmRzIFdlYgogICAgICAgICB0aGlzLl9ob3N0ID0gaG9zdDsKIAogICAgICAgICB0aGlzLmhh c0NoaWxkcmVuID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5leHBhbmRlZCA9IHRydWU7CiAgICAgfQog CiAgICAgLy8gUHVibGljCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9JbmRleGVkRGF0YWJhc2VIb3N0VHJlZUVsZW1lbnQuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9JbmRleGVkRGF0YWJhc2VIb3N0VHJl ZUVsZW1lbnQuanMKaW5kZXggMGIyMDViZi4uZDRmYjYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvSW5kZXhlZERhdGFiYXNlSG9zdFRyZWVF bGVtZW50LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0luZGV4ZWREYXRhYmFzZUhvc3RUcmVlRWxlbWVudC5qcwpAQCAtMzIsNiArMzIsNyBAQCBXZWJJ bnNwZWN0b3IuSW5kZXhlZERhdGFiYXNlSG9zdFRyZWVFbGVtZW50ID0gY2xhc3MgSW5kZXhlZERh dGFiYXNlSG9zdFRyZWVFbGVtZQogICAgICAgICB0aGlzLl9ob3N0ID0gaG9zdDsKIAogICAgICAg ICB0aGlzLmhhc0NoaWxkcmVuID0gdHJ1ZTsKKyAgICAgICAgdGhpcy5leHBhbmRlZCA9IHRydWU7 CiAgICAgfQogCiAgICAgLy8gUHVibGljCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5l bC5qcwppbmRleCAwOTU4YThiLi44OGNkMjYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRl YmFyUGFuZWwuanMKQEAgLTY3NCw2ICs2NzQsNyBAQCBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNp ZGViYXJQYW5lbCA9IGNsYXNzIE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbgog ICAgICAgICByZXR1cm4gdHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuRm9sZGVy VHJlZUVsZW1lbnQKICAgICAgICAgICAgIHx8IHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5z cGVjdG9yLkRhdGFiYXNlSG9zdFRyZWVFbGVtZW50CiAgICAgICAgICAgICB8fCB0cmVlRWxlbWVu dCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5JbmRleGVkRGF0YWJhc2VIb3N0VHJlZUVsZW1lbnQK KyAgICAgICAgICAgIHx8IHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkFwcGxp Y2F0aW9uQ2FjaGVNYW5pZmVzdFRyZWVFbGVtZW50CiAgICAgICAgICAgICB8fCB0eXBlb2YgdHJl ZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3QgPT09ICJzdHJpbmciCiAgICAgICAgICAgICB8fCB0 cmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFN0cmluZzsKICAgICB9Cg==