156083 2016-03-31 14:20:28 -0700 Web Automation: the interaction queue in WebAutomationSession::performKeyboardInteractions doesn't work 2016-03-31 14:51:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg graouts joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1179579 0 bburg 2016-03-31 14:20:28 -0700 Whoops, 1179580 1 webkit-bug-importer 2016-03-31 14:21:16 -0700 <rdar://problem/25473518> 1179581 2 275326 bburg 2016-03-31 14:22:32 -0700 Created attachment 275326 Patch 1179584 3 275326 timothy 2016-03-31 14:26:11 -0700 Comment on attachment 275326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=275326&action=review > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:750 > + actionsToPerform.reserveCapacity(interactions.length()); You can use uncheckedAppend in the loop since you do this. > Source/WebKit2/UIProcess/Automation/WebAutomationSession.cpp:752 > for (auto it = interactions.begin(); it != interactions.end(); ++it) { for (auto& interaction : interactions) { 1179598 4 bburg 2016-03-31 14:51:37 -0700 Committed r198918: <http://trac.webkit.org/changeset/198918> 275326 2016-03-31 14:22:32 -0700 2016-03-31 14:26:11 -0700 Patch bug-156083-20160331142236.patch text/plain 2426 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMTk4OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMmE0NTgwNjQzZWYxNjlk MTljYzQzYjU5ZjE0MDk2ZDA0Y2I3M2U3NC4uMDVhMTk2ZjJhYmRhNDIzNjIzNTVjM2ZkMDY3ZTVi YjFkMTNlYTM0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTAzLTMxICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBBdXRvbWF0aW9uOiB0aGUg aW50ZXJhY3Rpb24gcXVldWUgaW4gV2ViQXV0b21hdGlvblNlc3Npb246OnBlcmZvcm1LZXlJbnRl cmFjdGlvbnMgZG9lc24ndCB3b3JrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTYwODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9u LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQXV0b21hdGlvblNlc3Npb246OnBlcmZvcm1LZXli b2FyZEludGVyYWN0aW9ucyk6CisgICAgICAgIFVzZSBWZWN0b3I6OnJlc2VydmVDYXBhY2l0eSBp bnN0ZWFkIG9mIHRoZSBzaXplIGNvbnN0cnVjdG9yIHNpbmNlIHdlIHVzZSBhcHBlbmQuCisgICAg ICAgIEVtcHR5IHRoZSBpbnRlcmFjdGlvbiBxdWV1ZSBvdXRzaWRlIG9mIGxvb3BzIHNvIGFsbCBp bnRlcmFjdGlvbnMgYXJlIHBlcmZvcm1lZCBvbmNlLgorCiAyMDE2LTAzLTMxICBUaW1vdGh5IEhh dGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgQXV0b21hdGlvbjogQWRk IHN1cHBvcnQgZm9yIHNjcmlwdCB0aW1lb3V0cyB0byB0aGUgZXZhbHVhdGVKYXZhU2NyaXB0RnVu Y3Rpb24gY29tbWFuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9t YXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24uY3BwCmluZGV4IDFhZDc1NjYxOTYyYzgy NDBjYmM3YTdhNWQwMWRhODEzNzgxZTk5MTguLjZkM2FiMzE3Y2MyMmNlZjQ3N2NlYmY2MjQzMTk2 ZjI4YTNjYzIxYTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0 aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5jcHAKQEAgLTc0Niw3ICs3NDYsOCBA QCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9uOjpwZXJmb3JtS2V5Ym9hcmRJbnRlcmFjdGlvbnMo RXJyb3JTdHJpbmcmIGVycm9yU3RyaW5nLAogICAgICAgICBGQUlMX1dJVEhfUFJFREVGSU5FRF9F UlJPUl9NRVNTQUdFKEludmFsaWRQYXJhbWV0ZXIpOwogCiAgICAgLy8gVmFsaWRhdGUgYWxsIG9m IHRoZSBwYXJhbWV0ZXJzIGJlZm9yZSBwZXJmb3JtaW5nIGFueSBpbnRlcmFjdGlvbnMgd2l0aCB0 aGUgYnJvd3NpbmcgY29udGV4dCB1bmRlciB0ZXN0LgotICAgIFZlY3RvcjxzdGQ6OmZ1bmN0aW9u PHZvaWQoKT4+IGFjdGlvbnNUb1BlcmZvcm0oaW50ZXJhY3Rpb25zLmxlbmd0aCgpKTsKKyAgICBW ZWN0b3I8c3RkOjpmdW5jdGlvbjx2b2lkKCk+PiBhY3Rpb25zVG9QZXJmb3JtOworICAgIGFjdGlv bnNUb1BlcmZvcm0ucmVzZXJ2ZUNhcGFjaXR5KGludGVyYWN0aW9ucy5sZW5ndGgoKSk7CiAKICAg ICBmb3IgKGF1dG8gaXQgPSBpbnRlcmFjdGlvbnMuYmVnaW4oKTsgaXQgIT0gaW50ZXJhY3Rpb25z LmVuZCgpOyArK2l0KSB7CiAgICAgICAgIFJlZlB0cjxJbnNwZWN0b3JPYmplY3Q+IGludGVyYWN0 aW9uT2JqZWN0OwpAQCAtNzkxLDExICs3OTIsMTIgQEAgdm9pZCBXZWJBdXRvbWF0aW9uU2Vzc2lv bjo6cGVyZm9ybUtleWJvYXJkSW50ZXJhY3Rpb25zKEVycm9yU3RyaW5nJiBlcnJvclN0cmluZywK IAogICAgICAgICBpZiAoIWZvdW5kVmlydHVhbEtleSAmJiAhZm91bmRLZXlTZXF1ZW5jZSkKICAg ICAgICAgICAgIEZBSUxfV0lUSF9QUkVERUZJTkVEX0VSUk9SX01FU1NBR0UoTWlzc2luZ1BhcmFt ZXRlcik7Ci0KLSAgICAgICAgQVNTRVJUKGFjdGlvbnNUb1BlcmZvcm0uc2l6ZSgpKTsKLSAgICAg ICAgZm9yIChhdXRvJiBhY3Rpb24gOiBhY3Rpb25zVG9QZXJmb3JtKQotICAgICAgICAgICAgYWN0 aW9uKCk7CiAgICAgfQorCisgICAgQVNTRVJUKGFjdGlvbnNUb1BlcmZvcm0uc2l6ZSgpKTsKKyAg ICBmb3IgKGF1dG8mIGFjdGlvbiA6IGFjdGlvbnNUb1BlcmZvcm0pCisgICAgICAgIGFjdGlvbigp OworCiAjZW5kaWYgLy8gVVNFKEFQUEtJVCkKIH0KIAo=