156080 2016-03-31 13:08:27 -0700 Page overlay tests sometimes crash under MockPageOverlayClient::uninstallAllOverlays() 2016-04-01 09:38:26 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap commit-queue darin lforschler thorton oldest_to_newest 1179539 0 ap 2016-03-31 13:08:27 -0700 rdar://problem/24922183 1179540 1 275314 ap 2016-03-31 13:11:46 -0700 Created attachment 275314 proposed fix 1179730 2 275314 achristensen 2016-03-31 19:39:09 -0700 Comment on attachment 275314 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=275314&action=review r=me I would be ok with removing the dead code in this patch. > Source/WebCore/testing/MockPageOverlayClient.cpp:78 > + // FIXME: This is dead code, nothing ever calls this function. It's not clear to me what the intention was, Let's remove this, then! 1179741 3 275314 ap 2016-03-31 21:02:14 -0700 Comment on attachment 275314 proposed fix There is a lot more code to review, or possibly to fix. Out of scope for this patch. 1179750 4 275314 commit-queue 2016-03-31 21:53:59 -0700 Comment on attachment 275314 proposed fix Clearing flags on attachment: 275314 Committed r198940: <http://trac.webkit.org/changeset/198940> 1179751 5 commit-queue 2016-03-31 21:54:02 -0700 All reviewed patches have been landed. Closing bug. 1179868 6 darin 2016-04-01 09:36:06 -0700 To me, removing an unused function seems even better than adding a comment to it. 1179869 7 ap 2016-04-01 09:38:26 -0700 Normally, I would agree, but not in this case, where it's more likely correct to make the function used. rdar://problem/25471523 tracks that. 275314 2016-03-31 13:11:46 -0700 2016-03-31 21:53:59 -0700 proposed fix MockPageOverlay.txt text/plain 2940 ap SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE5ODkxMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTAzLTMxICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIFBhZ2Ugb3ZlcmxheSB0ZXN0 cyBzb21ldGltZXMgY3Jhc2ggdW5kZXIgTW9ja1BhZ2VPdmVybGF5Q2xpZW50Ojp1bmluc3RhbGxB bGxPdmVybGF5cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNTYwODAKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMjQ5MjIxODMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIE1vY2tQYWdlT3Zlcmxh eUNsaWVudDo6bV9vdmVybGF5cyByZWZlcmVuY2UgdGhlIG92ZXJsYXlzLiBUaGVyZSBpcyBubyBy ZWZlcmVuY2UKKyAgICAgICAgY3ljbGUgYmVjYXVzZSB0aGV5IGFyZSBhbGwgcmVtb3ZlZCBiZXR3 ZWVuIHRlc3QgcGFnZSBsb2Fkcy4KKworICAgICAgICAqIHRlc3RpbmcvTW9ja1BhZ2VPdmVybGF5 Q2xpZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1vY2tQYWdlT3ZlcmxheUNsaWVudDo6dW5p bnN0YWxsQWxsT3ZlcmxheXMpOgorICAgICAgICAoV2ViQ29yZTo6TW9ja1BhZ2VPdmVybGF5Q2xp ZW50OjpwYWdlT3ZlcmxheURlc3Ryb3llZCk6CisgICAgICAgICogdGVzdGluZy9Nb2NrUGFnZU92 ZXJsYXlDbGllbnQuaDoKKwogMjAxNi0wMy0zMSAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3 ZWJraXQub3JnPgogCiAgICAgICAgIGV2ZW50TWF5U3RhcnREcmFnKCkgZG9lcyBub3QgY2hlY2sg Zm9yIHNoaWZ0S2V5IG9yIGlzT3ZlckxpbmsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Rlc3Rpbmcv TW9ja1BhZ2VPdmVybGF5Q2xpZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS90 ZXN0aW5nL01vY2tQYWdlT3ZlcmxheUNsaWVudC5jcHAJKHJldmlzaW9uIDE5ODU4NykKKysrIFNv dXJjZS9XZWJDb3JlL3Rlc3RpbmcvTW9ja1BhZ2VPdmVybGF5Q2xpZW50LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjEsNyArNjEsNyBAQCBSZWY8TW9ja1BhZ2VPdmVybGF5PiBNb2NrUGFnZU92ZXJs YXlDbGllCiB2b2lkIE1vY2tQYWdlT3ZlcmxheUNsaWVudDo6dW5pbnN0YWxsQWxsT3ZlcmxheXMo KQogewogICAgIHdoaWxlICghbV9vdmVybGF5cy5pc0VtcHR5KCkpIHsKLSAgICAgICAgTW9ja1Bh Z2VPdmVybGF5KiBtb2NrT3ZlcmxheSA9IG1fb3ZlcmxheXMudGFrZUFueSgpOworICAgICAgICBS ZWZQdHI8TW9ja1BhZ2VPdmVybGF5PiBtb2NrT3ZlcmxheSA9IG1fb3ZlcmxheXMudGFrZUFueSgp OwogICAgICAgICBQYWdlT3ZlcmxheUNvbnRyb2xsZXIqIG92ZXJsYXlDb250cm9sbGVyID0gbW9j a092ZXJsYXktPm92ZXJsYXkoKS0+Y29udHJvbGxlcigpOwogICAgICAgICBBU1NFUlQob3Zlcmxh eUNvbnRyb2xsZXIpOwogICAgICAgICBvdmVybGF5Q29udHJvbGxlci0+dW5pbnN0YWxsUGFnZU92 ZXJsYXkobW9ja092ZXJsYXktPm92ZXJsYXkoKSwgUGFnZU92ZXJsYXk6OkZhZGVNb2RlOjpEb05v dEZhZGUpOwpAQCAtNzUsNiArNzUsOSBAQCBTdHJpbmcgTW9ja1BhZ2VPdmVybGF5Q2xpZW50Ojps YXllclRyZWVBCiAKIHZvaWQgTW9ja1BhZ2VPdmVybGF5Q2xpZW50OjpwYWdlT3ZlcmxheURlc3Ry b3llZChQYWdlT3ZlcmxheSYgb3ZlcmxheSkKIHsKKyAgICAvLyBGSVhNRTogVGhpcyBpcyBkZWFk IGNvZGUsIG5vdGhpbmcgZXZlciBjYWxscyB0aGlzIGZ1bmN0aW9uLiBJdCdzIG5vdCBjbGVhciB0 byBtZSB3aGF0IHRoZSBpbnRlbnRpb24gd2FzLAorICAgIC8vIHNpbmNlIE1vY2tQYWdlT3Zlcmxh eUNsaWVudCBoYXMgcmVmZXJlbmNlcyB0byBNb2NrUGFnZU92ZXJsYXlzLCBub3QgdG8gUGFnZU92 ZXJsYXlzLgorICAgIC8vIEFsc28sIGl0ZXJhdGluZyBvdmVyIGEgc2V0IHdoaWxlIG1vZGlmeWlu ZyBpdCBpcyBub3QgZ29vZC4KICAgICBmb3IgKGF1dG8mIG1vY2tPdmVybGF5IDogbV9vdmVybGF5 cykgewogICAgICAgICBpZiAobW9ja092ZXJsYXktPm92ZXJsYXkoKSA9PSAmb3ZlcmxheSkgewog ICAgICAgICAgICAgbV9vdmVybGF5cy5yZW1vdmUobW9ja092ZXJsYXkpOwpJbmRleDogU291cmNl L1dlYkNvcmUvdGVzdGluZy9Nb2NrUGFnZU92ZXJsYXlDbGllbnQuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS90ZXN0aW5nL01vY2tQYWdlT3ZlcmxheUNsaWVudC5oCShyZXZpc2lvbiAx OTg1ODcpCisrKyBTb3VyY2UvV2ViQ29yZS90ZXN0aW5nL01vY2tQYWdlT3ZlcmxheUNsaWVudC5o CSh3b3JraW5nIGNvcHkpCkBAIC02MCw3ICs2MCw3IEBAIHByaXZhdGU6CiAgICAgYm9vbCBjb3B5 QWNjZXNzaWJpbGl0eUF0dHJpYnV0ZUJvb2xWYWx1ZUZvclBvaW50KFBhZ2VPdmVybGF5JiwgU3Ry aW5nIC8qIGF0dHJpYnV0ZSAqLywgRmxvYXRQb2ludCwgYm9vbCYpIG92ZXJyaWRlOwogICAgIFZl Y3RvcjxTdHJpbmc+IGNvcHlBY2Nlc3NpYmlsaXR5QXR0cmlidXRlTmFtZXMoUGFnZU92ZXJsYXkm LCBib29sIC8qIHBhcmFtZXRlcml6ZWROYW1lcyAqLykgb3ZlcnJpZGU7CiAKLSAgICBIYXNoU2V0 PE1vY2tQYWdlT3ZlcmxheSo+IG1fb3ZlcmxheXM7CisgICAgSGFzaFNldDxSZWZQdHI8TW9ja1Bh Z2VPdmVybGF5Pj4gbV9vdmVybGF5czsKIH07CiAKIH0K