156071 2016-03-31 10:48:14 -0700 run-webkit-tests fails to create user's cache directory when System Integrity Protection is enabled 2016-03-31 16:45:50 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Mac OS X 10.11 RESOLVED FIXED InRadar P2 Normal --- 155455 1 dbates dbates ap bfulgham commit-queue glenn lforschler webkit-bug-importer oldest_to_newest 1179467 0 dbates 2016-03-31 10:48:14 -0700 On non-Apple Internal machines with System Integrity Protection enabled, run-webkit-tests fails to create the user's cache directory with suffix DIRHELPER_USER_DIR_SUFFIX because the path returned by os.confstr(65538) [1] does not include the suffix as confstr(3) only honors DIRHELPER_USER_DIR_SUFFIX for privileged processes when System Integrity Protection is enabled on non Apple-Internal machines. [1] <http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/port/mac.py?rev=198842#L126> 1179468 1 webkit-bug-importer 2016-03-31 10:48:48 -0700 <rdar://problem/25467827> 1179616 2 275339 dbates 2016-03-31 15:29:02 -0700 Created attachment 275339 Patch 1179653 3 275339 bfulgham 2016-03-31 16:12:46 -0700 Comment on attachment 275339 Patch r=me 1179678 4 dbates 2016-03-31 16:45:50 -0700 Committed r198930: <http://trac.webkit.org/changeset/198930> 275339 2016-03-31 15:29:02 -0700 2016-03-31 16:12:46 -0700 Patch bug-156071-20160331152906.patch text/plain 4485 dbates SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE5ODg5OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDMwIEBACisyMDE2LTAzLTMxICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4K KworICAgICAgICBydW4td2Via2l0LXRlc3RzIGZhaWxzIHRvIGNyZWF0ZSB1c2VyJ3MgY2FjaGUg ZGlyZWN0b3J5IHdoZW4gU3lzdGVtIEludGVncml0eSBQcm90ZWN0aW9uIGlzIGVuYWJsZWQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NjA3MQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjU0Njc4Mjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgcnVuLXdlYmtpdC10 ZXN0cyB3aWxsIGZhaWwgdG8gY3JlYXRlIHRoZSBzdWZmaXhlZCB1c2VyJ3MgY2FjaGUgZGlyZWN0 b3J5CisgICAgICAgIG9uIG5vbi1BcHBsZSBJbnRlcm5hbCBtYWNoaW5lcyB3aXRoIFN5c3RlbSBJ bnRlZ3JpdHkgUHJvdGVjdGlvbiBlbmFibGVkIGJlY2F1c2UgdGhlIE9TIG9ubHkKKyAgICAgICAg aG9ub3JzIHRoZSBzdWZmaXgsIHNwZWNpZmllZCBieSB0aGUgZW52aXJvbm1lbnQgdmFyaWFibGUg RElSSEVMUEVSX1VTRVJfRElSX1NVRkZJWCwgaW4KKyAgICAgICAgcHJpdmlsZWdlZCBwcm9jZXNz ZXMuIEFuZCBweXRob24oMSkgZG9lcyBub3QgaGF2ZSBzdWZmaWNpZW50IHByaXZpbGVnZXMuIEFz IGEgd29ya2Fyb3VuZCBmb3IKKyAgICAgICAgc3lzdGVtcyB0aGF0IGhhdmUgU3lzdGVtIEludGVn cml0eSBQcm90ZWN0aW9uIGVuYWJsZWQgd2UgY29tcHV0ZSB0aGUgcGF0aCB0byB0aGUgc3VmZml4 ZWQKKyAgICAgICAgdXNlcidzIGNhY2hlIGRpcmVjdG9yeSBieSBoYW5kLgorCisgICAgICAgIEFk ZGl0aW9uYWxseSwgZml4IGFuIGlzc3VlIHdoZXJlIHRoZSB1c2VyJ3MgY2FjaGUgZGlyZWN0b3J5 IGNyZWF0ZWQgYnkgcnVuLXdlYmtpdC10ZXN0IHdhcworICAgICAgICBuZXZlciBkZWxldGVkIG9u IGNlc3NhdGlvbiBvZiB0aGUgdGVzdCBydW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3BvcnQvZHJpdmVyLnB5OgorICAgICAgICAoRHJpdmVyLl9zdGFydCk6IEFjdHVhbGx5IHN0b3Jl IHRoZSBwYXRoIHRvIHRoZSB1c2VyJ3MgY2FjaGUgZGlyZWN0b3J5IGluIHNlbGYuX2RyaXZlcl91 c2VyX2NhY2hlX2RpcmVjdG9yeQorICAgICAgICBzbyB0aGF0IHdlIGNhbiBkZWxldGUgdGhpcyBk aXJlY3Rvcnkgb24gY2Vzc2F0aW9uIG9mIHRoZSB0ZXN0IHJ1bi4KKyAgICAgICAgKiBTY3JpcHRz L3dlYmtpdHB5L3BvcnQvbWFjLnB5OgorICAgICAgICAoTWFjUG9ydCk6CisgICAgICAgIChNYWNQ b3J0Ll9wYXRoX3RvX3VzZXJfY2FjaGVfZGlyZWN0b3J5KTogVW5zZXQgdGhlIGVudmlyb25tZW50 IHZhcmlhYmxlIERJUkhFTFBFUl9VU0VSX0RJUl9TVUZGSVggKGlmIHNldCksCisgICAgICAgIHF1 ZXJ5IHRoZSBPUyBmb3IgdGhlIHBhdGggdG8gdGhlIHVzZXIncyBjYWNoZSBkaXJlY3RvcnkgYW5k IGNvbmNhdGVuYXRlIHRoaXMgcGF0aCB3aXRoIHRoZQorICAgICAgICBzcGVjaWZpZWQgc3VmZml4 LgorCiAyMDE2LTAzLTMwICBEZXdlaSBaaHUgIDxkZXdlaV96aHVAYXBwbGUuY29tPgogCiAgICAg ICAgIEV4dGVuZCBhbmltb21ldGVyIHRpbWVvdXQgZm9yIHNsb3cgQ1BVcy4KSW5kZXg6IFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC9kcml2ZXIucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkocmV2aXNpb24gMTk4ODc3KQorKysgVG9vbHMv U2NyaXB0cy93ZWJraXRweS9wb3J0L2RyaXZlci5weQkod29ya2luZyBjb3B5KQpAQCAtMzUwLDcg KzM1MCw4IEBAIGNsYXNzIERyaXZlcihvYmplY3QpOgogICAgICAgICBzZWxmLl9kcml2ZXJfdXNl cl9kaXJlY3Rvcnlfc3VmZml4ID0gb3MucGF0aC5iYXNlbmFtZShzdHIoc2VsZi5fZHJpdmVyX3Rl bXBkaXIpKQogICAgICAgICB1c2VyX2NhY2hlX2RpcmVjdG9yeSA9IHNlbGYuX3BvcnQuX3BhdGhf dG9fdXNlcl9jYWNoZV9kaXJlY3Rvcnkoc2VsZi5fZHJpdmVyX3VzZXJfZGlyZWN0b3J5X3N1ZmZp eCkKICAgICAgICAgaWYgdXNlcl9jYWNoZV9kaXJlY3Rvcnk6Ci0gICAgICAgICAgICBzZWxmLl9k cml2ZXJfdXNlcl9jYWNoZV9kaXJlY3RvcnkgPSBzZWxmLl9wb3J0Ll9maWxlc3lzdGVtLm1heWJl X21ha2VfZGlyZWN0b3J5KHVzZXJfY2FjaGVfZGlyZWN0b3J5KQorICAgICAgICAgICAgc2VsZi5f cG9ydC5fZmlsZXN5c3RlbS5tYXliZV9tYWtlX2RpcmVjdG9yeSh1c2VyX2NhY2hlX2RpcmVjdG9y eSkKKyAgICAgICAgICAgIHNlbGYuX2RyaXZlcl91c2VyX2NhY2hlX2RpcmVjdG9yeSA9IHVzZXJf Y2FjaGVfZGlyZWN0b3J5CiAgICAgICAgIHNlcnZlcl9uYW1lID0gc2VsZi5fcG9ydC5kcml2ZXJf bmFtZSgpCiAgICAgICAgIGVudmlyb25tZW50ID0gc2VsZi5fcG9ydC5zZXR1cF9lbnZpcm9uX2Zv cl9zZXJ2ZXIoc2VydmVyX25hbWUpCiAgICAgICAgIGVudmlyb25tZW50ID0gc2VsZi5fc2V0dXBf ZW52aXJvbl9mb3JfZHJpdmVyKGVudmlyb25tZW50KQpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L21hYy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvbWFjLnB5CShyZXZpc2lvbiAxOTg4NzcpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Bv cnQvbWFjLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMTgsMTIgKzExOCwxOSBAQCBjbGFzcyBNYWNQ b3J0KEFwcGxlUG9ydCk6CiAgICAgICAgIHNlbGYuX2ZpbGVzeXN0ZW0ucm10cmVlKG9zLnBhdGgu ZXhwYW5kdXNlcignfi9MaWJyYXJ5L1dlYktpdC8nICsgc2VsZi5kcml2ZXJfbmFtZSgpKSkKIAog ICAgIGRlZiBfcGF0aF90b191c2VyX2NhY2hlX2RpcmVjdG9yeShzZWxmLCBzdWZmaXg9Tm9uZSk6 Ci0gICAgICAgIERJUkhFTFBFUl9VU0VSX0RJUl9TVUZGSVggPSAiRElSSEVMUEVSX1VTRVJfRElS X1NVRkZJWCIKKyAgICAgICAgRElSSEVMUEVSX1VTRVJfRElSX1NVRkZJWCA9ICdESVJIRUxQRVJf VVNFUl9ESVJfU1VGRklYJworICAgICAgICBDU19EQVJXSU5fVVNFUl9DQUNIRV9ESVIgPSA2NTUz OAorCisgICAgICAgICMgVGhlIGVudmlyb25tZW50IHZhcmlhYmxlIERJUkhFTFBFUl9VU0VSX0RJ Ul9TVUZGSVggaXMgb25seSBob25vcmVkIG9uIHN5c3RlbXMgd2l0aAorICAgICAgICAjIFN5c3Rl bSBJbnRlZ3JpdHkgUHJvdGVjdGlvbiBkaXNhYmxlZCBvciB3aXRoIGFuIEFwcGxlLUludGVybmFs IE9TLiBUbyBtYWtlIHRoaXMgY29kZQorICAgICAgICAjIHdvcmsgZm9yIGFsbCBzeXN0ZW0gY29u ZmlndXJhdGlvbnMgd2UgY29tcHV0ZSB0aGUgcGF0aCB3aXRoIHJlc3BlY3QgdG8gdGhlIHN1ZmZp eAorICAgICAgICAjIGJ5IGhhbmQgYW5kIHRlbXBvcmFyaWx5IHVuc2V0IHRoZSBlbnZpcm9ubWVu dCB2YXJpYWJsZSBESVJIRUxQRVJfVVNFUl9ESVJfU1VGRklYIChpZiBzZXQpCisgICAgICAgICMg dG8gYXZvaWQgaXQgaW5mbHVlbmNpbmcgY29uZnN0cigpIG9uIHN5c3RlbXMgdGhhdCBob25vciBE SVJIRUxQRVJfVVNFUl9ESVJfU1VGRklYLgogICAgICAgICBzYXZlZF9zdWZmaXggPSBOb25lCi0g ICAgICAgIGlmIHN1ZmZpeCBpcyBub3QgTm9uZToKLSAgICAgICAgICAgIHNhdmVkX3N1ZmZpeCA9 IG9zLmVudmlyb24uZ2V0KERJUkhFTFBFUl9VU0VSX0RJUl9TVUZGSVgpCi0gICAgICAgICAgICBv cy5lbnZpcm9uW0RJUkhFTFBFUl9VU0VSX0RJUl9TVUZGSVhdID0gc3VmZml4Ci0gICAgICAgIHJl c3VsdCA9IG9zLmNvbmZzdHIoNjU1MzgpICAjIF9DU19EQVJXSU5fVVNFUl9DQUNIRV9ESVIKKyAg ICAgICAgaWYgRElSSEVMUEVSX1VTRVJfRElSX1NVRkZJWCBpbiBvcy5lbnZpcm9uOgorICAgICAg ICAgICAgc2F2ZWRfc3VmZml4ID0gb3MuZW52aXJvbltESVJIRUxQRVJfVVNFUl9ESVJfU1VGRklY XQorICAgICAgICAgICAgZGVsIG9zLmVudmlyb25bRElSSEVMUEVSX1VTRVJfRElSX1NVRkZJWF0K KyAgICAgICAgcmVzdWx0ID0gb3MucGF0aC5qb2luKG9zLmNvbmZzdHIoQ1NfREFSV0lOX1VTRVJf Q0FDSEVfRElSKSwgc3VmZml4IG9yICcnKQogICAgICAgICBpZiBzYXZlZF9zdWZmaXggaXMgbm90 IE5vbmU6CiAgICAgICAgICAgICBvcy5lbnZpcm9uW0RJUkhFTFBFUl9VU0VSX0RJUl9TVUZGSVhd ID0gc2F2ZWRfc3VmZml4CiAgICAgICAgIHJldHVybiByZXN1bHQK