156055 2016-03-30 21:23:49 -0700 Simplify API of Test model by removing Test.setParentTest 2016-03-31 15:42:11 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez dewei_zhu joepeck rniwa slewis oldest_to_newest 1179322 0 rniwa 2016-03-30 21:23:49 -0700 Right now, Test model requires setParentTest to be called by its user to update its parent-child mapping. Simplify this cumbersome API. 1179324 1 275264 rniwa 2016-03-30 21:30:12 -0700 Created attachment 275264 Cleanup 1179609 2 275264 joepeck 2016-03-31 15:10:12 -0700 Comment on attachment 275264 Cleanup rs=me 1179610 3 275264 joepeck 2016-03-31 15:10:27 -0700 Comment on attachment 275264 Cleanup View in context: https://bugs.webkit.org/attachment.cgi?id=275264&action=review rs=me > Websites/perf.webkit.org/ChangeLog:24 > + > + Nit: extra newline here. 1179630 4 rniwa 2016-03-31 15:42:11 -0700 Committed r198923: <http://trac.webkit.org/changeset/198923> 275264 2016-03-30 21:30:12 -0700 2016-03-31 15:10:12 -0700 Cleanup bug-156055-20160330213016.patch text/plain 4693 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMTk4ODgyKQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDI3IEBACisyMDE2LTAzLTMwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFNpbXBsaWZ5IEFQSSBvZiBUZXN0IG1vZGVsIGJ5IHJlbW92aW5nIFRlc3Quc2V0 UGFyZW50VGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU2MDU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlZCBUZXN0LnNldFBhcmVudFRlc3QuIEtlZXAgdHJhY2sgb2YgdGhlIGNoaWxkLXBh cmVudCByZWxhdGlvbnNoaXAgdXNpbmcgdGhlIHN0YXRpYyBtYXAgaW5zdGVhZC4KKworICAgICAg ICBOb3cgZWFjaCB0ZXN0IG9ubHkgc3RvcmVzIHBhcmVudCdzIGlkIGFuZCB1c2VzIHRoZSBJRCBz dGF0aWMgbWFwIGluIFRlc3QucGFyZW50VGVzdCgpLgorCisgICAgICAgICogcHVibGljL3YzL21v ZGVscy9tYW5pZmVzdC5qczoKKyAgICAgICAgKE1hbmlmZXN0Ll9kaWRGZXRjaE1hbmlmZXN0LmJ1 aWxkT2JqZWN0c0Zyb21JZE1hcCk6IFJlbW92ZWQgdGhlIGNvZGUgdG8gY3JlYXRlIHRoZSBtYXAg b2YgY2hpbGQtcGFyZW50CisgICAgICAgIHJlbGF0aW9uc2hpcCBhbmQgY2FsbCBzZXRQYXJlbnRU ZXN0LgorICAgICAgICAqIHB1YmxpYy92My9tb2RlbHMvdGVzdC5qczoKKyAgICAgICAgKFRlc3Qp OiBVcGRhdGVkIGEgc3RhdGljIG1hcCBieSB0aGUgbmFtZSBvZiAiY2hpbGRUZXN0TWFwIiB0byBz dG9yZSBpdHNlbGYuIFdlIHNob3VsZCBwcm9iYWJseSBzb3J0CisgICAgICAgIGNoaWxkIHRlc3Rz IHVzaW5nIHNvbWUgZml4ZWQgY3JpdGVyaWEgaW4gdGhlIGZ1dHVyZSBpbnN0ZWFkIG9mIHJlbHlp bmcgb24gdGhlIGNyZWF0aW9uIG9yZGVyIGJ1dAorICAgICAgICBwcmVzZXJ2ZSB0aGUgb2xkIGNv ZGUncyBvcmRlcmluZyBmb3Igbm93LgorICAgICAgICAoVGVzdC5wcm90b3R5cGUucGFyZW50VGVz dCk6IExvb2sgdXAgdGhlIHN0YXRpYyBtYXAgYnkgdGhlIHBhcmVudCB0ZXN0J3MgaWQuCisgICAg ICAgIChUZXN0LnByb3RvdHlwZS5vbmx5Q29udGFpbnNTaW5nbGVNZXRyaWMpOgorICAgICAgICAo VGVzdC5wcm90b3R5cGUuc2V0UGFyZW50VGVzdCk6IERlbGV0ZWQuCisgICAgICAgIChUZXN0LnBy b3RvdHlwZS5jaGlsZFRlc3RzKTogTG9vayB1cCB0aGUgY2hpbGQgdGVzdCBtYXAuCisKKwogMjAx Ni0wMy0zMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWls ZFJlcXVlc3Qgc2hvdWxkIGhhdmUgYXNzb2NpYXRlZCBwbGF0Zm9ybSBhbmQgdGVzdApJbmRleDog V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9tb2RlbHMvbWFuaWZlc3QuanMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy92My9tb2RlbHMvbWFu aWZlc3QuanMJKHJldmlzaW9uIDE5ODg4MSkKKysrIFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9w dWJsaWMvdjMvbW9kZWxzL21hbmlmZXN0LmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xNSwxNSArMTUs OCBAQCBjbGFzcyBNYW5pZmVzdCB7CiAKICAgICAgICAgdmFyIHRlc3RzID0gW107CiAgICAgICAg IHZhciB0ZXN0UGFyZW50TWFwID0ge307Ci0gICAgICAgIGZvciAodmFyIHRlc3RJZCBpbiByYXdS ZXNwb25zZS50ZXN0cykgewotICAgICAgICAgICAgdmFyIHRlc3QgPSByYXdSZXNwb25zZS50ZXN0 c1t0ZXN0SWRdOwotICAgICAgICAgICAgdmFyIHRvcExldmVsID0gIXRlc3QucGFyZW50SWQ7Ci0g ICAgICAgICAgICBpZiAodGVzdC5wYXJlbnRJZCkKLSAgICAgICAgICAgICAgICB0ZXN0UGFyZW50 TWFwW3Rlc3RJZF0gPSBwYXJzZUludCh0ZXN0LnBhcmVudElkKTsKLSAgICAgICAgICAgIHRlc3Rz LnB1c2gobmV3IFRlc3QodGVzdElkLCB0ZXN0LCB0b3BMZXZlbCkpOwotICAgICAgICB9Ci0gICAg ICAgIGZvciAodmFyIHRlc3RJZCBpbiB0ZXN0UGFyZW50TWFwKQotICAgICAgICAgICAgVGVzdC5m aW5kQnlJZCh0ZXN0SWQpLnNldFBhcmVudFRlc3QoVGVzdC5maW5kQnlJZCh0ZXN0UGFyZW50TWFw W3Rlc3RJZF0pKTsKKyAgICAgICAgZm9yICh2YXIgdGVzdElkIGluIHJhd1Jlc3BvbnNlLnRlc3Rz KQorICAgICAgICAgICAgdGVzdHMucHVzaChuZXcgVGVzdCh0ZXN0SWQsIHJhd1Jlc3BvbnNlLnRl c3RzW3Rlc3RJZF0pKTsKIAogICAgICAgICBmdW5jdGlvbiBidWlsZE9iamVjdHNGcm9tSWRNYXAo aWRNYXAsIGNvbnN0cnVjdG9yLCByZXNvbHZlcikgewogICAgICAgICAgICAgZm9yICh2YXIgaWQg aW4gaWRNYXApIHsKSW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvbW9k ZWxzL3Rlc3QuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9tb2RlbHMvdGVzdC5qcwkocmV2aXNpb24gMTk4ODgxKQorKysgV2Vic2l0ZXMvcGVyZi53 ZWJraXQub3JnL3B1YmxpYy92My9tb2RlbHMvdGVzdC5qcwkod29ya2luZyBjb3B5KQpAQCAtMSwy MSArMSwyOCBAQAogJ3VzZSBzdHJpY3QnOwogCiBjbGFzcyBUZXN0IGV4dGVuZHMgTGFiZWxlZE9i amVjdCB7Ci0gICAgY29uc3RydWN0b3IoaWQsIG9iamVjdCwgaXNUb3BMZXZlbCkKKyAgICBjb25z dHJ1Y3RvcihpZCwgb2JqZWN0KQogICAgIHsKICAgICAgICAgc3VwZXIoaWQsIG9iamVjdCk7CiAg ICAgICAgIHRoaXMuX3VybCA9IG9iamVjdC51cmw7IC8vIEZJWE1FOiBVbnVzZWQKLSAgICAgICAg dGhpcy5fcGFyZW50ID0gbnVsbDsKKyAgICAgICAgdGhpcy5fcGFyZW50SWQgPSBvYmplY3QucGFy ZW50SWQ7CiAgICAgICAgIHRoaXMuX2NoaWxkVGVzdHMgPSBbXTsKICAgICAgICAgdGhpcy5fbWV0 cmljcyA9IFtdOwogCi0gICAgICAgIGlmIChpc1RvcExldmVsKQorICAgICAgICBpZiAoIXRoaXMu X3BhcmVudElkKQogICAgICAgICAgICAgdGhpcy5lbnN1cmVOYW1lZFN0YXRpY01hcCgndG9wTGV2 ZWxUZXN0cycpW2lkXSA9IHRoaXM7CisgICAgICAgIGVsc2UgeworICAgICAgICAgICAgdmFyIGNo aWxkTWFwID0gdGhpcy5lbnN1cmVOYW1lZFN0YXRpY01hcCgnY2hpbGRUZXN0TWFwJyk7CisgICAg ICAgICAgICBpZiAoIWNoaWxkTWFwW3RoaXMuX3BhcmVudElkXSkKKyAgICAgICAgICAgICAgICBj aGlsZE1hcFt0aGlzLl9wYXJlbnRJZF0gPSBbdGhpc107CisgICAgICAgICAgICBlbHNlCisgICAg ICAgICAgICAgICAgY2hpbGRNYXBbdGhpcy5fcGFyZW50SWRdLnB1c2godGhpcyk7CisgICAgICAg IH0KICAgICB9CiAKICAgICBzdGF0aWMgdG9wTGV2ZWxUZXN0cygpIHsgcmV0dXJuIHRoaXMuc29y dEJ5TmFtZSh0aGlzLmxpc3RGb3JTdGF0aWNNYXAoJ3RvcExldmVsVGVzdHMnKSk7IH0KIAotICAg IHBhcmVudFRlc3QoKSB7IHJldHVybiB0aGlzLl9wYXJlbnQ7IH0KKyAgICBwYXJlbnRUZXN0KCkg eyByZXR1cm4gVGVzdC5maW5kQnlJZCh0aGlzLl9wYXJlbnRJZCk7IH0KIAogICAgIHBhdGgoKQog ICAgIHsKQEAgLTI4LDE4ICszNSwxNiBAQCBjbGFzcyBUZXN0IGV4dGVuZHMgTGFiZWxlZE9iamVj dCB7CiAgICAgICAgIHJldHVybiBwYXRoOwogICAgIH0KIAotICAgIG9ubHlDb250YWluc1Npbmds ZU1ldHJpYygpIHsgcmV0dXJuICF0aGlzLl9jaGlsZFRlc3RzLmxlbmd0aCAmJiB0aGlzLl9tZXRy aWNzLmxlbmd0aCA9PSAxOyB9Ci0KLSAgICAvLyBGSVhNRTogV2Ugc2hvdWxkIHN0b3JlIHRoZSBj aGlsZCB0ZXN0IG9yZGVyIGluIHRoZSBzZXJ2ZXIuCi0gICAgY2hpbGRUZXN0cygpIHsgcmV0dXJu IHRoaXMuX2NoaWxkVGVzdHM7IH0KLSAgICBtZXRyaWNzKCkgeyByZXR1cm4gdGhpcy5fbWV0cmlj czsgfQorICAgIG9ubHlDb250YWluc1NpbmdsZU1ldHJpYygpIHsgcmV0dXJuICF0aGlzLmNoaWxk VGVzdHMoKS5sZW5ndGggJiYgdGhpcy5fbWV0cmljcy5sZW5ndGggPT0gMTsgfQogCi0gICAgc2V0 UGFyZW50VGVzdChwYXJlbnQpCisgICAgY2hpbGRUZXN0cygpCiAgICAgewotICAgICAgICBwYXJl bnQuYWRkQ2hpbGRUZXN0KHRoaXMpOwotICAgICAgICB0aGlzLl9wYXJlbnQgPSBwYXJlbnQ7Cisg ICAgICAgIHZhciBjaGlsZE1hcCA9IHRoaXMubmFtZWRTdGF0aWNNYXAoJ2NoaWxkVGVzdE1hcCcp OworICAgICAgICByZXR1cm4gY2hpbGRNYXAgJiYgdGhpcy5pZCgpIGluIGNoaWxkTWFwID8gY2hp bGRNYXBbdGhpcy5pZCgpXSA6IFtdOwogICAgIH0KIAorICAgIG1ldHJpY3MoKSB7IHJldHVybiB0 aGlzLl9tZXRyaWNzOyB9CisKICAgICBhZGRDaGlsZFRlc3QodGVzdCkgeyB0aGlzLl9jaGlsZFRl c3RzLnB1c2godGVzdCk7IH0KICAgICBhZGRNZXRyaWMobWV0cmljKSB7IHRoaXMuX21ldHJpY3Mu cHVzaChtZXRyaWMpOyB9CiB9Cg==